From: Wen Congyang <wency@cn.fujitsu.com>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Wen Congyang <wencongyang@gmail.com>,
Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>,
x86@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-acpi@vger.kernel.org,
linux-s390@vger.kernel.org, linux-sh@vger.kernel.org,
linux-ia64@vger.kernel.org, cmetcalf@tilera.com,
sparclinux@vger.kernel.org, rientjes@google.com,
liuj97@gmail.com, len.brown@intel.com, cl@linux.com,
minchan.kim@gmail.com, akpm@linux-foundation.org
Subject: Re: [PATCH 1/10] memory-hotplug : check whether memory is offline or not when removing memory
Date: Sat, 20 Oct 2012 08:50:45 +0800 [thread overview]
Message-ID: <5081F565.8020605@cn.fujitsu.com> (raw)
In-Reply-To: <CAHGf_=q=Agidyj_j6jhBdhNmJBy2u1dP+UMAoXbM=_=DyZJs_w@mail.gmail.com>
At 10/20/2012 02:33 AM, KOSAKI Motohiro Wrote:
>> I think it again, and found that this check is necessary. Because we only
>> lock memory hotplug when offlining pages. Here is the steps to offline and
>> remove memory:
>>
>> 1. lock memory hotplug
>> 2. offline a memory section
>> 3. unlock memory hotplug
>> 4. repeat 1-3 to offline all memory sections
>> 5. lock memory hotplug
>> 6. remove memory
>> 7. unlock memory hotplug
>>
>> All memory sections must be offlined before removing memory. But we don't
>> hold
>> the lock in the whole operation. So we should check whether all memory
>> sections
>> are offlined before step6.
>
> You should describe the race scenario in the patch description. OK?
>
OK
Thanks
Wen Congyang
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Wen Congyang <wency@cn.fujitsu.com>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Wen Congyang <wencongyang@gmail.com>,
Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>,
x86@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-acpi@vger.kernel.org,
linux-s390@vger.kernel.org, linux-sh@vger.kernel.org,
linux-ia64@vger.kernel.org, cmetcalf@tilera.com,
sparclinux@vger.kernel.org, rientjes@google.com,
liuj97@gmail.com, len.brown@intel.com, cl@linux.com,
minchan.kim@gmail.com, akpm@linux-foundation.org
Subject: Re: [PATCH 1/10] memory-hotplug : check whether memory is offline or not when removing memory
Date: Sat, 20 Oct 2012 00:50:45 +0000 [thread overview]
Message-ID: <5081F565.8020605@cn.fujitsu.com> (raw)
In-Reply-To: <CAHGf_=q=Agidyj_j6jhBdhNmJBy2u1dP+UMAoXbM=_=DyZJs_w@mail.gmail.com>
At 10/20/2012 02:33 AM, KOSAKI Motohiro Wrote:
>> I think it again, and found that this check is necessary. Because we only
>> lock memory hotplug when offlining pages. Here is the steps to offline and
>> remove memory:
>>
>> 1. lock memory hotplug
>> 2. offline a memory section
>> 3. unlock memory hotplug
>> 4. repeat 1-3 to offline all memory sections
>> 5. lock memory hotplug
>> 6. remove memory
>> 7. unlock memory hotplug
>>
>> All memory sections must be offlined before removing memory. But we don't
>> hold
>> the lock in the whole operation. So we should check whether all memory
>> sections
>> are offlined before step6.
>
> You should describe the race scenario in the patch description. OK?
>
OK
Thanks
Wen Congyang
WARNING: multiple messages have this Message-ID (diff)
From: Wen Congyang <wency@cn.fujitsu.com>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: linux-s390@vger.kernel.org, linux-ia64@vger.kernel.org,
len.brown@intel.com, linux-acpi@vger.kernel.org,
linux-sh@vger.kernel.org, x86@kernel.org,
linux-kernel@vger.kernel.org, cmetcalf@tilera.com,
Wen Congyang <wencongyang@gmail.com>,
linux-mm@kvack.org,
Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>,
minchan.kim@gmail.com, rientjes@google.com,
sparclinux@vger.kernel.org, cl@linux.com,
linuxppc-dev@lists.ozlabs.org, akpm@linux-foundation.org,
liuj97@gmail.com
Subject: Re: [PATCH 1/10] memory-hotplug : check whether memory is offline or not when removing memory
Date: Sat, 20 Oct 2012 08:50:45 +0800 [thread overview]
Message-ID: <5081F565.8020605@cn.fujitsu.com> (raw)
In-Reply-To: <CAHGf_=q=Agidyj_j6jhBdhNmJBy2u1dP+UMAoXbM=_=DyZJs_w@mail.gmail.com>
At 10/20/2012 02:33 AM, KOSAKI Motohiro Wrote:
>> I think it again, and found that this check is necessary. Because we only
>> lock memory hotplug when offlining pages. Here is the steps to offline and
>> remove memory:
>>
>> 1. lock memory hotplug
>> 2. offline a memory section
>> 3. unlock memory hotplug
>> 4. repeat 1-3 to offline all memory sections
>> 5. lock memory hotplug
>> 6. remove memory
>> 7. unlock memory hotplug
>>
>> All memory sections must be offlined before removing memory. But we don't
>> hold
>> the lock in the whole operation. So we should check whether all memory
>> sections
>> are offlined before step6.
>
> You should describe the race scenario in the patch description. OK?
>
OK
Thanks
Wen Congyang
WARNING: multiple messages have this Message-ID (diff)
From: Wen Congyang <wency@cn.fujitsu.com>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Wen Congyang <wencongyang@gmail.com>,
Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>,
x86@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-acpi@vger.kernel.org,
linux-s390@vger.kernel.org, linux-sh@vger.kernel.org,
linux-ia64@vger.kernel.org, cmetcalf@tilera.com,
sparclinux@vger.kernel.org, rientjes@google.com,
liuj97@gmail.com, len.brown@intel.com, cl@linux.com,
minchan.kim@gmail.com, akpm@linux-foundation.org
Subject: Re: [PATCH 1/10] memory-hotplug : check whether memory is offline or not when removing memory
Date: Sat, 20 Oct 2012 08:50:45 +0800 [thread overview]
Message-ID: <5081F565.8020605@cn.fujitsu.com> (raw)
In-Reply-To: <CAHGf_=q=Agidyj_j6jhBdhNmJBy2u1dP+UMAoXbM=_=DyZJs_w@mail.gmail.com>
At 10/20/2012 02:33 AM, KOSAKI Motohiro Wrote:
>> I think it again, and found that this check is necessary. Because we only
>> lock memory hotplug when offlining pages. Here is the steps to offline and
>> remove memory:
>>
>> 1. lock memory hotplug
>> 2. offline a memory section
>> 3. unlock memory hotplug
>> 4. repeat 1-3 to offline all memory sections
>> 5. lock memory hotplug
>> 6. remove memory
>> 7. unlock memory hotplug
>>
>> All memory sections must be offlined before removing memory. But we don't
>> hold
>> the lock in the whole operation. So we should check whether all memory
>> sections
>> are offlined before step6.
>
> You should describe the race scenario in the patch description. OK?
>
OK
Thanks
Wen Congyang
next prev parent reply other threads:[~2012-10-20 0:50 UTC|newest]
Thread overview: 129+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-05 2:20 [PATCH 0/10] memory-hotplug: hot-remove physical memory Yasuaki Ishimatsu
2012-10-05 2:20 ` Yasuaki Ishimatsu
2012-10-05 2:20 ` Yasuaki Ishimatsu
2012-10-05 2:20 ` Yasuaki Ishimatsu
2012-10-05 2:20 ` Yasuaki Ishimatsu
2012-10-05 2:25 ` [PATCH 1/10] memory-hotplug : check whether memory is offline or not when removing memory Yasuaki Ishimatsu
2012-10-05 2:25 ` Yasuaki Ishimatsu
2012-10-05 2:25 ` Yasuaki Ishimatsu
2012-10-05 2:25 ` Yasuaki Ishimatsu
2012-10-05 19:27 ` KOSAKI Motohiro
2012-10-05 19:27 ` KOSAKI Motohiro
2012-10-05 19:27 ` KOSAKI Motohiro
2012-10-05 19:27 ` KOSAKI Motohiro
2012-10-19 10:44 ` Wen Congyang
2012-10-19 10:44 ` Wen Congyang
2012-10-19 10:44 ` Wen Congyang
2012-10-19 10:44 ` Wen Congyang
2012-10-19 14:15 ` Wen Congyang
2012-10-19 14:15 ` Wen Congyang
2012-10-19 14:15 ` Wen Congyang
2012-10-19 14:15 ` Wen Congyang
2012-10-19 18:33 ` KOSAKI Motohiro
2012-10-19 18:33 ` KOSAKI Motohiro
2012-10-19 18:33 ` KOSAKI Motohiro
2012-10-19 18:33 ` KOSAKI Motohiro
2012-10-20 0:50 ` Wen Congyang [this message]
2012-10-20 0:50 ` Wen Congyang
2012-10-20 0:50 ` Wen Congyang
2012-10-20 0:50 ` Wen Congyang
2012-10-05 2:26 ` [PATCH 2/10] memory-hotplug : remove /sys/firmware/memmap/X sysfs Yasuaki Ishimatsu
2012-10-05 2:26 ` Yasuaki Ishimatsu
2012-10-05 2:26 ` Yasuaki Ishimatsu
2012-10-05 2:26 ` Yasuaki Ishimatsu
2012-10-05 2:26 ` Yasuaki Ishimatsu
2012-10-05 19:36 ` KOSAKI Motohiro
2012-10-05 19:36 ` KOSAKI Motohiro
2012-10-05 19:36 ` KOSAKI Motohiro
2012-10-05 19:36 ` KOSAKI Motohiro
2012-10-11 7:06 ` Yasuaki Ishimatsu
2012-10-11 7:06 ` Yasuaki Ishimatsu
2012-10-11 7:06 ` Yasuaki Ishimatsu
2012-10-11 7:06 ` Yasuaki Ishimatsu
2012-10-11 7:06 ` Yasuaki Ishimatsu
2012-10-05 2:29 ` [PATCH 3/10] memory-hotplug : introduce new function arch_remove_memory() for removing page table depends on architecture Yasuaki Ishimatsu
2012-10-05 2:29 ` Yasuaki Ishimatsu
2012-10-05 2:29 ` Yasuaki Ishimatsu
2012-10-05 2:29 ` Yasuaki Ishimatsu
2012-10-05 2:29 ` [PATCH 3/10] memory-hotplug : introduce new function arch_remove_memory() for removing page table de Yasuaki Ishimatsu
2012-10-05 2:31 ` [PATCH 4/10] memory-hotplug : unregister memory section on SPARSEMEM_VMEMMAP Yasuaki Ishimatsu
2012-10-05 2:31 ` Yasuaki Ishimatsu
2012-10-05 2:31 ` Yasuaki Ishimatsu
2012-10-05 2:31 ` Yasuaki Ishimatsu
2012-10-05 2:31 ` Yasuaki Ishimatsu
2012-10-05 2:32 ` [PATCH 5/10] memory-hotplug : memory-hotplug: check page type in get_page_bootmem Yasuaki Ishimatsu
2012-10-05 2:32 ` Yasuaki Ishimatsu
2012-10-05 2:32 ` Yasuaki Ishimatsu
2012-10-05 2:32 ` Yasuaki Ishimatsu
2012-10-05 2:32 ` Yasuaki Ishimatsu
2012-10-12 19:28 ` KOSAKI Motohiro
2012-10-12 19:28 ` KOSAKI Motohiro
2012-10-12 19:28 ` KOSAKI Motohiro
2012-10-12 19:28 ` KOSAKI Motohiro
2012-10-19 0:49 ` Yasuaki Ishimatsu
2012-10-19 0:49 ` Yasuaki Ishimatsu
2012-10-19 0:49 ` Yasuaki Ishimatsu
2012-10-19 0:49 ` Yasuaki Ishimatsu
2012-10-19 0:49 ` Yasuaki Ishimatsu
2012-10-19 1:55 ` Wen Congyang
2012-10-19 1:55 ` Wen Congyang
2012-10-19 1:55 ` Wen Congyang
2012-10-19 1:55 ` Wen Congyang
2012-10-05 2:33 ` [PATCH 6/10] memory-hotplug : implement register_page_bootmem_info_section of sparse-vmemmap Yasuaki Ishimatsu
2012-10-05 2:33 ` Yasuaki Ishimatsu
2012-10-05 2:33 ` Yasuaki Ishimatsu
2012-10-05 2:33 ` Yasuaki Ishimatsu
2012-10-05 2:34 ` [PATCH 7/10] memory-hotplug : remove memmap " Yasuaki Ishimatsu
2012-10-05 2:34 ` Yasuaki Ishimatsu
2012-10-05 2:34 ` Yasuaki Ishimatsu
2012-10-05 2:34 ` Yasuaki Ishimatsu
2012-10-05 2:34 ` Yasuaki Ishimatsu
2012-10-05 2:36 ` [PATCH 8/10] memory-hotplug : remove page table of x86_64 architecture Yasuaki Ishimatsu
2012-10-05 2:36 ` Yasuaki Ishimatsu
2012-10-05 2:36 ` Yasuaki Ishimatsu
2012-10-05 2:36 ` Yasuaki Ishimatsu
2012-10-08 4:37 ` Andi Kleen
2012-10-08 4:37 ` Andi Kleen
2012-10-08 4:37 ` Andi Kleen
2012-10-08 4:37 ` Andi Kleen
2012-10-08 5:23 ` Wen Congyang
2012-10-08 5:23 ` Wen Congyang
2012-10-08 5:23 ` Wen Congyang
2012-10-08 5:23 ` Wen Congyang
2012-10-11 0:35 ` Ni zhan Chen
2012-10-11 0:35 ` Ni zhan Chen
2012-10-11 0:35 ` Ni zhan Chen
2012-10-11 0:35 ` Ni zhan Chen
2012-10-09 8:26 ` wujianguo
2012-10-09 8:26 ` wujianguo
2012-10-09 8:26 ` wujianguo
2012-10-09 8:26 ` wujianguo
2012-10-22 7:11 ` Wen Congyang
2012-10-22 7:11 ` Wen Congyang
2012-10-22 7:11 ` Wen Congyang
2012-10-22 7:11 ` Wen Congyang
2012-10-23 7:09 ` wujianguo
2012-10-23 7:09 ` wujianguo
2012-10-23 7:09 ` wujianguo
2012-10-23 7:09 ` wujianguo
2012-10-23 7:41 ` Wen Congyang
2012-10-23 7:41 ` Wen Congyang
2012-10-23 7:41 ` Wen Congyang
2012-10-23 7:41 ` Wen Congyang
2012-10-05 2:37 ` [PATCH 9/10] memory-hotplug : memory_hotplug: clear zone when removing the memory Yasuaki Ishimatsu
2012-10-05 2:37 ` Yasuaki Ishimatsu
2012-10-05 2:37 ` Yasuaki Ishimatsu
2012-10-05 2:37 ` Yasuaki Ishimatsu
2012-10-05 2:38 ` [PATCH 10/10] memory-hotplug : remove sysfs file of node Yasuaki Ishimatsu
2012-10-05 2:38 ` Yasuaki Ishimatsu
2012-10-05 2:38 ` Yasuaki Ishimatsu
2012-10-05 2:38 ` Yasuaki Ishimatsu
2012-10-05 2:38 ` Yasuaki Ishimatsu
2012-10-05 19:06 ` [PATCH 0/10] memory-hotplug: hot-remove physical memory KOSAKI Motohiro
2012-10-05 19:06 ` KOSAKI Motohiro
2012-10-05 19:06 ` KOSAKI Motohiro
2012-10-05 19:06 ` KOSAKI Motohiro
2012-10-08 5:26 ` Wen Congyang
2012-10-08 5:26 ` Wen Congyang
2012-10-08 5:26 ` Wen Congyang
2012-10-08 5:26 ` Wen Congyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5081F565.8020605@cn.fujitsu.com \
--to=wency@cn.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=cmetcalf@tilera.com \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=liuj97@gmail.com \
--cc=minchan.kim@gmail.com \
--cc=rientjes@google.com \
--cc=sparclinux@vger.kernel.org \
--cc=wencongyang@gmail.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.