From: Stephen Boyd <sboyd@codeaurora.org>
To: Will Deacon <will.deacon@arm.com>
Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
Nicolas Pitre <nicolas.pitre@linaro.org>,
Dave Martin <dave.martin@linaro.org>,
Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>,
Russell King <linux@arm.linux.org.uk>,
"linux-sh@vger.kernel.org" <linux-sh@vger.kernel.org>,
Catalin Marinas <Catalin.Marinas@arm.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Amit Kucheria <amit.kucheria@linaro.org>,
Simon Horman <horms@verge.net.au>,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
Colin Cross <ccross@android.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
Wenzeng Chen <wzch@marvell.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [RFC PATCH v2 3/5] ARM: kernel: update cpu_suspend code to use cache LoUIS operations
Date: Tue, 11 Dec 2012 15:27:39 -0800 [thread overview]
Message-ID: <50C7C16B.7050106@codeaurora.org> (raw)
In-Reply-To: <20121211163843.GH16759@mudshark.cambridge.arm.com>
On 12/11/12 08:38, Will Deacon wrote:
> diff --git a/arch/arm/mm/cache-v7.S b/arch/arm/mm/cache-v7.S
> index cd95664..f58248f 100644
> --- a/arch/arm/mm/cache-v7.S
> +++ b/arch/arm/mm/cache-v7.S
> @@ -44,7 +44,8 @@ ENDPROC(v7_flush_icache_all)
> ENTRY(v7_flush_dcache_louis)
> dmb @ ensure ordering with previous memory accesses
> mrc p15, 1, r0, c0, c0, 1 @ read clidr, r0 = clidr
> - ands r3, r0, #0xe00000 @ extract LoUIS from clidr
> + ALT_SMP(ands r3, r0, #(7 << 21)) @ extract LoUIS from clidr
> + ALT_UP(ands r3, r0, #(7 << 27)) @ extract LoUU from clidr
> mov r3, r3, lsr #20 @ r3 = LoUIS * 2
You need to fix this mov as well, right?
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@codeaurora.org>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC PATCH v2 3/5] ARM: kernel: update cpu_suspend code to use cache LoUIS operations
Date: Tue, 11 Dec 2012 23:27:39 +0000 [thread overview]
Message-ID: <50C7C16B.7050106@codeaurora.org> (raw)
In-Reply-To: <20121211163843.GH16759@mudshark.cambridge.arm.com>
On 12/11/12 08:38, Will Deacon wrote:
> diff --git a/arch/arm/mm/cache-v7.S b/arch/arm/mm/cache-v7.S
> index cd95664..f58248f 100644
> --- a/arch/arm/mm/cache-v7.S
> +++ b/arch/arm/mm/cache-v7.S
> @@ -44,7 +44,8 @@ ENDPROC(v7_flush_icache_all)
> ENTRY(v7_flush_dcache_louis)
> dmb @ ensure ordering with previous memory accesses
> mrc p15, 1, r0, c0, c0, 1 @ read clidr, r0 = clidr
> - ands r3, r0, #0xe00000 @ extract LoUIS from clidr
> + ALT_SMP(ands r3, r0, #(7 << 21)) @ extract LoUIS from clidr
> + ALT_UP(ands r3, r0, #(7 << 27)) @ extract LoUU from clidr
> mov r3, r3, lsr #20 @ r3 = LoUIS * 2
You need to fix this mov as well, right?
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH v2 3/5] ARM: kernel: update cpu_suspend code to use cache LoUIS operations
Date: Tue, 11 Dec 2012 15:27:39 -0800 [thread overview]
Message-ID: <50C7C16B.7050106@codeaurora.org> (raw)
In-Reply-To: <20121211163843.GH16759@mudshark.cambridge.arm.com>
On 12/11/12 08:38, Will Deacon wrote:
> diff --git a/arch/arm/mm/cache-v7.S b/arch/arm/mm/cache-v7.S
> index cd95664..f58248f 100644
> --- a/arch/arm/mm/cache-v7.S
> +++ b/arch/arm/mm/cache-v7.S
> @@ -44,7 +44,8 @@ ENDPROC(v7_flush_icache_all)
> ENTRY(v7_flush_dcache_louis)
> dmb @ ensure ordering with previous memory accesses
> mrc p15, 1, r0, c0, c0, 1 @ read clidr, r0 = clidr
> - ands r3, r0, #0xe00000 @ extract LoUIS from clidr
> + ALT_SMP(ands r3, r0, #(7 << 21)) @ extract LoUIS from clidr
> + ALT_UP(ands r3, r0, #(7 << 27)) @ extract LoUU from clidr
> mov r3, r3, lsr #20 @ r3 = LoUIS * 2
You need to fix this mov as well, right?
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
next prev parent reply other threads:[~2012-12-11 23:27 UTC|newest]
Thread overview: 97+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-18 16:35 [RFC PATCH v2 0/5] ARM: augment cache flushing API Lorenzo Pieralisi
2012-09-18 16:35 ` Lorenzo Pieralisi
2012-09-18 16:35 ` [RFC PATCH v2 1/5] ARM: mm: implement LoUIS API for cache maintenance ops Lorenzo Pieralisi
2012-09-18 16:35 ` Lorenzo Pieralisi
2012-09-18 18:12 ` Nicolas Pitre
2012-09-18 18:12 ` Nicolas Pitre
2012-09-19 12:30 ` Lorenzo Pieralisi
2012-09-19 12:30 ` Lorenzo Pieralisi
2012-09-18 16:35 ` [RFC PATCH v2 2/5] ARM: mm: rename jump labels in v7_flush_dcache_all function Lorenzo Pieralisi
2012-09-18 16:35 ` Lorenzo Pieralisi
2012-09-18 18:13 ` Nicolas Pitre
2012-09-18 18:13 ` Nicolas Pitre
2012-09-19 13:51 ` Dave Martin
2012-09-19 13:51 ` Dave Martin
2012-09-20 10:32 ` Lorenzo Pieralisi
2012-09-20 10:32 ` Lorenzo Pieralisi
2012-09-20 11:01 ` Dave Martin
2012-09-20 11:01 ` Dave Martin
2012-09-18 16:35 ` [RFC PATCH v2 3/5] ARM: kernel: update cpu_suspend code to use cache LoUIS operations Lorenzo Pieralisi
2012-09-18 16:35 ` Lorenzo Pieralisi
2012-09-18 18:18 ` Nicolas Pitre
2012-09-18 18:18 ` Nicolas Pitre
2012-09-19 13:46 ` Dave Martin
2012-09-19 13:46 ` Dave Martin
2012-09-20 10:25 ` Lorenzo Pieralisi
2012-09-20 10:25 ` Lorenzo Pieralisi
2012-09-20 11:04 ` Dave Martin
2012-09-20 11:04 ` Dave Martin
2012-12-11 16:07 ` Guennadi Liakhovetski
2012-12-11 16:07 ` Guennadi Liakhovetski
2012-12-11 16:07 ` Guennadi Liakhovetski
2012-12-11 16:33 ` Will Deacon
2012-12-11 16:33 ` Will Deacon
2012-12-11 16:33 ` Will Deacon
2012-12-11 16:38 ` Will Deacon
2012-12-11 16:38 ` Will Deacon
2012-12-11 16:38 ` Will Deacon
2012-12-11 17:07 ` Guennadi Liakhovetski
2012-12-11 17:07 ` Guennadi Liakhovetski
2012-12-11 17:07 ` Guennadi Liakhovetski
2012-12-11 17:47 ` Will Deacon
2012-12-11 17:47 ` Will Deacon
2012-12-11 17:47 ` Will Deacon
2012-12-11 17:55 ` Guennadi Liakhovetski
2012-12-11 17:55 ` Guennadi Liakhovetski
2012-12-11 17:55 ` Guennadi Liakhovetski
2012-12-11 23:27 ` Stephen Boyd [this message]
2012-12-11 23:27 ` Stephen Boyd
2012-12-11 23:27 ` Stephen Boyd
2012-12-12 10:31 ` Will Deacon
2012-12-12 10:31 ` Will Deacon
2012-12-12 10:31 ` Will Deacon
2012-12-12 16:43 ` Guennadi Liakhovetski
2012-12-12 16:43 ` Guennadi Liakhovetski
2012-12-12 16:43 ` Guennadi Liakhovetski
2012-12-12 10:33 ` Lorenzo Pieralisi
2012-12-12 10:33 ` Lorenzo Pieralisi
2012-12-12 10:33 ` Lorenzo Pieralisi
2012-12-12 13:36 ` Will Deacon
2012-12-12 13:36 ` Will Deacon
2012-12-12 13:36 ` Will Deacon
2012-12-13 8:09 ` Guennadi Liakhovetski
2012-12-13 8:09 ` Guennadi Liakhovetski
2012-12-13 8:09 ` Guennadi Liakhovetski
2012-12-13 10:51 ` Will Deacon
2012-12-13 10:51 ` Will Deacon
2012-12-13 10:51 ` Will Deacon
2012-12-13 14:32 ` Guennadi Liakhovetski
2012-12-13 14:32 ` Guennadi Liakhovetski
2012-12-13 14:32 ` Guennadi Liakhovetski
2012-12-13 14:39 ` Santosh Shilimkar
2012-12-13 14:39 ` Santosh Shilimkar
2012-12-13 14:39 ` Santosh Shilimkar
2012-12-28 11:32 ` [PATCH v2] ARM: sh7372: fix cache clean / invalidate order Guennadi Liakhovetski
2012-12-28 11:32 ` Guennadi Liakhovetski
2012-12-28 11:32 ` Guennadi Liakhovetski
2012-12-28 21:50 ` Simon Horman
2012-12-28 21:50 ` Simon Horman
2012-12-28 21:50 ` Simon Horman
2012-12-13 14:52 ` [RFC PATCH v2 3/5] ARM: kernel: update cpu_suspend code to use cache LoUIS operations Will Deacon
2012-12-13 14:52 ` Will Deacon
2012-12-13 14:52 ` Will Deacon
2012-12-12 16:43 ` Guennadi Liakhovetski
2012-12-12 16:43 ` Guennadi Liakhovetski
2012-12-12 16:43 ` Guennadi Liakhovetski
2012-09-18 16:35 ` [RFC PATCH v2 4/5] ARM: kernel: update __cpu_disable to use cache LoUIS maintenance API Lorenzo Pieralisi
2012-09-18 16:35 ` Lorenzo Pieralisi
2012-09-18 18:19 ` Nicolas Pitre
2012-09-18 18:19 ` Nicolas Pitre
2012-09-18 16:35 ` [RFC PATCH v2 5/5] ARM: mm: update __v7_setup() to the new LoUIS cache " Lorenzo Pieralisi
2012-09-18 16:35 ` Lorenzo Pieralisi
2012-09-18 18:20 ` Nicolas Pitre
2012-09-18 18:20 ` Nicolas Pitre
2012-09-20 11:27 ` [RFC PATCH v2 0/5] ARM: augment cache flushing API Lorenzo Pieralisi
2012-09-20 11:27 ` Lorenzo Pieralisi
2012-09-21 8:07 ` Shawn Guo
2012-09-21 8:07 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50C7C16B.7050106@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=Catalin.Marinas@arm.com \
--cc=Lorenzo.Pieralisi@arm.com \
--cc=amit.kucheria@linaro.org \
--cc=ccross@android.com \
--cc=daniel.lezcano@linaro.org \
--cc=dave.martin@linaro.org \
--cc=g.liakhovetski@gmx.de \
--cc=horms@verge.net.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=nicolas.pitre@linaro.org \
--cc=santosh.shilimkar@ti.com \
--cc=will.deacon@arm.com \
--cc=wzch@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.