[Xenomai] XNARCH_TIMER_IRQ

[Xenomai] XNARCH_TIMER_IRQ

[Jan Kiszka]

Hi,

this may involve some refactoring of the HAL and a bit of I-pipe, so I
better ask first:

Not sure when it changed, but XNARCH_TIMER_IRQ may no longer return the
same values when called on different CPUs. Therefore, It should rather
be called XNARCH_THIS_CPU_TIMER_IRQ now.

Looking at its users (an I-pipe debug warning pointed it out), there are
two that don't expect this: xnintr_query_next() and format_irq_proc().
The former actually wants XNARCH_TIMER_IRQ(cpu), the latter needs
something like is_timer_irq_on_any_cpus(irq).

So I would propose to refactor XNARCH_TIMER_IRQ and RTHAL_TIMER_IRQ
accordingly. But this unfortunately requires extensions of I-pipe to
provide something like __ipipe_hrtimer_irq(cpu) and
__ipipe_this_cpu_hrtimer_irq. And some ugly workaround in Xenomai for
older I-pipe versions.

Does this make sense?

Jan

-- 
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux

Re: [Xenomai] XNARCH_TIMER_IRQ

[Gilles Chanteperdrix]

On 01/02/2013 06:43 PM, Jan Kiszka wrote:
> Hi,
> 
> this may involve some refactoring of the HAL and a bit of I-pipe, so I
> better ask first:
> 
> Not sure when it changed, but XNARCH_TIMER_IRQ may no longer return the
> same values when called on different CPUs. Therefore, It should rather
> be called XNARCH_THIS_CPU_TIMER_IRQ now.
> 
> Looking at its users (an I-pipe debug warning pointed it out), there are
> two that don't expect this: xnintr_query_next() and format_irq_proc().
> The former actually wants XNARCH_TIMER_IRQ(cpu), the latter needs
> something like is_timer_irq_on_any_cpus(irq).
> 
> So I would propose to refactor XNARCH_TIMER_IRQ and RTHAL_TIMER_IRQ
> accordingly. But this unfortunately requires extensions of I-pipe to
> provide something like __ipipe_hrtimer_irq(cpu) and
> __ipipe_this_cpu_hrtimer_irq. And some ugly workaround in Xenomai for
> older I-pipe versions.
> 
> Does this make sense?

Made something similar for forge:
http://git.xenomai.org/?p=xenomai-gch.git;a=commitdiff;h=37ca257af466e7e5fbfb402b39f088487d048fd5;hp=a9971c363fd361b428f12200536bc5a01dff9c05

-- 
					    Gilles.

Re: [Xenomai] XNARCH_TIMER_IRQ

[Jan Kiszka]

On 2013-01-03 16:16, Gilles Chanteperdrix wrote:
> On 01/02/2013 06:43 PM, Jan Kiszka wrote:
>> Hi,
>>
>> this may involve some refactoring of the HAL and a bit of I-pipe, so I
>> better ask first:
>>
>> Not sure when it changed, but XNARCH_TIMER_IRQ may no longer return the
>> same values when called on different CPUs. Therefore, It should rather
>> be called XNARCH_THIS_CPU_TIMER_IRQ now.
>>
>> Looking at its users (an I-pipe debug warning pointed it out), there are
>> two that don't expect this: xnintr_query_next() and format_irq_proc().
>> The former actually wants XNARCH_TIMER_IRQ(cpu), the latter needs
>> something like is_timer_irq_on_any_cpus(irq).
>>
>> So I would propose to refactor XNARCH_TIMER_IRQ and RTHAL_TIMER_IRQ
>> accordingly. But this unfortunately requires extensions of I-pipe to
>> provide something like __ipipe_hrtimer_irq(cpu) and
>> __ipipe_this_cpu_hrtimer_irq. And some ugly workaround in Xenomai for
>> older I-pipe versions.
>>
>> Does this make sense?
> 
> Made something similar for forge:
> http://git.xenomai.org/?p=xenomai-gch.git;a=commitdiff;h=37ca257af466e7e5fbfb402b39f088487d048fd5;hp=a9971c363fd361b428f12200536bc5a01dff9c05

Oh, great, there is already something usable in the core patches. Fix
for 2.6 will follow.

Jan

-- 
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux

Re: [Xenomai] XNARCH_TIMER_IRQ

[Philippe Gerum]

On 01/03/2013 04:44 PM, Jan Kiszka wrote:
> On 2013-01-03 16:16, Gilles Chanteperdrix wrote:
>> On 01/02/2013 06:43 PM, Jan Kiszka wrote:
>>> Hi,
>>>
>>> this may involve some refactoring of the HAL and a bit of I-pipe, so I
>>> better ask first:
>>>
>>> Not sure when it changed, but XNARCH_TIMER_IRQ may no longer return the
>>> same values when called on different CPUs. Therefore, It should rather
>>> be called XNARCH_THIS_CPU_TIMER_IRQ now.
>>>
>>> Looking at its users (an I-pipe debug warning pointed it out), there are
>>> two that don't expect this: xnintr_query_next() and format_irq_proc().
>>> The former actually wants XNARCH_TIMER_IRQ(cpu), the latter needs
>>> something like is_timer_irq_on_any_cpus(irq).
>>>
>>> So I would propose to refactor XNARCH_TIMER_IRQ and RTHAL_TIMER_IRQ
>>> accordingly. But this unfortunately requires extensions of I-pipe to
>>> provide something like __ipipe_hrtimer_irq(cpu) and
>>> __ipipe_this_cpu_hrtimer_irq. And some ugly workaround in Xenomai for
>>> older I-pipe versions.
>>>
>>> Does this make sense?
>>
>> Made something similar for forge:
>> http://git.xenomai.org/?p=xenomai-gch.git;a=commitdiff;h=37ca257af466e7e5fbfb402b39f088487d048fd5;hp=a9971c363fd361b428f12200536bc5a01dff9c05
>

Caution, this code is WIP. nktimer will have to move to the percpu 
scheduler descriptor to complete this.

> Oh, great, there is already something usable in the core patches. Fix
> for 2.6 will follow.
>

-- 
Philippe.

Re: [Xenomai] XNARCH_TIMER_IRQ

[Gilles Chanteperdrix]

On 01/03/2013 05:27 PM, Philippe Gerum wrote:
> On 01/03/2013 04:44 PM, Jan Kiszka wrote:
>> On 2013-01-03 16:16, Gilles Chanteperdrix wrote:
>>> On 01/02/2013 06:43 PM, Jan Kiszka wrote:
>>>> Hi,
>>>>
>>>> this may involve some refactoring of the HAL and a bit of I-pipe, so I
>>>> better ask first:
>>>>
>>>> Not sure when it changed, but XNARCH_TIMER_IRQ may no longer return the
>>>> same values when called on different CPUs. Therefore, It should rather
>>>> be called XNARCH_THIS_CPU_TIMER_IRQ now.
>>>>
>>>> Looking at its users (an I-pipe debug warning pointed it out), there are
>>>> two that don't expect this: xnintr_query_next() and format_irq_proc().
>>>> The former actually wants XNARCH_TIMER_IRQ(cpu), the latter needs
>>>> something like is_timer_irq_on_any_cpus(irq).
>>>>
>>>> So I would propose to refactor XNARCH_TIMER_IRQ and RTHAL_TIMER_IRQ
>>>> accordingly. But this unfortunately requires extensions of I-pipe to
>>>> provide something like __ipipe_hrtimer_irq(cpu) and
>>>> __ipipe_this_cpu_hrtimer_irq. And some ugly workaround in Xenomai for
>>>> older I-pipe versions.
>>>>
>>>> Does this make sense?
>>>
>>> Made something similar for forge:
>>> http://git.xenomai.org/?p=xenomai-gch.git;a=commitdiff;h=37ca257af466e7e5fbfb402b39f088487d048fd5;hp=a9971c363fd361b428f12200536bc5a01dff9c05
>>
> 
> Caution, this code is WIP. nktimer will have to move to the percpu 
> scheduler descriptor to complete this.

You mean nkclock? But does it make sense if the timer has the same irq
on all cpus?

-- 
					    Gilles.

Re: [Xenomai] XNARCH_TIMER_IRQ

[Philippe Gerum]

On 01/03/2013 06:21 PM, Gilles Chanteperdrix wrote:
> On 01/03/2013 05:27 PM, Philippe Gerum wrote:
>> On 01/03/2013 04:44 PM, Jan Kiszka wrote:
>>> On 2013-01-03 16:16, Gilles Chanteperdrix wrote:
>>>> On 01/02/2013 06:43 PM, Jan Kiszka wrote:
>>>>> Hi,
>>>>>
>>>>> this may involve some refactoring of the HAL and a bit of I-pipe, so I
>>>>> better ask first:
>>>>>
>>>>> Not sure when it changed, but XNARCH_TIMER_IRQ may no longer return the
>>>>> same values when called on different CPUs. Therefore, It should rather
>>>>> be called XNARCH_THIS_CPU_TIMER_IRQ now.
>>>>>
>>>>> Looking at its users (an I-pipe debug warning pointed it out), there are
>>>>> two that don't expect this: xnintr_query_next() and format_irq_proc().
>>>>> The former actually wants XNARCH_TIMER_IRQ(cpu), the latter needs
>>>>> something like is_timer_irq_on_any_cpus(irq).
>>>>>
>>>>> So I would propose to refactor XNARCH_TIMER_IRQ and RTHAL_TIMER_IRQ
>>>>> accordingly. But this unfortunately requires extensions of I-pipe to
>>>>> provide something like __ipipe_hrtimer_irq(cpu) and
>>>>> __ipipe_this_cpu_hrtimer_irq. And some ugly workaround in Xenomai for
>>>>> older I-pipe versions.
>>>>>
>>>>> Does this make sense?
>>>>
>>>> Made something similar for forge:
>>>> http://git.xenomai.org/?p=xenomai-gch.git;a=commitdiff;h=37ca257af466e7e5fbfb402b39f088487d048fd5;hp=a9971c363fd361b428f12200536bc5a01dff9c05
>>>
>>
>> Caution, this code is WIP. nktimer will have to move to the percpu
>> scheduler descriptor to complete this.
>
> You mean nkclock? But does it make sense if the timer has the same irq
> on all cpus?
>

If we stop assuming that for some archs, we have to stop assuming the 
same for any arch.

-- 
Philippe.

Re: [Xenomai] XNARCH_TIMER_IRQ

[Jan Kiszka]

On 2013-01-03 17:27, Philippe Gerum wrote:
> On 01/03/2013 04:44 PM, Jan Kiszka wrote:
>> On 2013-01-03 16:16, Gilles Chanteperdrix wrote:
>>> On 01/02/2013 06:43 PM, Jan Kiszka wrote:
>>>> Hi,
>>>>
>>>> this may involve some refactoring of the HAL and a bit of I-pipe, so I
>>>> better ask first:
>>>>
>>>> Not sure when it changed, but XNARCH_TIMER_IRQ may no longer return the
>>>> same values when called on different CPUs. Therefore, It should rather
>>>> be called XNARCH_THIS_CPU_TIMER_IRQ now.
>>>>
>>>> Looking at its users (an I-pipe debug warning pointed it out), there are
>>>> two that don't expect this: xnintr_query_next() and format_irq_proc().
>>>> The former actually wants XNARCH_TIMER_IRQ(cpu), the latter needs
>>>> something like is_timer_irq_on_any_cpus(irq).
>>>>
>>>> So I would propose to refactor XNARCH_TIMER_IRQ and RTHAL_TIMER_IRQ
>>>> accordingly. But this unfortunately requires extensions of I-pipe to
>>>> provide something like __ipipe_hrtimer_irq(cpu) and
>>>> __ipipe_this_cpu_hrtimer_irq. And some ugly workaround in Xenomai for
>>>> older I-pipe versions.
>>>>
>>>> Does this make sense?
>>>
>>> Made something similar for forge:
>>> http://git.xenomai.org/?p=xenomai-gch.git;a=commitdiff;h=37ca257af466e7e5fbfb402b39f088487d048fd5;hp=a9971c363fd361b428f12200536bc5a01dff9c05
>>
> 
> Caution, this code is WIP. nktimer will have to move to the percpu 
> scheduler descriptor to complete this.

That's nkclock in 2.6. Mostly a cosmetic issue, the interrupt name will
not be properly printed, statistics are already per-cpu. Could be
improved nevertheless.

Is there an easy way to find out if we have per-CPU timers on some arch?

Jan

-- 
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux

Re: [Xenomai] XNARCH_TIMER_IRQ

[Gilles Chanteperdrix]

On 01/03/2013 06:25 PM, Jan Kiszka wrote:
> On 2013-01-03 17:27, Philippe Gerum wrote:
>> On 01/03/2013 04:44 PM, Jan Kiszka wrote:
>>> On 2013-01-03 16:16, Gilles Chanteperdrix wrote:
>>>> On 01/02/2013 06:43 PM, Jan Kiszka wrote:
>>>>> Hi,
>>>>>
>>>>> this may involve some refactoring of the HAL and a bit of I-pipe, so I
>>>>> better ask first:
>>>>>
>>>>> Not sure when it changed, but XNARCH_TIMER_IRQ may no longer return the
>>>>> same values when called on different CPUs. Therefore, It should rather
>>>>> be called XNARCH_THIS_CPU_TIMER_IRQ now.
>>>>>
>>>>> Looking at its users (an I-pipe debug warning pointed it out), there are
>>>>> two that don't expect this: xnintr_query_next() and format_irq_proc().
>>>>> The former actually wants XNARCH_TIMER_IRQ(cpu), the latter needs
>>>>> something like is_timer_irq_on_any_cpus(irq).
>>>>>
>>>>> So I would propose to refactor XNARCH_TIMER_IRQ and RTHAL_TIMER_IRQ
>>>>> accordingly. But this unfortunately requires extensions of I-pipe to
>>>>> provide something like __ipipe_hrtimer_irq(cpu) and
>>>>> __ipipe_this_cpu_hrtimer_irq. And some ugly workaround in Xenomai for
>>>>> older I-pipe versions.
>>>>>
>>>>> Does this make sense?
>>>>
>>>> Made something similar for forge:
>>>> http://git.xenomai.org/?p=xenomai-gch.git;a=commitdiff;h=37ca257af466e7e5fbfb402b39f088487d048fd5;hp=a9971c363fd361b428f12200536bc5a01dff9c05
>>>
>>
>> Caution, this code is WIP. nktimer will have to move to the percpu 
>> scheduler descriptor to complete this.
> 
> That's nkclock in 2.6. Mostly a cosmetic issue, the interrupt name will
> not be properly printed, statistics are already per-cpu. Could be
> improved nevertheless.
> 
> Is there an easy way to find out if we have per-CPU timers on some arch?

The thing is you can also have a mix, on x86 for instance, you could in
theory have a mix between LAPIC on some cpus, and HPET on other cpus.
Each HPET will have its own MSI, but all the LAPICs will use the same irq.

-- 
					    Gilles.

Re: [Xenomai] XNARCH_TIMER_IRQ

[Philippe Gerum]

On 01/03/2013 06:25 PM, Jan Kiszka wrote:
> On 2013-01-03 17:27, Philippe Gerum wrote:
>> On 01/03/2013 04:44 PM, Jan Kiszka wrote:
>>> On 2013-01-03 16:16, Gilles Chanteperdrix wrote:
>>>> On 01/02/2013 06:43 PM, Jan Kiszka wrote:
>>>>> Hi,
>>>>>
>>>>> this may involve some refactoring of the HAL and a bit of I-pipe, so I
>>>>> better ask first:
>>>>>
>>>>> Not sure when it changed, but XNARCH_TIMER_IRQ may no longer return the
>>>>> same values when called on different CPUs. Therefore, It should rather
>>>>> be called XNARCH_THIS_CPU_TIMER_IRQ now.
>>>>>
>>>>> Looking at its users (an I-pipe debug warning pointed it out), there are
>>>>> two that don't expect this: xnintr_query_next() and format_irq_proc().
>>>>> The former actually wants XNARCH_TIMER_IRQ(cpu), the latter needs
>>>>> something like is_timer_irq_on_any_cpus(irq).
>>>>>
>>>>> So I would propose to refactor XNARCH_TIMER_IRQ and RTHAL_TIMER_IRQ
>>>>> accordingly. But this unfortunately requires extensions of I-pipe to
>>>>> provide something like __ipipe_hrtimer_irq(cpu) and
>>>>> __ipipe_this_cpu_hrtimer_irq. And some ugly workaround in Xenomai for
>>>>> older I-pipe versions.
>>>>>
>>>>> Does this make sense?
>>>>
>>>> Made something similar for forge:
>>>> http://git.xenomai.org/?p=xenomai-gch.git;a=commitdiff;h=37ca257af466e7e5fbfb402b39f088487d048fd5;hp=a9971c363fd361b428f12200536bc5a01dff9c05
>>>
>>
>> Caution, this code is WIP. nktimer will have to move to the percpu
>> scheduler descriptor to complete this.
>
> That's nkclock in 2.6. Mostly a cosmetic issue, the interrupt name will
> not be properly printed, statistics are already per-cpu. Could be
> improved nevertheless.
>

My point is to tell you that what you look to in -forge regarding this 
area is in a state of flux. I'm not referring to 2.6, I'm focusing 
almost exclusively on 3.x these days.

> Is there an easy way to find out if we have per-CPU timers on some arch?
>

Why should we assume differently?

> Jan
>


-- 
Philippe.

Re: [Xenomai] XNARCH_TIMER_IRQ

[Jan Kiszka]

On 2013-01-03 18:34, Philippe Gerum wrote:
> On 01/03/2013 06:25 PM, Jan Kiszka wrote:
>> On 2013-01-03 17:27, Philippe Gerum wrote:
>>> On 01/03/2013 04:44 PM, Jan Kiszka wrote:
>>>> On 2013-01-03 16:16, Gilles Chanteperdrix wrote:
>>>>> On 01/02/2013 06:43 PM, Jan Kiszka wrote:
>>>>>> Hi,
>>>>>>
>>>>>> this may involve some refactoring of the HAL and a bit of I-pipe, so I
>>>>>> better ask first:
>>>>>>
>>>>>> Not sure when it changed, but XNARCH_TIMER_IRQ may no longer return the
>>>>>> same values when called on different CPUs. Therefore, It should rather
>>>>>> be called XNARCH_THIS_CPU_TIMER_IRQ now.
>>>>>>
>>>>>> Looking at its users (an I-pipe debug warning pointed it out), there are
>>>>>> two that don't expect this: xnintr_query_next() and format_irq_proc().
>>>>>> The former actually wants XNARCH_TIMER_IRQ(cpu), the latter needs
>>>>>> something like is_timer_irq_on_any_cpus(irq).
>>>>>>
>>>>>> So I would propose to refactor XNARCH_TIMER_IRQ and RTHAL_TIMER_IRQ
>>>>>> accordingly. But this unfortunately requires extensions of I-pipe to
>>>>>> provide something like __ipipe_hrtimer_irq(cpu) and
>>>>>> __ipipe_this_cpu_hrtimer_irq. And some ugly workaround in Xenomai for
>>>>>> older I-pipe versions.
>>>>>>
>>>>>> Does this make sense?
>>>>>
>>>>> Made something similar for forge:
>>>>> http://git.xenomai.org/?p=xenomai-gch.git;a=commitdiff;h=37ca257af466e7e5fbfb402b39f088487d048fd5;hp=a9971c363fd361b428f12200536bc5a01dff9c05
>>>>
>>>
>>> Caution, this code is WIP. nktimer will have to move to the percpu
>>> scheduler descriptor to complete this.
>>
>> That's nkclock in 2.6. Mostly a cosmetic issue, the interrupt name will
>> not be properly printed, statistics are already per-cpu. Could be
>> improved nevertheless.
>>
> 
> My point is to tell you that what you look to in -forge regarding this 
> area is in a state of flux. I'm not referring to 2.6, I'm focusing 
> almost exclusively on 3.x these days.
> 
>> Is there an easy way to find out if we have per-CPU timers on some arch?
>>
> 
> Why should we assume differently?

To avoid dumping redundant statistic lines when some timer IRQ has no
home on a given CPU. But as there are also mixed setups possible as
Gilles pointed out, we need a different approach, likely just skip when
there are no hits.

Jan

-- 
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux

Re: [Xenomai] XNARCH_TIMER_IRQ

[Philippe Gerum]

On 01/03/2013 06:57 PM, Jan Kiszka wrote:
> On 2013-01-03 18:34, Philippe Gerum wrote:
>> On 01/03/2013 06:25 PM, Jan Kiszka wrote:
>>> On 2013-01-03 17:27, Philippe Gerum wrote:
>>>> On 01/03/2013 04:44 PM, Jan Kiszka wrote:
>>>>> On 2013-01-03 16:16, Gilles Chanteperdrix wrote:
>>>>>> On 01/02/2013 06:43 PM, Jan Kiszka wrote:
>>>>>>> Hi,
>>>>>>>
>>>>>>> this may involve some refactoring of the HAL and a bit of I-pipe, so I
>>>>>>> better ask first:
>>>>>>>
>>>>>>> Not sure when it changed, but XNARCH_TIMER_IRQ may no longer return the
>>>>>>> same values when called on different CPUs. Therefore, It should rather
>>>>>>> be called XNARCH_THIS_CPU_TIMER_IRQ now.
>>>>>>>
>>>>>>> Looking at its users (an I-pipe debug warning pointed it out), there are
>>>>>>> two that don't expect this: xnintr_query_next() and format_irq_proc().
>>>>>>> The former actually wants XNARCH_TIMER_IRQ(cpu), the latter needs
>>>>>>> something like is_timer_irq_on_any_cpus(irq).
>>>>>>>
>>>>>>> So I would propose to refactor XNARCH_TIMER_IRQ and RTHAL_TIMER_IRQ
>>>>>>> accordingly. But this unfortunately requires extensions of I-pipe to
>>>>>>> provide something like __ipipe_hrtimer_irq(cpu) and
>>>>>>> __ipipe_this_cpu_hrtimer_irq. And some ugly workaround in Xenomai for
>>>>>>> older I-pipe versions.
>>>>>>>
>>>>>>> Does this make sense?
>>>>>>
>>>>>> Made something similar for forge:
>>>>>> http://git.xenomai.org/?p=xenomai-gch.git;a=commitdiff;h=37ca257af466e7e5fbfb402b39f088487d048fd5;hp=a9971c363fd361b428f12200536bc5a01dff9c05
>>>>>
>>>>
>>>> Caution, this code is WIP. nktimer will have to move to the percpu
>>>> scheduler descriptor to complete this.
>>>
>>> That's nkclock in 2.6. Mostly a cosmetic issue, the interrupt name will
>>> not be properly printed, statistics are already per-cpu. Could be
>>> improved nevertheless.
>>>
>>
>> My point is to tell you that what you look to in -forge regarding this
>> area is in a state of flux. I'm not referring to 2.6, I'm focusing
>> almost exclusively on 3.x these days.
>>
>>> Is there an easy way to find out if we have per-CPU timers on some arch?
>>>
>>
>> Why should we assume differently?
>
> To avoid dumping redundant statistic lines when some timer IRQ has no
> home on a given CPU. But as there are also mixed setups possible as
> Gilles pointed out, we need a different approach, likely just skip when
> there are no hits.
>

Your question sounded like "is it possible to know whether an SMP arch 
may use different per-CPU IRQs for the timer". I was about to answer 
that testing for any pipeline core API rev >= 2 would do, excluding all 
legacy patches.

For the cosmetic issue you mention, testing rthal_supported_cpus would do.

-- 
Philippe.

Re: [Xenomai] XNARCH_TIMER_IRQ

[Jan Kiszka]

On 2013-01-04 11:01, Philippe Gerum wrote:
> On 01/03/2013 06:57 PM, Jan Kiszka wrote:
>> On 2013-01-03 18:34, Philippe Gerum wrote:
>>> On 01/03/2013 06:25 PM, Jan Kiszka wrote:
>>>> On 2013-01-03 17:27, Philippe Gerum wrote:
>>>>> On 01/03/2013 04:44 PM, Jan Kiszka wrote:
>>>>>> On 2013-01-03 16:16, Gilles Chanteperdrix wrote:
>>>>>>> On 01/02/2013 06:43 PM, Jan Kiszka wrote:
>>>>>>>> Hi,
>>>>>>>>
>>>>>>>> this may involve some refactoring of the HAL and a bit of I-pipe, so I
>>>>>>>> better ask first:
>>>>>>>>
>>>>>>>> Not sure when it changed, but XNARCH_TIMER_IRQ may no longer return the
>>>>>>>> same values when called on different CPUs. Therefore, It should rather
>>>>>>>> be called XNARCH_THIS_CPU_TIMER_IRQ now.
>>>>>>>>
>>>>>>>> Looking at its users (an I-pipe debug warning pointed it out), there are
>>>>>>>> two that don't expect this: xnintr_query_next() and format_irq_proc().
>>>>>>>> The former actually wants XNARCH_TIMER_IRQ(cpu), the latter needs
>>>>>>>> something like is_timer_irq_on_any_cpus(irq).
>>>>>>>>
>>>>>>>> So I would propose to refactor XNARCH_TIMER_IRQ and RTHAL_TIMER_IRQ
>>>>>>>> accordingly. But this unfortunately requires extensions of I-pipe to
>>>>>>>> provide something like __ipipe_hrtimer_irq(cpu) and
>>>>>>>> __ipipe_this_cpu_hrtimer_irq. And some ugly workaround in Xenomai for
>>>>>>>> older I-pipe versions.
>>>>>>>>
>>>>>>>> Does this make sense?
>>>>>>>
>>>>>>> Made something similar for forge:
>>>>>>> http://git.xenomai.org/?p=xenomai-gch.git;a=commitdiff;h=37ca257af466e7e5fbfb402b39f088487d048fd5;hp=a9971c363fd361b428f12200536bc5a01dff9c05
>>>>>>
>>>>>
>>>>> Caution, this code is WIP. nktimer will have to move to the percpu
>>>>> scheduler descriptor to complete this.
>>>>
>>>> That's nkclock in 2.6. Mostly a cosmetic issue, the interrupt name will
>>>> not be properly printed, statistics are already per-cpu. Could be
>>>> improved nevertheless.
>>>>
>>>
>>> My point is to tell you that what you look to in -forge regarding this
>>> area is in a state of flux. I'm not referring to 2.6, I'm focusing
>>> almost exclusively on 3.x these days.
>>>
>>>> Is there an easy way to find out if we have per-CPU timers on some arch?
>>>>
>>>
>>> Why should we assume differently?
>>
>> To avoid dumping redundant statistic lines when some timer IRQ has no
>> home on a given CPU. But as there are also mixed setups possible as
>> Gilles pointed out, we need a different approach, likely just skip when
>> there are no hits.
>>
> 
> Your question sounded like "is it possible to know whether an SMP arch 
> may use different per-CPU IRQs for the timer". I was about to answer 
> that testing for any pipeline core API rev >= 2 would do, excluding all 
> legacy patches.
> 
> For the cosmetic issue you mention, testing rthal_supported_cpus would do.

Nope, this is not sufficient. A per-CPU timer IRQ would then still
generate useless lines in stat for all those CPUs it is not bound to.

I'll resume the work on this as soon as I found the reason for the zero
page corruption we face now with 3.5.

Jan

-- 
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux

Re: [Xenomai] XNARCH_TIMER_IRQ

[Gilles Chanteperdrix]

On 01/04/2013 11:16 AM, Jan Kiszka wrote:
> On 2013-01-04 11:01, Philippe Gerum wrote:
>> On 01/03/2013 06:57 PM, Jan Kiszka wrote:
>>> On 2013-01-03 18:34, Philippe Gerum wrote:
>>>> On 01/03/2013 06:25 PM, Jan Kiszka wrote:
>>>>> On 2013-01-03 17:27, Philippe Gerum wrote:
>>>>>> On 01/03/2013 04:44 PM, Jan Kiszka wrote:
>>>>>>> On 2013-01-03 16:16, Gilles Chanteperdrix wrote:
>>>>>>>> On 01/02/2013 06:43 PM, Jan Kiszka wrote:
>>>>>>>>> Hi,
>>>>>>>>>
>>>>>>>>> this may involve some refactoring of the HAL and a bit of I-pipe, so I
>>>>>>>>> better ask first:
>>>>>>>>>
>>>>>>>>> Not sure when it changed, but XNARCH_TIMER_IRQ may no longer return the
>>>>>>>>> same values when called on different CPUs. Therefore, It should rather
>>>>>>>>> be called XNARCH_THIS_CPU_TIMER_IRQ now.
>>>>>>>>>
>>>>>>>>> Looking at its users (an I-pipe debug warning pointed it out), there are
>>>>>>>>> two that don't expect this: xnintr_query_next() and format_irq_proc().
>>>>>>>>> The former actually wants XNARCH_TIMER_IRQ(cpu), the latter needs
>>>>>>>>> something like is_timer_irq_on_any_cpus(irq).
>>>>>>>>>
>>>>>>>>> So I would propose to refactor XNARCH_TIMER_IRQ and RTHAL_TIMER_IRQ
>>>>>>>>> accordingly. But this unfortunately requires extensions of I-pipe to
>>>>>>>>> provide something like __ipipe_hrtimer_irq(cpu) and
>>>>>>>>> __ipipe_this_cpu_hrtimer_irq. And some ugly workaround in Xenomai for
>>>>>>>>> older I-pipe versions.
>>>>>>>>>
>>>>>>>>> Does this make sense?
>>>>>>>>
>>>>>>>> Made something similar for forge:
>>>>>>>> http://git.xenomai.org/?p=xenomai-gch.git;a=commitdiff;h=37ca257af466e7e5fbfb402b39f088487d048fd5;hp=a9971c363fd361b428f12200536bc5a01dff9c05
>>>>>>>
>>>>>>
>>>>>> Caution, this code is WIP. nktimer will have to move to the percpu
>>>>>> scheduler descriptor to complete this.
>>>>>
>>>>> That's nkclock in 2.6. Mostly a cosmetic issue, the interrupt name will
>>>>> not be properly printed, statistics are already per-cpu. Could be
>>>>> improved nevertheless.
>>>>>
>>>>
>>>> My point is to tell you that what you look to in -forge regarding this
>>>> area is in a state of flux. I'm not referring to 2.6, I'm focusing
>>>> almost exclusively on 3.x these days.
>>>>
>>>>> Is there an easy way to find out if we have per-CPU timers on some arch?
>>>>>
>>>>
>>>> Why should we assume differently?
>>>
>>> To avoid dumping redundant statistic lines when some timer IRQ has no
>>> home on a given CPU. But as there are also mixed setups possible as
>>> Gilles pointed out, we need a different approach, likely just skip when
>>> there are no hits.
>>>
>>
>> Your question sounded like "is it possible to know whether an SMP arch 
>> may use different per-CPU IRQs for the timer". I was about to answer 
>> that testing for any pipeline core API rev >= 2 would do, excluding all 
>> legacy patches.
>>
>> For the cosmetic issue you mention, testing rthal_supported_cpus would do.
> 
> Nope, this is not sufficient. A per-CPU timer IRQ would then still
> generate useless lines in stat for all those CPUs it is not bound to.

What we can do is, like linux, not print any irq number for the timer
irq, simply something like "local timer", in which case whether the
local timer irq is the same on all cpus or not does not matter.

-- 
					    Gilles.

Re: [Xenomai] XNARCH_TIMER_IRQ

[Philippe Gerum]

On 01/04/2013 11:16 AM, Jan Kiszka wrote:
> On 2013-01-04 11:01, Philippe Gerum wrote:
>> On 01/03/2013 06:57 PM, Jan Kiszka wrote:
>>> On 2013-01-03 18:34, Philippe Gerum wrote:
>>>> On 01/03/2013 06:25 PM, Jan Kiszka wrote:
>>>>> On 2013-01-03 17:27, Philippe Gerum wrote:
>>>>>> On 01/03/2013 04:44 PM, Jan Kiszka wrote:
>>>>>>> On 2013-01-03 16:16, Gilles Chanteperdrix wrote:
>>>>>>>> On 01/02/2013 06:43 PM, Jan Kiszka wrote:
>>>>>>>>> Hi,
>>>>>>>>>
>>>>>>>>> this may involve some refactoring of the HAL and a bit of I-pipe, so I
>>>>>>>>> better ask first:
>>>>>>>>>
>>>>>>>>> Not sure when it changed, but XNARCH_TIMER_IRQ may no longer return the
>>>>>>>>> same values when called on different CPUs. Therefore, It should rather
>>>>>>>>> be called XNARCH_THIS_CPU_TIMER_IRQ now.
>>>>>>>>>
>>>>>>>>> Looking at its users (an I-pipe debug warning pointed it out), there are
>>>>>>>>> two that don't expect this: xnintr_query_next() and format_irq_proc().
>>>>>>>>> The former actually wants XNARCH_TIMER_IRQ(cpu), the latter needs
>>>>>>>>> something like is_timer_irq_on_any_cpus(irq).
>>>>>>>>>
>>>>>>>>> So I would propose to refactor XNARCH_TIMER_IRQ and RTHAL_TIMER_IRQ
>>>>>>>>> accordingly. But this unfortunately requires extensions of I-pipe to
>>>>>>>>> provide something like __ipipe_hrtimer_irq(cpu) and
>>>>>>>>> __ipipe_this_cpu_hrtimer_irq. And some ugly workaround in Xenomai for
>>>>>>>>> older I-pipe versions.
>>>>>>>>>
>>>>>>>>> Does this make sense?
>>>>>>>>
>>>>>>>> Made something similar for forge:
>>>>>>>> http://git.xenomai.org/?p=xenomai-gch.git;a=commitdiff;h=37ca257af466e7e5fbfb402b39f088487d048fd5;hp=a9971c363fd361b428f12200536bc5a01dff9c05
>>>>>>>
>>>>>>
>>>>>> Caution, this code is WIP. nktimer will have to move to the percpu
>>>>>> scheduler descriptor to complete this.
>>>>>
>>>>> That's nkclock in 2.6. Mostly a cosmetic issue, the interrupt name will
>>>>> not be properly printed, statistics are already per-cpu. Could be
>>>>> improved nevertheless.
>>>>>
>>>>
>>>> My point is to tell you that what you look to in -forge regarding this
>>>> area is in a state of flux. I'm not referring to 2.6, I'm focusing
>>>> almost exclusively on 3.x these days.
>>>>
>>>>> Is there an easy way to find out if we have per-CPU timers on some arch?
>>>>>
>>>>
>>>> Why should we assume differently?
>>>
>>> To avoid dumping redundant statistic lines when some timer IRQ has no
>>> home on a given CPU. But as there are also mixed setups possible as
>>> Gilles pointed out, we need a different approach, likely just skip when
>>> there are no hits.
>>>
>>
>> Your question sounded like "is it possible to know whether an SMP arch
>> may use different per-CPU IRQs for the timer". I was about to answer
>> that testing for any pipeline core API rev >= 2 would do, excluding all
>> legacy patches.
>>
>> For the cosmetic issue you mention, testing rthal_supported_cpus would do.
>
> Nope, this is not sufficient. A per-CPU timer IRQ would then still
> generate useless lines in stat for all those CPUs it is not bound to.
>

You know which CPU has a real-time timer attached via 
rthal_supported_cpus, which timer IRQ # is attached to each real-time 
CPU when per-CPU timer IRQs are supported by the pipeline. For legacy 
patches which only allow a common IRQ line for all timers regardless of 
the CPU, the matter is solved by design. I still don't get where the 
issue would be.

> I'll resume the work on this as soon as I found the reason for the zero
> page corruption we face now with 3.5.
>
> Jan
>


-- 
Philippe.

Re: [Xenomai] XNARCH_TIMER_IRQ

[Jan Kiszka]

On 2013-01-04 11:32, Philippe Gerum wrote:
> On 01/04/2013 11:16 AM, Jan Kiszka wrote:
>> On 2013-01-04 11:01, Philippe Gerum wrote:
>>> On 01/03/2013 06:57 PM, Jan Kiszka wrote:
>>>> On 2013-01-03 18:34, Philippe Gerum wrote:
>>>>> On 01/03/2013 06:25 PM, Jan Kiszka wrote:
>>>>>> On 2013-01-03 17:27, Philippe Gerum wrote:
>>>>>>> On 01/03/2013 04:44 PM, Jan Kiszka wrote:
>>>>>>>> On 2013-01-03 16:16, Gilles Chanteperdrix wrote:
>>>>>>>>> On 01/02/2013 06:43 PM, Jan Kiszka wrote:
>>>>>>>>>> Hi,
>>>>>>>>>>
>>>>>>>>>> this may involve some refactoring of the HAL and a bit of I-pipe, so I
>>>>>>>>>> better ask first:
>>>>>>>>>>
>>>>>>>>>> Not sure when it changed, but XNARCH_TIMER_IRQ may no longer return the
>>>>>>>>>> same values when called on different CPUs. Therefore, It should rather
>>>>>>>>>> be called XNARCH_THIS_CPU_TIMER_IRQ now.
>>>>>>>>>>
>>>>>>>>>> Looking at its users (an I-pipe debug warning pointed it out), there are
>>>>>>>>>> two that don't expect this: xnintr_query_next() and format_irq_proc().
>>>>>>>>>> The former actually wants XNARCH_TIMER_IRQ(cpu), the latter needs
>>>>>>>>>> something like is_timer_irq_on_any_cpus(irq).
>>>>>>>>>>
>>>>>>>>>> So I would propose to refactor XNARCH_TIMER_IRQ and RTHAL_TIMER_IRQ
>>>>>>>>>> accordingly. But this unfortunately requires extensions of I-pipe to
>>>>>>>>>> provide something like __ipipe_hrtimer_irq(cpu) and
>>>>>>>>>> __ipipe_this_cpu_hrtimer_irq. And some ugly workaround in Xenomai for
>>>>>>>>>> older I-pipe versions.
>>>>>>>>>>
>>>>>>>>>> Does this make sense?
>>>>>>>>>
>>>>>>>>> Made something similar for forge:
>>>>>>>>> http://git.xenomai.org/?p=xenomai-gch.git;a=commitdiff;h=37ca257af466e7e5fbfb402b39f088487d048fd5;hp=a9971c363fd361b428f12200536bc5a01dff9c05
>>>>>>>>
>>>>>>>
>>>>>>> Caution, this code is WIP. nktimer will have to move to the percpu
>>>>>>> scheduler descriptor to complete this.
>>>>>>
>>>>>> That's nkclock in 2.6. Mostly a cosmetic issue, the interrupt name will
>>>>>> not be properly printed, statistics are already per-cpu. Could be
>>>>>> improved nevertheless.
>>>>>>
>>>>>
>>>>> My point is to tell you that what you look to in -forge regarding this
>>>>> area is in a state of flux. I'm not referring to 2.6, I'm focusing
>>>>> almost exclusively on 3.x these days.
>>>>>
>>>>>> Is there an easy way to find out if we have per-CPU timers on some arch?
>>>>>>
>>>>>
>>>>> Why should we assume differently?
>>>>
>>>> To avoid dumping redundant statistic lines when some timer IRQ has no
>>>> home on a given CPU. But as there are also mixed setups possible as
>>>> Gilles pointed out, we need a different approach, likely just skip when
>>>> there are no hits.
>>>>
>>>
>>> Your question sounded like "is it possible to know whether an SMP arch
>>> may use different per-CPU IRQs for the timer". I was about to answer
>>> that testing for any pipeline core API rev >= 2 would do, excluding all
>>> legacy patches.
>>>
>>> For the cosmetic issue you mention, testing rthal_supported_cpus would do.
>>
>> Nope, this is not sufficient. A per-CPU timer IRQ would then still
>> generate useless lines in stat for all those CPUs it is not bound to.
>>
> 
> You know which CPU has a real-time timer attached via 
> rthal_supported_cpus, which timer IRQ # is attached to each real-time 
> CPU when per-CPU timer IRQs are supported by the pipeline. For legacy 
> patches which only allow a common IRQ line for all timers regardless of 
> the CPU, the matter is solved by design. I still don't get where the 
> issue would be.

rthal_supported_cpus doesn't contain enough information. We need

is_valid_irq(irq, cpu):
	if (timer_irq(cpu) == irq)
		return true
	for_each_cpu(n)
		if (timer_irq(n) == irq)
			return false
	return true

for a cleaned up /stat output as we iterate over all combinations of
(irq, cpu) there. That for_each_cpu is a bit ugly, and that's why I was
considering to derive is_valid_irq from irq.hits > 0.

Jan

-- 
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux

Re: [Xenomai] XNARCH_TIMER_IRQ

[Philippe Gerum]

On 01/04/2013 12:22 PM, Jan Kiszka wrote:
> On 2013-01-04 11:32, Philippe Gerum wrote:
>> On 01/04/2013 11:16 AM, Jan Kiszka wrote:
>>> On 2013-01-04 11:01, Philippe Gerum wrote:
>>>> On 01/03/2013 06:57 PM, Jan Kiszka wrote:
>>>>> On 2013-01-03 18:34, Philippe Gerum wrote:
>>>>>> On 01/03/2013 06:25 PM, Jan Kiszka wrote:
>>>>>>> On 2013-01-03 17:27, Philippe Gerum wrote:
>>>>>>>> On 01/03/2013 04:44 PM, Jan Kiszka wrote:
>>>>>>>>> On 2013-01-03 16:16, Gilles Chanteperdrix wrote:
>>>>>>>>>> On 01/02/2013 06:43 PM, Jan Kiszka wrote:
>>>>>>>>>>> Hi,
>>>>>>>>>>>
>>>>>>>>>>> this may involve some refactoring of the HAL and a bit of I-pipe, so I
>>>>>>>>>>> better ask first:
>>>>>>>>>>>
>>>>>>>>>>> Not sure when it changed, but XNARCH_TIMER_IRQ may no longer return the
>>>>>>>>>>> same values when called on different CPUs. Therefore, It should rather
>>>>>>>>>>> be called XNARCH_THIS_CPU_TIMER_IRQ now.
>>>>>>>>>>>
>>>>>>>>>>> Looking at its users (an I-pipe debug warning pointed it out), there are
>>>>>>>>>>> two that don't expect this: xnintr_query_next() and format_irq_proc().
>>>>>>>>>>> The former actually wants XNARCH_TIMER_IRQ(cpu), the latter needs
>>>>>>>>>>> something like is_timer_irq_on_any_cpus(irq).
>>>>>>>>>>>
>>>>>>>>>>> So I would propose to refactor XNARCH_TIMER_IRQ and RTHAL_TIMER_IRQ
>>>>>>>>>>> accordingly. But this unfortunately requires extensions of I-pipe to
>>>>>>>>>>> provide something like __ipipe_hrtimer_irq(cpu) and
>>>>>>>>>>> __ipipe_this_cpu_hrtimer_irq. And some ugly workaround in Xenomai for
>>>>>>>>>>> older I-pipe versions.
>>>>>>>>>>>
>>>>>>>>>>> Does this make sense?
>>>>>>>>>>
>>>>>>>>>> Made something similar for forge:
>>>>>>>>>> http://git.xenomai.org/?p=xenomai-gch.git;a=commitdiff;h=37ca257af466e7e5fbfb402b39f088487d048fd5;hp=a9971c363fd361b428f12200536bc5a01dff9c05
>>>>>>>>>
>>>>>>>>
>>>>>>>> Caution, this code is WIP. nktimer will have to move to the percpu
>>>>>>>> scheduler descriptor to complete this.
>>>>>>>
>>>>>>> That's nkclock in 2.6. Mostly a cosmetic issue, the interrupt name will
>>>>>>> not be properly printed, statistics are already per-cpu. Could be
>>>>>>> improved nevertheless.
>>>>>>>
>>>>>>
>>>>>> My point is to tell you that what you look to in -forge regarding this
>>>>>> area is in a state of flux. I'm not referring to 2.6, I'm focusing
>>>>>> almost exclusively on 3.x these days.
>>>>>>
>>>>>>> Is there an easy way to find out if we have per-CPU timers on some arch?
>>>>>>>
>>>>>>
>>>>>> Why should we assume differently?
>>>>>
>>>>> To avoid dumping redundant statistic lines when some timer IRQ has no
>>>>> home on a given CPU. But as there are also mixed setups possible as
>>>>> Gilles pointed out, we need a different approach, likely just skip when
>>>>> there are no hits.
>>>>>
>>>>
>>>> Your question sounded like "is it possible to know whether an SMP arch
>>>> may use different per-CPU IRQs for the timer". I was about to answer
>>>> that testing for any pipeline core API rev >= 2 would do, excluding all
>>>> legacy patches.
>>>>
>>>> For the cosmetic issue you mention, testing rthal_supported_cpus would do.
>>>
>>> Nope, this is not sufficient. A per-CPU timer IRQ would then still
>>> generate useless lines in stat for all those CPUs it is not bound to.
>>>
>>
>> You know which CPU has a real-time timer attached via
>> rthal_supported_cpus, which timer IRQ # is attached to each real-time
>> CPU when per-CPU timer IRQs are supported by the pipeline. For legacy
>> patches which only allow a common IRQ line for all timers regardless of
>> the CPU, the matter is solved by design. I still don't get where the
>> issue would be.
>
> rthal_supported_cpus doesn't contain enough information. We need
>
> is_valid_irq(irq, cpu):
> 	if (timer_irq(cpu) == irq)
> 		return true
> 	for_each_cpu(n)
> 		if (timer_irq(n) == irq)
> 			return false
> 	return true
>
> for a cleaned up /stat output as we iterate over all combinations of
> (irq, cpu) there. That for_each_cpu is a bit ugly, and that's why I was
> considering to derive is_valid_irq from irq.hits > 0.
>


The problem goes away with cpus displayed on lines, and irq # on columns.

-- 
Philippe.

Re: [Xenomai] XNARCH_TIMER_IRQ

[Jan Kiszka]

On 2013-01-04 12:33, Philippe Gerum wrote:
> On 01/04/2013 12:22 PM, Jan Kiszka wrote:
>> On 2013-01-04 11:32, Philippe Gerum wrote:
>>> On 01/04/2013 11:16 AM, Jan Kiszka wrote:
>>>> On 2013-01-04 11:01, Philippe Gerum wrote:
>>>>> On 01/03/2013 06:57 PM, Jan Kiszka wrote:
>>>>>> On 2013-01-03 18:34, Philippe Gerum wrote:
>>>>>>> On 01/03/2013 06:25 PM, Jan Kiszka wrote:
>>>>>>>> On 2013-01-03 17:27, Philippe Gerum wrote:
>>>>>>>>> On 01/03/2013 04:44 PM, Jan Kiszka wrote:
>>>>>>>>>> On 2013-01-03 16:16, Gilles Chanteperdrix wrote:
>>>>>>>>>>> On 01/02/2013 06:43 PM, Jan Kiszka wrote:
>>>>>>>>>>>> Hi,
>>>>>>>>>>>>
>>>>>>>>>>>> this may involve some refactoring of the HAL and a bit of I-pipe, so I
>>>>>>>>>>>> better ask first:
>>>>>>>>>>>>
>>>>>>>>>>>> Not sure when it changed, but XNARCH_TIMER_IRQ may no longer return the
>>>>>>>>>>>> same values when called on different CPUs. Therefore, It should rather
>>>>>>>>>>>> be called XNARCH_THIS_CPU_TIMER_IRQ now.
>>>>>>>>>>>>
>>>>>>>>>>>> Looking at its users (an I-pipe debug warning pointed it out), there are
>>>>>>>>>>>> two that don't expect this: xnintr_query_next() and format_irq_proc().
>>>>>>>>>>>> The former actually wants XNARCH_TIMER_IRQ(cpu), the latter needs
>>>>>>>>>>>> something like is_timer_irq_on_any_cpus(irq).
>>>>>>>>>>>>
>>>>>>>>>>>> So I would propose to refactor XNARCH_TIMER_IRQ and RTHAL_TIMER_IRQ
>>>>>>>>>>>> accordingly. But this unfortunately requires extensions of I-pipe to
>>>>>>>>>>>> provide something like __ipipe_hrtimer_irq(cpu) and
>>>>>>>>>>>> __ipipe_this_cpu_hrtimer_irq. And some ugly workaround in Xenomai for
>>>>>>>>>>>> older I-pipe versions.
>>>>>>>>>>>>
>>>>>>>>>>>> Does this make sense?
>>>>>>>>>>>
>>>>>>>>>>> Made something similar for forge:
>>>>>>>>>>> http://git.xenomai.org/?p=xenomai-gch.git;a=commitdiff;h=37ca257af466e7e5fbfb402b39f088487d048fd5;hp=a9971c363fd361b428f12200536bc5a01dff9c05
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Caution, this code is WIP. nktimer will have to move to the percpu
>>>>>>>>> scheduler descriptor to complete this.
>>>>>>>>
>>>>>>>> That's nkclock in 2.6. Mostly a cosmetic issue, the interrupt name will
>>>>>>>> not be properly printed, statistics are already per-cpu. Could be
>>>>>>>> improved nevertheless.
>>>>>>>>
>>>>>>>
>>>>>>> My point is to tell you that what you look to in -forge regarding this
>>>>>>> area is in a state of flux. I'm not referring to 2.6, I'm focusing
>>>>>>> almost exclusively on 3.x these days.
>>>>>>>
>>>>>>>> Is there an easy way to find out if we have per-CPU timers on some arch?
>>>>>>>>
>>>>>>>
>>>>>>> Why should we assume differently?
>>>>>>
>>>>>> To avoid dumping redundant statistic lines when some timer IRQ has no
>>>>>> home on a given CPU. But as there are also mixed setups possible as
>>>>>> Gilles pointed out, we need a different approach, likely just skip when
>>>>>> there are no hits.
>>>>>>
>>>>>
>>>>> Your question sounded like "is it possible to know whether an SMP arch
>>>>> may use different per-CPU IRQs for the timer". I was about to answer
>>>>> that testing for any pipeline core API rev >= 2 would do, excluding all
>>>>> legacy patches.
>>>>>
>>>>> For the cosmetic issue you mention, testing rthal_supported_cpus would do.
>>>>
>>>> Nope, this is not sufficient. A per-CPU timer IRQ would then still
>>>> generate useless lines in stat for all those CPUs it is not bound to.
>>>>
>>>
>>> You know which CPU has a real-time timer attached via
>>> rthal_supported_cpus, which timer IRQ # is attached to each real-time
>>> CPU when per-CPU timer IRQs are supported by the pipeline. For legacy
>>> patches which only allow a common IRQ line for all timers regardless of
>>> the CPU, the matter is solved by design. I still don't get where the
>>> issue would be.
>>
>> rthal_supported_cpus doesn't contain enough information. We need
>>
>> is_valid_irq(irq, cpu):
>> 	if (timer_irq(cpu) == irq)
>> 		return true
>> 	for_each_cpu(n)
>> 		if (timer_irq(n) == irq)
>> 			return false
>> 	return true
>>
>> for a cleaned up /stat output as we iterate over all combinations of
>> (irq, cpu) there. That for_each_cpu is a bit ugly, and that's why I was
>> considering to derive is_valid_irq from irq.hits > 0.
>>
> 
> 
> The problem goes away with cpus displayed on lines, and irq # on columns.
> 

Not applicable to /stat.

Jan

-- 
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux

Re: [Xenomai] XNARCH_TIMER_IRQ

[Philippe Gerum]

On 01/04/2013 12:46 PM, Jan Kiszka wrote:
> On 2013-01-04 12:33, Philippe Gerum wrote:
>> On 01/04/2013 12:22 PM, Jan Kiszka wrote:
>>> On 2013-01-04 11:32, Philippe Gerum wrote:
>>>> On 01/04/2013 11:16 AM, Jan Kiszka wrote:
>>>>> On 2013-01-04 11:01, Philippe Gerum wrote:
>>>>>> On 01/03/2013 06:57 PM, Jan Kiszka wrote:
>>>>>>> On 2013-01-03 18:34, Philippe Gerum wrote:
>>>>>>>> On 01/03/2013 06:25 PM, Jan Kiszka wrote:
>>>>>>>>> On 2013-01-03 17:27, Philippe Gerum wrote:
>>>>>>>>>> On 01/03/2013 04:44 PM, Jan Kiszka wrote:
>>>>>>>>>>> On 2013-01-03 16:16, Gilles Chanteperdrix wrote:
>>>>>>>>>>>> On 01/02/2013 06:43 PM, Jan Kiszka wrote:
>>>>>>>>>>>>> Hi,
>>>>>>>>>>>>>
>>>>>>>>>>>>> this may involve some refactoring of the HAL and a bit of I-pipe, so I
>>>>>>>>>>>>> better ask first:
>>>>>>>>>>>>>
>>>>>>>>>>>>> Not sure when it changed, but XNARCH_TIMER_IRQ may no longer return the
>>>>>>>>>>>>> same values when called on different CPUs. Therefore, It should rather
>>>>>>>>>>>>> be called XNARCH_THIS_CPU_TIMER_IRQ now.
>>>>>>>>>>>>>
>>>>>>>>>>>>> Looking at its users (an I-pipe debug warning pointed it out), there are
>>>>>>>>>>>>> two that don't expect this: xnintr_query_next() and format_irq_proc().
>>>>>>>>>>>>> The former actually wants XNARCH_TIMER_IRQ(cpu), the latter needs
>>>>>>>>>>>>> something like is_timer_irq_on_any_cpus(irq).
>>>>>>>>>>>>>
>>>>>>>>>>>>> So I would propose to refactor XNARCH_TIMER_IRQ and RTHAL_TIMER_IRQ
>>>>>>>>>>>>> accordingly. But this unfortunately requires extensions of I-pipe to
>>>>>>>>>>>>> provide something like __ipipe_hrtimer_irq(cpu) and
>>>>>>>>>>>>> __ipipe_this_cpu_hrtimer_irq. And some ugly workaround in Xenomai for
>>>>>>>>>>>>> older I-pipe versions.
>>>>>>>>>>>>>
>>>>>>>>>>>>> Does this make sense?
>>>>>>>>>>>>
>>>>>>>>>>>> Made something similar for forge:
>>>>>>>>>>>> http://git.xenomai.org/?p=xenomai-gch.git;a=commitdiff;h=37ca257af466e7e5fbfb402b39f088487d048fd5;hp=a9971c363fd361b428f12200536bc5a01dff9c05
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Caution, this code is WIP. nktimer will have to move to the percpu
>>>>>>>>>> scheduler descriptor to complete this.
>>>>>>>>>
>>>>>>>>> That's nkclock in 2.6. Mostly a cosmetic issue, the interrupt name will
>>>>>>>>> not be properly printed, statistics are already per-cpu. Could be
>>>>>>>>> improved nevertheless.
>>>>>>>>>
>>>>>>>>
>>>>>>>> My point is to tell you that what you look to in -forge regarding this
>>>>>>>> area is in a state of flux. I'm not referring to 2.6, I'm focusing
>>>>>>>> almost exclusively on 3.x these days.
>>>>>>>>
>>>>>>>>> Is there an easy way to find out if we have per-CPU timers on some arch?
>>>>>>>>>
>>>>>>>>
>>>>>>>> Why should we assume differently?
>>>>>>>
>>>>>>> To avoid dumping redundant statistic lines when some timer IRQ has no
>>>>>>> home on a given CPU. But as there are also mixed setups possible as
>>>>>>> Gilles pointed out, we need a different approach, likely just skip when
>>>>>>> there are no hits.
>>>>>>>
>>>>>>
>>>>>> Your question sounded like "is it possible to know whether an SMP arch
>>>>>> may use different per-CPU IRQs for the timer". I was about to answer
>>>>>> that testing for any pipeline core API rev >= 2 would do, excluding all
>>>>>> legacy patches.
>>>>>>
>>>>>> For the cosmetic issue you mention, testing rthal_supported_cpus would do.
>>>>>
>>>>> Nope, this is not sufficient. A per-CPU timer IRQ would then still
>>>>> generate useless lines in stat for all those CPUs it is not bound to.
>>>>>
>>>>
>>>> You know which CPU has a real-time timer attached via
>>>> rthal_supported_cpus, which timer IRQ # is attached to each real-time
>>>> CPU when per-CPU timer IRQs are supported by the pipeline. For legacy
>>>> patches which only allow a common IRQ line for all timers regardless of
>>>> the CPU, the matter is solved by design. I still don't get where the
>>>> issue would be.
>>>
>>> rthal_supported_cpus doesn't contain enough information. We need
>>>
>>> is_valid_irq(irq, cpu):
>>> 	if (timer_irq(cpu) == irq)
>>> 		return true
>>> 	for_each_cpu(n)
>>> 		if (timer_irq(n) == irq)
>>> 			return false
>>> 	return true
>>>
>>> for a cleaned up /stat output as we iterate over all combinations of
>>> (irq, cpu) there. That for_each_cpu is a bit ugly, and that's why I was
>>> considering to derive is_valid_irq from irq.hits > 0.
>>>
>>
>>
>> The problem goes away with cpus displayed on lines, and irq # on columns.
>>
>
> Not applicable to /stat.
>

No, the real issue is that using /stat to display timer activity as 
thread placeholders is not applicable. So that stuff has to move to 
another /proc file.


-- 
Philippe.

Re: [Xenomai] XNARCH_TIMER_IRQ

[Gilles Chanteperdrix]

On 01/04/2013 01:54 PM, Philippe Gerum wrote:

> On 01/04/2013 12:46 PM, Jan Kiszka wrote:
>> On 2013-01-04 12:33, Philippe Gerum wrote:
>>> On 01/04/2013 12:22 PM, Jan Kiszka wrote:
>>>> On 2013-01-04 11:32, Philippe Gerum wrote:
>>>>> On 01/04/2013 11:16 AM, Jan Kiszka wrote:
>>>>>> On 2013-01-04 11:01, Philippe Gerum wrote:
>>>>>>> On 01/03/2013 06:57 PM, Jan Kiszka wrote:
>>>>>>>> On 2013-01-03 18:34, Philippe Gerum wrote:
>>>>>>>>> On 01/03/2013 06:25 PM, Jan Kiszka wrote:
>>>>>>>>>> On 2013-01-03 17:27, Philippe Gerum wrote:
>>>>>>>>>>> On 01/03/2013 04:44 PM, Jan Kiszka wrote:
>>>>>>>>>>>> On 2013-01-03 16:16, Gilles Chanteperdrix wrote:
>>>>>>>>>>>>> On 01/02/2013 06:43 PM, Jan Kiszka wrote:
>>>>>>>>>>>>>> Hi,
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> this may involve some refactoring of the HAL and a bit of I-pipe, so I
>>>>>>>>>>>>>> better ask first:
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Not sure when it changed, but XNARCH_TIMER_IRQ may no longer return the
>>>>>>>>>>>>>> same values when called on different CPUs. Therefore, It should rather
>>>>>>>>>>>>>> be called XNARCH_THIS_CPU_TIMER_IRQ now.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Looking at its users (an I-pipe debug warning pointed it out), there are
>>>>>>>>>>>>>> two that don't expect this: xnintr_query_next() and format_irq_proc().
>>>>>>>>>>>>>> The former actually wants XNARCH_TIMER_IRQ(cpu), the latter needs
>>>>>>>>>>>>>> something like is_timer_irq_on_any_cpus(irq).
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> So I would propose to refactor XNARCH_TIMER_IRQ and RTHAL_TIMER_IRQ
>>>>>>>>>>>>>> accordingly. But this unfortunately requires extensions of I-pipe to
>>>>>>>>>>>>>> provide something like __ipipe_hrtimer_irq(cpu) and
>>>>>>>>>>>>>> __ipipe_this_cpu_hrtimer_irq. And some ugly workaround in Xenomai for
>>>>>>>>>>>>>> older I-pipe versions.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Does this make sense?
>>>>>>>>>>>>>
>>>>>>>>>>>>> Made something similar for forge:
>>>>>>>>>>>>> http://git.xenomai.org/?p=xenomai-gch.git;a=commitdiff;h=37ca257af466e7e5fbfb402b39f088487d048fd5;hp=a9971c363fd361b428f12200536bc5a01dff9c05
>>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> Caution, this code is WIP. nktimer will have to move to the percpu
>>>>>>>>>>> scheduler descriptor to complete this.
>>>>>>>>>>
>>>>>>>>>> That's nkclock in 2.6. Mostly a cosmetic issue, the interrupt name will
>>>>>>>>>> not be properly printed, statistics are already per-cpu. Could be
>>>>>>>>>> improved nevertheless.
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>> My point is to tell you that what you look to in -forge regarding this
>>>>>>>>> area is in a state of flux. I'm not referring to 2.6, I'm focusing
>>>>>>>>> almost exclusively on 3.x these days.
>>>>>>>>>
>>>>>>>>>> Is there an easy way to find out if we have per-CPU timers on some arch?
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Why should we assume differently?
>>>>>>>>
>>>>>>>> To avoid dumping redundant statistic lines when some timer IRQ has no
>>>>>>>> home on a given CPU. But as there are also mixed setups possible as
>>>>>>>> Gilles pointed out, we need a different approach, likely just skip when
>>>>>>>> there are no hits.
>>>>>>>>
>>>>>>>
>>>>>>> Your question sounded like "is it possible to know whether an SMP arch
>>>>>>> may use different per-CPU IRQs for the timer". I was about to answer
>>>>>>> that testing for any pipeline core API rev >= 2 would do, excluding all
>>>>>>> legacy patches.
>>>>>>>
>>>>>>> For the cosmetic issue you mention, testing rthal_supported_cpus would do.
>>>>>>
>>>>>> Nope, this is not sufficient. A per-CPU timer IRQ would then still
>>>>>> generate useless lines in stat for all those CPUs it is not bound to.
>>>>>>
>>>>>
>>>>> You know which CPU has a real-time timer attached via
>>>>> rthal_supported_cpus, which timer IRQ # is attached to each real-time
>>>>> CPU when per-CPU timer IRQs are supported by the pipeline. For legacy
>>>>> patches which only allow a common IRQ line for all timers regardless of
>>>>> the CPU, the matter is solved by design. I still don't get where the
>>>>> issue would be.
>>>>
>>>> rthal_supported_cpus doesn't contain enough information. We need
>>>>
>>>> is_valid_irq(irq, cpu):
>>>> 	if (timer_irq(cpu) == irq)
>>>> 		return true
>>>> 	for_each_cpu(n)
>>>> 		if (timer_irq(n) == irq)
>>>> 			return false
>>>> 	return true
>>>>
>>>> for a cleaned up /stat output as we iterate over all combinations of
>>>> (irq, cpu) there. That for_each_cpu is a bit ugly, and that's why I was
>>>> considering to derive is_valid_irq from irq.hits > 0.
>>>>
>>>
>>>
>>> The problem goes away with cpus displayed on lines, and irq # on columns.
>>>
>>
>> Not applicable to /stat.
>>
> 
> No, the real issue is that using /stat to display timer activity as 
> thread placeholders is not applicable. So that stuff has to move to 
> another /proc file.


Ok, so what we need is a different /proc entry for timer activity. As
for the timer/irq association, the real problem is the aggregation of
statistics for timers sharing the same irq, not unlike what is done for
shared irqs.

-- 
                                                                Gilles.

Re: [Xenomai] XNARCH_TIMER_IRQ

[Jan Kiszka]

On 2013-01-06 17:08, Gilles Chanteperdrix wrote:
> On 01/04/2013 01:54 PM, Philippe Gerum wrote:
> 
>> On 01/04/2013 12:46 PM, Jan Kiszka wrote:
>>> On 2013-01-04 12:33, Philippe Gerum wrote:
>>>> On 01/04/2013 12:22 PM, Jan Kiszka wrote:
>>>>> On 2013-01-04 11:32, Philippe Gerum wrote:
>>>>>> On 01/04/2013 11:16 AM, Jan Kiszka wrote:
>>>>>>> On 2013-01-04 11:01, Philippe Gerum wrote:
>>>>>>>> On 01/03/2013 06:57 PM, Jan Kiszka wrote:
>>>>>>>>> On 2013-01-03 18:34, Philippe Gerum wrote:
>>>>>>>>>> On 01/03/2013 06:25 PM, Jan Kiszka wrote:
>>>>>>>>>>> On 2013-01-03 17:27, Philippe Gerum wrote:
>>>>>>>>>>>> On 01/03/2013 04:44 PM, Jan Kiszka wrote:
>>>>>>>>>>>>> On 2013-01-03 16:16, Gilles Chanteperdrix wrote:
>>>>>>>>>>>>>> On 01/02/2013 06:43 PM, Jan Kiszka wrote:
>>>>>>>>>>>>>>> Hi,
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> this may involve some refactoring of the HAL and a bit of I-pipe, so I
>>>>>>>>>>>>>>> better ask first:
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Not sure when it changed, but XNARCH_TIMER_IRQ may no longer return the
>>>>>>>>>>>>>>> same values when called on different CPUs. Therefore, It should rather
>>>>>>>>>>>>>>> be called XNARCH_THIS_CPU_TIMER_IRQ now.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Looking at its users (an I-pipe debug warning pointed it out), there are
>>>>>>>>>>>>>>> two that don't expect this: xnintr_query_next() and format_irq_proc().
>>>>>>>>>>>>>>> The former actually wants XNARCH_TIMER_IRQ(cpu), the latter needs
>>>>>>>>>>>>>>> something like is_timer_irq_on_any_cpus(irq).
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> So I would propose to refactor XNARCH_TIMER_IRQ and RTHAL_TIMER_IRQ
>>>>>>>>>>>>>>> accordingly. But this unfortunately requires extensions of I-pipe to
>>>>>>>>>>>>>>> provide something like __ipipe_hrtimer_irq(cpu) and
>>>>>>>>>>>>>>> __ipipe_this_cpu_hrtimer_irq. And some ugly workaround in Xenomai for
>>>>>>>>>>>>>>> older I-pipe versions.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Does this make sense?
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Made something similar for forge:
>>>>>>>>>>>>>> http://git.xenomai.org/?p=xenomai-gch.git;a=commitdiff;h=37ca257af466e7e5fbfb402b39f088487d048fd5;hp=a9971c363fd361b428f12200536bc5a01dff9c05
>>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> Caution, this code is WIP. nktimer will have to move to the percpu
>>>>>>>>>>>> scheduler descriptor to complete this.
>>>>>>>>>>>
>>>>>>>>>>> That's nkclock in 2.6. Mostly a cosmetic issue, the interrupt name will
>>>>>>>>>>> not be properly printed, statistics are already per-cpu. Could be
>>>>>>>>>>> improved nevertheless.
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> My point is to tell you that what you look to in -forge regarding this
>>>>>>>>>> area is in a state of flux. I'm not referring to 2.6, I'm focusing
>>>>>>>>>> almost exclusively on 3.x these days.
>>>>>>>>>>
>>>>>>>>>>> Is there an easy way to find out if we have per-CPU timers on some arch?
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Why should we assume differently?
>>>>>>>>>
>>>>>>>>> To avoid dumping redundant statistic lines when some timer IRQ has no
>>>>>>>>> home on a given CPU. But as there are also mixed setups possible as
>>>>>>>>> Gilles pointed out, we need a different approach, likely just skip when
>>>>>>>>> there are no hits.
>>>>>>>>>
>>>>>>>>
>>>>>>>> Your question sounded like "is it possible to know whether an SMP arch
>>>>>>>> may use different per-CPU IRQs for the timer". I was about to answer
>>>>>>>> that testing for any pipeline core API rev >= 2 would do, excluding all
>>>>>>>> legacy patches.
>>>>>>>>
>>>>>>>> For the cosmetic issue you mention, testing rthal_supported_cpus would do.
>>>>>>>
>>>>>>> Nope, this is not sufficient. A per-CPU timer IRQ would then still
>>>>>>> generate useless lines in stat for all those CPUs it is not bound to.
>>>>>>>
>>>>>>
>>>>>> You know which CPU has a real-time timer attached via
>>>>>> rthal_supported_cpus, which timer IRQ # is attached to each real-time
>>>>>> CPU when per-CPU timer IRQs are supported by the pipeline. For legacy
>>>>>> patches which only allow a common IRQ line for all timers regardless of
>>>>>> the CPU, the matter is solved by design. I still don't get where the
>>>>>> issue would be.
>>>>>
>>>>> rthal_supported_cpus doesn't contain enough information. We need
>>>>>
>>>>> is_valid_irq(irq, cpu):
>>>>> 	if (timer_irq(cpu) == irq)
>>>>> 		return true
>>>>> 	for_each_cpu(n)
>>>>> 		if (timer_irq(n) == irq)
>>>>> 			return false
>>>>> 	return true
>>>>>
>>>>> for a cleaned up /stat output as we iterate over all combinations of
>>>>> (irq, cpu) there. That for_each_cpu is a bit ugly, and that's why I was
>>>>> considering to derive is_valid_irq from irq.hits > 0.
>>>>>
>>>>
>>>>
>>>> The problem goes away with cpus displayed on lines, and irq # on columns.
>>>>
>>>
>>> Not applicable to /stat.
>>>
>>
>> No, the real issue is that using /stat to display timer activity as 
>> thread placeholders is not applicable. So that stuff has to move to 
>> another /proc file.
> 
> 
> Ok, so what we need is a different /proc entry for timer activity.

Splitting /proc is not a good idea from the usability POV. The whole
point of showing the load of IRQs in /stat is to have all information in
one place (percentages sum up to 100...).

I've pushed a simple patch via for-upstream in my repo that should be
sufficient for 2.6. We could refine on top later on.

> As
> for the timer/irq association, the real problem is the aggregation of
> statistics for timers sharing the same irq, not unlike what is done for
> shared irqs.

I cannot follow yet what aggregation issue you are referring to. Hits
are already reported per CPU in /irq, so the sharing of the number does
not matter.

Jan


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 261 bytes
Desc: OpenPGP digital signature
URL: <http://www.xenomai.org/pipermail/xenomai/attachments/20130107/a7199b7f/attachment.pgp>

Re: [Xenomai] XNARCH_TIMER_IRQ

[Gilles Chanteperdrix]

On 01/07/2013 12:02 AM, Jan Kiszka wrote:

> Splitting /proc is not a good idea from the usability POV. The whole
> point of showing the load of IRQs in /stat is to have all information in
> one place (percentages sum up to 100...).
> 
> I've pushed a simple patch via for-upstream in my repo that should be
> sufficient for 2.6. We could refine on top later on.


That is fine, except that you pushed the change of the intrlock to a
mutex as well...

-- 
                                                                Gilles.

Re: [Xenomai] XNARCH_TIMER_IRQ

[Jan Kiszka]

On 2013-01-07 00:11, Gilles Chanteperdrix wrote:
> On 01/07/2013 12:02 AM, Jan Kiszka wrote:
> 
>> Splitting /proc is not a good idea from the usability POV. The whole
>> point of showing the load of IRQs in /stat is to have all information in
>> one place (percentages sum up to 100...).
>>
>> I've pushed a simple patch via for-upstream in my repo that should be
>> sufficient for 2.6. We could refine on top later on.
> 
> 
> That is fine, except that you pushed the change of the intrlock to a
> mutex as well...

It shows how simple the change now is, may serve forge and it's last in
the series, thus easy to skip if you prefer.

Jan

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 261 bytes
Desc: OpenPGP digital signature
URL: <http://www.xenomai.org/pipermail/xenomai/attachments/20130107/7f2ade2d/attachment.pgp>