Re: [PATCH 00/21][RFC v3] systemd Integration

[Radu Moisan <radu.moisan@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1338 bytes --]


On 01/08/2013 02:57 PM, Enrico Scholz wrote:
> Radu Moisan <radu.moisan-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> writes:
>
>> Enrico Scholz (1):
>>    systemd: move disable operation into prerm() script
>     http://git.yoctoproject.org/cgit.cgi/poky-contrib/commit/?h=rmoisan/systemd&id=e01411c2400231a89bc76a229b38e7eb95b7cd81
>
> I am pretty sure that I added a 'Signed-off-by:' field to my patch but
> it is missing in the commit.  Other patches don't have the signed-off-by
> of the original author neither.
>
> Was this removal done on purpose?

I had to port the patch manually so I guess it got lost then. Do we want 
to have Sign-off-by from author as well?

>>    systemd: Introduce a create-volatile to create tmp directories
>     http://git.yoctoproject.org/cgit.cgi/poky-contrib/commit/?h=rmoisan/systemd&id=64de9a773c1ac79d4dbcb041ed7e66c19a3cf6b7
>
> When/because the order of files is really important, they should be installed
> with the usual <number>- prefix method (e.g. '00-create-volatile.conf').
>
> Else, when e.g. /var/cache/apache is created by a 3rd part recipe, it
> requires (yet more) ugly naming tricks (e.g. naming it
> 'zz-apache-httpd.conf') to ensure the correct order and it might break
> easily when something else is changed.
>
You have a point here. Noted.

Radu

[-- Attachment #2: Type: text/html, Size: 2575 bytes --]