From: Marc Zyngier <marc.zyngier@arm.com>
To: Santosh Shilimkar <santosh.shilimkar@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"tony@atomide.com" <tony@atomide.com>,
Rajendra Nayak <rnayak@ti.com>, Benoit Cousson <b-cousson@ti.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 5/5] ARM: dts: OMAP5: Specify nonsecure PPI IRQ for arch timer
Date: Fri, 18 Jan 2013 16:02:15 +0000 [thread overview]
Message-ID: <50F97207.1030706@arm.com> (raw)
In-Reply-To: <1358523141-12295-6-git-send-email-santosh.shilimkar@ti.com>
On 18/01/13 15:32, Santosh Shilimkar wrote:
> From: Rajendra Nayak <rnayak@ti.com>
>
> Specify both secure as well as nonsecure PPI IRQ for arch
> timer. This fixes the following errors seen on DT OMAP5 boot..
>
> [ 0.000000] arch_timer: No interrupt available, giving up
>
> Cc: Benoit Cousson <b-cousson@ti.com>
>
> Signed-off-by: Rajendra Nayak <rnayak@ti.com>
> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
> ---
> arch/arm/boot/dts/omap5.dtsi | 16 ++++++++++++----
> 1 file changed, 12 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi
> index 790bb2a..7a78d1b 100644
> --- a/arch/arm/boot/dts/omap5.dtsi
> +++ b/arch/arm/boot/dts/omap5.dtsi
> @@ -35,8 +35,12 @@
> compatible = "arm,cortex-a15";
> timer {
> compatible = "arm,armv7-timer";
> - /* 14th PPI IRQ, active low level-sensitive */
> - interrupts = <1 14 0x308>;
> + /*
> + * PPI secure/nonsecure IRQ,
> + * active low level-sensitive
> + */
> + interrupts = <1 13 0x308>,
> + <1 14 0x308>;
Care to add the virtual and HYP timer interrupts? So KVM can get a
chance to run on this HW...
> clock-frequency = <6144000>;
> };
> };
> @@ -44,8 +48,12 @@
> compatible = "arm,cortex-a15";
> timer {
> compatible = "arm,armv7-timer";
> - /* 14th PPI IRQ, active low level-sensitive */
> - interrupts = <1 14 0x308>;
> + /*
> + * PPI secure/nonsecure IRQ,
> + * active low level-sensitive
> + */
> + interrupts = <1 13 0x308>,
> + <1 14 0x308>;
Same here.
> clock-frequency = <6144000>;
> };
> };
>
Thanks,
M.
--
Jazz is not dead. It just smells funny...
WARNING: multiple messages have this Message-ID (diff)
From: marc.zyngier@arm.com (Marc Zyngier)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/5] ARM: dts: OMAP5: Specify nonsecure PPI IRQ for arch timer
Date: Fri, 18 Jan 2013 16:02:15 +0000 [thread overview]
Message-ID: <50F97207.1030706@arm.com> (raw)
In-Reply-To: <1358523141-12295-6-git-send-email-santosh.shilimkar@ti.com>
On 18/01/13 15:32, Santosh Shilimkar wrote:
> From: Rajendra Nayak <rnayak@ti.com>
>
> Specify both secure as well as nonsecure PPI IRQ for arch
> timer. This fixes the following errors seen on DT OMAP5 boot..
>
> [ 0.000000] arch_timer: No interrupt available, giving up
>
> Cc: Benoit Cousson <b-cousson@ti.com>
>
> Signed-off-by: Rajendra Nayak <rnayak@ti.com>
> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
> ---
> arch/arm/boot/dts/omap5.dtsi | 16 ++++++++++++----
> 1 file changed, 12 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi
> index 790bb2a..7a78d1b 100644
> --- a/arch/arm/boot/dts/omap5.dtsi
> +++ b/arch/arm/boot/dts/omap5.dtsi
> @@ -35,8 +35,12 @@
> compatible = "arm,cortex-a15";
> timer {
> compatible = "arm,armv7-timer";
> - /* 14th PPI IRQ, active low level-sensitive */
> - interrupts = <1 14 0x308>;
> + /*
> + * PPI secure/nonsecure IRQ,
> + * active low level-sensitive
> + */
> + interrupts = <1 13 0x308>,
> + <1 14 0x308>;
Care to add the virtual and HYP timer interrupts? So KVM can get a
chance to run on this HW...
> clock-frequency = <6144000>;
> };
> };
> @@ -44,8 +48,12 @@
> compatible = "arm,cortex-a15";
> timer {
> compatible = "arm,armv7-timer";
> - /* 14th PPI IRQ, active low level-sensitive */
> - interrupts = <1 14 0x308>;
> + /*
> + * PPI secure/nonsecure IRQ,
> + * active low level-sensitive
> + */
> + interrupts = <1 13 0x308>,
> + <1 14 0x308>;
Same here.
> clock-frequency = <6144000>;
> };
> };
>
Thanks,
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2013-01-18 16:02 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-18 15:32 [PATCH 0/5] ARM: OMAP5: Misc fixes Santosh Shilimkar
2013-01-18 15:32 ` Santosh Shilimkar
2013-01-18 15:32 ` [PATCH 1/5] ARM: OMAP5: Update SOC id detection code for ES2 Santosh Shilimkar
2013-01-18 15:32 ` Santosh Shilimkar
2013-01-18 15:32 ` [PATCH 2/5] ARM: OMAP2+: timer: Update the OMAP5 clocksource name as per clock data Santosh Shilimkar
2013-01-18 15:32 ` Santosh Shilimkar
2013-01-30 17:42 ` Jon Hunter
2013-01-30 17:42 ` Jon Hunter
2013-01-18 15:32 ` [PATCH 3/5] ARM: OMAP: prm: Allow prm init to success on OMAP5 SOCs Santosh Shilimkar
2013-01-18 15:32 ` Santosh Shilimkar
2013-01-18 15:32 ` [PATCH 4/5] ARM: dts: omap5-evm: Update available memory to 2032 MB Santosh Shilimkar
2013-01-18 15:32 ` Santosh Shilimkar
2013-01-18 15:32 ` [PATCH 5/5] ARM: dts: OMAP5: Specify nonsecure PPI IRQ for arch timer Santosh Shilimkar
2013-01-18 15:32 ` Santosh Shilimkar
2013-01-18 16:02 ` Marc Zyngier [this message]
2013-01-18 16:02 ` Marc Zyngier
2013-01-18 17:00 ` Santosh Shilimkar
2013-01-18 17:00 ` Santosh Shilimkar
2013-01-18 17:08 ` Marc Zyngier
2013-01-18 17:08 ` Marc Zyngier
2013-01-18 18:51 ` Santosh Shilimkar
2013-01-18 18:51 ` Santosh Shilimkar
2013-01-19 14:46 ` Marc Zyngier
2013-01-19 14:46 ` Marc Zyngier
2013-01-19 17:26 ` Santosh Shilimkar
2013-01-19 17:26 ` Santosh Shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50F97207.1030706@arm.com \
--to=marc.zyngier@arm.com \
--cc=b-cousson@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=rnayak@ti.com \
--cc=santosh.shilimkar@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.