From: Stephen Warren <swarren@wwwdotorg.org>
To: Peter De Schrijver <pdeschrijver@nvidia.com>
Cc: Prashant Gaikwad <pgaikwad@nvidia.com>,
Grant Likely <grant.likely@secretlab.ca>,
Rob Herring <rob.herring@calxeda.com>,
Rob Landley <rob@landley.net>,
Russell King <linux@arm.linux.org.uk>,
Simon Glass <sjg@chromium.org>,
Mike Turquette <mturquette@linaro.org>,
Joseph Lo <josephl@nvidia.com>,
"devicetree-discuss@lists.ozlabs.org"
<devicetree-discuss@lists.ozlabs.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v5 09/10] clk: tegra: Implement clocks for Tegra114
Date: Mon, 04 Feb 2013 14:01:09 -0700 [thread overview]
Message-ID: <51102195.9050604@wwwdotorg.org> (raw)
In-Reply-To: <20130204104531.GQ2364@tbergstrom-lnx.Nvidia.com>
On 02/04/2013 03:45 AM, Peter De Schrijver wrote:
> On Mon, Feb 04, 2013 at 08:08:55AM +0100, Prashant Gaikwad wrote:
>>> + /* xusb_hs_src */
>>> + val = readl(clk_base + CLK_SOURCE_XUSB_SS_SRC);
>>> + val |= BIT(25); /* always select PLLU_60M */
>>> + writel(val, clk_base + CLK_SOURCE_XUSB_SS_SRC);
>>> +
>>> + clk = clk_register_fixed_factor(NULL, "xusb_hs_src", "pll_u_60M", 0,
>>> + 1, 1);
>>> + clks[xusb_hs_src] = clk;
>>> +
>>
>> With device tree we can directly use pll_u_60M, no need to register
>> clock with fixed factor 1.
>
> This is true for now. In the future these clocks will need to be dvfs aware
> though. I think it makes sense to have a separate clock then?
Why does DVFS-awareness require it to be a different clock/ID?
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 09/10] clk: tegra: Implement clocks for Tegra114
Date: Mon, 04 Feb 2013 14:01:09 -0700 [thread overview]
Message-ID: <51102195.9050604@wwwdotorg.org> (raw)
In-Reply-To: <20130204104531.GQ2364@tbergstrom-lnx.Nvidia.com>
On 02/04/2013 03:45 AM, Peter De Schrijver wrote:
> On Mon, Feb 04, 2013 at 08:08:55AM +0100, Prashant Gaikwad wrote:
>>> + /* xusb_hs_src */
>>> + val = readl(clk_base + CLK_SOURCE_XUSB_SS_SRC);
>>> + val |= BIT(25); /* always select PLLU_60M */
>>> + writel(val, clk_base + CLK_SOURCE_XUSB_SS_SRC);
>>> +
>>> + clk = clk_register_fixed_factor(NULL, "xusb_hs_src", "pll_u_60M", 0,
>>> + 1, 1);
>>> + clks[xusb_hs_src] = clk;
>>> +
>>
>> With device tree we can directly use pll_u_60M, no need to register
>> clock with fixed factor 1.
>
> This is true for now. In the future these clocks will need to be dvfs aware
> though. I think it makes sense to have a separate clock then?
Why does DVFS-awareness require it to be a different clock/ID?
next prev parent reply other threads:[~2013-02-04 21:01 UTC|newest]
Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-01 10:18 [PATCH v5 00/10] Tegra114 clockframework Peter De Schrijver
2013-02-01 10:18 ` Peter De Schrijver
2013-02-01 10:18 ` Peter De Schrijver
2013-02-01 10:18 ` [PATCH v5 03/10] clk: tegra: Add PLL post divider table Peter De Schrijver
2013-02-01 10:18 ` Peter De Schrijver
2013-02-01 10:18 ` Peter De Schrijver
[not found] ` <1359713962-16822-4-git-send-email-pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-02-04 6:28 ` Prashant Gaikwad
2013-02-04 6:28 ` Prashant Gaikwad
2013-02-04 6:28 ` Prashant Gaikwad
[not found] ` <1359713962-16822-1-git-send-email-pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-02-01 10:18 ` [PATCH v5 01/10] clk: tegra: Refactor PLL programming code Peter De Schrijver
2013-02-01 10:18 ` Peter De Schrijver
2013-02-01 10:18 ` Peter De Schrijver
[not found] ` <1359713962-16822-2-git-send-email-pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-02-04 6:06 ` Prashant Gaikwad
2013-02-04 6:06 ` Prashant Gaikwad
2013-02-04 6:06 ` Prashant Gaikwad
2013-02-04 14:32 ` Peter De Schrijver
2013-02-04 14:32 ` Peter De Schrijver
2013-02-05 5:42 ` Prashant Gaikwad
2013-02-05 5:42 ` Prashant Gaikwad
[not found] ` <51109BB3.8000706-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-02-05 13:23 ` Peter De Schrijver
2013-02-05 13:23 ` Peter De Schrijver
2013-02-05 13:23 ` Peter De Schrijver
[not found] ` <20130205132355.GD3073-Rysk9IDjsxmJz7etNGeUX8VPkgjIgRvpAL8bYrjMMd8@public.gmane.org>
2013-02-06 12:32 ` Peter De Schrijver
2013-02-06 12:32 ` Peter De Schrijver
2013-02-06 12:32 ` Peter De Schrijver
2013-02-04 21:57 ` Stephen Warren
2013-02-04 21:57 ` Stephen Warren
2013-02-04 21:57 ` Stephen Warren
2013-02-01 10:18 ` [PATCH v5 02/10] clk: tegra: Add TEGRA_PLL_BYPASS flag Peter De Schrijver
2013-02-01 10:18 ` Peter De Schrijver
2013-02-01 10:18 ` Peter De Schrijver
[not found] ` <1359713962-16822-3-git-send-email-pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-02-04 6:13 ` Prashant Gaikwad
2013-02-04 6:13 ` Prashant Gaikwad
2013-02-04 6:13 ` Prashant Gaikwad
2013-02-01 10:18 ` [PATCH v5 04/10] clk: tegra: Add new fields and PLL types for Tegra114 Peter De Schrijver
2013-02-01 10:18 ` Peter De Schrijver
2013-02-01 10:18 ` Peter De Schrijver
[not found] ` <1359713962-16822-5-git-send-email-pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-02-01 19:40 ` Rhyland Klein
2013-02-01 19:40 ` Rhyland Klein
2013-02-01 19:40 ` Rhyland Klein
[not found] ` <510C1A2E.5010408-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-02-04 6:35 ` Prashant Gaikwad
2013-02-04 6:35 ` Prashant Gaikwad
2013-02-04 6:35 ` Prashant Gaikwad
[not found] ` <510F56B1.5060409-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-02-04 10:37 ` Peter De Schrijver
2013-02-04 10:37 ` Peter De Schrijver
2013-02-04 10:37 ` Peter De Schrijver
2013-02-01 10:18 ` [PATCH v5 05/10] clk: tegra: Add flags to tegra_clk_periph() Peter De Schrijver
2013-02-01 10:18 ` Peter De Schrijver
2013-02-01 10:18 ` Peter De Schrijver
[not found] ` <1359713962-16822-6-git-send-email-pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-02-04 6:33 ` Prashant Gaikwad
2013-02-04 6:33 ` Prashant Gaikwad
2013-02-04 6:33 ` Prashant Gaikwad
2013-02-01 10:18 ` [PATCH v5 06/10] clk: tegra: Workaround for Tegra114 MSENC problem Peter De Schrijver
2013-02-01 10:18 ` Peter De Schrijver
2013-02-01 10:18 ` Peter De Schrijver
2013-02-04 6:39 ` Prashant Gaikwad
2013-02-04 6:39 ` Prashant Gaikwad
2013-02-01 10:18 ` [PATCH v5 07/10] ARM: tegra: Define Tegra114 CAR binding Peter De Schrijver
2013-02-01 10:18 ` Peter De Schrijver
2013-02-01 10:18 ` Peter De Schrijver
2013-02-04 21:16 ` Stephen Warren
2013-02-04 21:16 ` Stephen Warren
2013-02-01 10:18 ` [PATCH v5 08/10] ARM: dt: Add references to tegra_car clocks Peter De Schrijver
2013-02-01 10:18 ` Peter De Schrijver
2013-02-01 10:18 ` Peter De Schrijver
2013-02-04 6:45 ` Prashant Gaikwad
2013-02-04 6:45 ` Prashant Gaikwad
2013-02-01 10:18 ` [PATCH v5 10/10] clk: tegra: devicetree match for nvidia,tegra114-car Peter De Schrijver
2013-02-01 10:18 ` Peter De Schrijver
2013-02-01 10:18 ` [PATCH v5 10/10] clk: tegra: devicetree match for nvidia, tegra114-car Peter De Schrijver
2013-02-04 7:10 ` [PATCH v5 10/10] clk: tegra: devicetree match for nvidia,tegra114-car Prashant Gaikwad
2013-02-04 7:10 ` [PATCH v5 10/10] clk: tegra: devicetree match for nvidia, tegra114-car Prashant Gaikwad
2013-02-01 10:18 ` [PATCH v5 09/10] clk: tegra: Implement clocks for Tegra114 Peter De Schrijver
2013-02-01 10:18 ` Peter De Schrijver
2013-02-01 10:18 ` Peter De Schrijver
2013-02-04 7:08 ` Prashant Gaikwad
2013-02-04 7:08 ` Prashant Gaikwad
[not found] ` <510F5E87.90801-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-02-04 10:45 ` Peter De Schrijver
2013-02-04 10:45 ` Peter De Schrijver
2013-02-04 10:45 ` Peter De Schrijver
[not found] ` <20130204104531.GQ2364-Rysk9IDjsxmJz7etNGeUX8VPkgjIgRvpAL8bYrjMMd8@public.gmane.org>
2013-02-04 14:07 ` Peter De Schrijver
2013-02-04 14:07 ` Peter De Schrijver
2013-02-04 14:07 ` Peter De Schrijver
2013-02-04 21:01 ` Stephen Warren [this message]
2013-02-04 21:01 ` Stephen Warren
2013-02-07 16:18 ` Peter De Schrijver
2013-02-07 16:18 ` Peter De Schrijver
2013-02-04 14:34 ` Peter De Schrijver
2013-02-04 14:34 ` Peter De Schrijver
[not found] ` <20130204143401.GW2364-Rysk9IDjsxmJz7etNGeUX8VPkgjIgRvpAL8bYrjMMd8@public.gmane.org>
2013-02-05 5:36 ` Prashant Gaikwad
2013-02-05 5:36 ` Prashant Gaikwad
2013-02-05 5:36 ` Prashant Gaikwad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51102195.9050604@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=josephl@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mturquette@linaro.org \
--cc=pdeschrijver@nvidia.com \
--cc=pgaikwad@nvidia.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=sjg@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.