From: Arnd Bergmann <arnd@arndb.de>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: David Daney <ddaney.cavm@gmail.com>,
linux-kernel@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, Will Deacon <will.deacon@arm.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
Marc Zyngier <marc.zyngier@arm.com>,
David Daney <david.daney@cavium.com>
Subject: Re: [PATCH v4 3/5] PCI: generic: Quit clobbering our pci_ops.
Date: Thu, 08 Oct 2015 17:09:56 +0200 [thread overview]
Message-ID: <5128429.u9O5dh5qKB@wuerfel> (raw)
In-Reply-To: <20151008150215.GB3885@localhost>
On Thursday 08 October 2015 10:02:16 Bjorn Helgaas wrote:
> [+cc Arnd]
>
> Arnd, you had comments on the previous version. What do you think of
> this one?
Looks good to me
> On Fri, Oct 02, 2015 at 11:44:01AM -0700, David Daney wrote:
> > From: David Daney <david.daney@cavium.com>
> >
> > The pci-host-generic driver keeps a global struct pci_ops which it
> > then patches with the .map_bus method appropriate for the bus device.
> > A problem arises when the driver is used for two different types of
> > bus devices, the .map_bus method for the last device probed clobbers
> > the method for all previous devices. The result, only the last bus
> > device probed has the proper .map_bus, and the others fail.
> >
> > Move the struct pci_ops into the bus specific structure, and
> > initialize a pointer to it when the bus device is probed.
> >
> > Acked-by: Will Deacon <will.deacon@arm.com>
> > Signed-off-by: David Daney <david.daney@cavium.com>
>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 3/5] PCI: generic: Quit clobbering our pci_ops.
Date: Thu, 08 Oct 2015 17:09:56 +0200 [thread overview]
Message-ID: <5128429.u9O5dh5qKB@wuerfel> (raw)
In-Reply-To: <20151008150215.GB3885@localhost>
On Thursday 08 October 2015 10:02:16 Bjorn Helgaas wrote:
> [+cc Arnd]
>
> Arnd, you had comments on the previous version. What do you think of
> this one?
Looks good to me
> On Fri, Oct 02, 2015 at 11:44:01AM -0700, David Daney wrote:
> > From: David Daney <david.daney@cavium.com>
> >
> > The pci-host-generic driver keeps a global struct pci_ops which it
> > then patches with the .map_bus method appropriate for the bus device.
> > A problem arises when the driver is used for two different types of
> > bus devices, the .map_bus method for the last device probed clobbers
> > the method for all previous devices. The result, only the last bus
> > device probed has the proper .map_bus, and the others fail.
> >
> > Move the struct pci_ops into the bus specific structure, and
> > initialize a pointer to it when the bus device is probed.
> >
> > Acked-by: Will Deacon <will.deacon@arm.com>
> > Signed-off-by: David Daney <david.daney@cavium.com>
>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
next prev parent reply other threads:[~2015-10-08 15:10 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-02 18:43 [PATCH v4 0/5] PCI: generic: Misc. bug fixes/enhancements David Daney
2015-10-02 18:43 ` David Daney
2015-10-02 18:43 ` [PATCH v4 1/5] PCI: Add pci_bus_fixup_irqs() David Daney
2015-10-02 18:43 ` David Daney
2015-10-07 19:44 ` Bjorn Helgaas
2015-10-07 19:44 ` Bjorn Helgaas
2015-10-07 20:08 ` David Daney
2015-10-07 20:08 ` David Daney
2015-10-07 20:08 ` David Daney
2015-10-07 23:08 ` Bjorn Helgaas
2015-10-07 23:08 ` Bjorn Helgaas
2015-10-08 2:07 ` Matthew Minter
2015-10-08 2:07 ` Matthew Minter
2015-10-08 2:07 ` Matthew Minter
2015-10-08 9:18 ` Lorenzo Pieralisi
2015-10-08 9:18 ` Lorenzo Pieralisi
2015-10-08 9:18 ` Lorenzo Pieralisi
2015-10-02 18:44 ` [PATCH v4 2/5] PCI: generic: Only fixup irqs for bus we are creating David Daney
2015-10-02 18:44 ` David Daney
2015-10-02 18:44 ` [PATCH v4 3/5] PCI: generic: Quit clobbering our pci_ops David Daney
2015-10-02 18:44 ` David Daney
2015-10-08 15:02 ` Bjorn Helgaas
2015-10-08 15:02 ` Bjorn Helgaas
2015-10-08 15:02 ` Bjorn Helgaas
2015-10-08 15:09 ` Arnd Bergmann [this message]
2015-10-08 15:09 ` Arnd Bergmann
2015-10-02 18:44 ` [PATCH v4 4/5] PCI: generic: Correct, and avoid overflow, in bus_max calculation David Daney
2015-10-02 18:44 ` David Daney
2015-10-08 15:02 ` Bjorn Helgaas
2015-10-08 15:02 ` Bjorn Helgaas
2015-10-08 15:11 ` Arnd Bergmann
2015-10-08 15:11 ` Arnd Bergmann
2015-10-08 15:18 ` Arnd Bergmann
2015-10-08 15:18 ` Arnd Bergmann
2015-10-08 15:39 ` David Daney
2015-10-08 15:39 ` David Daney
2015-10-08 15:39 ` David Daney
2015-10-08 17:27 ` Lorenzo Pieralisi
2015-10-08 17:27 ` Lorenzo Pieralisi
2015-10-08 17:27 ` Lorenzo Pieralisi
2015-10-02 18:44 ` [PATCH v4 5/5] PCI: generic: Pass proper starting bus number to pci_scan_root_bus() David Daney
2015-10-02 18:44 ` David Daney
2015-10-08 15:28 ` [PATCH v4 0/5] PCI: generic: Misc. bug fixes/enhancements Bjorn Helgaas
2015-10-08 15:28 ` Bjorn Helgaas
2015-10-08 15:44 ` David Daney
2015-10-08 15:44 ` David Daney
2015-10-08 15:44 ` David Daney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5128429.u9O5dh5qKB@wuerfel \
--to=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=david.daney@cavium.com \
--cc=ddaney.cavm@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=helgaas@kernel.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.