From: Paolo Bonzini <pbonzini@redhat.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Gleb Natapov <gleb@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Hu Tao <hutao@cn.fujitsu.com>, qemu-devel <qemu-devel@nongnu.org>,
Luiz Capitulino <lcapitulino@redhat.com>,
Blue Swirl <blauwirbel@gmail.com>,
Orit Wasserman <owasserm@redhat.com>,
kvm list <kvm@vger.kernel.org>,
Juan Quintela <quintela@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Jens Freimann <jfrei@linux.vnet.ibm.com>,
Jan Kiszka <jan.kiszka@siemens.com>,
Andrew Jones <drjones@redhat.com>,
Viktor Mihajlovski <mihajlov@linux.vnet.ibm.com>,
Alex Williamson <alex.williamson@redhat.com>,
Sasha Levin <levinsasha928@gmail.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Kevin Wolf <kwolf@redhat.com>, Alexander Graf <agraf@suse.de>,
Anthony Liguori <aliguori@us.ibm.com>,
Marcelo Tosatti <mtosatti@redhat.co
Subject: Re: [PATCH v13 6/8] introduce a new qom device to deal with panicked event
Date: Mon, 04 Mar 2013 11:21:11 +0100 [thread overview]
Message-ID: <51347597.8070406@redhat.com> (raw)
In-Reply-To: <5134730A.2050406@de.ibm.com>
Il 04/03/2013 11:10, Christian Borntraeger ha scritto:
> + //disabled wait: we either
> + //do a
> + //monitor_protocol_event(QEVENT_GUEST_PANICKED, whatever);
> + //or
> + //or call into pvevent
> r = EXCP_HALTED;
> break;
> case ICPT_CPU_STOP:
>
>
> I would prefer to just use the monitor_protocol_event, on the other hand
> a call into pvent could make it configurable.
I asked in my review to make pvevent not configurable, So
monitor_protocol_event(QEVENT_GUEST_PANICKED);
vm_stop(RUNSTATE_GUEST_PANICKED);
would do I guess.
Feel free to submit a patch to qemu-devel. Hu, please take any patch
that Christian submits and incorporate it in your series for future posting.
Paolo
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Gleb Natapov <gleb@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Hu Tao <hutao@cn.fujitsu.com>, qemu-devel <qemu-devel@nongnu.org>,
Luiz Capitulino <lcapitulino@redhat.com>,
Blue Swirl <blauwirbel@gmail.com>,
Orit Wasserman <owasserm@redhat.com>,
kvm list <kvm@vger.kernel.org>,
Juan Quintela <quintela@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Jens Freimann <jfrei@linux.vnet.ibm.com>,
Jan Kiszka <jan.kiszka@siemens.com>,
Andrew Jones <drjones@redhat.com>,
Viktor Mihajlovski <mihajlov@linux.vnet.ibm.com>,
Alex Williamson <alex.williamson@redhat.com>,
Sasha Levin <levinsasha928@gmail.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Kevin Wolf <kwolf@redhat.com>, Alexander Graf <agraf@suse.de>,
Anthony Liguori <aliguori@us.ibm.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Einar Lueck <elelueck@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH v13 6/8] introduce a new qom device to deal with panicked event
Date: Mon, 04 Mar 2013 11:21:11 +0100 [thread overview]
Message-ID: <51347597.8070406@redhat.com> (raw)
In-Reply-To: <5134730A.2050406@de.ibm.com>
Il 04/03/2013 11:10, Christian Borntraeger ha scritto:
> + //disabled wait: we either
> + //do a
> + //monitor_protocol_event(QEVENT_GUEST_PANICKED, whatever);
> + //or
> + //or call into pvevent
> r = EXCP_HALTED;
> break;
> case ICPT_CPU_STOP:
>
>
> I would prefer to just use the monitor_protocol_event, on the other hand
> a call into pvent could make it configurable.
I asked in my review to make pvevent not configurable, So
monitor_protocol_event(QEVENT_GUEST_PANICKED);
vm_stop(RUNSTATE_GUEST_PANICKED);
would do I guess.
Feel free to submit a patch to qemu-devel. Hu, please take any patch
that Christian submits and incorporate it in your series for future posting.
Paolo
next prev parent reply other threads:[~2013-03-04 10:21 UTC|newest]
Thread overview: 136+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-28 12:13 [PATCH v13 0/8] pv event interface between host and guest Hu Tao
2013-02-28 12:13 ` Hu Tao
2013-02-28 12:13 ` [PATCH v13] kvm: notify host when the guest is panicked Hu Tao
2013-02-28 12:13 ` Hu Tao
2013-02-28 12:13 ` [PATCH v13 1/8] save/load cpu runstate Hu Tao
2013-02-28 12:13 ` Hu Tao
2013-02-28 21:12 ` Eric Blake
2013-02-28 21:12 ` Eric Blake
2013-03-01 7:36 ` Hu Tao
2013-03-01 7:36 ` [Qemu-devel] " Hu Tao
2013-03-01 7:36 ` Hu Tao
2013-03-01 16:29 ` Eric Blake
2013-03-01 16:29 ` [Qemu-devel] " Eric Blake
2013-03-01 16:29 ` Eric Blake
2013-03-04 9:30 ` Paolo Bonzini
2013-03-04 9:30 ` [Qemu-devel] " Paolo Bonzini
2013-03-04 9:30 ` Paolo Bonzini
2013-03-05 2:33 ` Hu Tao
2013-03-05 2:33 ` [Qemu-devel] " Hu Tao
2013-03-05 2:33 ` Hu Tao
2013-03-05 8:24 ` Paolo Bonzini
2013-03-05 8:24 ` [Qemu-devel] " Paolo Bonzini
2013-03-05 8:24 ` Paolo Bonzini
2013-02-28 12:13 ` [PATCH v13 2/8] start vm after resetting it Hu Tao
2013-02-28 12:13 ` Hu Tao
2013-02-28 13:23 ` Jan Kiszka
2013-02-28 13:23 ` Jan Kiszka
2013-03-05 3:05 ` Hu Tao
2013-03-05 3:05 ` [Qemu-devel] " Hu Tao
2013-03-05 3:05 ` Hu Tao
2013-03-04 9:32 ` Paolo Bonzini
2013-03-04 9:32 ` [Qemu-devel] " Paolo Bonzini
2013-03-04 9:32 ` Paolo Bonzini
2013-03-05 3:06 ` Hu Tao
2013-03-05 3:06 ` [Qemu-devel] " Hu Tao
2013-03-05 3:06 ` Hu Tao
2013-02-28 12:13 ` [PATCH v13 3/8] update kernel headers Hu Tao
2013-02-28 12:13 ` Hu Tao
2013-02-28 12:13 ` [PATCH v13 4/8] add a new runstate: RUN_STATE_GUEST_PANICKED Hu Tao
2013-02-28 12:13 ` Hu Tao
2013-03-04 9:40 ` Paolo Bonzini
2013-03-04 9:40 ` [Qemu-devel] " Paolo Bonzini
2013-03-04 9:40 ` Paolo Bonzini
2013-03-05 3:17 ` Hu Tao
2013-03-05 3:17 ` [Qemu-devel] " Hu Tao
2013-03-05 3:17 ` Hu Tao
2013-03-05 8:26 ` Paolo Bonzini
2013-03-05 8:26 ` [Qemu-devel] " Paolo Bonzini
2013-03-05 8:26 ` Paolo Bonzini
2013-03-06 9:03 ` Hu Tao
2013-03-06 9:03 ` [Qemu-devel] " Hu Tao
2013-03-06 9:03 ` Hu Tao
2013-02-28 12:13 ` [PATCH v13 5/8] add a new qevent: QEVENT_GUEST_PANICKED Hu Tao
2013-02-28 12:13 ` Hu Tao
2013-03-01 16:31 ` Eric Blake
2013-03-01 16:31 ` [Qemu-devel] " Eric Blake
2013-03-01 16:31 ` Eric Blake
2013-03-05 3:17 ` Hu Tao
2013-03-05 3:17 ` [Qemu-devel] " Hu Tao
2013-03-05 3:17 ` Hu Tao
2013-03-04 9:40 ` Paolo Bonzini
2013-03-04 9:40 ` [Qemu-devel] " Paolo Bonzini
2013-03-04 9:40 ` Paolo Bonzini
2013-02-28 12:13 ` [PATCH v13 6/8] introduce a new qom device to deal with panicked event Hu Tao
2013-02-28 12:13 ` Hu Tao
2013-03-04 9:42 ` Paolo Bonzini
2013-03-04 9:42 ` [Qemu-devel] " Paolo Bonzini
2013-03-04 9:42 ` Paolo Bonzini
2013-03-04 10:10 ` Christian Borntraeger
2013-03-04 10:10 ` [Qemu-devel] " Christian Borntraeger
2013-03-04 10:21 ` Paolo Bonzini [this message]
2013-03-04 10:21 ` Paolo Bonzini
2013-02-28 12:13 ` [PATCH v13 7/8] allower the user to disable pv event support Hu Tao
2013-02-28 12:13 ` Hu Tao
2013-03-04 9:47 ` Paolo Bonzini
2013-03-04 9:47 ` [Qemu-devel] " Paolo Bonzini
2013-03-04 9:47 ` Paolo Bonzini
2013-02-28 12:13 ` [PATCH v13 8/8] pv event: add document to describe the usage Hu Tao
2013-02-28 12:13 ` Hu Tao
2013-03-03 9:17 ` [PATCH v13 0/8] pv event interface between host and guest Gleb Natapov
2013-03-03 9:17 ` [Qemu-devel] " Gleb Natapov
2013-03-03 9:17 ` Gleb Natapov
2013-03-04 10:05 ` Paolo Bonzini
2013-03-04 10:05 ` [Qemu-devel] " Paolo Bonzini
2013-03-04 10:05 ` Paolo Bonzini
2013-03-04 10:21 ` Gleb Natapov
2013-03-04 10:21 ` [Qemu-devel] " Gleb Natapov
2013-03-04 10:21 ` Gleb Natapov
2013-03-04 10:28 ` Paolo Bonzini
2013-03-04 10:28 ` [Qemu-devel] " Paolo Bonzini
2013-03-04 10:43 ` Gleb Natapov
2013-03-04 10:43 ` [Qemu-devel] " Gleb Natapov
2013-03-04 10:43 ` Gleb Natapov
2013-03-04 10:49 ` Paolo Bonzini
2013-03-04 10:49 ` [Qemu-devel] " Paolo Bonzini
2013-03-04 10:49 ` Paolo Bonzini
2013-03-04 10:59 ` Gleb Natapov
2013-03-04 10:59 ` [Qemu-devel] " Gleb Natapov
2013-03-04 10:59 ` Gleb Natapov
2013-03-04 11:10 ` Paolo Bonzini
2013-03-04 11:10 ` [Qemu-devel] " Paolo Bonzini
2013-03-04 11:10 ` Paolo Bonzini
2013-03-04 11:20 ` Gleb Natapov
2013-03-04 11:20 ` [Qemu-devel] " Gleb Natapov
2013-03-04 11:20 ` Gleb Natapov
2013-03-04 11:35 ` Paolo Bonzini
2013-03-04 11:35 ` [Qemu-devel] " Paolo Bonzini
2013-03-04 11:35 ` Paolo Bonzini
2013-03-04 11:52 ` Gleb Natapov
2013-03-04 11:52 ` [Qemu-devel] " Gleb Natapov
2013-03-04 11:52 ` Gleb Natapov
2013-03-04 12:21 ` Paolo Bonzini
2013-03-04 12:21 ` [Qemu-devel] " Paolo Bonzini
2013-03-04 12:21 ` Paolo Bonzini
2013-03-06 8:56 ` Hu Tao
2013-03-06 8:56 ` [Qemu-devel] " Hu Tao
2013-03-06 8:56 ` Hu Tao
2013-03-06 9:07 ` Paolo Bonzini
2013-03-06 9:07 ` [Qemu-devel] " Paolo Bonzini
2013-03-06 9:28 ` li guang
2013-03-06 9:28 ` li guang
2013-03-06 9:38 ` Gleb Natapov
2013-03-06 9:38 ` [Qemu-devel] " Gleb Natapov
2013-03-06 9:38 ` Gleb Natapov
2013-03-06 9:48 ` Paolo Bonzini
2013-03-06 9:48 ` [Qemu-devel] " Paolo Bonzini
2013-03-06 9:48 ` Paolo Bonzini
2013-03-06 9:59 ` Gleb Natapov
2013-03-06 9:59 ` [Qemu-devel] " Gleb Natapov
2013-03-06 9:59 ` Gleb Natapov
2013-03-06 8:46 ` Hu Tao
2013-03-06 8:46 ` [Qemu-devel] " Hu Tao
2013-03-06 8:46 ` Hu Tao
2013-03-06 9:37 ` Gleb Natapov
2013-03-06 9:37 ` [Qemu-devel] " Gleb Natapov
2013-03-06 9:37 ` Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51347597.8070406@redhat.com \
--to=pbonzini@redhat.com \
--cc=agraf@suse.de \
--cc=alex.williamson@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=armbru@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=borntraeger@de.ibm.com \
--cc=drjones@redhat.com \
--cc=gleb@redhat.com \
--cc=hutao@cn.fujitsu.com \
--cc=jan.kiszka@siemens.com \
--cc=jfrei@linux.vnet.ibm.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kvm@vger.kernel.org \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=levinsasha928@gmail.com \
--cc=mihajlov@linux.vnet.ibm.com \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.co \
--cc=owasserm@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.