All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Gleb Natapov <gleb@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
	kvm list <kvm@vger.kernel.org>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Hu Tao <hutao@cn.fujitsu.com>, qemu-devel <qemu-devel@nongnu.org>,
	Markus Armbruster <armbru@redhat.com>,
	Blue Swirl <blauwirbel@gmail.com>,
	Orit Wasserman <owasserm@redhat.com>,
	Juan Quintela <quintela@redhat.com>,
	Alexander Graf <agraf@suse.de>,
	Jan Kiszka <jan.kiszka@siemens.com>,
	Andrew Jones <drjones@redhat.com>,
	Alex Williamson <alex.williamson@redhat.com>,
	Sasha Levin <levinsasha928@gmail.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Luiz Capitulino <lcapitulino@redhat.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	Kevin Wolf <kwolf@redhat.com>,
	Anthony Liguori <aliguori@us.ibm.com>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v13 0/8] pv event interface between host and guest
Date: Mon, 04 Mar 2013 11:28:05 +0100	[thread overview]
Message-ID: <51347735.9090204@redhat.com> (raw)
In-Reply-To: <20130304102131.GK23616@redhat.com>

Il 04/03/2013 11:21, Gleb Natapov ha scritto:
>> > Just to clarify it for Hu Tao, the read from a random ioport is how the
>> > ACPI code will detect presence of the device.
>> > 
> Actually no (at least in the long run, for the first version it may be
> OK).

Agreed.

> Since we want to move DSDT generation into QEMU if device will not
> be present QEMU will not generate corresponded Device() in DSDT, or it
> will generate it with _STA() { Return (0x00)} hard coded.

Yes, this would be good.

> Seabios can do
> the same if we will pass it info about device presence via fw_cfg.

True, but I don't like this a lot.  I don't like splitting decisions
between SeaBIOS and the DSDT, you end up touching code all over the
place and writing ASL is simpler than patching---even with all the
machinery that we have.  It is also simpler to move ASL from SeaBIOS to
OVMF and/or viceversa.  I don't recall what was the opposition to a
fw_cfg driver directly in the DSDT, but I think this would be a good
usage for it.

Splitting it between QEMU and DSDT is a bit better, since you have to
touch QEMU anyway to implement the feature.

Anyhow, this does not apply to the next submission of this series.  I
think we can agree to the compromise of using ACPI but still read the
port in _STA.

Paolo

WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Gleb Natapov <gleb@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
	kvm list <kvm@vger.kernel.org>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Hu Tao <hutao@cn.fujitsu.com>, qemu-devel <qemu-devel@nongnu.org>,
	Markus Armbruster <armbru@redhat.com>,
	Blue Swirl <blauwirbel@gmail.com>,
	Orit Wasserman <owasserm@redhat.com>,
	Juan Quintela <quintela@redhat.com>,
	Alexander Graf <agraf@suse.de>,
	Jan Kiszka <jan.kiszka@siemens.com>,
	Andrew Jones <drjones@redhat.com>,
	Alex Williamson <alex.williamson@redhat.com>,
	Sasha Levin <levinsasha928@gmail.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Luiz Capitulino <lcapitulino@redhat.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	Kevin Wolf <kwolf@redhat.com>,
	Anthony Liguori <aliguori@us.ibm.com>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [Qemu-devel] [PATCH v13 0/8] pv event interface between host and guest
Date: Mon, 04 Mar 2013 11:28:05 +0100	[thread overview]
Message-ID: <51347735.9090204@redhat.com> (raw)
In-Reply-To: <20130304102131.GK23616@redhat.com>

Il 04/03/2013 11:21, Gleb Natapov ha scritto:
>> > Just to clarify it for Hu Tao, the read from a random ioport is how the
>> > ACPI code will detect presence of the device.
>> > 
> Actually no (at least in the long run, for the first version it may be
> OK).

Agreed.

> Since we want to move DSDT generation into QEMU if device will not
> be present QEMU will not generate corresponded Device() in DSDT, or it
> will generate it with _STA() { Return (0x00)} hard coded.

Yes, this would be good.

> Seabios can do
> the same if we will pass it info about device presence via fw_cfg.

True, but I don't like this a lot.  I don't like splitting decisions
between SeaBIOS and the DSDT, you end up touching code all over the
place and writing ASL is simpler than patching---even with all the
machinery that we have.  It is also simpler to move ASL from SeaBIOS to
OVMF and/or viceversa.  I don't recall what was the opposition to a
fw_cfg driver directly in the DSDT, but I think this would be a good
usage for it.

Splitting it between QEMU and DSDT is a bit better, since you have to
touch QEMU anyway to implement the feature.

Anyhow, this does not apply to the next submission of this series.  I
think we can agree to the compromise of using ACPI but still read the
port in _STA.

Paolo

  reply	other threads:[~2013-03-04 10:28 UTC|newest]

Thread overview: 136+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-28 12:13 [PATCH v13 0/8] pv event interface between host and guest Hu Tao
2013-02-28 12:13 ` Hu Tao
2013-02-28 12:13 ` [PATCH v13] kvm: notify host when the guest is panicked Hu Tao
2013-02-28 12:13   ` Hu Tao
2013-02-28 12:13 ` [PATCH v13 1/8] save/load cpu runstate Hu Tao
2013-02-28 12:13   ` Hu Tao
2013-02-28 21:12   ` Eric Blake
2013-02-28 21:12     ` Eric Blake
2013-03-01  7:36     ` Hu Tao
2013-03-01  7:36       ` [Qemu-devel] " Hu Tao
2013-03-01  7:36       ` Hu Tao
2013-03-01 16:29       ` Eric Blake
2013-03-01 16:29         ` [Qemu-devel] " Eric Blake
2013-03-01 16:29         ` Eric Blake
2013-03-04  9:30   ` Paolo Bonzini
2013-03-04  9:30     ` [Qemu-devel] " Paolo Bonzini
2013-03-04  9:30     ` Paolo Bonzini
2013-03-05  2:33     ` Hu Tao
2013-03-05  2:33       ` [Qemu-devel] " Hu Tao
2013-03-05  2:33       ` Hu Tao
2013-03-05  8:24       ` Paolo Bonzini
2013-03-05  8:24         ` [Qemu-devel] " Paolo Bonzini
2013-03-05  8:24         ` Paolo Bonzini
2013-02-28 12:13 ` [PATCH v13 2/8] start vm after resetting it Hu Tao
2013-02-28 12:13   ` Hu Tao
2013-02-28 13:23   ` Jan Kiszka
2013-02-28 13:23     ` Jan Kiszka
2013-03-05  3:05     ` Hu Tao
2013-03-05  3:05       ` [Qemu-devel] " Hu Tao
2013-03-05  3:05       ` Hu Tao
2013-03-04  9:32   ` Paolo Bonzini
2013-03-04  9:32     ` [Qemu-devel] " Paolo Bonzini
2013-03-04  9:32     ` Paolo Bonzini
2013-03-05  3:06     ` Hu Tao
2013-03-05  3:06       ` [Qemu-devel] " Hu Tao
2013-03-05  3:06       ` Hu Tao
2013-02-28 12:13 ` [PATCH v13 3/8] update kernel headers Hu Tao
2013-02-28 12:13   ` Hu Tao
2013-02-28 12:13 ` [PATCH v13 4/8] add a new runstate: RUN_STATE_GUEST_PANICKED Hu Tao
2013-02-28 12:13   ` Hu Tao
2013-03-04  9:40   ` Paolo Bonzini
2013-03-04  9:40     ` [Qemu-devel] " Paolo Bonzini
2013-03-04  9:40     ` Paolo Bonzini
2013-03-05  3:17     ` Hu Tao
2013-03-05  3:17       ` [Qemu-devel] " Hu Tao
2013-03-05  3:17       ` Hu Tao
2013-03-05  8:26       ` Paolo Bonzini
2013-03-05  8:26         ` [Qemu-devel] " Paolo Bonzini
2013-03-05  8:26         ` Paolo Bonzini
2013-03-06  9:03         ` Hu Tao
2013-03-06  9:03           ` [Qemu-devel] " Hu Tao
2013-03-06  9:03           ` Hu Tao
2013-02-28 12:13 ` [PATCH v13 5/8] add a new qevent: QEVENT_GUEST_PANICKED Hu Tao
2013-02-28 12:13   ` Hu Tao
2013-03-01 16:31   ` Eric Blake
2013-03-01 16:31     ` [Qemu-devel] " Eric Blake
2013-03-01 16:31     ` Eric Blake
2013-03-05  3:17     ` Hu Tao
2013-03-05  3:17       ` [Qemu-devel] " Hu Tao
2013-03-05  3:17       ` Hu Tao
2013-03-04  9:40   ` Paolo Bonzini
2013-03-04  9:40     ` [Qemu-devel] " Paolo Bonzini
2013-03-04  9:40     ` Paolo Bonzini
2013-02-28 12:13 ` [PATCH v13 6/8] introduce a new qom device to deal with panicked event Hu Tao
2013-02-28 12:13   ` Hu Tao
2013-03-04  9:42   ` Paolo Bonzini
2013-03-04  9:42     ` [Qemu-devel] " Paolo Bonzini
2013-03-04  9:42     ` Paolo Bonzini
2013-03-04 10:10   ` Christian Borntraeger
2013-03-04 10:10     ` [Qemu-devel] " Christian Borntraeger
2013-03-04 10:21     ` Paolo Bonzini
2013-03-04 10:21       ` [Qemu-devel] " Paolo Bonzini
2013-02-28 12:13 ` [PATCH v13 7/8] allower the user to disable pv event support Hu Tao
2013-02-28 12:13   ` Hu Tao
2013-03-04  9:47   ` Paolo Bonzini
2013-03-04  9:47     ` [Qemu-devel] " Paolo Bonzini
2013-03-04  9:47     ` Paolo Bonzini
2013-02-28 12:13 ` [PATCH v13 8/8] pv event: add document to describe the usage Hu Tao
2013-02-28 12:13   ` Hu Tao
2013-03-03  9:17 ` [PATCH v13 0/8] pv event interface between host and guest Gleb Natapov
2013-03-03  9:17   ` [Qemu-devel] " Gleb Natapov
2013-03-03  9:17   ` Gleb Natapov
2013-03-04 10:05   ` Paolo Bonzini
2013-03-04 10:05     ` [Qemu-devel] " Paolo Bonzini
2013-03-04 10:05     ` Paolo Bonzini
2013-03-04 10:21     ` Gleb Natapov
2013-03-04 10:21       ` [Qemu-devel] " Gleb Natapov
2013-03-04 10:21       ` Gleb Natapov
2013-03-04 10:28       ` Paolo Bonzini [this message]
2013-03-04 10:28         ` [Qemu-devel] " Paolo Bonzini
2013-03-04 10:43         ` Gleb Natapov
2013-03-04 10:43           ` [Qemu-devel] " Gleb Natapov
2013-03-04 10:43           ` Gleb Natapov
2013-03-04 10:49           ` Paolo Bonzini
2013-03-04 10:49             ` [Qemu-devel] " Paolo Bonzini
2013-03-04 10:49             ` Paolo Bonzini
2013-03-04 10:59             ` Gleb Natapov
2013-03-04 10:59               ` [Qemu-devel] " Gleb Natapov
2013-03-04 10:59               ` Gleb Natapov
2013-03-04 11:10               ` Paolo Bonzini
2013-03-04 11:10                 ` [Qemu-devel] " Paolo Bonzini
2013-03-04 11:10                 ` Paolo Bonzini
2013-03-04 11:20                 ` Gleb Natapov
2013-03-04 11:20                   ` [Qemu-devel] " Gleb Natapov
2013-03-04 11:20                   ` Gleb Natapov
2013-03-04 11:35                   ` Paolo Bonzini
2013-03-04 11:35                     ` [Qemu-devel] " Paolo Bonzini
2013-03-04 11:35                     ` Paolo Bonzini
2013-03-04 11:52                     ` Gleb Natapov
2013-03-04 11:52                       ` [Qemu-devel] " Gleb Natapov
2013-03-04 11:52                       ` Gleb Natapov
2013-03-04 12:21                       ` Paolo Bonzini
2013-03-04 12:21                         ` [Qemu-devel] " Paolo Bonzini
2013-03-04 12:21                         ` Paolo Bonzini
2013-03-06  8:56     ` Hu Tao
2013-03-06  8:56       ` [Qemu-devel] " Hu Tao
2013-03-06  8:56       ` Hu Tao
2013-03-06  9:07       ` Paolo Bonzini
2013-03-06  9:07         ` [Qemu-devel] " Paolo Bonzini
2013-03-06  9:28         ` li guang
2013-03-06  9:28           ` li guang
2013-03-06  9:38         ` Gleb Natapov
2013-03-06  9:38           ` [Qemu-devel] " Gleb Natapov
2013-03-06  9:38           ` Gleb Natapov
2013-03-06  9:48           ` Paolo Bonzini
2013-03-06  9:48             ` [Qemu-devel] " Paolo Bonzini
2013-03-06  9:48             ` Paolo Bonzini
2013-03-06  9:59             ` Gleb Natapov
2013-03-06  9:59               ` [Qemu-devel] " Gleb Natapov
2013-03-06  9:59               ` Gleb Natapov
2013-03-06  8:46   ` Hu Tao
2013-03-06  8:46     ` [Qemu-devel] " Hu Tao
2013-03-06  8:46     ` Hu Tao
2013-03-06  9:37     ` Gleb Natapov
2013-03-06  9:37       ` [Qemu-devel] " Gleb Natapov
2013-03-06  9:37       ` Gleb Natapov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51347735.9090204@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=agraf@suse.de \
    --cc=alex.williamson@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=armbru@redhat.com \
    --cc=blauwirbel@gmail.com \
    --cc=drjones@redhat.com \
    --cc=gleb@redhat.com \
    --cc=hutao@cn.fujitsu.com \
    --cc=jan.kiszka@siemens.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=kvm@vger.kernel.org \
    --cc=kwolf@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=levinsasha928@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=mtosatti@redhat.com \
    --cc=owasserm@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.