All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: qemu-trivial@nongnu.org, Peter Maydell <peter.maydell@linaro.org>,
	qemu-devel <qemu-devel@nongnu.org>,
	liguang <lig.fnst@cn.fujitsu.com>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] translate: remove redundantly included qemu/timer.h
Date: Wed, 01 May 2013 19:29:34 +0200	[thread overview]
Message-ID: <518150FE.1000501@suse.de> (raw)
In-Reply-To: <51814C37.4060000@msgid.tls.msk.ru>

Am 01.05.2013 19:09, schrieb Michael Tokarev:
> 30.04.2013 06:59, liguang wrote:
>> Signed-off-by: liguang <lig.fnst@cn.fujitsu.com>
>> ---
>>  translate-all.c |    1 -
>>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> Hmm.  Does we require S-o-b line even for such a trivial (but nevertheless important) stuff?

Yes: http://wiki.qemu.org/Contribute/SubmitAPatch

If it's missing, author can either reply with Signed-off-by - if you're
willing to fix it up - or resend.

And whenever you pick up patches, you sign them off as well.

> Also, Peter, does your followup email mean your Rewieved-by should be added too?

No, generally not if it was not explicitly given. Exception from the
rule: We have allowed to turn an informal "ack" into an Acked-by.

Thanks for taking over qemu-trivial!

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg


WARNING: multiple messages have this Message-ID (diff)
From: "Andreas Färber" <afaerber@suse.de>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: qemu-trivial@nongnu.org, Peter Maydell <peter.maydell@linaro.org>,
	qemu-devel <qemu-devel@nongnu.org>,
	liguang <lig.fnst@cn.fujitsu.com>
Subject: Re: [Qemu-devel] [PATCH] translate: remove redundantly included qemu/timer.h
Date: Wed, 01 May 2013 19:29:34 +0200	[thread overview]
Message-ID: <518150FE.1000501@suse.de> (raw)
In-Reply-To: <51814C37.4060000@msgid.tls.msk.ru>

Am 01.05.2013 19:09, schrieb Michael Tokarev:
> 30.04.2013 06:59, liguang wrote:
>> Signed-off-by: liguang <lig.fnst@cn.fujitsu.com>
>> ---
>>  translate-all.c |    1 -
>>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> Hmm.  Does we require S-o-b line even for such a trivial (but nevertheless important) stuff?

Yes: http://wiki.qemu.org/Contribute/SubmitAPatch

If it's missing, author can either reply with Signed-off-by - if you're
willing to fix it up - or resend.

And whenever you pick up patches, you sign them off as well.

> Also, Peter, does your followup email mean your Rewieved-by should be added too?

No, generally not if it was not explicitly given. Exception from the
rule: We have allowed to turn an informal "ack" into an Acked-by.

Thanks for taking over qemu-trivial!

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

  reply	other threads:[~2013-05-01 17:29 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-30  2:59 [Qemu-devel] [PATCH] translate: remove redundantly included qemu/timer.h liguang
2013-04-30  7:15 ` [Qemu-trivial] " Peter Maydell
2013-04-30  7:15   ` Peter Maydell
2013-05-01 17:09 ` [Qemu-trivial] " Michael Tokarev
2013-05-01 17:09   ` Michael Tokarev
2013-05-01 17:29   ` Andreas Färber [this message]
2013-05-01 17:29     ` Andreas Färber
2013-05-01 17:49   ` [Qemu-trivial] " Peter Maydell
2013-05-01 17:49     ` Peter Maydell
2013-05-18 11:26 ` [Qemu-trivial] " Michael Tokarev
2013-05-18 11:26   ` Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=518150FE.1000501@suse.de \
    --to=afaerber@suse.de \
    --cc=lig.fnst@cn.fujitsu.com \
    --cc=mjt@tls.msk.ru \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.