* [Qemu-devel] [PATCH] translate: remove redundantly included qemu/timer.h
@ 2013-04-30 2:59 liguang
2013-04-30 7:15 ` Peter Maydell
` (2 more replies)
0 siblings, 3 replies; 11+ messages in thread
From: liguang @ 2013-04-30 2:59 UTC (permalink / raw)
To: qemu-devel; +Cc: liguang
Signed-off-by: liguang <lig.fnst@cn.fujitsu.com>
---
translate-all.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/translate-all.c b/translate-all.c
index da93608..d04a116 100644
--- a/translate-all.c
+++ b/translate-all.c
@@ -55,7 +55,6 @@
#else
#include "exec/address-spaces.h"
#endif
-#include "qemu/timer.h"
#include "exec/cputlb.h"
#include "translate-all.h"
--
1.7.2.5
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [Qemu-trivial] [Qemu-devel] [PATCH] translate: remove redundantly included qemu/timer.h 2013-04-30 2:59 [Qemu-devel] [PATCH] translate: remove redundantly included qemu/timer.h liguang @ 2013-04-30 7:15 ` Peter Maydell 2013-05-01 17:09 ` Michael Tokarev 2013-05-18 11:26 ` Michael Tokarev 2 siblings, 0 replies; 11+ messages in thread From: Peter Maydell @ 2013-04-30 7:15 UTC (permalink / raw) To: liguang; +Cc: QEMU Trivial, Alexey Kardashevskiy, qemu-devel, Alexander Graf On 30 April 2013 03:59, liguang <lig.fnst@cn.fujitsu.com> wrote: > Signed-off-by: liguang <lig.fnst@cn.fujitsu.com> > --- > translate-all.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/translate-all.c b/translate-all.c > index da93608..d04a116 100644 > --- a/translate-all.c > +++ b/translate-all.c > @@ -55,7 +55,6 @@ > #else > #include "exec/address-spaces.h" > #endif > -#include "qemu/timer.h" Nice catch -- this was a fix for a compile failure when compiling with profiling enabled, which got fixed once directly (commit 0aa09897) and once via a commit through the PPC tree (commit c8ff5daa0). This change fixes the double-include by effectively reverting the latter commit. thanks -- PMM ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Qemu-devel] [PATCH] translate: remove redundantly included qemu/timer.h @ 2013-04-30 7:15 ` Peter Maydell 0 siblings, 0 replies; 11+ messages in thread From: Peter Maydell @ 2013-04-30 7:15 UTC (permalink / raw) To: liguang; +Cc: QEMU Trivial, Alexey Kardashevskiy, qemu-devel, Alexander Graf On 30 April 2013 03:59, liguang <lig.fnst@cn.fujitsu.com> wrote: > Signed-off-by: liguang <lig.fnst@cn.fujitsu.com> > --- > translate-all.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/translate-all.c b/translate-all.c > index da93608..d04a116 100644 > --- a/translate-all.c > +++ b/translate-all.c > @@ -55,7 +55,6 @@ > #else > #include "exec/address-spaces.h" > #endif > -#include "qemu/timer.h" Nice catch -- this was a fix for a compile failure when compiling with profiling enabled, which got fixed once directly (commit 0aa09897) and once via a commit through the PPC tree (commit c8ff5daa0). This change fixes the double-include by effectively reverting the latter commit. thanks -- PMM ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PATCH] translate: remove redundantly included qemu/timer.h 2013-04-30 2:59 [Qemu-devel] [PATCH] translate: remove redundantly included qemu/timer.h liguang @ 2013-05-01 17:09 ` Michael Tokarev 2013-05-01 17:09 ` Michael Tokarev 2013-05-18 11:26 ` Michael Tokarev 2 siblings, 0 replies; 11+ messages in thread From: Michael Tokarev @ 2013-05-01 17:09 UTC (permalink / raw) To: liguang; +Cc: qemu-trivial, Peter Maydell, qemu-devel 30.04.2013 06:59, liguang wrote: > Signed-off-by: liguang <lig.fnst@cn.fujitsu.com> > --- > translate-all.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) Hmm. Does we require S-o-b line even for such a trivial (but nevertheless important) stuff? Also, Peter, does your followup email mean your Rewieved-by should be added too? Confused, /mjt > diff --git a/translate-all.c b/translate-all.c > index da93608..d04a116 100644 > --- a/translate-all.c > +++ b/translate-all.c > @@ -55,7 +55,6 @@ > #else > #include "exec/address-spaces.h" > #endif > -#include "qemu/timer.h" > > #include "exec/cputlb.h" > #include "translate-all.h" > ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Qemu-devel] [PATCH] translate: remove redundantly included qemu/timer.h @ 2013-05-01 17:09 ` Michael Tokarev 0 siblings, 0 replies; 11+ messages in thread From: Michael Tokarev @ 2013-05-01 17:09 UTC (permalink / raw) To: liguang; +Cc: qemu-trivial, Peter Maydell, qemu-devel 30.04.2013 06:59, liguang wrote: > Signed-off-by: liguang <lig.fnst@cn.fujitsu.com> > --- > translate-all.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) Hmm. Does we require S-o-b line even for such a trivial (but nevertheless important) stuff? Also, Peter, does your followup email mean your Rewieved-by should be added too? Confused, /mjt > diff --git a/translate-all.c b/translate-all.c > index da93608..d04a116 100644 > --- a/translate-all.c > +++ b/translate-all.c > @@ -55,7 +55,6 @@ > #else > #include "exec/address-spaces.h" > #endif > -#include "qemu/timer.h" > > #include "exec/cputlb.h" > #include "translate-all.h" > ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PATCH] translate: remove redundantly included qemu/timer.h 2013-05-01 17:09 ` Michael Tokarev @ 2013-05-01 17:29 ` Andreas Färber -1 siblings, 0 replies; 11+ messages in thread From: Andreas Färber @ 2013-05-01 17:29 UTC (permalink / raw) To: Michael Tokarev; +Cc: qemu-trivial, Peter Maydell, qemu-devel, liguang Am 01.05.2013 19:09, schrieb Michael Tokarev: > 30.04.2013 06:59, liguang wrote: >> Signed-off-by: liguang <lig.fnst@cn.fujitsu.com> >> --- >> translate-all.c | 1 - >> 1 files changed, 0 insertions(+), 1 deletions(-) > > Hmm. Does we require S-o-b line even for such a trivial (but nevertheless important) stuff? Yes: http://wiki.qemu.org/Contribute/SubmitAPatch If it's missing, author can either reply with Signed-off-by - if you're willing to fix it up - or resend. And whenever you pick up patches, you sign them off as well. > Also, Peter, does your followup email mean your Rewieved-by should be added too? No, generally not if it was not explicitly given. Exception from the rule: We have allowed to turn an informal "ack" into an Acked-by. Thanks for taking over qemu-trivial! Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Qemu-devel] [PATCH] translate: remove redundantly included qemu/timer.h @ 2013-05-01 17:29 ` Andreas Färber 0 siblings, 0 replies; 11+ messages in thread From: Andreas Färber @ 2013-05-01 17:29 UTC (permalink / raw) To: Michael Tokarev; +Cc: qemu-trivial, Peter Maydell, qemu-devel, liguang Am 01.05.2013 19:09, schrieb Michael Tokarev: > 30.04.2013 06:59, liguang wrote: >> Signed-off-by: liguang <lig.fnst@cn.fujitsu.com> >> --- >> translate-all.c | 1 - >> 1 files changed, 0 insertions(+), 1 deletions(-) > > Hmm. Does we require S-o-b line even for such a trivial (but nevertheless important) stuff? Yes: http://wiki.qemu.org/Contribute/SubmitAPatch If it's missing, author can either reply with Signed-off-by - if you're willing to fix it up - or resend. And whenever you pick up patches, you sign them off as well. > Also, Peter, does your followup email mean your Rewieved-by should be added too? No, generally not if it was not explicitly given. Exception from the rule: We have allowed to turn an informal "ack" into an Acked-by. Thanks for taking over qemu-trivial! Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PATCH] translate: remove redundantly included qemu/timer.h 2013-05-01 17:09 ` Michael Tokarev @ 2013-05-01 17:49 ` Peter Maydell -1 siblings, 0 replies; 11+ messages in thread From: Peter Maydell @ 2013-05-01 17:49 UTC (permalink / raw) To: Michael Tokarev; +Cc: qemu-trivial, qemu-devel, liguang On 1 May 2013 18:09, Michael Tokarev <mjt@tls.msk.ru> wrote: > Also, Peter, does your followup email mean your Rewieved-by > should be added too? As Andreas says, you don't add R-b: tags unless they were explicitly given. However in this case I think I just forgot to write it, so here you are: Reviewed-by: Peter Maydell <peter.maydell@linaro.org> thanks -- PMM ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Qemu-devel] [PATCH] translate: remove redundantly included qemu/timer.h @ 2013-05-01 17:49 ` Peter Maydell 0 siblings, 0 replies; 11+ messages in thread From: Peter Maydell @ 2013-05-01 17:49 UTC (permalink / raw) To: Michael Tokarev; +Cc: qemu-trivial, qemu-devel, liguang On 1 May 2013 18:09, Michael Tokarev <mjt@tls.msk.ru> wrote: > Also, Peter, does your followup email mean your Rewieved-by > should be added too? As Andreas says, you don't add R-b: tags unless they were explicitly given. However in this case I think I just forgot to write it, so here you are: Reviewed-by: Peter Maydell <peter.maydell@linaro.org> thanks -- PMM ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PATCH] translate: remove redundantly included qemu/timer.h 2013-04-30 2:59 [Qemu-devel] [PATCH] translate: remove redundantly included qemu/timer.h liguang @ 2013-05-18 11:26 ` Michael Tokarev 2013-05-01 17:09 ` Michael Tokarev 2013-05-18 11:26 ` Michael Tokarev 2 siblings, 0 replies; 11+ messages in thread From: Michael Tokarev @ 2013-05-18 11:26 UTC (permalink / raw) To: liguang; +Cc: qemu-trivial, qemu-devel 30.04.2013 06:59, liguang wrote: > Signed-off-by: liguang <lig.fnst@cn.fujitsu.com> Thanks, applied to the trivial patches queue. /mjt ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Qemu-devel] [PATCH] translate: remove redundantly included qemu/timer.h @ 2013-05-18 11:26 ` Michael Tokarev 0 siblings, 0 replies; 11+ messages in thread From: Michael Tokarev @ 2013-05-18 11:26 UTC (permalink / raw) To: liguang; +Cc: qemu-trivial, qemu-devel 30.04.2013 06:59, liguang wrote: > Signed-off-by: liguang <lig.fnst@cn.fujitsu.com> Thanks, applied to the trivial patches queue. /mjt ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2013-05-18 11:26 UTC | newest] Thread overview: 11+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2013-04-30 2:59 [Qemu-devel] [PATCH] translate: remove redundantly included qemu/timer.h liguang 2013-04-30 7:15 ` [Qemu-trivial] " Peter Maydell 2013-04-30 7:15 ` Peter Maydell 2013-05-01 17:09 ` [Qemu-trivial] " Michael Tokarev 2013-05-01 17:09 ` Michael Tokarev 2013-05-01 17:29 ` [Qemu-trivial] " Andreas Färber 2013-05-01 17:29 ` Andreas Färber 2013-05-01 17:49 ` [Qemu-trivial] " Peter Maydell 2013-05-01 17:49 ` Peter Maydell 2013-05-18 11:26 ` [Qemu-trivial] " Michael Tokarev 2013-05-18 11:26 ` Michael Tokarev
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.