Re: [PATCH 06/14] ARM: bcm281xx: Remove init_irq declaration in machine description

[Maxime Ripard <maxime.ripard@free-electrons.com>]

Hi Christian,

Le 13/05/2013 22:06, Christian Daudt a écrit :
> On 13-05-13 02:44 AM, Maxime Ripard wrote:
>> Commit ebafed7a ("ARM: irq: Call irqchip_init if no init_irq function is
>> specified") removed the need to explictly setup the init_irq field in
>> the machine description when using only irqchip_init. Remove that
>> declaration for bcm281xx as well.
>>
>> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
>> ---
>>   arch/arm/mach-bcm/board_bcm.c | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/arch/arm/mach-bcm/board_bcm.c
>> b/arch/arm/mach-bcm/board_bcm.c
>> index 22e8421..24556cf 100644
>> --- a/arch/arm/mach-bcm/board_bcm.c
>> +++ b/arch/arm/mach-bcm/board_bcm.c
>> @@ -54,7 +54,6 @@ static void __init board_init(void)
>>   static const char * const bcm11351_dt_compat[] = { "bcm,bcm11351",
>> NULL, };
>>     DT_MACHINE_START(BCM11351_DT, "Broadcom Application Processor")
>> -    .init_irq = irqchip_init,
>>       .init_time = clocksource_of_init,
>>       .init_machine = board_init,
>>       .dt_compat = bcm11351_dt_compat,
> Acked-by: Christian Daudt <csd@broadcom.com>

Thanks!

I forgot to remove the include of irqchip.h into all these patches, so
I'll send a v2, and I guess you could probably merge it through your
tree after that directly.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com