tools/misc/xencov.c: build failure on NetBSD

tools/misc/xencov.c: build failure on NetBSD

[Christoph Egger]

Hi,

tools/misc/xencov.c fails to build.
NetBSD does not have MAP_LOCKED.

Christoph

Re: tools/misc/xencov.c: build failure on NetBSD

[Miguel Clara]

Christoph Egger <chegger <at> amazon.de> writes:

> 
> Hi,
> 
> tools/misc/xencov.c fails to build.
> NetBSD does not have MAP_LOCKED.
> 
> Christoph
> 

I wanted to test 4.3 on NetBSD but ended up with this problem too... In fact
this happened before in other parts of the code... 
http://lists.xen.org/archives/html/xen-devel/2012-06/msg00576.html

I guess this would fix it...

#ifdef __NetBSD__ 
/* MAP_LOCKED is Linux specific. MAP_WIRED is NetBSD's equivalent. */ 
#define MAP_LOCKED MAP_WIRED 
#endif 

Sadly I came across another error, still searching if it was already posted,
otherwise I will!

Re: tools/misc/xencov.c: build failure on NetBSD

[Miguel Clara]

>
> Sadly I came across another error, still searching if it was already posted,
> otherwise I will!

Acctually the other error was about libxl (array subscript has type
'char' ) this was already mentioned!

>
>
>
>

Re: tools/misc/xencov.c: build failure on NetBSD

[Ian Campbell]

On Thu, 2013-05-23 at 02:04 +0100, Miguel Clara wrote:
> >
> > Sadly I came across another error, still searching if it was already posted,
> > otherwise I will!
> 
> Acctually the other error was about libxl (array subscript has type
> 'char' ) this was already mentioned!

DO you have a reference? Was there a patch?

Ian.

Re: tools/misc/xencov.c: build failure on NetBSD

[Miguel Clara]

here: http://www.gossamer-threads.com/lists/xen/devel/282660

- fix error: array subscript has type 'char'



On Thu, May 23, 2013 at 10:14 AM, Ian Campbell <Ian.Campbell@citrix.com> wrote:
> On Thu, 2013-05-23 at 02:04 +0100, Miguel Clara wrote:
>> >
>> > Sadly I came across another error, still searching if it was already posted,
>> > otherwise I will!
>>
>> Acctually the other error was about libxl (array subscript has type
>> 'char' ) this was already mentioned!
>
> DO you have a reference? Was there a patch?
>
> Ian.
>

Re: tools/misc/xencov.c: build failure on NetBSD

[Ian Campbell]

On Wed, 2013-05-22 at 23:43 +0000, Miguel Clara wrote:
> Christoph Egger <chegger <at> amazon.de> writes:
> 
> > 
> > Hi,
> > 
> > tools/misc/xencov.c fails to build.
> > NetBSD does not have MAP_LOCKED.
> > 
> > Christoph
> > 
> 
> I wanted to test 4.3 on NetBSD but ended up with this problem too... In fact
> this happened before in other parts of the code... 
> http://lists.xen.org/archives/html/xen-devel/2012-06/msg00576.html
> 
> I guess this would fix it...

Please can you confirm and if so submit a patch

See http://wiki.xen.org/wiki/Submitting_Xen_Patches for some hints on
how to do that.

> 
> #ifdef __NetBSD__ 
> /* MAP_LOCKED is Linux specific. MAP_WIRED is NetBSD's equivalent. */ 
> #define MAP_LOCKED MAP_WIRED 
> #endif 
> 
> Sadly I came across another error, still searching if it was already posted,
> otherwise I will!
> 
> 
> 
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel

Re: tools/misc/xencov.c: build failure on NetBSD

[Miguel Clara]

[-- Attachment #1: Type: text/plain, Size: 1202 bytes --]

For now I simply added the code to tools/misc/xencov.c

Not sure if its the best way to do it.

On Thu, May 23, 2013 at 10:13 AM, Ian Campbell <Ian.Campbell@citrix.com> wrote:
> On Wed, 2013-05-22 at 23:43 +0000, Miguel Clara wrote:
>> Christoph Egger <chegger <at> amazon.de> writes:
>>
>> >
>> > Hi,
>> >
>> > tools/misc/xencov.c fails to build.
>> > NetBSD does not have MAP_LOCKED.
>> >
>> > Christoph
>> >
>>
>> I wanted to test 4.3 on NetBSD but ended up with this problem too... In fact
>> this happened before in other parts of the code...
>> http://lists.xen.org/archives/html/xen-devel/2012-06/msg00576.html
>>
>> I guess this would fix it...
>
> Please can you confirm and if so submit a patch
>
> See http://wiki.xen.org/wiki/Submitting_Xen_Patches for some hints on
> how to do that.
>
>>
>> #ifdef __NetBSD__
>> /* MAP_LOCKED is Linux specific. MAP_WIRED is NetBSD's equivalent. */
>> #define MAP_LOCKED MAP_WIRED
>> #endif
>>
>> Sadly I came across another error, still searching if it was already posted,
>> otherwise I will!
>>
>>
>>
>>
>>
>>
>> _______________________________________________
>> Xen-devel mailing list
>> Xen-devel@lists.xen.org
>> http://lists.xen.org/xen-devel
>
>

[-- Attachment #2: xencov.c_netbsd.patch --]
[-- Type: application/octet-stream, Size: 384 bytes --]

--- tools/misc/xencov.c	2013-05-23 01:09:18.000000000 +0000
+++ xencov.c_netbsd.patch	2013-05-23 01:04:49.000000000 +0000
@@ -26,6 +26,11 @@
 #include <err.h>
 #include <sys/mman.h>
 
+#ifdef __NetBSD__
+/* MAP_LOCKED is Linux specific. MAP_WIRED is NetBSD's equivalent. */
+#define MAP_LOCKED MAP_WIRED
+#endif
+
 static xc_interface *gcov_xch = NULL;
 
 static void gcov_init(void)

[-- Attachment #3: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: tools/misc/xencov.c: build failure on NetBSD

[Egger, Christoph]

On 23.05.13 12:59, Miguel Clara wrote:
> For now I simply added the code to tools/misc/xencov.c
> 
> Not sure if its the best way to do it.
> 
> On Thu, May 23, 2013 at 10:13 AM, Ian Campbell <Ian.Campbell@citrix.com> wrote:
>> On Wed, 2013-05-22 at 23:43 +0000, Miguel Clara wrote:
>>> Christoph Egger <chegger <at> amazon.de> writes:
>>>
>>>>
>>>> Hi,
>>>>
>>>> tools/misc/xencov.c fails to build.
>>>> NetBSD does not have MAP_LOCKED.
>>>>
>>>> Christoph
>>>>
>>>
>>> I wanted to test 4.3 on NetBSD but ended up with this problem too... In fact
>>> this happened before in other parts of the code...
>>> http://lists.xen.org/archives/html/xen-devel/2012-06/msg00576.html
>>>
>>> I guess this would fix it...
>>
>> Please can you confirm and if so submit a patch
>>
>> See http://wiki.xen.org/wiki/Submitting_Xen_Patches for some hints on
>> how to do that.
>>
>>>
>>> #ifdef __NetBSD__
>>> /* MAP_LOCKED is Linux specific. MAP_WIRED is NetBSD's equivalent. */
>>> #define MAP_LOCKED MAP_WIRED
>>> #endif
>>>
>>> Sadly I came across another error, still searching if it was already posted,
>>> otherwise I will!

I send this as a proper patch. Please add your Signed-off-by.

Christoph