* [PATCH] ARM: SAMSUNG: devs: Add names to fimd0 IRQ resources
@ 2013-05-15 15:09 ` Tomasz Figa
0 siblings, 0 replies; 9+ messages in thread
From: Tomasz Figa @ 2013-05-15 15:09 UTC (permalink / raw)
To: linux-samsung-soc
Cc: linux-arm-kernel, kgene.kim, arnd, olof, Tomasz Figa,
Kyungmin Park
Since commit 1977e6d8 (drm/exynos: change the method for getting the
interrupt) the Exynos DRM FIMD driver requires IRQ resources to be
named. This patch fixes probe failure in non-DT cases by adding
appropriate resource names to fimd0 platform device.
Signed-off-by: Tomasz Figa <t.figa@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
arch/arm/plat-samsung/devs.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/plat-samsung/devs.c b/arch/arm/plat-samsung/devs.c
index 30c2fe2..0f9c3f4 100644
--- a/arch/arm/plat-samsung/devs.c
+++ b/arch/arm/plat-samsung/devs.c
@@ -311,9 +311,9 @@ struct platform_device s5p_device_jpeg = {
#ifdef CONFIG_S5P_DEV_FIMD0
static struct resource s5p_fimd0_resource[] = {
[0] = DEFINE_RES_MEM(S5P_PA_FIMD0, SZ_32K),
- [1] = DEFINE_RES_IRQ(IRQ_FIMD0_VSYNC),
- [2] = DEFINE_RES_IRQ(IRQ_FIMD0_FIFO),
- [3] = DEFINE_RES_IRQ(IRQ_FIMD0_SYSTEM),
+ [1] = DEFINE_RES_IRQ_NAMED(IRQ_FIMD0_VSYNC, "vsync"),
+ [2] = DEFINE_RES_IRQ_NAMED(IRQ_FIMD0_FIFO, "fifo"),
+ [3] = DEFINE_RES_IRQ_NAMED(IRQ_FIMD0_SYSTEM, "lcd_sys"),
};
struct platform_device s5p_device_fimd0 = {
--
1.8.2.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH] ARM: SAMSUNG: devs: Add names to fimd0 IRQ resources
@ 2013-05-15 15:09 ` Tomasz Figa
0 siblings, 0 replies; 9+ messages in thread
From: Tomasz Figa @ 2013-05-15 15:09 UTC (permalink / raw)
To: linux-arm-kernel
Since commit 1977e6d8 (drm/exynos: change the method for getting the
interrupt) the Exynos DRM FIMD driver requires IRQ resources to be
named. This patch fixes probe failure in non-DT cases by adding
appropriate resource names to fimd0 platform device.
Signed-off-by: Tomasz Figa <t.figa@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
arch/arm/plat-samsung/devs.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/plat-samsung/devs.c b/arch/arm/plat-samsung/devs.c
index 30c2fe2..0f9c3f4 100644
--- a/arch/arm/plat-samsung/devs.c
+++ b/arch/arm/plat-samsung/devs.c
@@ -311,9 +311,9 @@ struct platform_device s5p_device_jpeg = {
#ifdef CONFIG_S5P_DEV_FIMD0
static struct resource s5p_fimd0_resource[] = {
[0] = DEFINE_RES_MEM(S5P_PA_FIMD0, SZ_32K),
- [1] = DEFINE_RES_IRQ(IRQ_FIMD0_VSYNC),
- [2] = DEFINE_RES_IRQ(IRQ_FIMD0_FIFO),
- [3] = DEFINE_RES_IRQ(IRQ_FIMD0_SYSTEM),
+ [1] = DEFINE_RES_IRQ_NAMED(IRQ_FIMD0_VSYNC, "vsync"),
+ [2] = DEFINE_RES_IRQ_NAMED(IRQ_FIMD0_FIFO, "fifo"),
+ [3] = DEFINE_RES_IRQ_NAMED(IRQ_FIMD0_SYSTEM, "lcd_sys"),
};
struct platform_device s5p_device_fimd0 = {
--
1.8.2.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH] ARM: SAMSUNG: devs: Add names to fimd0 IRQ resources
2013-05-15 15:09 ` Tomasz Figa
@ 2013-05-20 20:01 ` Tomasz Figa
-1 siblings, 0 replies; 9+ messages in thread
From: Tomasz Figa @ 2013-05-20 20:01 UTC (permalink / raw)
To: kgene.kim
Cc: Tomasz Figa, linux-samsung-soc, linux-arm-kernel, arnd, olof,
Kyungmin Park
Hi Kukjin,
On Wednesday 15 of May 2013 17:09:44 Tomasz Figa wrote:
> Since commit 1977e6d8 (drm/exynos: change the method for getting the
> interrupt) the Exynos DRM FIMD driver requires IRQ resources to be
> named. This patch fixes probe failure in non-DT cases by adding
> appropriate resource names to fimd0 platform device.
>
> Signed-off-by: Tomasz Figa <t.figa@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> arch/arm/plat-samsung/devs.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/plat-samsung/devs.c b/arch/arm/plat-samsung/devs.c
> index 30c2fe2..0f9c3f4 100644
> --- a/arch/arm/plat-samsung/devs.c
> +++ b/arch/arm/plat-samsung/devs.c
> @@ -311,9 +311,9 @@ struct platform_device s5p_device_jpeg = {
> #ifdef CONFIG_S5P_DEV_FIMD0
> static struct resource s5p_fimd0_resource[] = {
> [0] = DEFINE_RES_MEM(S5P_PA_FIMD0, SZ_32K),
> - [1] = DEFINE_RES_IRQ(IRQ_FIMD0_VSYNC),
> - [2] = DEFINE_RES_IRQ(IRQ_FIMD0_FIFO),
> - [3] = DEFINE_RES_IRQ(IRQ_FIMD0_SYSTEM),
> + [1] = DEFINE_RES_IRQ_NAMED(IRQ_FIMD0_VSYNC, "vsync"),
> + [2] = DEFINE_RES_IRQ_NAMED(IRQ_FIMD0_FIFO, "fifo"),
> + [3] = DEFINE_RES_IRQ_NAMED(IRQ_FIMD0_SYSTEM, "lcd_sys"),
> };
>
> struct platform_device s5p_device_fimd0 = {
This is a fix of a regression introduced to 3.10-rc1. Could you apply this
patch to your fixes branch, please?
Best regards,
Tomasz
^ permalink raw reply [flat|nested] 9+ messages in thread* [PATCH] ARM: SAMSUNG: devs: Add names to fimd0 IRQ resources
@ 2013-05-20 20:01 ` Tomasz Figa
0 siblings, 0 replies; 9+ messages in thread
From: Tomasz Figa @ 2013-05-20 20:01 UTC (permalink / raw)
To: linux-arm-kernel
Hi Kukjin,
On Wednesday 15 of May 2013 17:09:44 Tomasz Figa wrote:
> Since commit 1977e6d8 (drm/exynos: change the method for getting the
> interrupt) the Exynos DRM FIMD driver requires IRQ resources to be
> named. This patch fixes probe failure in non-DT cases by adding
> appropriate resource names to fimd0 platform device.
>
> Signed-off-by: Tomasz Figa <t.figa@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> arch/arm/plat-samsung/devs.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/plat-samsung/devs.c b/arch/arm/plat-samsung/devs.c
> index 30c2fe2..0f9c3f4 100644
> --- a/arch/arm/plat-samsung/devs.c
> +++ b/arch/arm/plat-samsung/devs.c
> @@ -311,9 +311,9 @@ struct platform_device s5p_device_jpeg = {
> #ifdef CONFIG_S5P_DEV_FIMD0
> static struct resource s5p_fimd0_resource[] = {
> [0] = DEFINE_RES_MEM(S5P_PA_FIMD0, SZ_32K),
> - [1] = DEFINE_RES_IRQ(IRQ_FIMD0_VSYNC),
> - [2] = DEFINE_RES_IRQ(IRQ_FIMD0_FIFO),
> - [3] = DEFINE_RES_IRQ(IRQ_FIMD0_SYSTEM),
> + [1] = DEFINE_RES_IRQ_NAMED(IRQ_FIMD0_VSYNC, "vsync"),
> + [2] = DEFINE_RES_IRQ_NAMED(IRQ_FIMD0_FIFO, "fifo"),
> + [3] = DEFINE_RES_IRQ_NAMED(IRQ_FIMD0_SYSTEM, "lcd_sys"),
> };
>
> struct platform_device s5p_device_fimd0 = {
This is a fix of a regression introduced to 3.10-rc1. Could you apply this
patch to your fixes branch, please?
Best regards,
Tomasz
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] ARM: SAMSUNG: devs: Add names to fimd0 IRQ resources
2013-05-15 15:09 ` Tomasz Figa
@ 2013-05-24 21:46 ` Kukjin Kim
-1 siblings, 0 replies; 9+ messages in thread
From: Kukjin Kim @ 2013-05-24 21:46 UTC (permalink / raw)
Cc: Tomasz Figa, linux-samsung-soc, linux-arm-kernel, kgene.kim, arnd,
olof, Kyungmin Park
On 05/16/13 00:09, Tomasz Figa wrote:
> Since commit 1977e6d8 (drm/exynos: change the method for getting the
> interrupt) the Exynos DRM FIMD driver requires IRQ resources to be
> named. This patch fixes probe failure in non-DT cases by adding
> appropriate resource names to fimd0 platform device.
>
> Signed-off-by: Tomasz Figa<t.figa@samsung.com>
> Signed-off-by: Kyungmin Park<kyungmin.park@samsung.com>
> ---
> arch/arm/plat-samsung/devs.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/plat-samsung/devs.c b/arch/arm/plat-samsung/devs.c
> index 30c2fe2..0f9c3f4 100644
> --- a/arch/arm/plat-samsung/devs.c
> +++ b/arch/arm/plat-samsung/devs.c
> @@ -311,9 +311,9 @@ struct platform_device s5p_device_jpeg = {
> #ifdef CONFIG_S5P_DEV_FIMD0
> static struct resource s5p_fimd0_resource[] = {
> [0] = DEFINE_RES_MEM(S5P_PA_FIMD0, SZ_32K),
> - [1] = DEFINE_RES_IRQ(IRQ_FIMD0_VSYNC),
> - [2] = DEFINE_RES_IRQ(IRQ_FIMD0_FIFO),
> - [3] = DEFINE_RES_IRQ(IRQ_FIMD0_SYSTEM),
> + [1] = DEFINE_RES_IRQ_NAMED(IRQ_FIMD0_VSYNC, "vsync"),
> + [2] = DEFINE_RES_IRQ_NAMED(IRQ_FIMD0_FIFO, "fifo"),
> + [3] = DEFINE_RES_IRQ_NAMED(IRQ_FIMD0_SYSTEM, "lcd_sys"),
> };
>
> struct platform_device s5p_device_fimd0 = {
Applied into fixes.
Thanks.
- Kukjin
^ permalink raw reply [flat|nested] 9+ messages in thread* [PATCH] ARM: SAMSUNG: devs: Add names to fimd0 IRQ resources
@ 2013-05-24 21:46 ` Kukjin Kim
0 siblings, 0 replies; 9+ messages in thread
From: Kukjin Kim @ 2013-05-24 21:46 UTC (permalink / raw)
To: linux-arm-kernel
On 05/16/13 00:09, Tomasz Figa wrote:
> Since commit 1977e6d8 (drm/exynos: change the method for getting the
> interrupt) the Exynos DRM FIMD driver requires IRQ resources to be
> named. This patch fixes probe failure in non-DT cases by adding
> appropriate resource names to fimd0 platform device.
>
> Signed-off-by: Tomasz Figa<t.figa@samsung.com>
> Signed-off-by: Kyungmin Park<kyungmin.park@samsung.com>
> ---
> arch/arm/plat-samsung/devs.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/plat-samsung/devs.c b/arch/arm/plat-samsung/devs.c
> index 30c2fe2..0f9c3f4 100644
> --- a/arch/arm/plat-samsung/devs.c
> +++ b/arch/arm/plat-samsung/devs.c
> @@ -311,9 +311,9 @@ struct platform_device s5p_device_jpeg = {
> #ifdef CONFIG_S5P_DEV_FIMD0
> static struct resource s5p_fimd0_resource[] = {
> [0] = DEFINE_RES_MEM(S5P_PA_FIMD0, SZ_32K),
> - [1] = DEFINE_RES_IRQ(IRQ_FIMD0_VSYNC),
> - [2] = DEFINE_RES_IRQ(IRQ_FIMD0_FIFO),
> - [3] = DEFINE_RES_IRQ(IRQ_FIMD0_SYSTEM),
> + [1] = DEFINE_RES_IRQ_NAMED(IRQ_FIMD0_VSYNC, "vsync"),
> + [2] = DEFINE_RES_IRQ_NAMED(IRQ_FIMD0_FIFO, "fifo"),
> + [3] = DEFINE_RES_IRQ_NAMED(IRQ_FIMD0_SYSTEM, "lcd_sys"),
> };
>
> struct platform_device s5p_device_fimd0 = {
Applied into fixes.
Thanks.
- Kukjin
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] ARM: SAMSUNG: devs: Add names to fimd0 IRQ resources
2013-05-15 15:09 ` Tomasz Figa
@ 2013-05-24 21:46 ` Kukjin Kim
-1 siblings, 0 replies; 9+ messages in thread
From: Kukjin Kim @ 2013-05-24 21:46 UTC (permalink / raw)
Cc: Tomasz Figa, linux-samsung-soc, linux-arm-kernel, kgene.kim, arnd,
olof, Kyungmin Park
On 05/16/13 00:09, Tomasz Figa wrote:
> Since commit 1977e6d8 (drm/exynos: change the method for getting the
> interrupt) the Exynos DRM FIMD driver requires IRQ resources to be
> named. This patch fixes probe failure in non-DT cases by adding
> appropriate resource names to fimd0 platform device.
>
> Signed-off-by: Tomasz Figa<t.figa@samsung.com>
> Signed-off-by: Kyungmin Park<kyungmin.park@samsung.com>
> ---
> arch/arm/plat-samsung/devs.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/plat-samsung/devs.c b/arch/arm/plat-samsung/devs.c
> index 30c2fe2..0f9c3f4 100644
> --- a/arch/arm/plat-samsung/devs.c
> +++ b/arch/arm/plat-samsung/devs.c
> @@ -311,9 +311,9 @@ struct platform_device s5p_device_jpeg = {
> #ifdef CONFIG_S5P_DEV_FIMD0
> static struct resource s5p_fimd0_resource[] = {
> [0] = DEFINE_RES_MEM(S5P_PA_FIMD0, SZ_32K),
> - [1] = DEFINE_RES_IRQ(IRQ_FIMD0_VSYNC),
> - [2] = DEFINE_RES_IRQ(IRQ_FIMD0_FIFO),
> - [3] = DEFINE_RES_IRQ(IRQ_FIMD0_SYSTEM),
> + [1] = DEFINE_RES_IRQ_NAMED(IRQ_FIMD0_VSYNC, "vsync"),
> + [2] = DEFINE_RES_IRQ_NAMED(IRQ_FIMD0_FIFO, "fifo"),
> + [3] = DEFINE_RES_IRQ_NAMED(IRQ_FIMD0_SYSTEM, "lcd_sys"),
> };
>
> struct platform_device s5p_device_fimd0 = {
Applied into fixes.
Thanks.
- Kukjin
^ permalink raw reply [flat|nested] 9+ messages in thread* [PATCH] ARM: SAMSUNG: devs: Add names to fimd0 IRQ resources
@ 2013-05-24 21:46 ` Kukjin Kim
0 siblings, 0 replies; 9+ messages in thread
From: Kukjin Kim @ 2013-05-24 21:46 UTC (permalink / raw)
To: linux-arm-kernel
On 05/16/13 00:09, Tomasz Figa wrote:
> Since commit 1977e6d8 (drm/exynos: change the method for getting the
> interrupt) the Exynos DRM FIMD driver requires IRQ resources to be
> named. This patch fixes probe failure in non-DT cases by adding
> appropriate resource names to fimd0 platform device.
>
> Signed-off-by: Tomasz Figa<t.figa@samsung.com>
> Signed-off-by: Kyungmin Park<kyungmin.park@samsung.com>
> ---
> arch/arm/plat-samsung/devs.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/plat-samsung/devs.c b/arch/arm/plat-samsung/devs.c
> index 30c2fe2..0f9c3f4 100644
> --- a/arch/arm/plat-samsung/devs.c
> +++ b/arch/arm/plat-samsung/devs.c
> @@ -311,9 +311,9 @@ struct platform_device s5p_device_jpeg = {
> #ifdef CONFIG_S5P_DEV_FIMD0
> static struct resource s5p_fimd0_resource[] = {
> [0] = DEFINE_RES_MEM(S5P_PA_FIMD0, SZ_32K),
> - [1] = DEFINE_RES_IRQ(IRQ_FIMD0_VSYNC),
> - [2] = DEFINE_RES_IRQ(IRQ_FIMD0_FIFO),
> - [3] = DEFINE_RES_IRQ(IRQ_FIMD0_SYSTEM),
> + [1] = DEFINE_RES_IRQ_NAMED(IRQ_FIMD0_VSYNC, "vsync"),
> + [2] = DEFINE_RES_IRQ_NAMED(IRQ_FIMD0_FIFO, "fifo"),
> + [3] = DEFINE_RES_IRQ_NAMED(IRQ_FIMD0_SYSTEM, "lcd_sys"),
> };
>
> struct platform_device s5p_device_fimd0 = {
Applied into fixes.
Thanks.
- Kukjin
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] ARM: SAMSUNG: devs: Add names to fimd0 IRQ resources
@ 2013-05-16 8:12 Jingoo Han
0 siblings, 0 replies; 9+ messages in thread
From: Jingoo Han @ 2013-05-16 8:12 UTC (permalink / raw)
To: Tomasz Figa, linux-samsung-soc@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org, Kukjin Kim, arnd@arndb.de,
olof@lixom.net, Kyungmin Park, Jingoo Han
Thursday, May 16, 2013 12:10 AM, Tomasz Figa wrote:
>
> Since commit 1977e6d8 (drm/exynos: change the method for getting the
> interrupt) the Exynos DRM FIMD driver requires IRQ resources to be
> named. This patch fixes probe failure in non-DT cases by adding
> appropriate resource names to fimd0 platform device.
>
> Signed-off-by: Tomasz Figa <t.figa@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
It looks good.
Thank you for sending the patch.
Acked-by: Jingoo Han <jg1.han@samsung.com>
Best regards,
Jingoo Han
> ---
> arch/arm/plat-samsung/devs.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/plat-samsung/devs.c b/arch/arm/plat-samsung/devs.c
> index 30c2fe2..0f9c3f4 100644
> --- a/arch/arm/plat-samsung/devs.c
> +++ b/arch/arm/plat-samsung/devs.c
> @@ -311,9 +311,9 @@ struct platform_device s5p_device_jpeg = {
> #ifdef CONFIG_S5P_DEV_FIMD0
> static struct resource s5p_fimd0_resource[] = {
> [0] = DEFINE_RES_MEM(S5P_PA_FIMD0, SZ_32K),
> - [1] = DEFINE_RES_IRQ(IRQ_FIMD0_VSYNC),
> - [2] = DEFINE_RES_IRQ(IRQ_FIMD0_FIFO),
> - [3] = DEFINE_RES_IRQ(IRQ_FIMD0_SYSTEM),
> + [1] = DEFINE_RES_IRQ_NAMED(IRQ_FIMD0_VSYNC, "vsync"),
> + [2] = DEFINE_RES_IRQ_NAMED(IRQ_FIMD0_FIFO, "fifo"),
> + [3] = DEFINE_RES_IRQ_NAMED(IRQ_FIMD0_SYSTEM, "lcd_sys"),
> };
>
> struct platform_device s5p_device_fimd0 = {
> --
> 1.8.2.1
>
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2013-05-24 21:46 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-15 15:09 [PATCH] ARM: SAMSUNG: devs: Add names to fimd0 IRQ resources Tomasz Figa
2013-05-15 15:09 ` Tomasz Figa
2013-05-20 20:01 ` Tomasz Figa
2013-05-20 20:01 ` Tomasz Figa
2013-05-24 21:46 ` Kukjin Kim
2013-05-24 21:46 ` Kukjin Kim
2013-05-24 21:46 ` Kukjin Kim
2013-05-24 21:46 ` Kukjin Kim
-- strict thread matches above, loose matches on Subject: below --
2013-05-16 8:12 Jingoo Han
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.