* [Qemu-trivial] [PATCH] target-mips: Remove assignment to a variable which is never used
@ 2013-07-25 20:10 ` Stefan Weil
0 siblings, 0 replies; 10+ messages in thread
From: Stefan Weil @ 2013-07-25 20:10 UTC (permalink / raw)
To: qemu-trivial; +Cc: Stefan Weil, qemu-devel
This assignment causes a compiler warning for compilations with the compiler
option -Wunused-but-set-variable (which is included with -Wextra).
Removing it allows using -Wextra for QEMU code without suppressing too many
extra warnings.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
target-mips/op_helper.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/target-mips/op_helper.c b/target-mips/op_helper.c
index 5cf1c3f..b828375 100644
--- a/target-mips/op_helper.c
+++ b/target-mips/op_helper.c
@@ -1735,7 +1735,6 @@ target_ulong helper_evpe(CPUMIPSState *env)
void helper_fork(target_ulong arg1, target_ulong arg2)
{
// arg1 = rt, arg2 = rs
- arg1 = 0;
// TODO: store to TC register
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 10+ messages in thread* [Qemu-devel] [PATCH] target-mips: Remove assignment to a variable which is never used
@ 2013-07-25 20:10 ` Stefan Weil
0 siblings, 0 replies; 10+ messages in thread
From: Stefan Weil @ 2013-07-25 20:10 UTC (permalink / raw)
To: qemu-trivial; +Cc: Stefan Weil, qemu-devel, Aurelien Jarno
This assignment causes a compiler warning for compilations with the compiler
option -Wunused-but-set-variable (which is included with -Wextra).
Removing it allows using -Wextra for QEMU code without suppressing too many
extra warnings.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
target-mips/op_helper.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/target-mips/op_helper.c b/target-mips/op_helper.c
index 5cf1c3f..b828375 100644
--- a/target-mips/op_helper.c
+++ b/target-mips/op_helper.c
@@ -1735,7 +1735,6 @@ target_ulong helper_evpe(CPUMIPSState *env)
void helper_fork(target_ulong arg1, target_ulong arg2)
{
// arg1 = rt, arg2 = rs
- arg1 = 0;
// TODO: store to TC register
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [Qemu-trivial] [PATCH] target-mips: Remove assignment to a variable which is never used
2013-07-25 20:10 ` [Qemu-devel] " Stefan Weil
@ 2013-07-27 7:22 ` Michael Tokarev
-1 siblings, 0 replies; 10+ messages in thread
From: Michael Tokarev @ 2013-07-27 7:22 UTC (permalink / raw)
To: Stefan Weil; +Cc: qemu-trivial, qemu-devel
26.07.2013 00:10, Stefan Weil wrote:
> This assignment causes a compiler warning for compilations with the compiler
> option -Wunused-but-set-variable (which is included with -Wextra).
>
> Removing it allows using -Wextra for QEMU code without suppressing too many
> extra warnings.
Thanks, applied to the trivial patches queue.
/mjt
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] target-mips: Remove assignment to a variable which is never used
@ 2013-07-27 7:22 ` Michael Tokarev
0 siblings, 0 replies; 10+ messages in thread
From: Michael Tokarev @ 2013-07-27 7:22 UTC (permalink / raw)
To: Stefan Weil; +Cc: qemu-trivial, qemu-devel
26.07.2013 00:10, Stefan Weil wrote:
> This assignment causes a compiler warning for compilations with the compiler
> option -Wunused-but-set-variable (which is included with -Wextra).
>
> Removing it allows using -Wextra for QEMU code without suppressing too many
> extra warnings.
Thanks, applied to the trivial patches queue.
/mjt
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Qemu-trivial] [PATCH] target-mips: Remove assignment to a variable which is never used
2013-07-25 20:10 ` [Qemu-devel] " Stefan Weil
@ 2013-07-28 22:37 ` Aurelien Jarno
-1 siblings, 0 replies; 10+ messages in thread
From: Aurelien Jarno @ 2013-07-28 22:37 UTC (permalink / raw)
To: Stefan Weil; +Cc: qemu-trivial, qemu-devel
On Thu, Jul 25, 2013 at 10:10:31PM +0200, Stefan Weil wrote:
> This assignment causes a compiler warning for compilations with the compiler
> option -Wunused-but-set-variable (which is included with -Wextra).
>
> Removing it allows using -Wextra for QEMU code without suppressing too many
> extra warnings.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> target-mips/op_helper.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/target-mips/op_helper.c b/target-mips/op_helper.c
> index 5cf1c3f..b828375 100644
> --- a/target-mips/op_helper.c
> +++ b/target-mips/op_helper.c
> @@ -1735,7 +1735,6 @@ target_ulong helper_evpe(CPUMIPSState *env)
> void helper_fork(target_ulong arg1, target_ulong arg2)
> {
> // arg1 = rt, arg2 = rs
> - arg1 = 0;
> // TODO: store to TC register
> }
>
Thanks, applied.
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [Qemu-devel] [PATCH] target-mips: Remove assignment to a variable which is never used
@ 2013-07-28 22:37 ` Aurelien Jarno
0 siblings, 0 replies; 10+ messages in thread
From: Aurelien Jarno @ 2013-07-28 22:37 UTC (permalink / raw)
To: Stefan Weil; +Cc: qemu-trivial, qemu-devel
On Thu, Jul 25, 2013 at 10:10:31PM +0200, Stefan Weil wrote:
> This assignment causes a compiler warning for compilations with the compiler
> option -Wunused-but-set-variable (which is included with -Wextra).
>
> Removing it allows using -Wextra for QEMU code without suppressing too many
> extra warnings.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> target-mips/op_helper.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/target-mips/op_helper.c b/target-mips/op_helper.c
> index 5cf1c3f..b828375 100644
> --- a/target-mips/op_helper.c
> +++ b/target-mips/op_helper.c
> @@ -1735,7 +1735,6 @@ target_ulong helper_evpe(CPUMIPSState *env)
> void helper_fork(target_ulong arg1, target_ulong arg2)
> {
> // arg1 = rt, arg2 = rs
> - arg1 = 0;
> // TODO: store to TC register
> }
>
Thanks, applied.
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [Qemu-trivial] [PATCH] target-mips: Remove assignment to a variable which is never used
2013-07-28 22:37 ` [Qemu-devel] " Aurelien Jarno
@ 2013-07-29 6:13 ` Michael Tokarev
-1 siblings, 0 replies; 10+ messages in thread
From: Michael Tokarev @ 2013-07-29 6:13 UTC (permalink / raw)
To: Aurelien Jarno; +Cc: qemu-trivial, Stefan Weil, qemu-devel
On 29.07.2013 02:37, Aurelien Jarno wrote:
> On Thu, Jul 25, 2013 at 10:10:31PM +0200, Stefan Weil wrote:
>> This assignment causes a compiler warning for compilations with the compiler
>> option -Wunused-but-set-variable (which is included with -Wextra).
>>
>> Removing it allows using -Wextra for QEMU code without suppressing too many
>> extra warnings.
>>
>> Signed-off-by: Stefan Weil <sw@weilnetz.de>
>> ---
>> target-mips/op_helper.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/target-mips/op_helper.c b/target-mips/op_helper.c
>> index 5cf1c3f..b828375 100644
>> --- a/target-mips/op_helper.c
>> +++ b/target-mips/op_helper.c
>> @@ -1735,7 +1735,6 @@ target_ulong helper_evpe(CPUMIPSState *env)
>> void helper_fork(target_ulong arg1, target_ulong arg2)
>> {
>> // arg1 = rt, arg2 = rs
>> - arg1 = 0;
>> // TODO: store to TC register
>> }
>
> Thanks, applied.
FWIW, you're applying this (and "linux-user: correct argument number ..")
3 days after I sent a pull request for trivial-patches which includes
these patches.
Should I rebase and re-issue my pull request now?
Thanks,
/mjt
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [Qemu-devel] [Qemu-trivial] [PATCH] target-mips: Remove assignment to a variable which is never used
@ 2013-07-29 6:13 ` Michael Tokarev
0 siblings, 0 replies; 10+ messages in thread
From: Michael Tokarev @ 2013-07-29 6:13 UTC (permalink / raw)
To: Aurelien Jarno; +Cc: qemu-trivial, Stefan Weil, qemu-devel
On 29.07.2013 02:37, Aurelien Jarno wrote:
> On Thu, Jul 25, 2013 at 10:10:31PM +0200, Stefan Weil wrote:
>> This assignment causes a compiler warning for compilations with the compiler
>> option -Wunused-but-set-variable (which is included with -Wextra).
>>
>> Removing it allows using -Wextra for QEMU code without suppressing too many
>> extra warnings.
>>
>> Signed-off-by: Stefan Weil <sw@weilnetz.de>
>> ---
>> target-mips/op_helper.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/target-mips/op_helper.c b/target-mips/op_helper.c
>> index 5cf1c3f..b828375 100644
>> --- a/target-mips/op_helper.c
>> +++ b/target-mips/op_helper.c
>> @@ -1735,7 +1735,6 @@ target_ulong helper_evpe(CPUMIPSState *env)
>> void helper_fork(target_ulong arg1, target_ulong arg2)
>> {
>> // arg1 = rt, arg2 = rs
>> - arg1 = 0;
>> // TODO: store to TC register
>> }
>
> Thanks, applied.
FWIW, you're applying this (and "linux-user: correct argument number ..")
3 days after I sent a pull request for trivial-patches which includes
these patches.
Should I rebase and re-issue my pull request now?
Thanks,
/mjt
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [Qemu-trivial] [PATCH] target-mips: Remove assignment to a variable which is never used
2013-07-29 6:13 ` [Qemu-devel] " Michael Tokarev
@ 2013-07-29 7:41 ` Aurelien Jarno
-1 siblings, 0 replies; 10+ messages in thread
From: Aurelien Jarno @ 2013-07-29 7:41 UTC (permalink / raw)
To: Michael Tokarev; +Cc: qemu-trivial, Stefan Weil, qemu-devel
On Mon, Jul 29, 2013 at 10:13:31AM +0400, Michael Tokarev wrote:
> On 29.07.2013 02:37, Aurelien Jarno wrote:
> >On Thu, Jul 25, 2013 at 10:10:31PM +0200, Stefan Weil wrote:
> >>This assignment causes a compiler warning for compilations with the compiler
> >>option -Wunused-but-set-variable (which is included with -Wextra).
> >>
> >>Removing it allows using -Wextra for QEMU code without suppressing too many
> >>extra warnings.
> >>
> >>Signed-off-by: Stefan Weil <sw@weilnetz.de>
> >>---
> >> target-mips/op_helper.c | 1 -
> >> 1 file changed, 1 deletion(-)
> >>
> >>diff --git a/target-mips/op_helper.c b/target-mips/op_helper.c
> >>index 5cf1c3f..b828375 100644
> >>--- a/target-mips/op_helper.c
> >>+++ b/target-mips/op_helper.c
> >>@@ -1735,7 +1735,6 @@ target_ulong helper_evpe(CPUMIPSState *env)
> >> void helper_fork(target_ulong arg1, target_ulong arg2)
> >> {
> >> // arg1 = rt, arg2 = rs
> >>- arg1 = 0;
> >> // TODO: store to TC register
> >> }
> >
> >Thanks, applied.
>
> FWIW, you're applying this (and "linux-user: correct argument number ..")
> 3 days after I sent a pull request for trivial-patches which includes
> these patches.
Sorry about that, I haven't seen it was applied to this tree.
> Should I rebase and re-issue my pull request now?
Git is smart enough to handle that, you don't need to redo the pull
request, which btw I have pulled.
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [Qemu-devel] [Qemu-trivial] [PATCH] target-mips: Remove assignment to a variable which is never used
@ 2013-07-29 7:41 ` Aurelien Jarno
0 siblings, 0 replies; 10+ messages in thread
From: Aurelien Jarno @ 2013-07-29 7:41 UTC (permalink / raw)
To: Michael Tokarev; +Cc: qemu-trivial, Stefan Weil, qemu-devel
On Mon, Jul 29, 2013 at 10:13:31AM +0400, Michael Tokarev wrote:
> On 29.07.2013 02:37, Aurelien Jarno wrote:
> >On Thu, Jul 25, 2013 at 10:10:31PM +0200, Stefan Weil wrote:
> >>This assignment causes a compiler warning for compilations with the compiler
> >>option -Wunused-but-set-variable (which is included with -Wextra).
> >>
> >>Removing it allows using -Wextra for QEMU code without suppressing too many
> >>extra warnings.
> >>
> >>Signed-off-by: Stefan Weil <sw@weilnetz.de>
> >>---
> >> target-mips/op_helper.c | 1 -
> >> 1 file changed, 1 deletion(-)
> >>
> >>diff --git a/target-mips/op_helper.c b/target-mips/op_helper.c
> >>index 5cf1c3f..b828375 100644
> >>--- a/target-mips/op_helper.c
> >>+++ b/target-mips/op_helper.c
> >>@@ -1735,7 +1735,6 @@ target_ulong helper_evpe(CPUMIPSState *env)
> >> void helper_fork(target_ulong arg1, target_ulong arg2)
> >> {
> >> // arg1 = rt, arg2 = rs
> >>- arg1 = 0;
> >> // TODO: store to TC register
> >> }
> >
> >Thanks, applied.
>
> FWIW, you're applying this (and "linux-user: correct argument number ..")
> 3 days after I sent a pull request for trivial-patches which includes
> these patches.
Sorry about that, I haven't seen it was applied to this tree.
> Should I rebase and re-issue my pull request now?
Git is smart enough to handle that, you don't need to redo the pull
request, which btw I have pulled.
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2013-07-29 7:41 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-25 20:10 [Qemu-trivial] [PATCH] target-mips: Remove assignment to a variable which is never used Stefan Weil
2013-07-25 20:10 ` [Qemu-devel] " Stefan Weil
2013-07-27 7:22 ` [Qemu-trivial] " Michael Tokarev
2013-07-27 7:22 ` [Qemu-devel] " Michael Tokarev
2013-07-28 22:37 ` Aurelien Jarno
2013-07-28 22:37 ` [Qemu-devel] " Aurelien Jarno
2013-07-29 6:13 ` [Qemu-trivial] " Michael Tokarev
2013-07-29 6:13 ` [Qemu-devel] " Michael Tokarev
2013-07-29 7:41 ` Aurelien Jarno
2013-07-29 7:41 ` [Qemu-devel] " Aurelien Jarno
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.