From: Santosh Shilimkar <santosh.shilimkar@ti.com>
To: Benoit Cousson <bcousson@baylibre.com>
Cc: Daniel Mack <zonque@gmail.com>,
netdev@vger.kernel.org, nsekhar@ti.com,
sergei.shtylyov@cogentembedded.com, davem@davemloft.net,
ujhelyi.m@gmail.com, mugunthanvnm@ti.com, vaibhav.bedia@ti.com,
d-gerlach@ti.com, linux-arm-kernel@lists.infradead.org,
linux-omap@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v4 3/5] net: ethernet: cpsw: introduce ti,am3352-cpsw compatible string
Date: Fri, 23 Aug 2013 11:54:45 -0400 [thread overview]
Message-ID: <521785C5.9000903@ti.com> (raw)
In-Reply-To: <52177E29.6040103@baylibre.com>
On Friday 23 August 2013 11:22 AM, Benoit Cousson wrote:
> Hi Santosh,
>
> [...]
>
>>> +static const struct of_device_id cpsw_of_mtable[] = {
>>> + {
>>> + .compatible = "ti,am3352-cpsw",
>> I didn't notice this earlier, but can't you use the IP version
>> as a compatible instead of using a SOC name. Whats really SOC specific
>> on this IP ? Sorry i have missed any earlier discussion on this but
>> this approach doesn't seem good. Its like adding SOC checks in the
>> driver subsystem.
>
> Hehe, welcome to the club!
> I keep arguing about that as well :-)
>
> I think we should create a Facebook group: "against-the-soc-version-in-the-compatible-string".
>
Indeed !!
Regards,
Santosh
WARNING: multiple messages have this Message-ID (diff)
From: santosh.shilimkar@ti.com (Santosh Shilimkar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 3/5] net: ethernet: cpsw: introduce ti,am3352-cpsw compatible string
Date: Fri, 23 Aug 2013 11:54:45 -0400 [thread overview]
Message-ID: <521785C5.9000903@ti.com> (raw)
In-Reply-To: <52177E29.6040103@baylibre.com>
On Friday 23 August 2013 11:22 AM, Benoit Cousson wrote:
> Hi Santosh,
>
> [...]
>
>>> +static const struct of_device_id cpsw_of_mtable[] = {
>>> + {
>>> + .compatible = "ti,am3352-cpsw",
>> I didn't notice this earlier, but can't you use the IP version
>> as a compatible instead of using a SOC name. Whats really SOC specific
>> on this IP ? Sorry i have missed any earlier discussion on this but
>> this approach doesn't seem good. Its like adding SOC checks in the
>> driver subsystem.
>
> Hehe, welcome to the club!
> I keep arguing about that as well :-)
>
> I think we should create a Facebook group: "against-the-soc-version-in-the-compatible-string".
>
Indeed !!
Regards,
Santosh
WARNING: multiple messages have this Message-ID (diff)
From: Santosh Shilimkar <santosh.shilimkar@ti.com>
To: Benoit Cousson <bcousson@baylibre.com>
Cc: Daniel Mack <zonque@gmail.com>, <netdev@vger.kernel.org>,
<nsekhar@ti.com>, <sergei.shtylyov@cogentembedded.com>,
<davem@davemloft.net>, <ujhelyi.m@gmail.com>,
<mugunthanvnm@ti.com>, <vaibhav.bedia@ti.com>, <d-gerlach@ti.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-omap@vger.kernel.org>, <devicetree@vger.kernel.org>
Subject: Re: [PATCH v4 3/5] net: ethernet: cpsw: introduce ti,am3352-cpsw compatible string
Date: Fri, 23 Aug 2013 11:54:45 -0400 [thread overview]
Message-ID: <521785C5.9000903@ti.com> (raw)
In-Reply-To: <52177E29.6040103@baylibre.com>
On Friday 23 August 2013 11:22 AM, Benoit Cousson wrote:
> Hi Santosh,
>
> [...]
>
>>> +static const struct of_device_id cpsw_of_mtable[] = {
>>> + {
>>> + .compatible = "ti,am3352-cpsw",
>> I didn't notice this earlier, but can't you use the IP version
>> as a compatible instead of using a SOC name. Whats really SOC specific
>> on this IP ? Sorry i have missed any earlier discussion on this but
>> this approach doesn't seem good. Its like adding SOC checks in the
>> driver subsystem.
>
> Hehe, welcome to the club!
> I keep arguing about that as well :-)
>
> I think we should create a Facebook group: "against-the-soc-version-in-the-compatible-string".
>
Indeed !!
Regards,
Santosh
next prev parent reply other threads:[~2013-08-23 15:54 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-23 14:16 [PATCH v4 0/5] cpsw: support for control module register Daniel Mack
2013-08-23 14:16 ` Daniel Mack
2013-08-23 14:16 ` [PATCH v4 1/5] net: ethernet: cpsw: switch to devres allocations Daniel Mack
2013-08-23 14:16 ` Daniel Mack
2013-08-23 18:10 ` Sergei Shtylyov
2013-08-23 18:10 ` Sergei Shtylyov
2013-08-23 18:34 ` Daniel Mack
2013-08-23 18:34 ` Daniel Mack
2013-08-23 14:16 ` [PATCH v4 2/5] net: ethernet: cpsw: add optional third memory region for CONTROL module Daniel Mack
2013-08-23 14:16 ` Daniel Mack
2013-08-23 14:59 ` Sergei Shtylyov
2013-08-23 14:59 ` Sergei Shtylyov
2013-08-23 16:21 ` Daniel Mack
2013-08-23 16:21 ` Daniel Mack
2013-08-23 17:37 ` Sergei Shtylyov
2013-08-23 17:37 ` Sergei Shtylyov
2013-08-23 14:16 ` [PATCH v4 3/5] net: ethernet: cpsw: introduce ti,am3352-cpsw compatible string Daniel Mack
2013-08-23 14:16 ` [PATCH v4 3/5] net: ethernet: cpsw: introduce ti, am3352-cpsw " Daniel Mack
2013-08-23 14:23 ` [PATCH v4 3/5] net: ethernet: cpsw: introduce ti,am3352-cpsw " Santosh Shilimkar
2013-08-23 14:23 ` Santosh Shilimkar
2013-08-23 14:23 ` Santosh Shilimkar
2013-08-23 15:22 ` Benoit Cousson
2013-08-23 15:22 ` Benoit Cousson
2013-08-23 15:54 ` Santosh Shilimkar [this message]
2013-08-23 15:54 ` Santosh Shilimkar
2013-08-23 15:54 ` Santosh Shilimkar
2013-08-23 16:30 ` Daniel Mack
2013-08-23 16:30 ` Daniel Mack
2013-08-23 16:56 ` Santosh Shilimkar
2013-08-23 16:56 ` Santosh Shilimkar
2013-08-23 17:09 ` Sekhar Nori
2013-08-23 17:09 ` Sekhar Nori
2013-08-23 17:09 ` Sekhar Nori
2013-08-23 17:17 ` Daniel Mack
2013-08-23 17:17 ` Daniel Mack
2013-08-23 17:19 ` Santosh Shilimkar
2013-08-23 17:19 ` Santosh Shilimkar
2013-08-23 17:24 ` Daniel Mack
2013-08-23 17:24 ` Daniel Mack
2013-08-23 17:28 ` Santosh Shilimkar
2013-08-23 17:28 ` Santosh Shilimkar
2013-08-23 17:28 ` Santosh Shilimkar
2013-08-23 17:39 ` Sekhar Nori
2013-08-23 17:39 ` Sekhar Nori
2013-08-23 17:39 ` Sekhar Nori
2013-08-23 18:10 ` Santosh Shilimkar
2013-08-23 18:10 ` Santosh Shilimkar
2013-08-23 18:29 ` Mugunthan V N
2013-08-23 18:29 ` Mugunthan V N
2013-08-23 19:54 ` Santosh Shilimkar
2013-08-23 19:54 ` Santosh Shilimkar
2013-08-23 19:54 ` Santosh Shilimkar
2013-08-26 5:59 ` Mugunthan V N
2013-08-26 5:59 ` Mugunthan V N
2013-08-26 6:45 ` Sekhar Nori
2013-08-26 6:45 ` Sekhar Nori
2013-08-26 6:45 ` Sekhar Nori
2013-08-23 17:23 ` Mugunthan V N
2013-08-23 17:23 ` Mugunthan V N
2013-08-23 17:23 ` Mugunthan V N
2013-08-26 5:22 ` Gupta, Pekon
2013-08-26 5:22 ` Gupta, Pekon
2013-08-23 16:31 ` Sekhar Nori
2013-08-23 16:31 ` Sekhar Nori
2013-08-23 16:31 ` Sekhar Nori
2013-08-23 16:45 ` Mugunthan V N
2013-08-23 16:45 ` Mugunthan V N
2013-08-23 16:45 ` Mugunthan V N
2013-08-23 17:05 ` Santosh Shilimkar
2013-08-23 17:05 ` Santosh Shilimkar
2013-08-23 17:05 ` Santosh Shilimkar
2013-08-23 14:16 ` [PATCH v4 4/5] net: ethernet: cpsw: add support for hardware interface mode config Daniel Mack
2013-08-23 14:16 ` Daniel Mack
2013-08-23 16:50 ` Mugunthan V N
2013-08-23 16:50 ` Mugunthan V N
2013-08-23 16:50 ` Mugunthan V N
2013-08-23 14:16 ` [PATCH v4 5/5] ARM: dts: am33xx: adopt to cpsw changes Daniel Mack
2013-08-23 14:16 ` Daniel Mack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521785C5.9000903@ti.com \
--to=santosh.shilimkar@ti.com \
--cc=bcousson@baylibre.com \
--cc=d-gerlach@ti.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=ujhelyi.m@gmail.com \
--cc=vaibhav.bedia@ti.com \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.