From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Daniel Mack <zonque@gmail.com>
Cc: netdev@vger.kernel.org, bcousson@baylibre.com, nsekhar@ti.com,
davem@davemloft.net, ujhelyi.m@gmail.com, mugunthanvnm@ti.com,
vaibhav.bedia@ti.com, d-gerlach@ti.com,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v4 2/5] net: ethernet: cpsw: add optional third memory region for CONTROL module
Date: Fri, 23 Aug 2013 21:37:20 +0400 [thread overview]
Message-ID: <52179DD0.4010300@cogentembedded.com> (raw)
In-Reply-To: <52178BED.1070308@gmail.com>
On 08/23/2013 08:21 PM, Daniel Mack wrote:
>>> + priv->gmii_sel_reg = devm_ioremap_resource(&pdev->dev, res);
>>> + if (IS_ERR(priv->gmii_sel_reg)) {
>>> + dev_err(priv->dev, "unable to map control i/o region\n");
>> You didn't actually seem to heed my words about error message.
> Well yes I did, but only in the check for platform_get_resource(). As
> the comment says - we pass on if that memory region is not given, but if
> it is given, it also has to be valid.
Yes, but what I told you was devm_ioremap_resource() prints the error
messages itself, so that you don't have to. And you even consented with that. :-)
>> And don't you want to do:
>> res = PTR_ERR(priv->gmii_sel_reg);
Well, I've messed with the variable name: 'res' is struct resource *',
what I meant was *int* variable.
> Erm, of course. Sorry for that.
> Daniel
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 2/5] net: ethernet: cpsw: add optional third memory region for CONTROL module
Date: Fri, 23 Aug 2013 21:37:20 +0400 [thread overview]
Message-ID: <52179DD0.4010300@cogentembedded.com> (raw)
In-Reply-To: <52178BED.1070308@gmail.com>
On 08/23/2013 08:21 PM, Daniel Mack wrote:
>>> + priv->gmii_sel_reg = devm_ioremap_resource(&pdev->dev, res);
>>> + if (IS_ERR(priv->gmii_sel_reg)) {
>>> + dev_err(priv->dev, "unable to map control i/o region\n");
>> You didn't actually seem to heed my words about error message.
> Well yes I did, but only in the check for platform_get_resource(). As
> the comment says - we pass on if that memory region is not given, but if
> it is given, it also has to be valid.
Yes, but what I told you was devm_ioremap_resource() prints the error
messages itself, so that you don't have to. And you even consented with that. :-)
>> And don't you want to do:
>> res = PTR_ERR(priv->gmii_sel_reg);
Well, I've messed with the variable name: 'res' is struct resource *',
what I meant was *int* variable.
> Erm, of course. Sorry for that.
> Daniel
WBR, Sergei
next prev parent reply other threads:[~2013-08-23 17:37 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-23 14:16 [PATCH v4 0/5] cpsw: support for control module register Daniel Mack
2013-08-23 14:16 ` Daniel Mack
2013-08-23 14:16 ` [PATCH v4 1/5] net: ethernet: cpsw: switch to devres allocations Daniel Mack
2013-08-23 14:16 ` Daniel Mack
2013-08-23 18:10 ` Sergei Shtylyov
2013-08-23 18:10 ` Sergei Shtylyov
2013-08-23 18:34 ` Daniel Mack
2013-08-23 18:34 ` Daniel Mack
2013-08-23 14:16 ` [PATCH v4 2/5] net: ethernet: cpsw: add optional third memory region for CONTROL module Daniel Mack
2013-08-23 14:16 ` Daniel Mack
2013-08-23 14:59 ` Sergei Shtylyov
2013-08-23 14:59 ` Sergei Shtylyov
2013-08-23 16:21 ` Daniel Mack
2013-08-23 16:21 ` Daniel Mack
2013-08-23 17:37 ` Sergei Shtylyov [this message]
2013-08-23 17:37 ` Sergei Shtylyov
2013-08-23 14:16 ` [PATCH v4 3/5] net: ethernet: cpsw: introduce ti,am3352-cpsw compatible string Daniel Mack
2013-08-23 14:16 ` [PATCH v4 3/5] net: ethernet: cpsw: introduce ti, am3352-cpsw " Daniel Mack
2013-08-23 14:23 ` [PATCH v4 3/5] net: ethernet: cpsw: introduce ti,am3352-cpsw " Santosh Shilimkar
2013-08-23 14:23 ` Santosh Shilimkar
2013-08-23 14:23 ` Santosh Shilimkar
2013-08-23 15:22 ` Benoit Cousson
2013-08-23 15:22 ` Benoit Cousson
2013-08-23 15:54 ` Santosh Shilimkar
2013-08-23 15:54 ` Santosh Shilimkar
2013-08-23 15:54 ` Santosh Shilimkar
2013-08-23 16:30 ` Daniel Mack
2013-08-23 16:30 ` Daniel Mack
2013-08-23 16:56 ` Santosh Shilimkar
2013-08-23 16:56 ` Santosh Shilimkar
2013-08-23 17:09 ` Sekhar Nori
2013-08-23 17:09 ` Sekhar Nori
2013-08-23 17:09 ` Sekhar Nori
2013-08-23 17:17 ` Daniel Mack
2013-08-23 17:17 ` Daniel Mack
2013-08-23 17:19 ` Santosh Shilimkar
2013-08-23 17:19 ` Santosh Shilimkar
2013-08-23 17:24 ` Daniel Mack
2013-08-23 17:24 ` Daniel Mack
2013-08-23 17:28 ` Santosh Shilimkar
2013-08-23 17:28 ` Santosh Shilimkar
2013-08-23 17:28 ` Santosh Shilimkar
2013-08-23 17:39 ` Sekhar Nori
2013-08-23 17:39 ` Sekhar Nori
2013-08-23 17:39 ` Sekhar Nori
2013-08-23 18:10 ` Santosh Shilimkar
2013-08-23 18:10 ` Santosh Shilimkar
2013-08-23 18:29 ` Mugunthan V N
2013-08-23 18:29 ` Mugunthan V N
2013-08-23 19:54 ` Santosh Shilimkar
2013-08-23 19:54 ` Santosh Shilimkar
2013-08-23 19:54 ` Santosh Shilimkar
2013-08-26 5:59 ` Mugunthan V N
2013-08-26 5:59 ` Mugunthan V N
2013-08-26 6:45 ` Sekhar Nori
2013-08-26 6:45 ` Sekhar Nori
2013-08-26 6:45 ` Sekhar Nori
2013-08-23 17:23 ` Mugunthan V N
2013-08-23 17:23 ` Mugunthan V N
2013-08-23 17:23 ` Mugunthan V N
2013-08-26 5:22 ` Gupta, Pekon
2013-08-26 5:22 ` Gupta, Pekon
2013-08-23 16:31 ` Sekhar Nori
2013-08-23 16:31 ` Sekhar Nori
2013-08-23 16:31 ` Sekhar Nori
2013-08-23 16:45 ` Mugunthan V N
2013-08-23 16:45 ` Mugunthan V N
2013-08-23 16:45 ` Mugunthan V N
2013-08-23 17:05 ` Santosh Shilimkar
2013-08-23 17:05 ` Santosh Shilimkar
2013-08-23 17:05 ` Santosh Shilimkar
2013-08-23 14:16 ` [PATCH v4 4/5] net: ethernet: cpsw: add support for hardware interface mode config Daniel Mack
2013-08-23 14:16 ` Daniel Mack
2013-08-23 16:50 ` Mugunthan V N
2013-08-23 16:50 ` Mugunthan V N
2013-08-23 16:50 ` Mugunthan V N
2013-08-23 14:16 ` [PATCH v4 5/5] ARM: dts: am33xx: adopt to cpsw changes Daniel Mack
2013-08-23 14:16 ` Daniel Mack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52179DD0.4010300@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=bcousson@baylibre.com \
--cc=d-gerlach@ti.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=ujhelyi.m@gmail.com \
--cc=vaibhav.bedia@ti.com \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.