From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Chris Healy <cphealy@gmail.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
"David S. Miller" <davem@davemloft.net>,
buytenh@wantstofly.org
Subject: Re: [Bridge] [PATCH 1/1] bridge: fix message_age_timer calculation
Date: Wed, 11 Sep 2013 22:40:59 +0400 [thread overview]
Message-ID: <5230B93B.3040900@cogentembedded.com> (raw)
In-Reply-To: <1378745768-4495-1-git-send-email-cphealy@gmail.com>
Hello.
On 09/09/2013 08:56 PM, Chris Healy wrote:
> This changes the message_age_timer calculation to use the BPDU's max age as opposed to the local bridge's max age. This is in accordance with section 8.6.2.3.2 Step 2 of the 802.1D-1998 sprecification.
You should wrap your changelog lines at 80 chars at most, preferably less.
> With the current implementation, when running with very large bridge diameters, convergance will not always occur even if a root bridge is configured to have a longer max age.
> Tested successfully on bridge diameters of ~200.
> Signed-off-by: Chris Healy <cphealy@gmail.com>
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Chris Healy <cphealy@gmail.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
"David S. Miller" <davem@davemloft.net>,
buytenh@wantstofly.org
Subject: Re: [PATCH 1/1] bridge: fix message_age_timer calculation
Date: Wed, 11 Sep 2013 22:40:59 +0400 [thread overview]
Message-ID: <5230B93B.3040900@cogentembedded.com> (raw)
In-Reply-To: <1378745768-4495-1-git-send-email-cphealy@gmail.com>
Hello.
On 09/09/2013 08:56 PM, Chris Healy wrote:
> This changes the message_age_timer calculation to use the BPDU's max age as opposed to the local bridge's max age. This is in accordance with section 8.6.2.3.2 Step 2 of the 802.1D-1998 sprecification.
You should wrap your changelog lines at 80 chars at most, preferably less.
> With the current implementation, when running with very large bridge diameters, convergance will not always occur even if a root bridge is configured to have a longer max age.
> Tested successfully on bridge diameters of ~200.
> Signed-off-by: Chris Healy <cphealy@gmail.com>
WBR, Sergei
next prev parent reply other threads:[~2013-09-11 18:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-09 16:56 [Bridge] [PATCH 1/1] bridge: fix message_age_timer calculation Chris Healy
2013-09-09 16:56 ` Chris Healy
2013-09-10 18:41 ` [Bridge] " Stephen Hemminger
2013-09-10 18:41 ` Stephen Hemminger
2013-09-11 18:40 ` Sergei Shtylyov [this message]
2013-09-11 18:40 ` Sergei Shtylyov
2013-09-11 20:48 ` [Bridge] " David Miller
2013-09-11 20:48 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5230B93B.3040900@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=bridge@lists.linux-foundation.org \
--cc=buytenh@wantstofly.org \
--cc=cphealy@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.