* [Bridge] [PATCH 1/1] bridge: fix message_age_timer calculation
@ 2013-09-09 16:56 ` Chris Healy
0 siblings, 0 replies; 8+ messages in thread
From: Chris Healy @ 2013-09-09 16:56 UTC (permalink / raw)
To: Stephen Hemminger, David S. Miller; +Cc: netdev, bridge, buytenh
This changes the message_age_timer calculation to use the BPDU's max age as opposed to the local bridge's max age. This is in accordance with section 8.6.2.3.2 Step 2 of the 802.1D-1998 sprecification.
With the current implementation, when running with very large bridge diameters, convergance will not always occur even if a root bridge is configured to have a longer max age.
Tested successfully on bridge diameters of ~200.
Signed-off-by: Chris Healy <cphealy@gmail.com>
---
net/bridge/br_stp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/bridge/br_stp.c b/net/bridge/br_stp.c
index 1c0a50f..f1887ba 100644
--- a/net/bridge/br_stp.c
+++ b/net/bridge/br_stp.c
@@ -209,7 +209,7 @@ static void br_record_config_information(struct net_bridge_port *p,
p->designated_age = jiffies - bpdu->message_age;
mod_timer(&p->message_age_timer, jiffies
- + (p->br->max_age - bpdu->message_age));
+ + (bpdu->max_age - bpdu->message_age));
}
/* called under bridge lock */
--
1.8.1.2
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 1/1] bridge: fix message_age_timer calculation
@ 2013-09-09 16:56 ` Chris Healy
0 siblings, 0 replies; 8+ messages in thread
From: Chris Healy @ 2013-09-09 16:56 UTC (permalink / raw)
To: Stephen Hemminger, David S. Miller; +Cc: netdev, bridge, buytenh
This changes the message_age_timer calculation to use the BPDU's max age as opposed to the local bridge's max age. This is in accordance with section 8.6.2.3.2 Step 2 of the 802.1D-1998 sprecification.
With the current implementation, when running with very large bridge diameters, convergance will not always occur even if a root bridge is configured to have a longer max age.
Tested successfully on bridge diameters of ~200.
Signed-off-by: Chris Healy <cphealy@gmail.com>
---
net/bridge/br_stp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/bridge/br_stp.c b/net/bridge/br_stp.c
index 1c0a50f..f1887ba 100644
--- a/net/bridge/br_stp.c
+++ b/net/bridge/br_stp.c
@@ -209,7 +209,7 @@ static void br_record_config_information(struct net_bridge_port *p,
p->designated_age = jiffies - bpdu->message_age;
mod_timer(&p->message_age_timer, jiffies
- + (p->br->max_age - bpdu->message_age));
+ + (bpdu->max_age - bpdu->message_age));
}
/* called under bridge lock */
--
1.8.1.2
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [Bridge] [PATCH 1/1] bridge: fix message_age_timer calculation
2013-09-09 16:56 ` Chris Healy
@ 2013-09-10 18:41 ` Stephen Hemminger
-1 siblings, 0 replies; 8+ messages in thread
From: Stephen Hemminger @ 2013-09-10 18:41 UTC (permalink / raw)
To: Chris Healy; +Cc: netdev, bridge, David S. Miller, buytenh
On Mon, 9 Sep 2013 09:56:08 -0700
Chris Healy <cphealy@gmail.com> wrote:
> This changes the message_age_timer calculation to use the BPDU's max age as opposed to the local bridge's max age. This is in accordance with section 8.6.2.3.2 Step 2 of the 802.1D-1998 sprecification.
>
> With the current implementation, when running with very large bridge diameters, convergance will not always occur even if a root bridge is configured to have a longer max age.
>
> Tested successfully on bridge diameters of ~200.
>
> Signed-off-by: Chris Healy <cphealy@gmail.com>
> ---
> net/bridge/br_stp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/bridge/br_stp.c b/net/bridge/br_stp.c
> index 1c0a50f..f1887ba 100644
> --- a/net/bridge/br_stp.c
> +++ b/net/bridge/br_stp.c
> @@ -209,7 +209,7 @@ static void br_record_config_information(struct net_bridge_port *p,
> p->designated_age = jiffies - bpdu->message_age;
>
> mod_timer(&p->message_age_timer, jiffies
> - + (p->br->max_age - bpdu->message_age));
> + + (bpdu->max_age - bpdu->message_age));
> }
>
> /* called under bridge lock */
This makes sense.
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/1] bridge: fix message_age_timer calculation
@ 2013-09-10 18:41 ` Stephen Hemminger
0 siblings, 0 replies; 8+ messages in thread
From: Stephen Hemminger @ 2013-09-10 18:41 UTC (permalink / raw)
To: Chris Healy; +Cc: David S. Miller, bridge, netdev, buytenh
On Mon, 9 Sep 2013 09:56:08 -0700
Chris Healy <cphealy@gmail.com> wrote:
> This changes the message_age_timer calculation to use the BPDU's max age as opposed to the local bridge's max age. This is in accordance with section 8.6.2.3.2 Step 2 of the 802.1D-1998 sprecification.
>
> With the current implementation, when running with very large bridge diameters, convergance will not always occur even if a root bridge is configured to have a longer max age.
>
> Tested successfully on bridge diameters of ~200.
>
> Signed-off-by: Chris Healy <cphealy@gmail.com>
> ---
> net/bridge/br_stp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/bridge/br_stp.c b/net/bridge/br_stp.c
> index 1c0a50f..f1887ba 100644
> --- a/net/bridge/br_stp.c
> +++ b/net/bridge/br_stp.c
> @@ -209,7 +209,7 @@ static void br_record_config_information(struct net_bridge_port *p,
> p->designated_age = jiffies - bpdu->message_age;
>
> mod_timer(&p->message_age_timer, jiffies
> - + (p->br->max_age - bpdu->message_age));
> + + (bpdu->max_age - bpdu->message_age));
> }
>
> /* called under bridge lock */
This makes sense.
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Bridge] [PATCH 1/1] bridge: fix message_age_timer calculation
2013-09-09 16:56 ` Chris Healy
@ 2013-09-11 18:40 ` Sergei Shtylyov
-1 siblings, 0 replies; 8+ messages in thread
From: Sergei Shtylyov @ 2013-09-11 18:40 UTC (permalink / raw)
To: Chris Healy; +Cc: Stephen Hemminger, netdev, bridge, David S. Miller, buytenh
Hello.
On 09/09/2013 08:56 PM, Chris Healy wrote:
> This changes the message_age_timer calculation to use the BPDU's max age as opposed to the local bridge's max age. This is in accordance with section 8.6.2.3.2 Step 2 of the 802.1D-1998 sprecification.
You should wrap your changelog lines at 80 chars at most, preferably less.
> With the current implementation, when running with very large bridge diameters, convergance will not always occur even if a root bridge is configured to have a longer max age.
> Tested successfully on bridge diameters of ~200.
> Signed-off-by: Chris Healy <cphealy@gmail.com>
WBR, Sergei
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 1/1] bridge: fix message_age_timer calculation
@ 2013-09-11 18:40 ` Sergei Shtylyov
0 siblings, 0 replies; 8+ messages in thread
From: Sergei Shtylyov @ 2013-09-11 18:40 UTC (permalink / raw)
To: Chris Healy; +Cc: Stephen Hemminger, netdev, bridge, David S. Miller, buytenh
Hello.
On 09/09/2013 08:56 PM, Chris Healy wrote:
> This changes the message_age_timer calculation to use the BPDU's max age as opposed to the local bridge's max age. This is in accordance with section 8.6.2.3.2 Step 2 of the 802.1D-1998 sprecification.
You should wrap your changelog lines at 80 chars at most, preferably less.
> With the current implementation, when running with very large bridge diameters, convergance will not always occur even if a root bridge is configured to have a longer max age.
> Tested successfully on bridge diameters of ~200.
> Signed-off-by: Chris Healy <cphealy@gmail.com>
WBR, Sergei
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [Bridge] [PATCH 1/1] bridge: fix message_age_timer calculation
2013-09-11 18:40 ` Sergei Shtylyov
@ 2013-09-11 20:48 ` David Miller
-1 siblings, 0 replies; 8+ messages in thread
From: David Miller @ 2013-09-11 20:48 UTC (permalink / raw)
To: sergei.shtylyov; +Cc: stephen, netdev, bridge, buytenh
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Date: Wed, 11 Sep 2013 22:40:59 +0400
> Hello.
>
> On 09/09/2013 08:56 PM, Chris Healy wrote:
>
>> This changes the message_age_timer calculation to use the BPDU's max
>> age as opposed to the local bridge's max age. This is in accordance
>> with section 8.6.2.3.2 Step 2 of the 802.1D-1998 sprecification.
>
> You should wrap your changelog lines at 80 chars at most, preferably
> less.
Yes, please fix this and resubmit.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/1] bridge: fix message_age_timer calculation
@ 2013-09-11 20:48 ` David Miller
0 siblings, 0 replies; 8+ messages in thread
From: David Miller @ 2013-09-11 20:48 UTC (permalink / raw)
To: sergei.shtylyov; +Cc: stephen, netdev, bridge, buytenh
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Date: Wed, 11 Sep 2013 22:40:59 +0400
> Hello.
>
> On 09/09/2013 08:56 PM, Chris Healy wrote:
>
>> This changes the message_age_timer calculation to use the BPDU's max
>> age as opposed to the local bridge's max age. This is in accordance
>> with section 8.6.2.3.2 Step 2 of the 802.1D-1998 sprecification.
>
> You should wrap your changelog lines at 80 chars at most, preferably
> less.
Yes, please fix this and resubmit.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2013-09-11 20:48 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-09 16:56 [Bridge] [PATCH 1/1] bridge: fix message_age_timer calculation Chris Healy
2013-09-09 16:56 ` Chris Healy
2013-09-10 18:41 ` [Bridge] " Stephen Hemminger
2013-09-10 18:41 ` Stephen Hemminger
2013-09-11 18:40 ` [Bridge] " Sergei Shtylyov
2013-09-11 18:40 ` Sergei Shtylyov
2013-09-11 20:48 ` [Bridge] " David Miller
2013-09-11 20:48 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.