All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
Cc: frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	Tomasz Figa <tomasz.figa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Benjamin Herrenschmidt
	<benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>,
	"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Linux Kernel list
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Marek Szyprowski
	<m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
	Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
	Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
	Grant Likely
	<grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>,
	Jon Loeliger <jdl-CYoMK+44s/E@public.gmane.org>,
	David Gibson
	<david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
Subject: Re: "memory" binding issues
Date: Wed, 18 Sep 2013 10:28:44 -0600	[thread overview]
Message-ID: <5239D4BC.3030600@wwwdotorg.org> (raw)
In-Reply-To: <CAOesGMh0F09OAR4bepGSCE5Z5OZ56fBmDPBSfwZ+NB9RgcE0Vw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

On 09/17/2013 03:15 PM, Olof Johansson wrote:
> On Tue, Sep 17, 2013 at 2:08 PM, Frank Rowand <frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>> On 9/17/2013 9:43 AM, Olof Johansson wrote:
>>> On Tue, Sep 17, 2013 at 09:56:39AM +0200, Tomasz Figa wrote:
>>>> I'm afraid that I must disagree. For consistency I'd rather go with what
>>>> Ben said. Please see ePAPR chapter 2.2.1.1, which clearly defines how
>>>> nodes should be named.
>>>
>>> 2.2.1.1 is there to point out that unit address _has_ to reflect reg.
>>>
>>> 2.2.3 says that unit addresses can be omitted.
>>
>> 2.2.3 is talking about path names.
>>
>> 2.2.1.1 is talking about node names.
>>
>> 2.2.1.1 _does_ require the unit address in the node name, 2.2.3 does not
>> remove that requirement.
> 
> Sigh, that's horrible. OF clearly doesn't require it.
> 
> I guess people prefer to follow ePAPR even though it's broken? That
> means someone needs to cleanup the current dts files. Any takers?

FWIW, I investigated enhancing dtc to enforce this rule. Here are the
results:

********** TEST SUMMARY
*     Total testcases:	1446
*                PASS:	1252
*                FAIL:	58
*   Bad configuration:	136
* Strange test result:	0
**********

That's just in dtc itself, and not any of the *.dts in the kernel or
U-Boot source trees...

I'll see how much of patch it takes to fix up all the test-cases in dtc.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: Olof Johansson <olof@lixom.net>
Cc: frowand.list@gmail.com, Tomasz Figa <tomasz.figa@gmail.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Linux Kernel list <linux-kernel@vger.kernel.org>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Stephen Warren <swarren@nvidia.com>,
	Rob Herring <rob.herring@calxeda.com>,
	Grant Likely <grant.likely@secretlab.ca>,
	Jon Loeliger <jdl@jdl.com>,
	David Gibson <david@gibson.dropbear.id.au>
Subject: Re: "memory" binding issues
Date: Wed, 18 Sep 2013 10:28:44 -0600	[thread overview]
Message-ID: <5239D4BC.3030600@wwwdotorg.org> (raw)
In-Reply-To: <CAOesGMh0F09OAR4bepGSCE5Z5OZ56fBmDPBSfwZ+NB9RgcE0Vw@mail.gmail.com>

On 09/17/2013 03:15 PM, Olof Johansson wrote:
> On Tue, Sep 17, 2013 at 2:08 PM, Frank Rowand <frowand.list@gmail.com> wrote:
>> On 9/17/2013 9:43 AM, Olof Johansson wrote:
>>> On Tue, Sep 17, 2013 at 09:56:39AM +0200, Tomasz Figa wrote:
>>>> I'm afraid that I must disagree. For consistency I'd rather go with what
>>>> Ben said. Please see ePAPR chapter 2.2.1.1, which clearly defines how
>>>> nodes should be named.
>>>
>>> 2.2.1.1 is there to point out that unit address _has_ to reflect reg.
>>>
>>> 2.2.3 says that unit addresses can be omitted.
>>
>> 2.2.3 is talking about path names.
>>
>> 2.2.1.1 is talking about node names.
>>
>> 2.2.1.1 _does_ require the unit address in the node name, 2.2.3 does not
>> remove that requirement.
> 
> Sigh, that's horrible. OF clearly doesn't require it.
> 
> I guess people prefer to follow ePAPR even though it's broken? That
> means someone needs to cleanup the current dts files. Any takers?

FWIW, I investigated enhancing dtc to enforce this rule. Here are the
results:

********** TEST SUMMARY
*     Total testcases:	1446
*                PASS:	1252
*                FAIL:	58
*   Bad configuration:	136
* Strange test result:	0
**********

That's just in dtc itself, and not any of the *.dts in the kernel or
U-Boot source trees...

I'll see how much of patch it takes to fix up all the test-cases in dtc.

  parent reply	other threads:[~2013-09-18 16:28 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-16  2:57 "memory" binding issues Benjamin Herrenschmidt
2013-09-16  2:57 ` Benjamin Herrenschmidt
2013-09-16 15:22 ` Kumar Gala
2013-09-16 15:22   ` Kumar Gala
2013-09-16 22:42   ` Benjamin Herrenschmidt
2013-09-17 15:53     ` Kumar Gala
2013-09-17 15:53       ` Kumar Gala
2013-09-16 16:17 ` Stephen Warren
2013-09-16 16:17   ` Stephen Warren
     [not found]   ` <52372F2A.2050003-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-09-16 22:46     ` Benjamin Herrenschmidt
2013-09-16 22:46       ` Benjamin Herrenschmidt
2013-09-16 22:48       ` Olof Johansson
2013-09-16 22:48         ` Olof Johansson
     [not found]         ` <CAOesGMgE1jiF5OHsmPQz2z66Bcqu0HeAj=taE1vmFK-0-0s2TQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-09-16 23:47           ` Benjamin Herrenschmidt
2013-09-16 23:47             ` Benjamin Herrenschmidt
2013-09-16 23:48             ` Olof Johansson
     [not found]               ` <CAOesGMjDFOThCYPgPq5mS8-Uk5Ye=omye329EKRsb-q_akTP4Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-09-17  1:37                 ` Benjamin Herrenschmidt
2013-09-17  1:37                   ` Benjamin Herrenschmidt
2013-09-17  7:56           ` Tomasz Figa
2013-09-17  7:56             ` Tomasz Figa
2013-09-17 16:43             ` Olof Johansson
2013-09-17 16:43               ` Olof Johansson
     [not found]               ` <20130917164307.GA31327-O5ziIzlqnXUVNXGz7ipsyg@public.gmane.org>
2013-09-17 21:08                 ` Frank Rowand
2013-09-17 21:08                   ` Frank Rowand
     [not found]                   ` <5238C4D1.6060500-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-09-17 21:15                     ` Olof Johansson
2013-09-17 21:15                       ` Olof Johansson
     [not found]                       ` <CAOesGMh0F09OAR4bepGSCE5Z5OZ56fBmDPBSfwZ+NB9RgcE0Vw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-09-17 21:19                         ` Tomasz Figa
2013-09-17 21:19                           ` Tomasz Figa
2013-09-17 21:33                           ` Olof Johansson
     [not found]                             ` <CAOesGMjt6RsvYRjXxpB=v-Ro6iyUN=YzkDd1mfHqCDJJDRJvLg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-09-17 23:04                               ` Benjamin Herrenschmidt
2013-09-17 23:04                                 ` Benjamin Herrenschmidt
2013-09-17 23:25                                 ` Olof Johansson
2013-09-17 23:25                                   ` Olof Johansson
2013-09-17 21:56                         ` Benjamin Herrenschmidt
2013-09-17 21:56                           ` Benjamin Herrenschmidt
2013-09-18 16:28                         ` Stephen Warren [this message]
2013-09-18 16:28                           ` Stephen Warren
     [not found]                           ` <5239D4BC.3030600-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-09-19  0:29                             ` David Gibson
2013-09-19  0:29                               ` David Gibson
2013-09-18  1:25                     ` David Gibson
2013-09-18  1:25                       ` David Gibson
2013-09-18  1:31             ` Grant Likely
2013-09-18  1:31               ` Grant Likely
2013-09-18  1:38       ` Grant Likely
     [not found]         ` <20130918013823.D617CC42C81-WNowdnHR2B42iJbIjFUEsiwD8/FfD2ys@public.gmane.org>
2013-09-18  8:08           ` Benjamin Herrenschmidt
2013-09-18  8:08             ` Benjamin Herrenschmidt
2013-09-18  2:57 ` Grant Likely
2013-09-18  2:57   ` Grant Likely
     [not found]   ` <20130918025714.A69D8C42C8F-WNowdnHR2B42iJbIjFUEsiwD8/FfD2ys@public.gmane.org>
2013-09-18  8:21     ` Benjamin Herrenschmidt
2013-09-18  8:21       ` Benjamin Herrenschmidt
2013-09-27 15:42       ` Kumar Gala
2013-09-27 15:42         ` Kumar Gala
2013-10-03 15:04         ` Kumar Gala
  -- strict thread matches above, loose matches on Subject: below --
2013-09-16  2:41 Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5239D4BC.3030600@wwwdotorg.org \
    --to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
    --cc=benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org \
    --cc=david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org \
    --cc=jdl-CYoMK+44s/E@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    --cc=olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org \
    --cc=rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org \
    --cc=swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=tomasz.figa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.