All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andreas Tobler <andreast@FreeBSD.org>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Anthony Liguori <aliguori@amazon.com>,
	kvm@vger.kernel.org, Gleb Natapov <gleb@redhat.com>,
	patches@linaro.org
Subject: Re: [PATCH for-1.7] target-i386: Fix build by providing stub kvm_arch_get_supported_cpuid()
Date: Mon, 11 Nov 2013 22:28:18 +0100	[thread overview]
Message-ID: <52814BF2.3010101@FreeBSD.org> (raw)
In-Reply-To: <1384204922-8250-1-git-send-email-peter.maydell@linaro.org>

On 11.11.13 22:22, Peter Maydell wrote:
> Fix build failures with clang when KVM is not enabled by
> providing a stub version of kvm_arch_get_supported_cpuid().
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> I wouldn't be surprised if this also affected debug gcc
> builds with KVM disabled, but I haven't checked.

I can confirm the patch below fixes the clang link issue here. Also, the
gcc debug build does work.

Thanks a lot!

Andreas
> 
> Incidentally, since this is an x86 specific function its
> prototype should be moved into target-i386/kvm_i386.h, but
> that's a separate patch.
> 
>  target-i386/kvm-stub.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/target-i386/kvm-stub.c b/target-i386/kvm-stub.c
> index 11429c4..18fe938 100644
> --- a/target-i386/kvm-stub.c
> +++ b/target-i386/kvm-stub.c
> @@ -16,3 +16,9 @@ bool kvm_allows_irq0_override(void)
>  {
>      return 1;
>  }
> +
> +uint32_t kvm_arch_get_supported_cpuid(KVMState *env, uint32_t function,
> +                                      uint32_t index, int reg)
> +{
> +    return 0;
> +}
> 

WARNING: multiple messages have this Message-ID (diff)
From: Andreas Tobler <andreast@FreeBSD.org>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Anthony Liguori <aliguori@amazon.com>,
	kvm@vger.kernel.org, Gleb Natapov <gleb@redhat.com>,
	patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH for-1.7] target-i386: Fix build by providing stub kvm_arch_get_supported_cpuid()
Date: Mon, 11 Nov 2013 22:28:18 +0100	[thread overview]
Message-ID: <52814BF2.3010101@FreeBSD.org> (raw)
In-Reply-To: <1384204922-8250-1-git-send-email-peter.maydell@linaro.org>

On 11.11.13 22:22, Peter Maydell wrote:
> Fix build failures with clang when KVM is not enabled by
> providing a stub version of kvm_arch_get_supported_cpuid().
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> I wouldn't be surprised if this also affected debug gcc
> builds with KVM disabled, but I haven't checked.

I can confirm the patch below fixes the clang link issue here. Also, the
gcc debug build does work.

Thanks a lot!

Andreas
> 
> Incidentally, since this is an x86 specific function its
> prototype should be moved into target-i386/kvm_i386.h, but
> that's a separate patch.
> 
>  target-i386/kvm-stub.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/target-i386/kvm-stub.c b/target-i386/kvm-stub.c
> index 11429c4..18fe938 100644
> --- a/target-i386/kvm-stub.c
> +++ b/target-i386/kvm-stub.c
> @@ -16,3 +16,9 @@ bool kvm_allows_irq0_override(void)
>  {
>      return 1;
>  }
> +
> +uint32_t kvm_arch_get_supported_cpuid(KVMState *env, uint32_t function,
> +                                      uint32_t index, int reg)
> +{
> +    return 0;
> +}
> 

  reply	other threads:[~2013-11-11 21:28 UTC|newest]

Thread overview: 70+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-11 21:22 [PATCH for-1.7] target-i386: Fix build by providing stub kvm_arch_get_supported_cpuid() Peter Maydell
2013-11-11 21:22 ` [Qemu-devel] " Peter Maydell
2013-11-11 21:28 ` Andreas Tobler [this message]
2013-11-11 21:28   ` Andreas Tobler
2013-11-11 22:19 ` Paolo Bonzini
2013-11-11 22:19   ` [Qemu-devel] " Paolo Bonzini
2013-11-11 22:38   ` Peter Maydell
2013-11-11 22:38     ` [Qemu-devel] " Peter Maydell
2013-11-11 23:11     ` Paolo Bonzini
2013-11-11 23:11       ` [Qemu-devel] " Paolo Bonzini
2013-11-11 23:21       ` Anthony Liguori
2013-11-11 23:21         ` [Qemu-devel] " Anthony Liguori
2013-11-12  7:09         ` Paolo Bonzini
2013-11-12  7:09           ` [Qemu-devel] " Paolo Bonzini
2013-11-12 11:07         ` Peter Maydell
2013-11-12 11:07           ` [Qemu-devel] " Peter Maydell
2013-11-12 12:09           ` Paolo Bonzini
2013-11-12 12:09             ` [Qemu-devel] " Paolo Bonzini
2013-11-12 12:16             ` Peter Maydell
2013-11-12 12:16               ` [Qemu-devel] " Peter Maydell
2013-11-12 13:12               ` Paolo Bonzini
2013-11-12 13:12                 ` [Qemu-devel] " Paolo Bonzini
2013-11-12 13:21                 ` Peter Maydell
2013-11-12 13:21                   ` [Qemu-devel] " Peter Maydell
2013-11-12 13:26                   ` Gleb Natapov
2013-11-12 13:26                     ` [Qemu-devel] " Gleb Natapov
2013-11-12 13:23                 ` Gleb Natapov
2013-11-12 13:23                   ` [Qemu-devel] " Gleb Natapov
2013-11-12 13:57                   ` Paolo Bonzini
2013-11-12 13:57                     ` [Qemu-devel] " Paolo Bonzini
2013-11-12 14:09                     ` Gleb Natapov
2013-11-12 14:09                       ` [Qemu-devel] " Gleb Natapov
2013-11-12 14:14                       ` Peter Maydell
2013-11-12 14:14                         ` [Qemu-devel] " Peter Maydell
2013-11-12 14:57                       ` Paolo Bonzini
2013-11-12 14:57                         ` [Qemu-devel] " Paolo Bonzini
2013-11-12 15:13                         ` Peter Maydell
2013-11-12 15:13                           ` [Qemu-devel] " Peter Maydell
2013-11-12 15:21                           ` Paolo Bonzini
2013-11-12 15:21                             ` [Qemu-devel] " Paolo Bonzini
2013-11-12 15:32                             ` Peter Maydell
2013-11-12 15:32                               ` [Qemu-devel] " Peter Maydell
2013-11-12 15:58                               ` Paolo Bonzini
2013-11-12 15:58                                 ` [Qemu-devel] " Paolo Bonzini
2013-11-12 16:08                                 ` Peter Maydell
2013-11-12 16:08                                   ` [Qemu-devel] " Peter Maydell
2013-11-12 17:04                                   ` Anthony Liguori
2013-11-12 17:04                                     ` [Qemu-devel] " Anthony Liguori
2013-11-12 17:20                                     ` Peter Maydell
2013-11-12 17:20                                       ` [Qemu-devel] " Peter Maydell
2013-11-12 18:54                                     ` Richard Henderson
2013-11-12 18:54                                       ` Richard Henderson
2013-11-12 18:57                                       ` Peter Maydell
2013-11-12 18:57                                         ` Peter Maydell
2013-11-12 19:15                                         ` Stefan Weil
2013-11-12 19:15                                           ` [Qemu-devel] " Stefan Weil
2013-11-12 22:53                                       ` Paolo Bonzini
2013-11-12 22:53                                         ` Paolo Bonzini
2013-11-13  2:27                                         ` Richard Henderson
2013-11-13  2:27                                           ` Richard Henderson
2013-11-13  7:25                                           ` Paolo Bonzini
2013-11-13  7:25                                             ` Paolo Bonzini
2013-11-13 22:23                                             ` Peter Maydell
2013-11-13 22:23                                               ` Peter Maydell
2013-11-13  7:26                                           ` Gleb Natapov
2013-11-13  7:26                                             ` Gleb Natapov
2013-11-12 14:01                 ` Peter Maydell
2013-11-12 14:01                   ` [Qemu-devel] " Peter Maydell
2013-11-11 23:23       ` Peter Maydell
2013-11-11 23:23         ` [Qemu-devel] " Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52814BF2.3010101@FreeBSD.org \
    --to=andreast@freebsd.org \
    --cc=aliguori@amazon.com \
    --cc=gleb@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=patches@linaro.org \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.