From: Stefan Weil <sw@weilnetz.de>
To: Peter Maydell <peter.maydell@linaro.org>,
Richard Henderson <rth@twiddle.net>
Cc: kvm-devel <kvm@vger.kernel.org>, Gleb Natapov <gleb@redhat.com>,
Patch Tracking <patches@linaro.org>,
QEMU Developers <qemu-devel@nongnu.org>,
Andreas Tobler <andreast@freebsd.org>,
Anthony Liguori <anthony@codemonkey.ws>,
Paolo Bonzini <pbonzini@redhat.com>,
Anthony Liguori <aliguori@amazon.com>
Subject: Re: [PATCH for-1.7] target-i386: Fix build by providing stub kvm_arch_get_supported_cpuid()
Date: Tue, 12 Nov 2013 20:15:54 +0100 [thread overview]
Message-ID: <52827E6A.7050603@weilnetz.de> (raw)
In-Reply-To: <CAFEAcA_eikGjppSv_UBF+BKHMq4JbA-T_hYgm=v_sKpRuR2AjA@mail.gmail.com>
Am 12.11.2013 19:57, schrieb Peter Maydell:
> On 12 November 2013 18:54, Richard Henderson <rth@twiddle.net> wrote:
>> For what it's worth, I think BOTH of the patches that have been posted
>> should be applied. That is, the patch that does (X || 1) -> (1 || X),
>> and the patch that adds the stub.
> I think that makes sense and would be happy with that as a resolution.
>
> thanks
> -- PMM
>
+1.
By the way: I added a stub for kvm_arch_get_supported_cpuid() in my kvm
patch, too
(see http://patchwork.ozlabs.org/patch/260512/). It called
g_assert_not_reached()instead
of returning 0.Maybe this can be added in a later patch.
Regards,
Stefan
WARNING: multiple messages have this Message-ID (diff)
From: Stefan Weil <sw@weilnetz.de>
To: Peter Maydell <peter.maydell@linaro.org>,
Richard Henderson <rth@twiddle.net>
Cc: kvm-devel <kvm@vger.kernel.org>, Gleb Natapov <gleb@redhat.com>,
Patch Tracking <patches@linaro.org>,
QEMU Developers <qemu-devel@nongnu.org>,
Andreas Tobler <andreast@freebsd.org>,
Anthony Liguori <anthony@codemonkey.ws>,
Paolo Bonzini <pbonzini@redhat.com>,
Anthony Liguori <aliguori@amazon.com>
Subject: Re: [Qemu-devel] [PATCH for-1.7] target-i386: Fix build by providing stub kvm_arch_get_supported_cpuid()
Date: Tue, 12 Nov 2013 20:15:54 +0100 [thread overview]
Message-ID: <52827E6A.7050603@weilnetz.de> (raw)
In-Reply-To: <CAFEAcA_eikGjppSv_UBF+BKHMq4JbA-T_hYgm=v_sKpRuR2AjA@mail.gmail.com>
Am 12.11.2013 19:57, schrieb Peter Maydell:
> On 12 November 2013 18:54, Richard Henderson <rth@twiddle.net> wrote:
>> For what it's worth, I think BOTH of the patches that have been posted
>> should be applied. That is, the patch that does (X || 1) -> (1 || X),
>> and the patch that adds the stub.
> I think that makes sense and would be happy with that as a resolution.
>
> thanks
> -- PMM
>
+1.
By the way: I added a stub for kvm_arch_get_supported_cpuid() in my kvm
patch, too
(see http://patchwork.ozlabs.org/patch/260512/). It called
g_assert_not_reached()instead
of returning 0.Maybe this can be added in a later patch.
Regards,
Stefan
next prev parent reply other threads:[~2013-11-12 19:15 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-11 21:22 [PATCH for-1.7] target-i386: Fix build by providing stub kvm_arch_get_supported_cpuid() Peter Maydell
2013-11-11 21:22 ` [Qemu-devel] " Peter Maydell
2013-11-11 21:28 ` Andreas Tobler
2013-11-11 21:28 ` [Qemu-devel] " Andreas Tobler
2013-11-11 22:19 ` Paolo Bonzini
2013-11-11 22:19 ` [Qemu-devel] " Paolo Bonzini
2013-11-11 22:38 ` Peter Maydell
2013-11-11 22:38 ` [Qemu-devel] " Peter Maydell
2013-11-11 23:11 ` Paolo Bonzini
2013-11-11 23:11 ` [Qemu-devel] " Paolo Bonzini
2013-11-11 23:21 ` Anthony Liguori
2013-11-11 23:21 ` [Qemu-devel] " Anthony Liguori
2013-11-12 7:09 ` Paolo Bonzini
2013-11-12 7:09 ` [Qemu-devel] " Paolo Bonzini
2013-11-12 11:07 ` Peter Maydell
2013-11-12 11:07 ` [Qemu-devel] " Peter Maydell
2013-11-12 12:09 ` Paolo Bonzini
2013-11-12 12:09 ` [Qemu-devel] " Paolo Bonzini
2013-11-12 12:16 ` Peter Maydell
2013-11-12 12:16 ` [Qemu-devel] " Peter Maydell
2013-11-12 13:12 ` Paolo Bonzini
2013-11-12 13:12 ` [Qemu-devel] " Paolo Bonzini
2013-11-12 13:21 ` Peter Maydell
2013-11-12 13:21 ` [Qemu-devel] " Peter Maydell
2013-11-12 13:26 ` Gleb Natapov
2013-11-12 13:26 ` [Qemu-devel] " Gleb Natapov
2013-11-12 13:23 ` Gleb Natapov
2013-11-12 13:23 ` [Qemu-devel] " Gleb Natapov
2013-11-12 13:57 ` Paolo Bonzini
2013-11-12 13:57 ` [Qemu-devel] " Paolo Bonzini
2013-11-12 14:09 ` Gleb Natapov
2013-11-12 14:09 ` [Qemu-devel] " Gleb Natapov
2013-11-12 14:14 ` Peter Maydell
2013-11-12 14:14 ` [Qemu-devel] " Peter Maydell
2013-11-12 14:57 ` Paolo Bonzini
2013-11-12 14:57 ` [Qemu-devel] " Paolo Bonzini
2013-11-12 15:13 ` Peter Maydell
2013-11-12 15:13 ` [Qemu-devel] " Peter Maydell
2013-11-12 15:21 ` Paolo Bonzini
2013-11-12 15:21 ` [Qemu-devel] " Paolo Bonzini
2013-11-12 15:32 ` Peter Maydell
2013-11-12 15:32 ` [Qemu-devel] " Peter Maydell
2013-11-12 15:58 ` Paolo Bonzini
2013-11-12 15:58 ` [Qemu-devel] " Paolo Bonzini
2013-11-12 16:08 ` Peter Maydell
2013-11-12 16:08 ` [Qemu-devel] " Peter Maydell
2013-11-12 17:04 ` Anthony Liguori
2013-11-12 17:04 ` [Qemu-devel] " Anthony Liguori
2013-11-12 17:20 ` Peter Maydell
2013-11-12 17:20 ` [Qemu-devel] " Peter Maydell
2013-11-12 18:54 ` Richard Henderson
2013-11-12 18:54 ` Richard Henderson
2013-11-12 18:57 ` Peter Maydell
2013-11-12 18:57 ` Peter Maydell
2013-11-12 19:15 ` Stefan Weil [this message]
2013-11-12 19:15 ` Stefan Weil
2013-11-12 22:53 ` Paolo Bonzini
2013-11-12 22:53 ` Paolo Bonzini
2013-11-13 2:27 ` Richard Henderson
2013-11-13 2:27 ` Richard Henderson
2013-11-13 7:25 ` Paolo Bonzini
2013-11-13 7:25 ` Paolo Bonzini
2013-11-13 22:23 ` Peter Maydell
2013-11-13 22:23 ` Peter Maydell
2013-11-13 7:26 ` Gleb Natapov
2013-11-13 7:26 ` Gleb Natapov
2013-11-12 14:01 ` Peter Maydell
2013-11-12 14:01 ` [Qemu-devel] " Peter Maydell
2013-11-11 23:23 ` Peter Maydell
2013-11-11 23:23 ` [Qemu-devel] " Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52827E6A.7050603@weilnetz.de \
--to=sw@weilnetz.de \
--cc=aliguori@amazon.com \
--cc=andreast@freebsd.org \
--cc=anthony@codemonkey.ws \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=patches@linaro.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.