All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Liu <jeff.liu@oracle.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 0/6] list: introduce list_last_entry_or_null()
Date: Fri, 15 Nov 2013 12:29:48 +0800	[thread overview]
Message-ID: <5285A33C.4040808@oracle.com> (raw)

Hi Folks,

This patch is trying to introduce a new list helper to retrieve the
last entry or return NULL if the list is empty corresponding to it,
which is inspired by Jiri Pirko's list_first_entry_or_null().

With this trivial helper, we could get a little benefit to simplify
the code logic of xfs_ail_max() and make the code looks a bit more
consistent with xfs_ail_min() which has already been simplified
via list_first_entry_or_null().

Moreover, as a per simple grep against fs as well as driver's tree,
I think there are some other places could make use of it for similar
purpose, here I spread this helper over some file systems as well.

Any comments are welcome!

Thanks,
-Jeff



WARNING: multiple messages have this Message-ID (diff)
From: Jeff Liu <jeff.liu@oracle.com>
To: linux-kernel@vger.kernel.org
Cc: jfs-discussion@lists.sourceforge.net, jiri@resnulli.us,
	gregkh@linuxfoundation.org, oleg@redhat.com,
	"xfs@oss.sgi.com" <xfs@oss.sgi.com>,
	cluster-devel@redhat.com, linux-mtd@lists.infradead.org,
	akpm@linux-foundation.org
Subject: [PATCH 0/6] list: introduce list_last_entry_or_null()
Date: Fri, 15 Nov 2013 12:29:48 +0800	[thread overview]
Message-ID: <5285A33C.4040808@oracle.com> (raw)

Hi Folks,

This patch is trying to introduce a new list helper to retrieve the
last entry or return NULL if the list is empty corresponding to it,
which is inspired by Jiri Pirko's list_first_entry_or_null().

With this trivial helper, we could get a little benefit to simplify
the code logic of xfs_ail_max() and make the code looks a bit more
consistent with xfs_ail_min() which has already been simplified
via list_first_entry_or_null().

Moreover, as a per simple grep against fs as well as driver's tree,
I think there are some other places could make use of it for similar
purpose, here I spread this helper over some file systems as well.

Any comments are welcome!

Thanks,
-Jeff

WARNING: multiple messages have this Message-ID (diff)
From: Jeff Liu <jeff.liu@oracle.com>
To: linux-kernel@vger.kernel.org
Cc: jfs-discussion@lists.sourceforge.net, jiri@resnulli.us,
	gregkh@linuxfoundation.org, oleg@redhat.com,
	"xfs@oss.sgi.com" <xfs@oss.sgi.com>,
	cluster-devel@redhat.com, linux-mtd@lists.infradead.org,
	akpm@linux-foundation.org
Subject: [PATCH 0/6] list: introduce list_last_entry_or_null()
Date: Fri, 15 Nov 2013 12:29:48 +0800	[thread overview]
Message-ID: <5285A33C.4040808@oracle.com> (raw)

Hi Folks,

This patch is trying to introduce a new list helper to retrieve the
last entry or return NULL if the list is empty corresponding to it,
which is inspired by Jiri Pirko's list_first_entry_or_null().

With this trivial helper, we could get a little benefit to simplify
the code logic of xfs_ail_max() and make the code looks a bit more
consistent with xfs_ail_min() which has already been simplified
via list_first_entry_or_null().

Moreover, as a per simple grep against fs as well as driver's tree,
I think there are some other places could make use of it for similar
purpose, here I spread this helper over some file systems as well.

Any comments are welcome!

Thanks,
-Jeff

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

WARNING: multiple messages have this Message-ID (diff)
From: Jeff Liu <jeff.liu@oracle.com>
To: linux-kernel@vger.kernel.org
Cc: akpm@linux-foundation.org, "xfs@oss.sgi.com" <xfs@oss.sgi.com>,
	cluster-devel@redhat.com, linux-mtd@lists.infradead.org,
	jfs-discussion@lists.sourceforge.net, oleg@redhat.com,
	jiri@resnulli.us, gregkh@linuxfoundation.org
Subject: [PATCH 0/6] list: introduce list_last_entry_or_null()
Date: Fri, 15 Nov 2013 12:29:48 +0800	[thread overview]
Message-ID: <5285A33C.4040808@oracle.com> (raw)

Hi Folks,

This patch is trying to introduce a new list helper to retrieve the
last entry or return NULL if the list is empty corresponding to it,
which is inspired by Jiri Pirko's list_first_entry_or_null().

With this trivial helper, we could get a little benefit to simplify
the code logic of xfs_ail_max() and make the code looks a bit more
consistent with xfs_ail_min() which has already been simplified
via list_first_entry_or_null().

Moreover, as a per simple grep against fs as well as driver's tree,
I think there are some other places could make use of it for similar
purpose, here I spread this helper over some file systems as well.

Any comments are welcome!

Thanks,
-Jeff

             reply	other threads:[~2013-11-15  4:29 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-15  4:29 Jeff Liu [this message]
2013-11-15  4:29 ` [PATCH 0/6] list: introduce list_last_entry_or_null() Jeff Liu
2013-11-15  4:29 ` Jeff Liu
2013-11-15  4:29 ` Jeff Liu
2013-11-15 14:11 ` [Cluster-devel] " Christoph Hellwig
2013-11-15 14:11   ` Christoph Hellwig
2013-11-15 14:11   ` Christoph Hellwig
2013-11-15 14:11   ` Christoph Hellwig
2013-11-15 14:26   ` [Cluster-devel] " Steven Whitehouse
2013-11-15 14:26     ` Steven Whitehouse
2013-11-15 14:26     ` Steven Whitehouse
2013-11-15 14:26     ` Steven Whitehouse
2013-11-15 16:00   ` Jeff Liu
2013-11-15 16:00     ` Jeff Liu
2013-11-15 16:00     ` Jeff Liu
2013-11-15 16:00     ` Jeff Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5285A33C.4040808@oracle.com \
    --to=jeff.liu@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.