* [PATCH] gpio: drop users of irq_set_chip_and_handler_name()
@ 2013-11-26 13:32 Linus Walleij
2013-11-29 10:20 ` Mika Westerberg
2013-12-02 18:27 ` David Cohen
0 siblings, 2 replies; 3+ messages in thread
From: Linus Walleij @ 2013-11-26 13:32 UTC (permalink / raw)
To: linux-gpio
Cc: Alexandre Courbot, Linus Walleij, David Cohen, Mika Westerberg,
Mathias Nyman, Dan Carpenter
Switch all users of irq_set_chip_and_handler_name() to simply
use irq_set_chip_and_handler(), all just provide a boilerplate
name like "demux" or "mux" - a fact which is anyway obvious
from the hwirq number from the irqdomain now present in e.g.
/proc/interrupts.
Cc: David Cohen <david.a.cohen@linux.intel.com>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Mathias Nyman <mathias.nyman@linux.intel.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
I'm challenging all users of this function to make an argument
for it to stay in, and suspecting that this is mostly a copy
and paste artifact...
---
drivers/gpio/gpio-intel-mid.c | 3 +--
drivers/gpio/gpio-lynxpoint.c | 3 +--
drivers/gpio/gpio-msic.c | 7 +++----
drivers/gpio/gpio-timberdale.c | 4 ++--
4 files changed, 7 insertions(+), 10 deletions(-)
diff --git a/drivers/gpio/gpio-intel-mid.c b/drivers/gpio/gpio-intel-mid.c
index be803af658ac..17f135046c7f 100644
--- a/drivers/gpio/gpio-intel-mid.c
+++ b/drivers/gpio/gpio-intel-mid.c
@@ -358,8 +358,7 @@ static int intel_gpio_irq_map(struct irq_domain *d, unsigned int irq,
{
struct intel_mid_gpio *priv = d->host_data;
- irq_set_chip_and_handler_name(irq, &intel_mid_irqchip,
- handle_simple_irq, "demux");
+ irq_set_chip_and_handler(irq, &intel_mid_irqchip, handle_simple_irq);
irq_set_chip_data(irq, priv);
irq_set_irq_type(irq, IRQ_TYPE_NONE);
diff --git a/drivers/gpio/gpio-lynxpoint.c b/drivers/gpio/gpio-lynxpoint.c
index f1ca9d5880b6..89867ed7bd50 100644
--- a/drivers/gpio/gpio-lynxpoint.c
+++ b/drivers/gpio/gpio-lynxpoint.c
@@ -331,8 +331,7 @@ static int lp_gpio_irq_map(struct irq_domain *d, unsigned int irq,
{
struct lp_gpio *lg = d->host_data;
- irq_set_chip_and_handler_name(irq, &lp_irqchip, handle_simple_irq,
- "demux");
+ irq_set_chip_and_handler(irq, &lp_irqchip, handle_simple_irq);
irq_set_chip_data(irq, lg);
irq_set_irq_type(irq, IRQ_TYPE_NONE);
diff --git a/drivers/gpio/gpio-msic.c b/drivers/gpio/gpio-msic.c
index d75eaa3a1dcc..69d60ab1d698 100644
--- a/drivers/gpio/gpio-msic.c
+++ b/drivers/gpio/gpio-msic.c
@@ -305,10 +305,9 @@ static int platform_msic_gpio_probe(struct platform_device *pdev)
for (i = 0; i < mg->chip.ngpio; i++) {
irq_set_chip_data(i + mg->irq_base, mg);
- irq_set_chip_and_handler_name(i + mg->irq_base,
- &msic_irqchip,
- handle_simple_irq,
- "demux");
+ irq_set_chip_and_handler(i + mg->irq_base,
+ &msic_irqchip,
+ handle_simple_irq);
}
irq_set_chained_handler(mg->irq, msic_gpio_irq_handler);
irq_set_handler_data(mg->irq, mg);
diff --git a/drivers/gpio/gpio-timberdale.c b/drivers/gpio/gpio-timberdale.c
index 7a0e956ef1ed..521971e6a9f5 100644
--- a/drivers/gpio/gpio-timberdale.c
+++ b/drivers/gpio/gpio-timberdale.c
@@ -290,8 +290,8 @@ static int timbgpio_probe(struct platform_device *pdev)
return 0;
for (i = 0; i < pdata->nr_pins; i++) {
- irq_set_chip_and_handler_name(tgpio->irq_base + i,
- &timbgpio_irqchip, handle_simple_irq, "mux");
+ irq_set_chip_and_handler(tgpio->irq_base + i,
+ &timbgpio_irqchip, handle_simple_irq);
irq_set_chip_data(tgpio->irq_base + i, tgpio);
#ifdef CONFIG_ARM
set_irq_flags(tgpio->irq_base + i, IRQF_VALID | IRQF_PROBE);
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] gpio: drop users of irq_set_chip_and_handler_name()
2013-11-26 13:32 [PATCH] gpio: drop users of irq_set_chip_and_handler_name() Linus Walleij
@ 2013-11-29 10:20 ` Mika Westerberg
2013-12-02 18:27 ` David Cohen
1 sibling, 0 replies; 3+ messages in thread
From: Mika Westerberg @ 2013-11-29 10:20 UTC (permalink / raw)
To: Linus Walleij
Cc: linux-gpio, Alexandre Courbot, David Cohen, Mathias Nyman,
Dan Carpenter
On Tue, Nov 26, 2013 at 02:32:51PM +0100, Linus Walleij wrote:
> Switch all users of irq_set_chip_and_handler_name() to simply
> use irq_set_chip_and_handler(), all just provide a boilerplate
> name like "demux" or "mux" - a fact which is anyway obvious
> from the hwirq number from the irqdomain now present in e.g.
> /proc/interrupts.
>
> Cc: David Cohen <david.a.cohen@linux.intel.com>
> Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
> Cc: Mathias Nyman <mathias.nyman@linux.intel.com>
> Cc: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> I'm challenging all users of this function to make an argument
> for it to stay in, and suspecting that this is mostly a copy
> and paste artifact...
I think so also. To me the patch makes perfect sense and it didn't break
anything on lynxpoint.
For gpio-lynxpoint:
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Tested-by: Mika Westerberg <mika.westerberg@linux.intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio: drop users of irq_set_chip_and_handler_name()
2013-11-26 13:32 [PATCH] gpio: drop users of irq_set_chip_and_handler_name() Linus Walleij
2013-11-29 10:20 ` Mika Westerberg
@ 2013-12-02 18:27 ` David Cohen
1 sibling, 0 replies; 3+ messages in thread
From: David Cohen @ 2013-12-02 18:27 UTC (permalink / raw)
To: Linus Walleij
Cc: linux-gpio, Alexandre Courbot, Mika Westerberg, Mathias Nyman,
Dan Carpenter
Hi Linus,
On 11/26/2013 05:32 AM, Linus Walleij wrote:
> Switch all users of irq_set_chip_and_handler_name() to simply
> use irq_set_chip_and_handler(), all just provide a boilerplate
> name like "demux" or "mux" - a fact which is anyway obvious
> from the hwirq number from the irqdomain now present in e.g.
> /proc/interrupts.
>
> Cc: David Cohen <david.a.cohen@linux.intel.com>
> Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
> Cc: Mathias Nyman <mathias.nyman@linux.intel.com>
> Cc: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> I'm challenging all users of this function to make an argument
> for it to stay in, and suspecting that this is mostly a copy
> and paste artifact...
> ---
> drivers/gpio/gpio-intel-mid.c | 3 +--
> drivers/gpio/gpio-lynxpoint.c | 3 +--
> drivers/gpio/gpio-msic.c | 7 +++----
> drivers/gpio/gpio-timberdale.c | 4 ++--
> 4 files changed, 7 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/gpio/gpio-intel-mid.c b/drivers/gpio/gpio-intel-mid.c
> index be803af658ac..17f135046c7f 100644
> --- a/drivers/gpio/gpio-intel-mid.c
> +++ b/drivers/gpio/gpio-intel-mid.c
> @@ -358,8 +358,7 @@ static int intel_gpio_irq_map(struct irq_domain *d, unsigned int irq,
> {
> struct intel_mid_gpio *priv = d->host_data;
>
> - irq_set_chip_and_handler_name(irq, &intel_mid_irqchip,
> - handle_simple_irq, "demux");
> + irq_set_chip_and_handler(irq, &intel_mid_irqchip, handle_simple_irq);
> irq_set_chip_data(irq, priv);
> irq_set_irq_type(irq, IRQ_TYPE_NONE);
>
For intel-mid case:
Acked-by: David Cohen <david.a.cohen@linux.intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-12-02 18:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-26 13:32 [PATCH] gpio: drop users of irq_set_chip_and_handler_name() Linus Walleij
2013-11-29 10:20 ` Mika Westerberg
2013-12-02 18:27 ` David Cohen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.