From: Kukjin Kim <kgene.kim@samsung.com>
To: Michael Opdenacker <michael.opdenacker@free-electrons.com>
Cc: ben-linux@fluff.org, kgene.kim@samsung.com,
linux@arm.linux.org.uk, linux-samsung-soc@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH][RESEND] ARM: SAMSUNG: remove IRQF_DISABLED
Date: Tue, 10 Dec 2013 06:17:29 +0900 [thread overview]
Message-ID: <52A63369.8010000@samsung.com> (raw)
In-Reply-To: <1386579735-4065-1-git-send-email-michael.opdenacker@free-electrons.com>
On 12/09/13 18:02, Michael Opdenacker wrote:
> This patch proposes to remove the use of the IRQF_DISABLED flag
>
> It's a NOOP since 2.6.35 and it will be removed one day.
>
> Signed-off-by: Michael Opdenacker<michael.opdenacker@free-electrons.com>
> Reviewed-by: Jingoo Han<jg1.han@samsung.com>
> ---
> arch/arm/mach-s3c24xx/dma.c | 2 +-
> arch/arm/mach-s3c24xx/simtec-usb.c | 3 +--
> arch/arm/mach-s3c64xx/mach-smartq.c | 2 +-
> 3 files changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/mach-s3c24xx/dma.c b/arch/arm/mach-s3c24xx/dma.c
> index 4a65cba3295d..a8dafc174fe3 100644
> --- a/arch/arm/mach-s3c24xx/dma.c
> +++ b/arch/arm/mach-s3c24xx/dma.c
> @@ -742,7 +742,7 @@ int s3c2410_dma_request(enum dma_ch channel,
> chan->irq_claimed = 1;
> local_irq_restore(flags);
>
> - err = request_irq(chan->irq, s3c2410_dma_irq, IRQF_DISABLED,
> + err = request_irq(chan->irq, s3c2410_dma_irq, 0,
> client->name, (void *)chan);
>
> local_irq_save(flags);
> diff --git a/arch/arm/mach-s3c24xx/simtec-usb.c b/arch/arm/mach-s3c24xx/simtec-usb.c
> index 2ed2e32430dc..bb3eac6a7697 100644
> --- a/arch/arm/mach-s3c24xx/simtec-usb.c
> +++ b/arch/arm/mach-s3c24xx/simtec-usb.c
> @@ -78,8 +78,7 @@ static void usb_simtec_enableoc(struct s3c2410_hcd_info *info, int on)
>
> if (on) {
> ret = request_irq(BAST_IRQ_USBOC, usb_simtec_ocirq,
> - IRQF_DISABLED | IRQF_TRIGGER_RISING |
> - IRQF_TRIGGER_FALLING,
> + IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING,
> "USB Over-current", info);
> if (ret != 0) {
> printk(KERN_ERR "failed to request usb oc irq\n");
> diff --git a/arch/arm/mach-s3c64xx/mach-smartq.c b/arch/arm/mach-s3c64xx/mach-smartq.c
> index a6b338fd0470..08a889c141da 100644
> --- a/arch/arm/mach-s3c64xx/mach-smartq.c
> +++ b/arch/arm/mach-s3c64xx/mach-smartq.c
> @@ -106,7 +106,7 @@ static void smartq_usb_host_enableoc(struct s3c2410_hcd_info *info, int on)
>
> if (on) {
> ret = request_irq(gpio_to_irq(S3C64XX_GPL(10)),
> - smartq_usb_host_ocirq, IRQF_DISABLED |
> + smartq_usb_host_ocirq,
> IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING,
> "USB host overcurrent", info);
> if (ret != 0)
Looks OK to me, applied.
Thanks,
Kukjin
WARNING: multiple messages have this Message-ID (diff)
From: kgene.kim@samsung.com (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH][RESEND] ARM: SAMSUNG: remove IRQF_DISABLED
Date: Tue, 10 Dec 2013 06:17:29 +0900 [thread overview]
Message-ID: <52A63369.8010000@samsung.com> (raw)
In-Reply-To: <1386579735-4065-1-git-send-email-michael.opdenacker@free-electrons.com>
On 12/09/13 18:02, Michael Opdenacker wrote:
> This patch proposes to remove the use of the IRQF_DISABLED flag
>
> It's a NOOP since 2.6.35 and it will be removed one day.
>
> Signed-off-by: Michael Opdenacker<michael.opdenacker@free-electrons.com>
> Reviewed-by: Jingoo Han<jg1.han@samsung.com>
> ---
> arch/arm/mach-s3c24xx/dma.c | 2 +-
> arch/arm/mach-s3c24xx/simtec-usb.c | 3 +--
> arch/arm/mach-s3c64xx/mach-smartq.c | 2 +-
> 3 files changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/mach-s3c24xx/dma.c b/arch/arm/mach-s3c24xx/dma.c
> index 4a65cba3295d..a8dafc174fe3 100644
> --- a/arch/arm/mach-s3c24xx/dma.c
> +++ b/arch/arm/mach-s3c24xx/dma.c
> @@ -742,7 +742,7 @@ int s3c2410_dma_request(enum dma_ch channel,
> chan->irq_claimed = 1;
> local_irq_restore(flags);
>
> - err = request_irq(chan->irq, s3c2410_dma_irq, IRQF_DISABLED,
> + err = request_irq(chan->irq, s3c2410_dma_irq, 0,
> client->name, (void *)chan);
>
> local_irq_save(flags);
> diff --git a/arch/arm/mach-s3c24xx/simtec-usb.c b/arch/arm/mach-s3c24xx/simtec-usb.c
> index 2ed2e32430dc..bb3eac6a7697 100644
> --- a/arch/arm/mach-s3c24xx/simtec-usb.c
> +++ b/arch/arm/mach-s3c24xx/simtec-usb.c
> @@ -78,8 +78,7 @@ static void usb_simtec_enableoc(struct s3c2410_hcd_info *info, int on)
>
> if (on) {
> ret = request_irq(BAST_IRQ_USBOC, usb_simtec_ocirq,
> - IRQF_DISABLED | IRQF_TRIGGER_RISING |
> - IRQF_TRIGGER_FALLING,
> + IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING,
> "USB Over-current", info);
> if (ret != 0) {
> printk(KERN_ERR "failed to request usb oc irq\n");
> diff --git a/arch/arm/mach-s3c64xx/mach-smartq.c b/arch/arm/mach-s3c64xx/mach-smartq.c
> index a6b338fd0470..08a889c141da 100644
> --- a/arch/arm/mach-s3c64xx/mach-smartq.c
> +++ b/arch/arm/mach-s3c64xx/mach-smartq.c
> @@ -106,7 +106,7 @@ static void smartq_usb_host_enableoc(struct s3c2410_hcd_info *info, int on)
>
> if (on) {
> ret = request_irq(gpio_to_irq(S3C64XX_GPL(10)),
> - smartq_usb_host_ocirq, IRQF_DISABLED |
> + smartq_usb_host_ocirq,
> IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING,
> "USB host overcurrent", info);
> if (ret != 0)
Looks OK to me, applied.
Thanks,
Kukjin
next prev parent reply other threads:[~2013-12-09 21:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <000801cec874$%han@samsung.com>
2013-12-09 9:02 ` [PATCH][RESEND] ARM: SAMSUNG: remove IRQF_DISABLED Michael Opdenacker
2013-12-09 9:02 ` Michael Opdenacker
2013-12-09 21:17 ` Kukjin Kim [this message]
2013-12-09 21:17 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A63369.8010000@samsung.com \
--to=kgene.kim@samsung.com \
--cc=ben-linux@fluff.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=michael.opdenacker@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.