All of lore.kernel.org
 help / color / mirror / Atom feed
From: syin@broadcom.com (Sherman Yin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 4/6] pinctrl: Add pinctrl binding for Broadcom Capri SoCs
Date: Tue, 17 Dec 2013 18:02:07 -0800	[thread overview]
Message-ID: <52B1021F.2010708@broadcom.com> (raw)
In-Reply-To: <CACRpkdZ5Cxii48CsVJzEaBhvZOs8JCcR_hJV=RczhHbW4aqG-w@mail.gmail.com>

On 13-12-16 05:17 AM, Linus Walleij wrote:
> On Sat, Dec 14, 2013 at 2:16 AM, Sherman Yin <syin@broadcom.com> wrote:
>
>>>> +- bias-pull-up:                        Integer. Pull up strength in Ohm:
>>>> +                                       1: 1.2 kOhm
>>>> +                                       2: 1.8 kOhm
>>>> +                                       3: 720 Ohm
>>>> +                                       4: 2.7 kOhm
>>>> +                                       5: 831 Ohm
>>>> +                                       6: 1.08 kOhm
>>>> +                                       7: 568 Ohm
>>>
>>>
>>> Please do not use these custom enumerators 1 thru 7.
>>> Instead say that the argument is given in ohms, so for
>>> example:
>>>
>>> bias-pull-up = <12000>;
>>>
>>> Then translate this into the proper enumerator in your
>>> driver instead.
>>
>> Ok.  The 3 bits in this enumeration correspond to enabling the 3 pull up Rs
>> (1.2k, 1.8k, 2.7k) in parallel, so the enum kind of make sense. But sure I
>> can change it to actual ohms and will error out in the driver if specified
>> value is not one of the 7.
>
> Aha, that's how they do it :-)
>
> Please write this in a comment in the driver because it makes
> it a lot easier to understand what is going on, and e.g. how to
> fuzz an apropriate resistance.

Yes, I plan to explain where those odd numbers come from in this file.

> Can you tell me something about how such resistors are produced
> in silicon?

Sorry I'm not quite sure.  I only know a little bit of the circuitry 
down to the schematic level...

Regards,
Sherman

WARNING: multiple messages have this Message-ID (diff)
From: Sherman Yin <syin-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
To: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: "Rob Herring"
	<rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
	"Heiko Stübner" <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>,
	"Pawel Moll" <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
	"Mark Rutland" <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	"Stephen Warren"
	<swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
	"Ian Campbell"
	<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
	"Rob Landley" <rob-VoJi6FS/r0vR7s880joybQ@public.gmane.org>,
	"Christian Daudt" <bcm-xK7y4jjYLqYh9ZMKESR00Q@public.gmane.org>,
	"Russell King" <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
	"Grant Likely"
	<grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	"Matt Porter"
	<matt.porter-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	bcm-kernel-feedback-list
	<bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>,
	"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: [PATCH v3 4/6] pinctrl: Add pinctrl binding for Broadcom Capri SoCs
Date: Tue, 17 Dec 2013 18:02:07 -0800	[thread overview]
Message-ID: <52B1021F.2010708@broadcom.com> (raw)
In-Reply-To: <CACRpkdZ5Cxii48CsVJzEaBhvZOs8JCcR_hJV=RczhHbW4aqG-w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

On 13-12-16 05:17 AM, Linus Walleij wrote:
> On Sat, Dec 14, 2013 at 2:16 AM, Sherman Yin <syin-dY08KVG/lbpWk0Htik3J/w@public.gmane.org> wrote:
>
>>>> +- bias-pull-up:                        Integer. Pull up strength in Ohm:
>>>> +                                       1: 1.2 kOhm
>>>> +                                       2: 1.8 kOhm
>>>> +                                       3: 720 Ohm
>>>> +                                       4: 2.7 kOhm
>>>> +                                       5: 831 Ohm
>>>> +                                       6: 1.08 kOhm
>>>> +                                       7: 568 Ohm
>>>
>>>
>>> Please do not use these custom enumerators 1 thru 7.
>>> Instead say that the argument is given in ohms, so for
>>> example:
>>>
>>> bias-pull-up = <12000>;
>>>
>>> Then translate this into the proper enumerator in your
>>> driver instead.
>>
>> Ok.  The 3 bits in this enumeration correspond to enabling the 3 pull up Rs
>> (1.2k, 1.8k, 2.7k) in parallel, so the enum kind of make sense. But sure I
>> can change it to actual ohms and will error out in the driver if specified
>> value is not one of the 7.
>
> Aha, that's how they do it :-)
>
> Please write this in a comment in the driver because it makes
> it a lot easier to understand what is going on, and e.g. how to
> fuzz an apropriate resistance.

Yes, I plan to explain where those odd numbers come from in this file.

> Can you tell me something about how such resistors are produced
> in silicon?

Sorry I'm not quite sure.  I only know a little bit of the circuitry 
down to the schematic level...

Regards,
Sherman
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Sherman Yin <syin@broadcom.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "Rob Herring" <rob.herring@calxeda.com>,
	"Heiko Stübner" <heiko@sntech.de>,
	"Pawel Moll" <pawel.moll@arm.com>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Stephen Warren" <swarren@wwwdotorg.org>,
	"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
	"Rob Landley" <rob@landley.net>,
	"Christian Daudt" <bcm@fixthebug.org>,
	"Russell King" <linux@arm.linux.org.uk>,
	"Grant Likely" <grant.likely@linaro.org>,
	"Matt Porter" <matt.porter@linaro.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 4/6] pinctrl: Add pinctrl binding for Broadcom Capri SoCs
Date: Tue, 17 Dec 2013 18:02:07 -0800	[thread overview]
Message-ID: <52B1021F.2010708@broadcom.com> (raw)
In-Reply-To: <CACRpkdZ5Cxii48CsVJzEaBhvZOs8JCcR_hJV=RczhHbW4aqG-w@mail.gmail.com>

On 13-12-16 05:17 AM, Linus Walleij wrote:
> On Sat, Dec 14, 2013 at 2:16 AM, Sherman Yin <syin@broadcom.com> wrote:
>
>>>> +- bias-pull-up:                        Integer. Pull up strength in Ohm:
>>>> +                                       1: 1.2 kOhm
>>>> +                                       2: 1.8 kOhm
>>>> +                                       3: 720 Ohm
>>>> +                                       4: 2.7 kOhm
>>>> +                                       5: 831 Ohm
>>>> +                                       6: 1.08 kOhm
>>>> +                                       7: 568 Ohm
>>>
>>>
>>> Please do not use these custom enumerators 1 thru 7.
>>> Instead say that the argument is given in ohms, so for
>>> example:
>>>
>>> bias-pull-up = <12000>;
>>>
>>> Then translate this into the proper enumerator in your
>>> driver instead.
>>
>> Ok.  The 3 bits in this enumeration correspond to enabling the 3 pull up Rs
>> (1.2k, 1.8k, 2.7k) in parallel, so the enum kind of make sense. But sure I
>> can change it to actual ohms and will error out in the driver if specified
>> value is not one of the 7.
>
> Aha, that's how they do it :-)
>
> Please write this in a comment in the driver because it makes
> it a lot easier to understand what is going on, and e.g. how to
> fuzz an apropriate resistance.

Yes, I plan to explain where those odd numbers come from in this file.

> Can you tell me something about how such resistors are produced
> in silicon?

Sorry I'm not quite sure.  I only know a little bit of the circuitry 
down to the schematic level...

Regards,
Sherman

  reply	other threads:[~2013-12-18  2:02 UTC|newest]

Thread overview: 196+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-04  0:23 [PATCH 0/4] Add Broadcom Capri pinctrl driver Sherman Yin
2013-10-04  0:23 ` Sherman Yin
2013-10-04  0:23 ` Sherman Yin
2013-10-04  0:23 ` [PATCH 1/4] pinctrl: Add void * to pinctrl_pin_desc Sherman Yin
2013-10-04  0:23   ` Sherman Yin
2013-10-09  8:55   ` Linus Walleij
2013-10-09  8:55     ` Linus Walleij
2013-10-09  8:55     ` Linus Walleij
2013-10-09 22:57     ` Sherman Yin
2013-10-09 22:57       ` Sherman Yin
2013-10-04  0:23 ` [PATCH 2/4] pinctrl: Add pinctrl binding for Broadcom Capri SoCs Sherman Yin
2013-10-04  0:23   ` Sherman Yin
2013-10-04  0:23   ` Sherman Yin
2013-10-04 12:51   ` Matt Porter
2013-10-04 12:51     ` Matt Porter
2013-10-09  8:53   ` Linus Walleij
2013-10-09  8:53     ` Linus Walleij
2013-10-09  8:53     ` Linus Walleij
2013-10-10 17:57     ` Sherman Yin
2013-10-10 17:57       ` Sherman Yin
2013-10-04  0:23 ` [PATCH 3/4] ARM: pinctrl: Add Broadcom Capri pinctrl driver Sherman Yin
2013-10-04  0:23   ` Sherman Yin
2013-10-04  0:23   ` Sherman Yin
2013-10-09  9:10   ` Linus Walleij
2013-10-09  9:10     ` Linus Walleij
2013-10-10 23:48     ` Sherman Yin
2013-10-10 23:48       ` Sherman Yin
2013-10-11  8:14       ` Linus Walleij
2013-10-11  8:14         ` Linus Walleij
2013-10-11  8:14         ` Linus Walleij
2013-10-11 18:25         ` Sherman Yin
2013-10-11 18:25           ` Sherman Yin
2013-10-22 23:29           ` Sherman Yin
2013-10-22 23:29             ` Sherman Yin
2013-10-25 22:48             ` Sherman Yin
2013-10-25 22:48               ` Sherman Yin
2013-11-04 12:24               ` Linus Walleij
2013-11-04 12:24                 ` Linus Walleij
2013-11-04 23:26                 ` Heiko Stübner
2013-11-04 23:26                   ` Heiko Stübner
2013-11-05  0:04                   ` Stephen Warren
2013-11-05  0:04                     ` Stephen Warren
2013-11-06  2:02                     ` Sherman Yin
2013-11-06  2:02                       ` Sherman Yin
2013-11-06  9:40                       ` Linus Walleij
2013-11-06  9:40                         ` Linus Walleij
2013-11-08  0:29                         ` Sherman Yin
2013-11-08  0:29                           ` Sherman Yin
2013-11-11 10:01                           ` Linus Walleij
2013-11-11 10:01                             ` Linus Walleij
2013-11-13 23:43                             ` Sherman Yin
2013-11-13 23:43                               ` Sherman Yin
2013-11-13 23:43                               ` Sherman Yin
2013-11-19 20:39                               ` Linus Walleij
2013-11-19 20:39                                 ` Linus Walleij
2013-11-06 17:00                       ` Stephen Warren
2013-11-06 17:00                         ` Stephen Warren
2013-11-06 17:00                         ` Stephen Warren
2013-11-07 22:01                         ` Sherman Yin
2013-11-07 22:01                           ` Sherman Yin
2013-11-06  9:29                     ` Linus Walleij
2013-11-06  9:29                       ` Linus Walleij
2013-10-17  6:03   ` Christian Daudt
2013-10-17  6:03     ` Christian Daudt
2013-10-17 14:54     ` Stephen Warren
2013-10-17 14:54       ` Stephen Warren
2013-10-17 15:31       ` Christian Daudt
2013-10-17 15:31         ` Christian Daudt
2013-12-11  0:05         ` Sherman Yin
2013-12-11  0:05           ` Sherman Yin
2013-12-12 20:43           ` Linus Walleij
2013-12-12 20:43             ` Linus Walleij
2013-10-04  0:23 ` [PATCH 4/4] pinctrl: Enable pinctrl for Broadcom Capri SoCs Sherman Yin
2013-10-04  0:23   ` Sherman Yin
2013-10-09  9:11   ` Linus Walleij
2013-10-09  9:11     ` Linus Walleij
2013-10-07 19:28 ` [PATCH v2 0/4] Add Broadcom Capri pinctrl driver Sherman Yin
2013-10-07 19:28   ` Sherman Yin
2013-10-07 19:28   ` [PATCH v2 1/4] pinctrl: Add void * to pinctrl_pin_desc Sherman Yin
2013-10-07 19:28     ` Sherman Yin
2013-10-07 19:28   ` [PATCH v2 2/4] pinctrl: Add pinctrl binding for Broadcom Capri SoCs Sherman Yin
2013-10-07 19:28     ` Sherman Yin
2013-10-07 19:28   ` [PATCH v2 3/4] ARM: pinctrl: Add Broadcom Capri pinctrl driver Sherman Yin
2013-10-07 19:28     ` Sherman Yin
2013-10-07 19:28   ` [PATCH v2 4/4] pinctrl: Enable pinctrl for Broadcom Capri SoCs Sherman Yin
2013-10-07 19:28     ` Sherman Yin
2013-12-11 18:37   ` [PATCH v3 0/6] Add Broadcom Capri pinctrl driver Sherman Yin
2013-12-11 18:37     ` Sherman Yin
2013-12-11 18:37     ` Sherman Yin
2013-12-11 18:37     ` [PATCH v3 1/6] pinctrl: Add void * to pinctrl_pin_desc Sherman Yin
2013-12-11 18:37       ` Sherman Yin
2013-12-11 18:37       ` Sherman Yin
2013-12-11 18:37     ` [PATCH v3 2/6] pinctrl: Adds slew-rate, input-enable/disable Sherman Yin
2013-12-11 18:37       ` Sherman Yin
2013-12-11 18:37       ` Sherman Yin
2013-12-12 20:41       ` Linus Walleij
2013-12-12 20:41         ` Linus Walleij
2013-12-16  9:55       ` Linus Walleij
2013-12-16  9:55         ` Linus Walleij
2013-12-11 18:37     ` [PATCH v3 3/6] pinctrl: Make PINCTRL selectable by defconfig/menuconfig Sherman Yin
2013-12-11 18:37       ` Sherman Yin
2013-12-11 18:37       ` Sherman Yin
2013-12-12 20:39       ` Linus Walleij
2013-12-12 20:39         ` Linus Walleij
2013-12-12 21:35         ` Christian Daudt
2013-12-12 21:35           ` Christian Daudt
2013-12-16 10:01           ` Linus Walleij
2013-12-16 10:01             ` Linus Walleij
2013-12-17  0:18             ` Bjorn Andersson
2013-12-17  0:18               ` Bjorn Andersson
2013-12-17  0:18               ` Bjorn Andersson
2013-12-20  9:37               ` Linus Walleij
2013-12-20  9:37                 ` Linus Walleij
2013-12-20 20:58                 ` Arnd Bergmann
2013-12-20 20:58                   ` Arnd Bergmann
2013-12-20 20:58                   ` Arnd Bergmann
2013-12-21  2:15                   ` Sherman Yin
2013-12-21  2:15                     ` Sherman Yin
2013-12-11 18:37     ` [PATCH v3 4/6] pinctrl: Add pinctrl binding for Broadcom Capri SoCs Sherman Yin
2013-12-11 18:37       ` Sherman Yin
2013-12-11 18:37       ` Sherman Yin
2013-12-12 20:37       ` Linus Walleij
2013-12-12 20:37         ` Linus Walleij
2013-12-14  1:16         ` Sherman Yin
2013-12-14  1:16           ` Sherman Yin
2013-12-14  1:16           ` Sherman Yin
2013-12-16 13:17           ` Linus Walleij
2013-12-16 13:17             ` Linus Walleij
2013-12-18  2:02             ` Sherman Yin [this message]
2013-12-18  2:02               ` Sherman Yin
2013-12-18  2:02               ` Sherman Yin
2013-12-11 18:37     ` [PATCH v3 5/6] ARM: pinctrl: Add Broadcom Capri pinctrl driver Sherman Yin
2013-12-11 18:37       ` Sherman Yin
2013-12-11 18:37       ` Sherman Yin
2013-12-12 20:54       ` Linus Walleij
2013-12-12 20:54         ` Linus Walleij
2013-12-13 10:22         ` Mark Brown
2013-12-13 10:22           ` Mark Brown
2013-12-19  0:12           ` Sherman Yin
2013-12-19  0:12             ` Sherman Yin
2013-12-18 23:56         ` Sherman Yin
2013-12-18 23:56           ` Sherman Yin
2013-12-21  2:31           ` Sherman Yin
2013-12-21  2:31             ` Sherman Yin
2013-12-11 18:37     ` [PATCH v3 6/6] pinctrl: Enable pinctrl for Broadcom Capri SoCs Sherman Yin
2013-12-11 18:37       ` Sherman Yin
2013-12-11 18:37       ` Sherman Yin
2013-12-21  2:13     ` [PATCH v4 0/6] Add Broadcom Capri pinctrl driver Sherman Yin
2013-12-21  2:13       ` Sherman Yin
2013-12-21  2:13       ` Sherman Yin
2013-12-21  2:13       ` [PATCH v4 1/4] pinctrl: Add void * to pinctrl_pin_desc Sherman Yin
2013-12-21  2:13         ` Sherman Yin
2013-12-21  2:13         ` Sherman Yin
2014-01-16 13:26         ` Linus Walleij
2014-01-16 13:26           ` Linus Walleij
2013-12-21  2:13       ` [PATCH v4 2/4] pinctrl: Add pinctrl binding for Broadcom Capri SoCs Sherman Yin
2013-12-21  2:13         ` Sherman Yin
2013-12-21  2:13         ` Sherman Yin
2014-01-07 17:15         ` Linus Walleij
2014-01-07 17:15           ` Linus Walleij
2014-01-07 20:45           ` Sherman Yin
2014-01-07 20:45             ` Sherman Yin
2014-01-14 10:16             ` Linus Walleij
2014-01-14 10:16               ` Linus Walleij
2014-01-14 19:00               ` Sherman Yin
2014-01-14 19:00                 ` Sherman Yin
2014-01-15  9:40                 ` Linus Walleij
2014-01-15  9:40                   ` Linus Walleij
2014-01-15 16:39                   ` Mark Rutland
2014-01-15 16:39                     ` Mark Rutland
2014-01-16 13:24         ` Linus Walleij
2014-01-16 13:24           ` Linus Walleij
2014-01-16 13:24           ` Linus Walleij
2013-12-21  2:13       ` [PATCH v4 3/4] ARM: pinctrl: Add Broadcom Capri pinctrl driver Sherman Yin
2013-12-21  2:13         ` Sherman Yin
2013-12-21  2:13         ` Sherman Yin
2014-01-16 13:19         ` Linus Walleij
2014-01-16 13:19           ` Linus Walleij
2014-01-17 19:59           ` Sherman Yin
2014-01-17 19:59             ` Sherman Yin
2014-01-18  2:56             ` Matt Porter
2014-01-18  2:56               ` Matt Porter
2014-01-18  2:56               ` Matt Porter
2014-01-20  8:16               ` Linus Walleij
2014-01-20  8:16                 ` Linus Walleij
2014-01-20 19:14                 ` Sherman Yin
2014-01-20 19:14                   ` Sherman Yin
2014-01-21 12:35                   ` Linus Walleij
2014-01-21 12:35                     ` Linus Walleij
2014-01-21 13:49                 ` Matt Porter
2014-01-21 13:49                   ` Matt Porter
2013-12-21  2:13       ` [PATCH v4 4/4] pinctrl: Enable pinctrl for Broadcom Capri SoCs Sherman Yin
2013-12-21  2:13         ` Sherman Yin
2013-12-21  2:13         ` Sherman Yin
2014-01-16 13:28         ` Linus Walleij
2014-01-16 13:28           ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52B1021F.2010708@broadcom.com \
    --to=syin@broadcom.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.