All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Scott Wood <scottwood@freescale.com>
Cc: Gleb Natapov <gleb@kernel.org>,
	kvm-ppc@vger.kernel.org, kvm@vger.kernel.org,
	Stephen Hemminger <stephen@networkplumber.org>,
	Alexander Graf <agraf@suse.de>
Subject: Re: [PATCH] kvm: Provide kvm_vcpu_eligible_for_directed_yield() stub
Date: Wed, 15 Jan 2014 11:04:59 +0000	[thread overview]
Message-ID: <52D66B5B.5060101@redhat.com> (raw)
In-Reply-To: <1389314596-18814-1-git-send-email-scottwood@freescale.com>

Il 10/01/2014 01:43, Scott Wood ha scritto:
> Commit 7940876e1330671708186ac3386aa521ffb5c182 ("kvm: make local
> functions static") broke KVM PPC builds due to removing (rather than
> moving) the stub version of kvm_vcpu_eligible_for_directed_yield().
> 
> This patch reintroduces it.
> 
> Signed-off-by: Scott Wood <scottwood@freescale.com>
> Cc: Stephen Hemminger <stephen@networkplumber.org>
> Cc: Alexander Graf <agraf@suse.de>
> ---
>  virt/kvm/kvm_main.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> index 4733fa1..f896665 100644
> --- a/virt/kvm/kvm_main.c
> +++ b/virt/kvm/kvm_main.c
> @@ -1771,6 +1771,11 @@ static bool kvm_vcpu_eligible_for_directed_yield(struct kvm_vcpu *vcpu)
>  
>  	return eligible;
>  }
> +#else
> +static bool kvm_vcpu_eligible_for_directed_yield(struct kvm_vcpu *vcpu)
> +{
> +	return true;
> +}
>  #endif

I moved the #ifdef inside the function.  Thanks for the fix.

Paolo

>  
>  void kvm_vcpu_on_spin(struct kvm_vcpu *me)
> 

Applied to kvm/queue

WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Scott Wood <scottwood@freescale.com>
Cc: Gleb Natapov <gleb@kernel.org>,
	kvm-ppc@vger.kernel.org, kvm@vger.kernel.org,
	Stephen Hemminger <stephen@networkplumber.org>,
	Alexander Graf <agraf@suse.de>
Subject: Re: [PATCH] kvm: Provide kvm_vcpu_eligible_for_directed_yield() stub
Date: Wed, 15 Jan 2014 12:04:59 +0100	[thread overview]
Message-ID: <52D66B5B.5060101@redhat.com> (raw)
In-Reply-To: <1389314596-18814-1-git-send-email-scottwood@freescale.com>

Il 10/01/2014 01:43, Scott Wood ha scritto:
> Commit 7940876e1330671708186ac3386aa521ffb5c182 ("kvm: make local
> functions static") broke KVM PPC builds due to removing (rather than
> moving) the stub version of kvm_vcpu_eligible_for_directed_yield().
> 
> This patch reintroduces it.
> 
> Signed-off-by: Scott Wood <scottwood@freescale.com>
> Cc: Stephen Hemminger <stephen@networkplumber.org>
> Cc: Alexander Graf <agraf@suse.de>
> ---
>  virt/kvm/kvm_main.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> index 4733fa1..f896665 100644
> --- a/virt/kvm/kvm_main.c
> +++ b/virt/kvm/kvm_main.c
> @@ -1771,6 +1771,11 @@ static bool kvm_vcpu_eligible_for_directed_yield(struct kvm_vcpu *vcpu)
>  
>  	return eligible;
>  }
> +#else
> +static bool kvm_vcpu_eligible_for_directed_yield(struct kvm_vcpu *vcpu)
> +{
> +	return true;
> +}
>  #endif

I moved the #ifdef inside the function.  Thanks for the fix.

Paolo

>  
>  void kvm_vcpu_on_spin(struct kvm_vcpu *me)
> 

Applied to kvm/queue

  reply	other threads:[~2014-01-15 11:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-10  0:43 [PATCH] kvm: Provide kvm_vcpu_eligible_for_directed_yield() stub Scott Wood
2014-01-10  0:43 ` Scott Wood
2014-01-15 11:04 ` Paolo Bonzini [this message]
2014-01-15 11:04   ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52D66B5B.5060101@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=agraf@suse.de \
    --cc=gleb@kernel.org \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=scottwood@freescale.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.