* [PATCH] kvm: Provide kvm_vcpu_eligible_for_directed_yield() stub
@ 2014-01-10 0:43 ` Scott Wood
0 siblings, 0 replies; 4+ messages in thread
From: Scott Wood @ 2014-01-10 0:43 UTC (permalink / raw)
To: Gleb Natapov, Paolo Bonzini
Cc: kvm-ppc, kvm, Scott Wood, Stephen Hemminger, Alexander Graf
Commit 7940876e1330671708186ac3386aa521ffb5c182 ("kvm: make local
functions static") broke KVM PPC builds due to removing (rather than
moving) the stub version of kvm_vcpu_eligible_for_directed_yield().
This patch reintroduces it.
Signed-off-by: Scott Wood <scottwood@freescale.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>
Cc: Alexander Graf <agraf@suse.de>
---
virt/kvm/kvm_main.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
index 4733fa1..f896665 100644
--- a/virt/kvm/kvm_main.c
+++ b/virt/kvm/kvm_main.c
@@ -1771,6 +1771,11 @@ static bool kvm_vcpu_eligible_for_directed_yield(struct kvm_vcpu *vcpu)
return eligible;
}
+#else
+static bool kvm_vcpu_eligible_for_directed_yield(struct kvm_vcpu *vcpu)
+{
+ return true;
+}
#endif
void kvm_vcpu_on_spin(struct kvm_vcpu *me)
--
1.8.3.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] kvm: Provide kvm_vcpu_eligible_for_directed_yield() stub
@ 2014-01-10 0:43 ` Scott Wood
0 siblings, 0 replies; 4+ messages in thread
From: Scott Wood @ 2014-01-10 0:43 UTC (permalink / raw)
To: Gleb Natapov, Paolo Bonzini
Cc: kvm-ppc, kvm, Scott Wood, Stephen Hemminger, Alexander Graf
Commit 7940876e1330671708186ac3386aa521ffb5c182 ("kvm: make local
functions static") broke KVM PPC builds due to removing (rather than
moving) the stub version of kvm_vcpu_eligible_for_directed_yield().
This patch reintroduces it.
Signed-off-by: Scott Wood <scottwood@freescale.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>
Cc: Alexander Graf <agraf@suse.de>
---
virt/kvm/kvm_main.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
index 4733fa1..f896665 100644
--- a/virt/kvm/kvm_main.c
+++ b/virt/kvm/kvm_main.c
@@ -1771,6 +1771,11 @@ static bool kvm_vcpu_eligible_for_directed_yield(struct kvm_vcpu *vcpu)
return eligible;
}
+#else
+static bool kvm_vcpu_eligible_for_directed_yield(struct kvm_vcpu *vcpu)
+{
+ return true;
+}
#endif
void kvm_vcpu_on_spin(struct kvm_vcpu *me)
--
1.8.3.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] kvm: Provide kvm_vcpu_eligible_for_directed_yield() stub
2014-01-10 0:43 ` Scott Wood
@ 2014-01-15 11:04 ` Paolo Bonzini
-1 siblings, 0 replies; 4+ messages in thread
From: Paolo Bonzini @ 2014-01-15 11:04 UTC (permalink / raw)
To: Scott Wood; +Cc: Gleb Natapov, kvm-ppc, kvm, Stephen Hemminger, Alexander Graf
Il 10/01/2014 01:43, Scott Wood ha scritto:
> Commit 7940876e1330671708186ac3386aa521ffb5c182 ("kvm: make local
> functions static") broke KVM PPC builds due to removing (rather than
> moving) the stub version of kvm_vcpu_eligible_for_directed_yield().
>
> This patch reintroduces it.
>
> Signed-off-by: Scott Wood <scottwood@freescale.com>
> Cc: Stephen Hemminger <stephen@networkplumber.org>
> Cc: Alexander Graf <agraf@suse.de>
> ---
> virt/kvm/kvm_main.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> index 4733fa1..f896665 100644
> --- a/virt/kvm/kvm_main.c
> +++ b/virt/kvm/kvm_main.c
> @@ -1771,6 +1771,11 @@ static bool kvm_vcpu_eligible_for_directed_yield(struct kvm_vcpu *vcpu)
>
> return eligible;
> }
> +#else
> +static bool kvm_vcpu_eligible_for_directed_yield(struct kvm_vcpu *vcpu)
> +{
> + return true;
> +}
> #endif
I moved the #ifdef inside the function. Thanks for the fix.
Paolo
>
> void kvm_vcpu_on_spin(struct kvm_vcpu *me)
>
Applied to kvm/queue
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] kvm: Provide kvm_vcpu_eligible_for_directed_yield() stub
@ 2014-01-15 11:04 ` Paolo Bonzini
0 siblings, 0 replies; 4+ messages in thread
From: Paolo Bonzini @ 2014-01-15 11:04 UTC (permalink / raw)
To: Scott Wood; +Cc: Gleb Natapov, kvm-ppc, kvm, Stephen Hemminger, Alexander Graf
Il 10/01/2014 01:43, Scott Wood ha scritto:
> Commit 7940876e1330671708186ac3386aa521ffb5c182 ("kvm: make local
> functions static") broke KVM PPC builds due to removing (rather than
> moving) the stub version of kvm_vcpu_eligible_for_directed_yield().
>
> This patch reintroduces it.
>
> Signed-off-by: Scott Wood <scottwood@freescale.com>
> Cc: Stephen Hemminger <stephen@networkplumber.org>
> Cc: Alexander Graf <agraf@suse.de>
> ---
> virt/kvm/kvm_main.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> index 4733fa1..f896665 100644
> --- a/virt/kvm/kvm_main.c
> +++ b/virt/kvm/kvm_main.c
> @@ -1771,6 +1771,11 @@ static bool kvm_vcpu_eligible_for_directed_yield(struct kvm_vcpu *vcpu)
>
> return eligible;
> }
> +#else
> +static bool kvm_vcpu_eligible_for_directed_yield(struct kvm_vcpu *vcpu)
> +{
> + return true;
> +}
> #endif
I moved the #ifdef inside the function. Thanks for the fix.
Paolo
>
> void kvm_vcpu_on_spin(struct kvm_vcpu *me)
>
Applied to kvm/queue
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-01-15 11:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-10 0:43 [PATCH] kvm: Provide kvm_vcpu_eligible_for_directed_yield() stub Scott Wood
2014-01-10 0:43 ` Scott Wood
2014-01-15 11:04 ` Paolo Bonzini
2014-01-15 11:04 ` Paolo Bonzini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.