* [PATCH] spi: sc18is602: Remove sc18is602_setup() because it is done by spi core
@ 2014-01-20 15:18 Axel Lin
2014-01-20 16:24 ` Guenter Roeck
2014-01-20 18:33 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2014-01-20 15:18 UTC (permalink / raw)
To: Mark Brown; +Cc: Guenter Roeck, linux-spi-u79uwXL29TY76Z2rM5mHXA
The checking for spi->mode is done in the implementation of spi_setup().
Calling sc18is602_check_transfer(spi, NULL, 0) is pointless because
the code is equivent to checking if spi->max_speed_hz is 0.
Note, sc18is602_check_transfer actually allows spi->max_speed_hz is 0
if t->speed_hz is set. So return error in sc18is602_setup() when
spi->max_speed_hz is 0 does not make sense.
Signed-off-by: Axel Lin <axel.lin-8E1dMatC8ynQT0dZR+AlfA@public.gmane.org>
---
drivers/spi/spi-sc18is602.c | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/drivers/spi/spi-sc18is602.c b/drivers/spi/spi-sc18is602.c
index 121c2e1..b3ac776 100644
--- a/drivers/spi/spi-sc18is602.c
+++ b/drivers/spi/spi-sc18is602.c
@@ -245,14 +245,6 @@ error:
return status;
}
-static int sc18is602_setup(struct spi_device *spi)
-{
- if (spi->mode & ~(SPI_CPHA | SPI_CPOL | SPI_LSB_FIRST))
- return -EINVAL;
-
- return sc18is602_check_transfer(spi, NULL, 0);
-}
-
static int sc18is602_probe(struct i2c_client *client,
const struct i2c_device_id *id)
{
@@ -306,7 +298,6 @@ static int sc18is602_probe(struct i2c_client *client,
master->bus_num = client->adapter->nr;
master->mode_bits = SPI_CPHA | SPI_CPOL | SPI_LSB_FIRST;
master->bits_per_word_mask = SPI_BPW_MASK(8);
- master->setup = sc18is602_setup;
master->transfer_one_message = sc18is602_transfer_one;
master->dev.of_node = np;
--
1.8.1.2
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] spi: sc18is602: Remove sc18is602_setup() because it is done by spi core
2014-01-20 15:18 [PATCH] spi: sc18is602: Remove sc18is602_setup() because it is done by spi core Axel Lin
@ 2014-01-20 16:24 ` Guenter Roeck
2014-01-20 18:33 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2014-01-20 16:24 UTC (permalink / raw)
To: Axel Lin, Mark Brown; +Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA
On 01/20/2014 07:18 AM, Axel Lin wrote:
> The checking for spi->mode is done in the implementation of spi_setup().
> Calling sc18is602_check_transfer(spi, NULL, 0) is pointless because
> the code is equivent to checking if spi->max_speed_hz is 0.
> Note, sc18is602_check_transfer actually allows spi->max_speed_hz is 0
> if t->speed_hz is set. So return error in sc18is602_setup() when
> spi->max_speed_hz is 0 does not make sense.
>
> Signed-off-by: Axel Lin <axel.lin-8E1dMatC8ynQT0dZR+AlfA@public.gmane.org>
Acked-by: Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] spi: sc18is602: Remove sc18is602_setup() because it is done by spi core
2014-01-20 15:18 [PATCH] spi: sc18is602: Remove sc18is602_setup() because it is done by spi core Axel Lin
2014-01-20 16:24 ` Guenter Roeck
@ 2014-01-20 18:33 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2014-01-20 18:33 UTC (permalink / raw)
To: Axel Lin; +Cc: Guenter Roeck, linux-spi-u79uwXL29TY76Z2rM5mHXA
[-- Attachment #1: Type: text/plain, Size: 468 bytes --]
On Mon, Jan 20, 2014 at 11:18:45PM +0800, Axel Lin wrote:
> The checking for spi->mode is done in the implementation of spi_setup().
> Calling sc18is602_check_transfer(spi, NULL, 0) is pointless because
> the code is equivent to checking if spi->max_speed_hz is 0.
> Note, sc18is602_check_transfer actually allows spi->max_speed_hz is 0
> if t->speed_hz is set. So return error in sc18is602_setup() when
> spi->max_speed_hz is 0 does not make sense.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-01-20 18:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-20 15:18 [PATCH] spi: sc18is602: Remove sc18is602_setup() because it is done by spi core Axel Lin
2014-01-20 16:24 ` Guenter Roeck
2014-01-20 18:33 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.