All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Mark Brown <broonie@kernel.org>
Cc: Jean Delvare <khali@linux-fr.org>,
	Liam Girdwood <lgirdwood@gmail.com>, Wei Ni <wni@nvidia.com>,
	linux-kernel@vger.kernel.org,
	LM Sensors <lm-sensors@lm-sensors.org>
Subject: Re: [lm-sensors] lm90 driver no longer working on PCs in 3.13
Date: Mon, 27 Jan 2014 04:16:37 +0000	[thread overview]
Message-ID: <52E5DDA5.2010705@roeck-us.net> (raw)
In-Reply-To: <20140126235103.GP11727@sirena.org.uk>

On 01/26/2014 03:51 PM, Mark Brown wrote:
> On Sun, Jan 26, 2014 at 02:04:06PM -0800, Guenter Roeck wrote:
>
>> I think I have a better idea: Surround the regulator code, or at least
>> its error handling, in the lm90 driver with
>
>> 	if (IS_ENABLED(CONFIG_OF)) {
>> 	}
>
>> Would that be ok ? If yes I'll submit a patch. I'll do the same in
>> another driver I am working on.
>
> That's not going to have the desired effect in cases where DT is built
> into the kernel but not in use on the current system (which is a
> configuration that gets used) and will remove error handling for non-DT
> systems that do have regulators set up.  There's not the relationship
> between this and DT that you seem think there is...
>
> Besides, if we're going to do a bodge like that we should do it in the
> core and not in individual callers.
>

Then it appears the only remedy at this time is to revert the patch.

Guenter


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: Mark Brown <broonie@kernel.org>
Cc: Jean Delvare <khali@linux-fr.org>,
	Liam Girdwood <lgirdwood@gmail.com>, Wei Ni <wni@nvidia.com>,
	linux-kernel@vger.kernel.org,
	LM Sensors <lm-sensors@lm-sensors.org>
Subject: Re: [lm-sensors] lm90 driver no longer working on PCs in 3.13
Date: Sun, 26 Jan 2014 20:16:37 -0800	[thread overview]
Message-ID: <52E5DDA5.2010705@roeck-us.net> (raw)
In-Reply-To: <20140126235103.GP11727@sirena.org.uk>

On 01/26/2014 03:51 PM, Mark Brown wrote:
> On Sun, Jan 26, 2014 at 02:04:06PM -0800, Guenter Roeck wrote:
>
>> I think I have a better idea: Surround the regulator code, or at least
>> its error handling, in the lm90 driver with
>
>> 	if (IS_ENABLED(CONFIG_OF)) {
>> 	}
>
>> Would that be ok ? If yes I'll submit a patch. I'll do the same in
>> another driver I am working on.
>
> That's not going to have the desired effect in cases where DT is built
> into the kernel but not in use on the current system (which is a
> configuration that gets used) and will remove error handling for non-DT
> systems that do have regulators set up.  There's not the relationship
> between this and DT that you seem think there is...
>
> Besides, if we're going to do a bodge like that we should do it in the
> core and not in individual callers.
>

Then it appears the only remedy at this time is to revert the patch.

Guenter


  reply	other threads:[~2014-01-27  4:16 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-26 19:28 [lm-sensors] lm90 driver no longer working on PCs in 3.13 Guenter Roeck
2014-01-26 19:28 ` Guenter Roeck
2014-01-26 20:13 ` [lm-sensors] " Jean Delvare
2014-01-26 20:13   ` Jean Delvare
2014-01-26 20:42   ` [lm-sensors] " Mark Brown
2014-01-26 20:42     ` Mark Brown
2014-01-26 20:44   ` [lm-sensors] " Guenter Roeck
2014-01-26 20:44     ` Guenter Roeck
2014-01-26 20:49     ` [lm-sensors] " Jean Delvare
2014-01-26 20:49       ` Jean Delvare
2014-01-26 21:22       ` [lm-sensors] " Mark Brown
2014-01-26 21:22         ` Mark Brown
2014-01-26 21:40         ` [lm-sensors] " Guenter Roeck
2014-01-26 21:40           ` Guenter Roeck
2014-01-26 21:53           ` [lm-sensors] " Mark Brown
2014-01-26 21:53             ` Mark Brown
2014-01-26 22:02             ` [lm-sensors] " Guenter Roeck
2014-01-26 22:02               ` Guenter Roeck
2014-01-26 23:37               ` [lm-sensors] " Mark Brown
2014-01-26 23:37                 ` Mark Brown
2014-01-26 21:44         ` [lm-sensors] " Jean Delvare
2014-01-26 21:44           ` Jean Delvare
2014-01-26 23:15           ` [lm-sensors] " Mark Brown
2014-01-26 23:15             ` Mark Brown
2014-01-27 10:10             ` [lm-sensors] " Geert Uytterhoeven
2014-01-27 10:10               ` Geert Uytterhoeven
2014-01-27 13:18               ` [lm-sensors] " Mark Brown
2014-01-27 13:18                 ` Mark Brown
2014-01-26 21:50       ` [lm-sensors] " Guenter Roeck
2014-01-26 21:50         ` Guenter Roeck
2014-01-26 22:04         ` [lm-sensors] " Guenter Roeck
2014-01-26 22:04           ` Guenter Roeck
2014-01-26 23:51           ` Mark Brown
2014-01-26 23:51             ` Mark Brown
2014-01-27  4:16             ` Guenter Roeck [this message]
2014-01-27  4:16               ` Guenter Roeck
2014-01-27 10:34               ` Mark Brown
2014-01-27 10:34                 ` Mark Brown
2014-01-27 17:19             ` Stephen Warren
2014-01-27 17:19               ` Stephen Warren
2014-01-27 18:50               ` Guenter Roeck
2014-01-27 18:50                 ` Guenter Roeck
2014-01-27 22:04                 ` Jean Delvare
2014-01-27 22:04                   ` Jean Delvare
2014-01-27 23:41                   ` Guenter Roeck
2014-01-27 23:41                     ` Guenter Roeck
2014-01-27 23:58                     ` Mark Brown
2014-01-27 23:58                       ` Mark Brown
2014-01-28  2:33                       ` Guenter Roeck
2014-01-28  2:33                         ` Guenter Roeck
2014-01-28 10:24                         ` Mark Brown
2014-01-28 10:24                           ` Mark Brown
2014-01-28 12:34                   ` Mark Brown
2014-01-28 12:34                     ` Mark Brown
2014-01-27 22:36                 ` Mark Brown
2014-01-27 22:36                   ` Mark Brown
2014-01-26 20:52     ` Mark Brown
2014-01-26 20:52       ` Mark Brown
2014-01-26 21:47       ` [lm-sensors] " Guenter Roeck
2014-01-26 21:47         ` Guenter Roeck
2014-01-26 22:01         ` [lm-sensors] " Mark Brown
2014-01-26 22:01           ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52E5DDA5.2010705@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=broonie@kernel.org \
    --cc=khali@linux-fr.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    --cc=wni@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.