All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Nicolas Pitre <nicolas.pitre@linaro.org>,
	Russell King <linux@arm.linux.org.uk>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mundt <lethal@linux-sh.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org,
	linux-pm@vger.kernel.org, linaro-kernel@lists.linaro.org
Subject: Re: [PATCH 8/9] X86: remove redundant cpuidle_idle_call()
Date: Mon, 27 Jan 2014 09:43:12 +0100	[thread overview]
Message-ID: <52E61C20.50804@linaro.org> (raw)
In-Reply-To: <1390802904-28399-9-git-send-email-nicolas.pitre@linaro.org>

On 01/27/2014 07:08 AM, Nicolas Pitre wrote:
> The core idle loop now takes care of it.
>
> Signed-off-by: Nicolas Pitre <nico@linaro.org>

Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>

> ---
>   arch/x86/kernel/process.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c
> index 3fb8d95ab8..4505e2a950 100644
> --- a/arch/x86/kernel/process.c
> +++ b/arch/x86/kernel/process.c
> @@ -298,10 +298,7 @@ void arch_cpu_idle_dead(void)
>    */
>   void arch_cpu_idle(void)
>   {
> -	if (cpuidle_idle_call())
> -		x86_idle();
> -	else
> -		local_irq_enable();

For the record, it was pointless to enable the local irq here because it 
is handled by the cpuidle framework when exiting the idle state.

> +	x86_idle();
>   }
>
>   /*
>


-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

WARNING: multiple messages have this Message-ID (diff)
From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 8/9] X86: remove redundant cpuidle_idle_call()
Date: Mon, 27 Jan 2014 08:43:12 +0000	[thread overview]
Message-ID: <52E61C20.50804@linaro.org> (raw)
In-Reply-To: <1390802904-28399-9-git-send-email-nicolas.pitre@linaro.org>

On 01/27/2014 07:08 AM, Nicolas Pitre wrote:
> The core idle loop now takes care of it.
>
> Signed-off-by: Nicolas Pitre <nico@linaro.org>

Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>

> ---
>   arch/x86/kernel/process.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c
> index 3fb8d95ab8..4505e2a950 100644
> --- a/arch/x86/kernel/process.c
> +++ b/arch/x86/kernel/process.c
> @@ -298,10 +298,7 @@ void arch_cpu_idle_dead(void)
>    */
>   void arch_cpu_idle(void)
>   {
> -	if (cpuidle_idle_call())
> -		x86_idle();
> -	else
> -		local_irq_enable();

For the record, it was pointless to enable the local irq here because it 
is handled by the cpuidle framework when exiting the idle state.

> +	x86_idle();
>   }
>
>   /*
>


-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog


WARNING: multiple messages have this Message-ID (diff)
From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Nicolas Pitre <nicolas.pitre@linaro.org>,
	Russell King <linux@arm.linux.org.uk>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mundt <lethal@linux-sh.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org,
	linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 8/9] X86: remove redundant cpuidle_idle_call()
Date: Mon, 27 Jan 2014 09:43:12 +0100	[thread overview]
Message-ID: <52E61C20.50804@linaro.org> (raw)
In-Reply-To: <1390802904-28399-9-git-send-email-nicolas.pitre@linaro.org>

On 01/27/2014 07:08 AM, Nicolas Pitre wrote:
> The core idle loop now takes care of it.
>
> Signed-off-by: Nicolas Pitre <nico@linaro.org>

Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>

> ---
>   arch/x86/kernel/process.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c
> index 3fb8d95ab8..4505e2a950 100644
> --- a/arch/x86/kernel/process.c
> +++ b/arch/x86/kernel/process.c
> @@ -298,10 +298,7 @@ void arch_cpu_idle_dead(void)
>    */
>   void arch_cpu_idle(void)
>   {
> -	if (cpuidle_idle_call())
> -		x86_idle();
> -	else
> -		local_irq_enable();

For the record, it was pointless to enable the local irq here because it 
is handled by the cpuidle framework when exiting the idle state.

> +	x86_idle();
>   }
>
>   /*
>


-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

WARNING: multiple messages have this Message-ID (diff)
From: daniel.lezcano@linaro.org (Daniel Lezcano)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 8/9] X86: remove redundant cpuidle_idle_call()
Date: Mon, 27 Jan 2014 09:43:12 +0100	[thread overview]
Message-ID: <52E61C20.50804@linaro.org> (raw)
In-Reply-To: <1390802904-28399-9-git-send-email-nicolas.pitre@linaro.org>

On 01/27/2014 07:08 AM, Nicolas Pitre wrote:
> The core idle loop now takes care of it.
>
> Signed-off-by: Nicolas Pitre <nico@linaro.org>

Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>

> ---
>   arch/x86/kernel/process.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c
> index 3fb8d95ab8..4505e2a950 100644
> --- a/arch/x86/kernel/process.c
> +++ b/arch/x86/kernel/process.c
> @@ -298,10 +298,7 @@ void arch_cpu_idle_dead(void)
>    */
>   void arch_cpu_idle(void)
>   {
> -	if (cpuidle_idle_call())
> -		x86_idle();
> -	else
> -		local_irq_enable();

For the record, it was pointless to enable the local irq here because it 
is handled by the cpuidle framework when exiting the idle state.

> +	x86_idle();
>   }
>
>   /*
>


-- 
  <http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

  reply	other threads:[~2014-01-27  8:43 UTC|newest]

Thread overview: 132+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-27  6:08 [PATCH 0/9] setting the table for integration of cpuidle with the scheduler Nicolas Pitre
2014-01-27  6:08 ` Nicolas Pitre
2014-01-27  6:08 ` Nicolas Pitre
2014-01-27  6:08 ` Nicolas Pitre
2014-01-27  6:08 ` [PATCH 1/9] ARM: get rid of arch_cpu_idle_prepare() Nicolas Pitre
2014-01-27  6:08   ` Nicolas Pitre
2014-01-27  6:08   ` Nicolas Pitre
2014-01-27  6:08   ` Nicolas Pitre
2014-01-27  8:22   ` Daniel Lezcano
2014-01-27  8:22     ` Daniel Lezcano
2014-01-27  8:22     ` Daniel Lezcano
2014-01-27  8:22     ` Daniel Lezcano
2014-01-27 16:07     ` Russell King - ARM Linux
2014-01-27 16:07       ` Russell King - ARM Linux
2014-01-27 16:07       ` Russell King - ARM Linux
2014-01-27 16:07       ` Russell King - ARM Linux
2014-01-27 17:12       ` Daniel Lezcano
2014-01-27 17:12         ` Daniel Lezcano
2014-01-27 17:12         ` Daniel Lezcano
2014-01-27 17:12         ` Daniel Lezcano
2014-01-27 17:21         ` Russell King - ARM Linux
2014-01-27 17:21           ` Russell King - ARM Linux
2014-01-27 17:21           ` Russell King - ARM Linux
2014-01-27 17:21           ` Russell King - ARM Linux
2014-01-27 17:30           ` Daniel Lezcano
2014-01-27 17:30             ` Daniel Lezcano
2014-01-27 17:30             ` Daniel Lezcano
2014-01-27 17:30             ` Daniel Lezcano
2014-01-27 17:35           ` Peter Zijlstra
2014-01-27 17:35             ` Peter Zijlstra
2014-01-27 17:35             ` Peter Zijlstra
2014-01-27 17:35             ` Peter Zijlstra
2014-01-27 17:35             ` Peter Zijlstra
2014-01-27 12:45   ` Russell King - ARM Linux
2014-01-27 12:45     ` Russell King - ARM Linux
2014-01-27 12:45     ` Russell King - ARM Linux
2014-01-27 12:45     ` Russell King - ARM Linux
2014-01-27 15:45     ` Nicolas Pitre
2014-01-27 15:45       ` Nicolas Pitre
2014-01-27 15:45       ` Nicolas Pitre
2014-01-27 15:45       ` Nicolas Pitre
2014-01-27 16:06       ` Russell King - ARM Linux
2014-01-27 16:06         ` Russell King - ARM Linux
2014-01-27 16:06         ` Russell King - ARM Linux
2014-01-27 16:06         ` Russell King - ARM Linux
2014-01-27 17:36         ` Nicolas Pitre
2014-01-27 17:36           ` Nicolas Pitre
2014-01-27 17:36           ` Nicolas Pitre
2014-01-27 17:36           ` Nicolas Pitre
2014-01-27  6:08 ` [PATCH 2/9] ARM64: " Nicolas Pitre
2014-01-27  6:08   ` Nicolas Pitre
2014-01-27  6:08   ` Nicolas Pitre
2014-01-27  6:08   ` Nicolas Pitre
2014-01-27  8:23   ` Daniel Lezcano
2014-01-27  8:23     ` Daniel Lezcano
2014-01-27  8:23     ` Daniel Lezcano
2014-01-27  8:23     ` Daniel Lezcano
2014-01-27 15:43   ` Catalin Marinas
2014-01-27 15:43     ` Catalin Marinas
2014-01-27 15:43     ` Catalin Marinas
2014-01-27 15:43     ` Catalin Marinas
2014-01-27 15:51     ` Nicolas Pitre
2014-01-27 15:51       ` Nicolas Pitre
2014-01-27 15:51       ` Nicolas Pitre
2014-01-27 15:51       ` Nicolas Pitre
2014-01-27 15:57       ` Catalin Marinas
2014-01-27 15:57         ` Catalin Marinas
2014-01-27 15:57         ` Catalin Marinas
2014-01-27 15:57         ` Catalin Marinas
2014-01-29 18:00         ` Nicolas Pitre
2014-01-30 11:36           ` Catalin Marinas
2014-01-27  6:08 ` [PATCH 3/9] idle: no more arch_cpu_idle_prepare() users Nicolas Pitre
2014-01-27  6:08   ` Nicolas Pitre
2014-01-27  6:08   ` Nicolas Pitre
2014-01-27  6:08   ` Nicolas Pitre
2014-01-27  8:24   ` Daniel Lezcano
2014-01-27  8:24     ` Daniel Lezcano
2014-01-27  8:24     ` Daniel Lezcano
2014-01-27  8:24     ` Daniel Lezcano
2014-01-27  6:08 ` [PATCH 4/9] idle: move the cpuidle entry point to the generic idle loop Nicolas Pitre
2014-01-27  6:08   ` Nicolas Pitre
2014-01-27  6:08   ` Nicolas Pitre
2014-01-27  6:08   ` Nicolas Pitre
2014-01-27  8:32   ` Daniel Lezcano
2014-01-27  8:32     ` Daniel Lezcano
2014-01-27  8:32     ` Daniel Lezcano
2014-01-27  8:32     ` Daniel Lezcano
2014-01-27  6:08 ` [PATCH 5/9] ARM: remove redundant cpuidle_idle_call() Nicolas Pitre
2014-01-27  6:08   ` Nicolas Pitre
2014-01-27  6:08   ` Nicolas Pitre
2014-01-27  6:08   ` Nicolas Pitre
2014-01-27  8:33   ` Daniel Lezcano
2014-01-27  8:33     ` Daniel Lezcano
2014-01-27  8:33     ` Daniel Lezcano
2014-01-27  8:33     ` Daniel Lezcano
2014-01-27  6:08 ` [PATCH 6/9] PPC: " Nicolas Pitre
2014-01-27  6:08   ` Nicolas Pitre
2014-01-27  6:08   ` Nicolas Pitre
2014-01-27  6:08   ` Nicolas Pitre
2014-01-27  8:35   ` Daniel Lezcano
2014-01-27  8:35     ` Daniel Lezcano
2014-01-27  8:35     ` Daniel Lezcano
2014-01-27  8:35     ` Daniel Lezcano
2014-01-27 11:59   ` Preeti U Murthy
2014-01-27 12:11     ` Preeti U Murthy
2014-01-27 11:59     ` Preeti U Murthy
2014-01-27 11:59     ` Preeti U Murthy
2014-01-27  6:08 ` [PATCH 7/9] SH: " Nicolas Pitre
2014-01-27  6:08   ` Nicolas Pitre
2014-01-27  6:08   ` Nicolas Pitre
2014-01-27  6:08   ` Nicolas Pitre
2014-01-27  8:35   ` Daniel Lezcano
2014-01-27  8:35     ` Daniel Lezcano
2014-01-27  8:35     ` Daniel Lezcano
2014-01-27  8:35     ` Daniel Lezcano
2014-01-27  6:08 ` [PATCH 8/9] X86: " Nicolas Pitre
2014-01-27  6:08   ` Nicolas Pitre
2014-01-27  6:08   ` Nicolas Pitre
2014-01-27  6:08   ` Nicolas Pitre
2014-01-27  8:43   ` Daniel Lezcano [this message]
2014-01-27  8:43     ` Daniel Lezcano
2014-01-27  8:43     ` Daniel Lezcano
2014-01-27  8:43     ` Daniel Lezcano
2014-01-27  6:08 ` [PATCH 9/9] cpu/idle.c: move to sched/idle.c Nicolas Pitre
2014-01-27  6:08   ` Nicolas Pitre
2014-01-27  6:08   ` Nicolas Pitre
2014-01-27  6:08   ` Nicolas Pitre
2014-01-27 12:47 ` [PATCH 0/9] setting the table for integration of cpuidle with the scheduler Peter Zijlstra
2014-01-27 12:47   ` Peter Zijlstra
2014-01-27 12:47   ` Peter Zijlstra
2014-01-27 12:47   ` Peter Zijlstra
2014-01-27 12:47   ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52E61C20.50804@linaro.org \
    --to=daniel.lezcano@linaro.org \
    --cc=benh@kernel.crashing.org \
    --cc=catalin.marinas@arm.com \
    --cc=lethal@linux-sh.org \
    --cc=linaro-kernel@lists.linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mingo@redhat.com \
    --cc=nicolas.pitre@linaro.org \
    --cc=peterz@infradead.org \
    --cc=rjw@rjwysocki.net \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.