All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tero Kristo <t-kristo@ti.com>
To: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>,
	Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	linux-kernel@vger.kernel.org, pali.rohar@gmail.com, pavel@ucw.cz,
	chf.fritz@googlemail.com, nm@ti.com
Subject: Re: [BISECTED] OMAP: DSS: clk rate mismatch
Date: Wed, 29 Jan 2014 11:10:30 +0200	[thread overview]
Message-ID: <52E8C586.7040907@ti.com> (raw)
In-Reply-To: <52E7F451.7040708@gmail.com>

On 01/28/2014 08:17 PM, Ivaylo Dimitrov wrote:
>
>
> On 28.01.2014 10:48, Tomi Valkeinen wrote:
>
>> I made a somewhat hacky quickfix for beagle. Applying that and the
>> clk-divider from the link above makes things work for me. However, as I
>> said, the issue with n900 might be different, but it'd be interesting to
>> hear if it has any effect.
>>
>>   Tomi
>>
>
> Applying those 2 patches doesn't help, still get exactly the same warning.
>
> Find attached my clk_summary (with my hacky patch applied, otherwise I
> cannot boot the device)
>
> Ivo

It looks like the omap36xx version of the omap96m_alwon_fck is modelled 
improperly in the dts files. I don't have access to omap36xx hardware 
myself, but give a try for the following patch:


From: Tero Kristo <t-kristo@ti.com>
Date: Wed, 29 Jan 2014 11:03:46 +0200
Subject: [PATCH] ARM: dts: omap36xx: fix omap96m_alwon_fck

OMAP36xx has different hardware implementation for the omap96m_alwon_fck
compared to other OMAP3 variants. Reflect this properly in the dts file.

Signed-off-by: Tero Kristo <t-kristo@ti.com>
---
  arch/arm/boot/dts/omap36xx-clocks.dtsi |    9 +++++++++
  1 file changed, 9 insertions(+)

diff --git a/arch/arm/boot/dts/omap36xx-clocks.dtsi 
b/arch/arm/boot/dts/omap36xx-clocks.dtsi
index 2fcf253..24ddf3f 100644
--- a/arch/arm/boot/dts/omap36xx-clocks.dtsi
+++ b/arch/arm/boot/dts/omap36xx-clocks.dtsi
@@ -88,3 +88,12 @@
  			 <&mcbsp4_ick>, <&uart4_fck>;
  	};
  };
+
+&omap_96m_alwon_fck {
+	compatible = "ti,divider-clock";
+	clocks = <&omap_192m_alwon_fck>;
+	ti,bit-shift = <12>;
+	ti,max-div = <2>;
+	reg = <0x0a40>;
+	ti,index-starts-at-one;
+};
-- 
1.7.9.5

WARNING: multiple messages have this Message-ID (diff)
From: Tero Kristo <t-kristo@ti.com>
To: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>,
	Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <pali.rohar@gmail.com>,
	<pavel@ucw.cz>, <chf.fritz@googlemail.com>, <nm@ti.com>
Subject: Re: [BISECTED] OMAP: DSS: clk rate mismatch
Date: Wed, 29 Jan 2014 11:10:30 +0200	[thread overview]
Message-ID: <52E8C586.7040907@ti.com> (raw)
In-Reply-To: <52E7F451.7040708@gmail.com>

On 01/28/2014 08:17 PM, Ivaylo Dimitrov wrote:
>
>
> On 28.01.2014 10:48, Tomi Valkeinen wrote:
>
>> I made a somewhat hacky quickfix for beagle. Applying that and the
>> clk-divider from the link above makes things work for me. However, as I
>> said, the issue with n900 might be different, but it'd be interesting to
>> hear if it has any effect.
>>
>>   Tomi
>>
>
> Applying those 2 patches doesn't help, still get exactly the same warning.
>
> Find attached my clk_summary (with my hacky patch applied, otherwise I
> cannot boot the device)
>
> Ivo

It looks like the omap36xx version of the omap96m_alwon_fck is modelled 
improperly in the dts files. I don't have access to omap36xx hardware 
myself, but give a try for the following patch:


From: Tero Kristo <t-kristo@ti.com>
Date: Wed, 29 Jan 2014 11:03:46 +0200
Subject: [PATCH] ARM: dts: omap36xx: fix omap96m_alwon_fck

OMAP36xx has different hardware implementation for the omap96m_alwon_fck
compared to other OMAP3 variants. Reflect this properly in the dts file.

Signed-off-by: Tero Kristo <t-kristo@ti.com>
---
  arch/arm/boot/dts/omap36xx-clocks.dtsi |    9 +++++++++
  1 file changed, 9 insertions(+)

diff --git a/arch/arm/boot/dts/omap36xx-clocks.dtsi 
b/arch/arm/boot/dts/omap36xx-clocks.dtsi
index 2fcf253..24ddf3f 100644
--- a/arch/arm/boot/dts/omap36xx-clocks.dtsi
+++ b/arch/arm/boot/dts/omap36xx-clocks.dtsi
@@ -88,3 +88,12 @@
  			 <&mcbsp4_ick>, <&uart4_fck>;
  	};
  };
+
+&omap_96m_alwon_fck {
+	compatible = "ti,divider-clock";
+	clocks = <&omap_192m_alwon_fck>;
+	ti,bit-shift = <12>;
+	ti,max-div = <2>;
+	reg = <0x0a40>;
+	ti,index-starts-at-one;
+};
-- 
1.7.9.5

  reply	other threads:[~2014-01-29  9:10 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-27 17:30 [BISECTED] OMAP: DSS: clk rate mismatch Ivaylo Dimitrov
2014-01-27 18:41 ` Christoph Fritz
2014-01-28  9:04   ` Tomi Valkeinen
2014-01-28  9:04     ` Tomi Valkeinen
2014-01-28  9:35     ` Christoph Fritz
2014-01-28  9:48       ` Tomi Valkeinen
2014-01-28  9:48         ` Tomi Valkeinen
2014-01-28 13:40         ` Tero Kristo
2014-01-28 13:40           ` Tero Kristo
2014-01-28 17:02           ` Christoph Fritz
2014-01-29 11:21             ` OMAP: clock DT conversion issues with omap36xx Christoph Fritz
2014-01-29 14:57               ` Tero Kristo
2014-01-29 14:57                 ` Tero Kristo
2014-02-01 18:55                 ` Christoph Fritz
2014-01-29 19:03               ` Nishanth Menon
2014-01-29 19:03                 ` Nishanth Menon
2014-02-01 18:52                 ` Christoph Fritz
2014-02-02 20:09                   ` Christoph Fritz
2014-02-04 15:50               ` Tero Kristo
2014-02-04 15:50                 ` Tero Kristo
2014-02-07 10:12                 ` Christoph Fritz
2014-02-07 13:49                   ` Tomi Valkeinen
2014-02-07 13:49                     ` Tomi Valkeinen
2014-02-10 20:54                     ` Christoph Fritz
2014-02-11 14:53                       ` Tomi Valkeinen
2014-02-11 14:53                         ` Tomi Valkeinen
2014-02-12 13:18                   ` Tomi Valkeinen
2014-02-12 13:18                     ` Tomi Valkeinen
2014-02-12 22:30                     ` Belisko Marek
2014-02-13  9:03                     ` Tomi Valkeinen
2014-02-13  9:03                       ` Tomi Valkeinen
2014-02-13 10:05                       ` Tomi Valkeinen
2014-02-13 10:05                         ` Tomi Valkeinen
2014-02-14  2:18                         ` Christoph Fritz
2014-01-28  7:50 ` [BISECTED] OMAP: DSS: clk rate mismatch Tomi Valkeinen
2014-01-28  7:50   ` Tomi Valkeinen
2014-01-28  8:48   ` Tomi Valkeinen
2014-01-28  8:48     ` Tomi Valkeinen
2014-01-28 18:17     ` Ivaylo Dimitrov
2014-01-29  9:10       ` Tero Kristo [this message]
2014-01-29  9:10         ` Tero Kristo
2014-01-29  9:29         ` Ivaylo Dimitrov
2014-01-29  9:38           ` Tomi Valkeinen
2014-01-29  9:38             ` Tomi Valkeinen
2014-01-29  9:50             ` Tero Kristo
2014-01-29  9:50               ` Tero Kristo
2014-01-29 11:30       ` Tomi Valkeinen
2014-01-29 11:30         ` Tomi Valkeinen
2014-01-29 18:52         ` Ivaylo Dimitrov
2014-01-30  6:04           ` Tomi Valkeinen
2014-01-30  6:04             ` Tomi Valkeinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52E8C586.7040907@ti.com \
    --to=t-kristo@ti.com \
    --cc=chf.fritz@googlemail.com \
    --cc=ivo.g.dimitrov.75@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=pali.rohar@gmail.com \
    --cc=pavel@ucw.cz \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.