From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Christoph Fritz <chf.fritz@googlemail.com>,
Tero Kristo <t-kristo@ti.com>
Cc: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
linux-kernel@vger.kernel.org, pali.rohar@gmail.com, pavel@ucw.cz,
Nishanth Menon <nm@ti.com>
Subject: Re: OMAP: clock DT conversion issues with omap36xx
Date: Thu, 13 Feb 2014 12:05:51 +0200 [thread overview]
Message-ID: <52FC98FF.20800@ti.com> (raw)
In-Reply-To: <52FC8A78.1050500@ti.com>
[-- Attachment #1: Type: text/plain, Size: 1055 bytes --]
On 13/02/14 11:03, Tomi Valkeinen wrote:
> On 12/02/14 15:18, Tomi Valkeinen wrote:
>
>> However, I hacked together the patch below, which "fixes" the issue for
>> 96m and dss fclk. It sets the clock parents so that the x2 clocks are
>> skipped, and makes the x2 clock nodes compatible with "unused", making
>> them effectively disappear. I only verified dss fclk, so Christoph, can
>> you verify the 96m clock?
>
> Aaand the hack patch I sent is crap... We can't skip the x2 clock path,
> as the dpll4_mNx2_ck clock nodes handle enable/disable bit, which is
> present on 3630 also.
>
> I think the best and simplest way to fix this is by setting the
> multiplier in the dpll4_mNx2_mul_ck nodes to 1. I don't know why I
> didn't think of it yesterday.
>
> I have a bunch of other patches needed to get the clocks right, so I'll
> send a series separately a bit later today.
I just sent the "OMAP: OMAP3 DSS related clock patches" series to l-o
and arm lists, which hopefully solves issues discussed in this thread.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Christoph Fritz <chf.fritz@googlemail.com>,
Tero Kristo <t-kristo@ti.com>
Cc: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <pali.rohar@gmail.com>,
<pavel@ucw.cz>, Nishanth Menon <nm@ti.com>
Subject: Re: OMAP: clock DT conversion issues with omap36xx
Date: Thu, 13 Feb 2014 12:05:51 +0200 [thread overview]
Message-ID: <52FC98FF.20800@ti.com> (raw)
In-Reply-To: <52FC8A78.1050500@ti.com>
[-- Attachment #1: Type: text/plain, Size: 1055 bytes --]
On 13/02/14 11:03, Tomi Valkeinen wrote:
> On 12/02/14 15:18, Tomi Valkeinen wrote:
>
>> However, I hacked together the patch below, which "fixes" the issue for
>> 96m and dss fclk. It sets the clock parents so that the x2 clocks are
>> skipped, and makes the x2 clock nodes compatible with "unused", making
>> them effectively disappear. I only verified dss fclk, so Christoph, can
>> you verify the 96m clock?
>
> Aaand the hack patch I sent is crap... We can't skip the x2 clock path,
> as the dpll4_mNx2_ck clock nodes handle enable/disable bit, which is
> present on 3630 also.
>
> I think the best and simplest way to fix this is by setting the
> multiplier in the dpll4_mNx2_mul_ck nodes to 1. I don't know why I
> didn't think of it yesterday.
>
> I have a bunch of other patches needed to get the clocks right, so I'll
> send a series separately a bit later today.
I just sent the "OMAP: OMAP3 DSS related clock patches" series to l-o
and arm lists, which hopefully solves issues discussed in this thread.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
next prev parent reply other threads:[~2014-02-13 10:05 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-27 17:30 [BISECTED] OMAP: DSS: clk rate mismatch Ivaylo Dimitrov
2014-01-27 18:41 ` Christoph Fritz
2014-01-28 9:04 ` Tomi Valkeinen
2014-01-28 9:04 ` Tomi Valkeinen
2014-01-28 9:35 ` Christoph Fritz
2014-01-28 9:48 ` Tomi Valkeinen
2014-01-28 9:48 ` Tomi Valkeinen
2014-01-28 13:40 ` Tero Kristo
2014-01-28 13:40 ` Tero Kristo
2014-01-28 17:02 ` Christoph Fritz
2014-01-29 11:21 ` OMAP: clock DT conversion issues with omap36xx Christoph Fritz
2014-01-29 14:57 ` Tero Kristo
2014-01-29 14:57 ` Tero Kristo
2014-02-01 18:55 ` Christoph Fritz
2014-01-29 19:03 ` Nishanth Menon
2014-01-29 19:03 ` Nishanth Menon
2014-02-01 18:52 ` Christoph Fritz
2014-02-02 20:09 ` Christoph Fritz
2014-02-04 15:50 ` Tero Kristo
2014-02-04 15:50 ` Tero Kristo
2014-02-07 10:12 ` Christoph Fritz
2014-02-07 13:49 ` Tomi Valkeinen
2014-02-07 13:49 ` Tomi Valkeinen
2014-02-10 20:54 ` Christoph Fritz
2014-02-11 14:53 ` Tomi Valkeinen
2014-02-11 14:53 ` Tomi Valkeinen
2014-02-12 13:18 ` Tomi Valkeinen
2014-02-12 13:18 ` Tomi Valkeinen
2014-02-12 22:30 ` Belisko Marek
2014-02-13 9:03 ` Tomi Valkeinen
2014-02-13 9:03 ` Tomi Valkeinen
2014-02-13 10:05 ` Tomi Valkeinen [this message]
2014-02-13 10:05 ` Tomi Valkeinen
2014-02-14 2:18 ` Christoph Fritz
2014-01-28 7:50 ` [BISECTED] OMAP: DSS: clk rate mismatch Tomi Valkeinen
2014-01-28 7:50 ` Tomi Valkeinen
2014-01-28 8:48 ` Tomi Valkeinen
2014-01-28 8:48 ` Tomi Valkeinen
2014-01-28 18:17 ` Ivaylo Dimitrov
2014-01-29 9:10 ` Tero Kristo
2014-01-29 9:10 ` Tero Kristo
2014-01-29 9:29 ` Ivaylo Dimitrov
2014-01-29 9:38 ` Tomi Valkeinen
2014-01-29 9:38 ` Tomi Valkeinen
2014-01-29 9:50 ` Tero Kristo
2014-01-29 9:50 ` Tero Kristo
2014-01-29 11:30 ` Tomi Valkeinen
2014-01-29 11:30 ` Tomi Valkeinen
2014-01-29 18:52 ` Ivaylo Dimitrov
2014-01-30 6:04 ` Tomi Valkeinen
2014-01-30 6:04 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52FC98FF.20800@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=chf.fritz@googlemail.com \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=pali.rohar@gmail.com \
--cc=pavel@ucw.cz \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.