From: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
To: "Andreas Färber" <afaerber@suse.de>
Cc: Peter Maydell <peter.maydell@linaro.org>,
qemu-devel@nongnu.org, Blue Swirl <blauwirbel@gmail.com>,
Bob Breuer <breuerr@mc.net>, Gerd Hoffmann <kraxel@redhat.com>,
Anthony Liguori <aliguori@amazon.com>,
Alon Levy <alevy@redhat.com>,
Artyom Tarasenko <atar4qemu@gmail.com>
Subject: Re: [Qemu-devel] [PATCHv2 2/2] sun4m: Add Sun CG3 framebuffer initialisation function
Date: Wed, 19 Feb 2014 21:23:26 +0000 [thread overview]
Message-ID: <530520CE.4060805@ilande.co.uk> (raw)
In-Reply-To: <530200F1.7050704@ilande.co.uk>
On 17/02/14 12:30, Mark Cave-Ayland wrote:
> On 09/02/14 15:32, Andreas Färber wrote:
>
>> IIUC SUNW,cgthree is an optional device, so it's not covered by my
>> qom-test. Please follow-up with a tests/cg3-test.c so that it gets
>> covered. Compare my recent PCI NIC series for how such a stub could look
>> like, in particular vmxnet3-test.c since this will be sparc-only.
>
> Okay - should this be a totally separate patch or appended to the end of
> this patchset?
So I tried this, and if I launch with -device cgthree then I get an
error about the device not being pluggable (which I'm guessing is
because the device is attached to sysbus).
Some further poking shows that several other of the -vga devices appear
to be marked as non-pluggable too, so I'm not sure this could work with
QOM tests based upon the current implementation.
ATB,
Mark.
prev parent reply other threads:[~2014-02-19 21:25 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-08 16:38 [Qemu-devel] [PATCHv2 0/2] sun4m: Implement Sun CG3 framebuffer for QEMU Mark Cave-Ayland
2014-02-08 16:38 ` [Qemu-devel] [PATCHv2 1/2] sun4m: Add Sun CG3 framebuffer and corresponding OpenBIOS FCode ROM Mark Cave-Ayland
2014-02-09 4:14 ` Peter Crosthwaite
2014-02-09 13:35 ` Mark Cave-Ayland
2014-02-14 14:54 ` Peter Crosthwaite
2014-02-17 12:50 ` Mark Cave-Ayland
2014-02-17 16:18 ` Bob Breuer
2014-02-09 14:41 ` Peter Maydell
2014-02-09 15:19 ` Mark Cave-Ayland
2014-02-09 15:33 ` Peter Maydell
2014-02-17 12:33 ` Mark Cave-Ayland
2014-02-09 15:10 ` Andreas Färber
2014-02-09 15:24 ` Mark Cave-Ayland
2014-02-09 15:39 ` Andreas Färber
2014-02-10 8:20 ` Paolo Bonzini
2014-02-17 12:43 ` Mark Cave-Ayland
2014-02-17 12:54 ` Paolo Bonzini
2014-02-08 16:38 ` [Qemu-devel] [PATCHv2 2/2] sun4m: Add Sun CG3 framebuffer initialisation function Mark Cave-Ayland
2014-02-09 15:32 ` Andreas Färber
2014-02-17 12:30 ` Mark Cave-Ayland
2014-02-19 21:23 ` Mark Cave-Ayland [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530520CE.4060805@ilande.co.uk \
--to=mark.cave-ayland@ilande.co.uk \
--cc=afaerber@suse.de \
--cc=alevy@redhat.com \
--cc=aliguori@amazon.com \
--cc=atar4qemu@gmail.com \
--cc=blauwirbel@gmail.com \
--cc=breuerr@mc.net \
--cc=kraxel@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.