From: Ben Greear <greearb@candelatech.com>
To: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH] ath10k: make TARGET_NUM_PEERS match WMI_MAX_KEY_INDEX.
Date: Wed, 26 Feb 2014 09:51:21 -0800 [thread overview]
Message-ID: <530E2999.6000901@candelatech.com> (raw)
In-Reply-To: <87r46plt07.fsf@kamboji.qca.qualcomm.com>
On 02/26/2014 08:48 AM, Kalle Valo wrote:
> greearb@candelatech.com writes:
>
>> From: Ben Greear <greearb@candelatech.com>
>>
>> This appears to fix the problem of running out of keys
>> in the firmware. Possibly it only hides the problem,
>> however.
>>
>> Signed-off-by: Ben Greear <greearb@candelatech.com>
>
> IIRC you asked me to drop this patch in other thread. I have now done
> that.
Yes, it breaks upstream firmware (looks like it asserts, but not sure exactly
why).
I still think it might be a problem, but it would take someone with newer
firmware source and/or better understanding of how the keys are supposed
to work to know for sure.
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Ben Greear <greearb@candelatech.com>
To: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ath10k: make TARGET_NUM_PEERS match WMI_MAX_KEY_INDEX.
Date: Wed, 26 Feb 2014 09:51:21 -0800 [thread overview]
Message-ID: <530E2999.6000901@candelatech.com> (raw)
In-Reply-To: <87r46plt07.fsf@kamboji.qca.qualcomm.com>
On 02/26/2014 08:48 AM, Kalle Valo wrote:
> greearb@candelatech.com writes:
>
>> From: Ben Greear <greearb@candelatech.com>
>>
>> This appears to fix the problem of running out of keys
>> in the firmware. Possibly it only hides the problem,
>> however.
>>
>> Signed-off-by: Ben Greear <greearb@candelatech.com>
>
> IIRC you asked me to drop this patch in other thread. I have now done
> that.
Yes, it breaks upstream firmware (looks like it asserts, but not sure exactly
why).
I still think it might be a problem, but it would take someone with newer
firmware source and/or better understanding of how the keys are supposed
to work to know for sure.
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2014-02-26 17:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-18 16:56 [PATCH] ath10k: make TARGET_NUM_PEERS match WMI_MAX_KEY_INDEX greearb
2014-02-18 16:56 ` greearb
2014-02-26 16:48 ` Kalle Valo
2014-02-26 16:48 ` Kalle Valo
2014-02-26 17:51 ` Ben Greear [this message]
2014-02-26 17:51 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530E2999.6000901@candelatech.com \
--to=greearb@candelatech.com \
--cc=ath10k@lists.infradead.org \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.