* [PATCH] ath10k: make TARGET_NUM_PEERS match WMI_MAX_KEY_INDEX.
@ 2014-02-18 16:56 ` greearb
0 siblings, 0 replies; 6+ messages in thread
From: greearb @ 2014-02-18 16:56 UTC (permalink / raw)
To: ath10k; +Cc: Ben Greear, linux-wireless
From: Ben Greear <greearb@candelatech.com>
This appears to fix the problem of running out of keys
in the firmware. Possibly it only hides the problem,
however.
Signed-off-by: Ben Greear <greearb@candelatech.com>
---
drivers/net/wireless/ath/ath10k/hw.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/hw.h b/drivers/net/wireless/ath/ath10k/hw.h
index 89167d5..dede8e0 100644
--- a/drivers/net/wireless/ath/ath10k/hw.h
+++ b/drivers/net/wireless/ath/ath10k/hw.h
@@ -83,7 +83,7 @@ enum ath10k_mcast2ucast_mode {
#define TARGET_NUM_PEERS 16
#define TARGET_NUM_OFFLOAD_PEERS 0
#define TARGET_NUM_OFFLOAD_REORDER_BUFS 0
-#define TARGET_NUM_PEER_KEYS 2
+#define TARGET_NUM_PEER_KEYS (WMI_MAX_KEY_INDEX + 1) /* 4 */
#define TARGET_NUM_TIDS (2 * ((TARGET_NUM_PEERS) + (TARGET_NUM_VDEVS)))
#define TARGET_TX_CHAIN_MASK (BIT(0) | BIT(1) | BIT(2))
#define TARGET_RX_CHAIN_MASK (BIT(0) | BIT(1) | BIT(2))
@@ -125,7 +125,7 @@ enum ath10k_mcast2ucast_mode {
#define TARGET_10X_NUM_OFFLOAD_PEERS 0
#define TARGET_10X_NUM_OFFLOAD_REORDER_BUFS 0
-#define TARGET_10X_NUM_PEER_KEYS 2
+#define TARGET_10X_NUM_PEER_KEYS (WMI_MAX_KEY_INDEX + 1) /* 4 */
#define TARGET_10X_NUM_TIDS 256
#define TARGET_10X_TX_CHAIN_MASK (BIT(0) | BIT(1) | BIT(2))
#define TARGET_10X_RX_CHAIN_MASK (BIT(0) | BIT(1) | BIT(2))
--
1.7.11.7
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] ath10k: make TARGET_NUM_PEERS match WMI_MAX_KEY_INDEX.
@ 2014-02-18 16:56 ` greearb
0 siblings, 0 replies; 6+ messages in thread
From: greearb @ 2014-02-18 16:56 UTC (permalink / raw)
To: ath10k; +Cc: linux-wireless, Ben Greear
From: Ben Greear <greearb@candelatech.com>
This appears to fix the problem of running out of keys
in the firmware. Possibly it only hides the problem,
however.
Signed-off-by: Ben Greear <greearb@candelatech.com>
---
drivers/net/wireless/ath/ath10k/hw.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/hw.h b/drivers/net/wireless/ath/ath10k/hw.h
index 89167d5..dede8e0 100644
--- a/drivers/net/wireless/ath/ath10k/hw.h
+++ b/drivers/net/wireless/ath/ath10k/hw.h
@@ -83,7 +83,7 @@ enum ath10k_mcast2ucast_mode {
#define TARGET_NUM_PEERS 16
#define TARGET_NUM_OFFLOAD_PEERS 0
#define TARGET_NUM_OFFLOAD_REORDER_BUFS 0
-#define TARGET_NUM_PEER_KEYS 2
+#define TARGET_NUM_PEER_KEYS (WMI_MAX_KEY_INDEX + 1) /* 4 */
#define TARGET_NUM_TIDS (2 * ((TARGET_NUM_PEERS) + (TARGET_NUM_VDEVS)))
#define TARGET_TX_CHAIN_MASK (BIT(0) | BIT(1) | BIT(2))
#define TARGET_RX_CHAIN_MASK (BIT(0) | BIT(1) | BIT(2))
@@ -125,7 +125,7 @@ enum ath10k_mcast2ucast_mode {
#define TARGET_10X_NUM_OFFLOAD_PEERS 0
#define TARGET_10X_NUM_OFFLOAD_REORDER_BUFS 0
-#define TARGET_10X_NUM_PEER_KEYS 2
+#define TARGET_10X_NUM_PEER_KEYS (WMI_MAX_KEY_INDEX + 1) /* 4 */
#define TARGET_10X_NUM_TIDS 256
#define TARGET_10X_TX_CHAIN_MASK (BIT(0) | BIT(1) | BIT(2))
#define TARGET_10X_RX_CHAIN_MASK (BIT(0) | BIT(1) | BIT(2))
--
1.7.11.7
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ath10k: make TARGET_NUM_PEERS match WMI_MAX_KEY_INDEX.
2014-02-18 16:56 ` greearb
@ 2014-02-26 16:48 ` Kalle Valo
-1 siblings, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2014-02-26 16:48 UTC (permalink / raw)
To: greearb; +Cc: linux-wireless, ath10k
greearb@candelatech.com writes:
> From: Ben Greear <greearb@candelatech.com>
>
> This appears to fix the problem of running out of keys
> in the firmware. Possibly it only hides the problem,
> however.
>
> Signed-off-by: Ben Greear <greearb@candelatech.com>
IIRC you asked me to drop this patch in other thread. I have now done
that.
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ath10k: make TARGET_NUM_PEERS match WMI_MAX_KEY_INDEX.
@ 2014-02-26 16:48 ` Kalle Valo
0 siblings, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2014-02-26 16:48 UTC (permalink / raw)
To: greearb; +Cc: ath10k, linux-wireless
greearb@candelatech.com writes:
> From: Ben Greear <greearb@candelatech.com>
>
> This appears to fix the problem of running out of keys
> in the firmware. Possibly it only hides the problem,
> however.
>
> Signed-off-by: Ben Greear <greearb@candelatech.com>
IIRC you asked me to drop this patch in other thread. I have now done
that.
--
Kalle Valo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ath10k: make TARGET_NUM_PEERS match WMI_MAX_KEY_INDEX.
2014-02-26 16:48 ` Kalle Valo
@ 2014-02-26 17:51 ` Ben Greear
-1 siblings, 0 replies; 6+ messages in thread
From: Ben Greear @ 2014-02-26 17:51 UTC (permalink / raw)
To: Kalle Valo; +Cc: linux-wireless, ath10k
On 02/26/2014 08:48 AM, Kalle Valo wrote:
> greearb@candelatech.com writes:
>
>> From: Ben Greear <greearb@candelatech.com>
>>
>> This appears to fix the problem of running out of keys
>> in the firmware. Possibly it only hides the problem,
>> however.
>>
>> Signed-off-by: Ben Greear <greearb@candelatech.com>
>
> IIRC you asked me to drop this patch in other thread. I have now done
> that.
Yes, it breaks upstream firmware (looks like it asserts, but not sure exactly
why).
I still think it might be a problem, but it would take someone with newer
firmware source and/or better understanding of how the keys are supposed
to work to know for sure.
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ath10k: make TARGET_NUM_PEERS match WMI_MAX_KEY_INDEX.
@ 2014-02-26 17:51 ` Ben Greear
0 siblings, 0 replies; 6+ messages in thread
From: Ben Greear @ 2014-02-26 17:51 UTC (permalink / raw)
To: Kalle Valo; +Cc: ath10k, linux-wireless
On 02/26/2014 08:48 AM, Kalle Valo wrote:
> greearb@candelatech.com writes:
>
>> From: Ben Greear <greearb@candelatech.com>
>>
>> This appears to fix the problem of running out of keys
>> in the firmware. Possibly it only hides the problem,
>> however.
>>
>> Signed-off-by: Ben Greear <greearb@candelatech.com>
>
> IIRC you asked me to drop this patch in other thread. I have now done
> that.
Yes, it breaks upstream firmware (looks like it asserts, but not sure exactly
why).
I still think it might be a problem, but it would take someone with newer
firmware source and/or better understanding of how the keys are supposed
to work to know for sure.
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-02-26 17:51 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-18 16:56 [PATCH] ath10k: make TARGET_NUM_PEERS match WMI_MAX_KEY_INDEX greearb
2014-02-18 16:56 ` greearb
2014-02-26 16:48 ` Kalle Valo
2014-02-26 16:48 ` Kalle Valo
2014-02-26 17:51 ` Ben Greear
2014-02-26 17:51 ` Ben Greear
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.