* [Qemu-devel] [PATCH] serial-pci: Set prog interface field of pci config to 16550 compatible
@ 2014-02-27 1:05 BALATON Zoltan
2014-03-10 18:40 ` BALATON Zoltan
0 siblings, 1 reply; 31+ messages in thread
From: BALATON Zoltan @ 2014-02-27 1:05 UTC (permalink / raw)
To: qemu-devel
Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
---
hw/char/serial-pci.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/char/serial-pci.c b/hw/char/serial-pci.c
index 991c99f..e662b77 100644
--- a/hw/char/serial-pci.c
+++ b/hw/char/serial-pci.c
@@ -60,6 +60,7 @@ static int serial_pci_init(PCIDevice *dev)
return -1;
}
+ pci->dev.config[PCI_CLASS_PROG] = 0x02; /* 16550 compatible */
pci->dev.config[PCI_INTERRUPT_PIN] = 0x01;
s->irq = pci_allocate_irq(&pci->dev);
--
1.8.1.5
^ permalink raw reply related [flat|nested] 31+ messages in thread* Re: [Qemu-trivial] [Qemu-devel] [PATCH] serial-pci: Set prog interface field of pci config to 16550 compatible
2014-02-27 1:05 [Qemu-devel] [PATCH] serial-pci: Set prog interface field of pci config to 16550 compatible BALATON Zoltan
@ 2014-03-10 18:40 ` BALATON Zoltan
0 siblings, 0 replies; 31+ messages in thread
From: BALATON Zoltan @ 2014-03-10 18:40 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial
Ping!
http://patchwork.ozlabs.org/patch/324674/
On Thu, 27 Feb 2014, BALATON Zoltan wrote:
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
> hw/char/serial-pci.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/char/serial-pci.c b/hw/char/serial-pci.c
> index 991c99f..e662b77 100644
> --- a/hw/char/serial-pci.c
> +++ b/hw/char/serial-pci.c
> @@ -60,6 +60,7 @@ static int serial_pci_init(PCIDevice *dev)
> return -1;
> }
>
> + pci->dev.config[PCI_CLASS_PROG] = 0x02; /* 16550 compatible */
> pci->dev.config[PCI_INTERRUPT_PIN] = 0x01;
> s->irq = pci_allocate_irq(&pci->dev);
>
> --
> 1.8.1.5
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [Qemu-devel] [PATCH] serial-pci: Set prog interface field of pci config to 16550 compatible
@ 2014-03-10 18:40 ` BALATON Zoltan
0 siblings, 0 replies; 31+ messages in thread
From: BALATON Zoltan @ 2014-03-10 18:40 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial
Ping!
http://patchwork.ozlabs.org/patch/324674/
On Thu, 27 Feb 2014, BALATON Zoltan wrote:
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
> hw/char/serial-pci.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/char/serial-pci.c b/hw/char/serial-pci.c
> index 991c99f..e662b77 100644
> --- a/hw/char/serial-pci.c
> +++ b/hw/char/serial-pci.c
> @@ -60,6 +60,7 @@ static int serial_pci_init(PCIDevice *dev)
> return -1;
> }
>
> + pci->dev.config[PCI_CLASS_PROG] = 0x02; /* 16550 compatible */
> pci->dev.config[PCI_INTERRUPT_PIN] = 0x01;
> s->irq = pci_allocate_irq(&pci->dev);
>
> --
> 1.8.1.5
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PATCH] serial-pci: Set prog interface field of pci config to 16550 compatible
2014-03-10 18:40 ` BALATON Zoltan
@ 2014-03-14 16:21 ` Michael Tokarev
-1 siblings, 0 replies; 31+ messages in thread
From: Michael Tokarev @ 2014-03-14 16:21 UTC (permalink / raw)
To: BALATON Zoltan; +Cc: qemu-trivial, qemu-devel
10.03.2014 22:40, BALATON Zoltan wrote:
> Ping!
> http://patchwork.ozlabs.org/patch/324674/
>
> On Thu, 27 Feb 2014, BALATON Zoltan wrote:
>> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
>> ---
>> hw/char/serial-pci.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/hw/char/serial-pci.c b/hw/char/serial-pci.c
>> index 991c99f..e662b77 100644
>> --- a/hw/char/serial-pci.c
>> +++ b/hw/char/serial-pci.c
>> @@ -60,6 +60,7 @@ static int serial_pci_init(PCIDevice *dev)
>> return -1;
>> }
>>
>> + pci->dev.config[PCI_CLASS_PROG] = 0x02; /* 16550 compatible */
>> pci->dev.config[PCI_INTERRUPT_PIN] = 0x01;
>> s->irq = pci_allocate_irq(&pci->dev);
Hm. While this is an one-liner indeed, I'm not sure it's the right
value. From my pci.ids:
C 07 Communication controller
00 Serial controller
00 8250
01 16450
02 16550
03 16650
04 16750
05 16850
06 16950
so it seems correct thing to do.
What about multi_serial_pci_init() -- should it too set prog-if
like this?
Thanks,
/mjt
^ permalink raw reply [flat|nested] 31+ messages in thread* Re: [Qemu-devel] [Qemu-trivial] [PATCH] serial-pci: Set prog interface field of pci config to 16550 compatible
@ 2014-03-14 16:21 ` Michael Tokarev
0 siblings, 0 replies; 31+ messages in thread
From: Michael Tokarev @ 2014-03-14 16:21 UTC (permalink / raw)
To: BALATON Zoltan; +Cc: qemu-trivial, qemu-devel
10.03.2014 22:40, BALATON Zoltan wrote:
> Ping!
> http://patchwork.ozlabs.org/patch/324674/
>
> On Thu, 27 Feb 2014, BALATON Zoltan wrote:
>> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
>> ---
>> hw/char/serial-pci.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/hw/char/serial-pci.c b/hw/char/serial-pci.c
>> index 991c99f..e662b77 100644
>> --- a/hw/char/serial-pci.c
>> +++ b/hw/char/serial-pci.c
>> @@ -60,6 +60,7 @@ static int serial_pci_init(PCIDevice *dev)
>> return -1;
>> }
>>
>> + pci->dev.config[PCI_CLASS_PROG] = 0x02; /* 16550 compatible */
>> pci->dev.config[PCI_INTERRUPT_PIN] = 0x01;
>> s->irq = pci_allocate_irq(&pci->dev);
Hm. While this is an one-liner indeed, I'm not sure it's the right
value. From my pci.ids:
C 07 Communication controller
00 Serial controller
00 8250
01 16450
02 16550
03 16650
04 16750
05 16850
06 16950
so it seems correct thing to do.
What about multi_serial_pci_init() -- should it too set prog-if
like this?
Thanks,
/mjt
^ permalink raw reply [flat|nested] 31+ messages in thread* Re: [Qemu-trivial] [Qemu-devel] [PATCH] serial-pci: Set prog interface field of pci config to 16550 compatible
2014-03-14 16:21 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
@ 2014-03-14 17:44 ` BALATON Zoltan
-1 siblings, 0 replies; 31+ messages in thread
From: BALATON Zoltan @ 2014-03-14 17:44 UTC (permalink / raw)
To: Michael Tokarev; +Cc: qemu-trivial, qemu-devel
On Fri, 14 Mar 2014, Michael Tokarev wrote:
> 10.03.2014 22:40, BALATON Zoltan wrote:
>> Ping!
>> http://patchwork.ozlabs.org/patch/324674/
>>
>> On Thu, 27 Feb 2014, BALATON Zoltan wrote:
>>> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
>>> ---
>>> hw/char/serial-pci.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/hw/char/serial-pci.c b/hw/char/serial-pci.c
>>> index 991c99f..e662b77 100644
>>> --- a/hw/char/serial-pci.c
>>> +++ b/hw/char/serial-pci.c
>>> @@ -60,6 +60,7 @@ static int serial_pci_init(PCIDevice *dev)
>>> return -1;
>>> }
>>>
>>> + pci->dev.config[PCI_CLASS_PROG] = 0x02; /* 16550 compatible */
>>> pci->dev.config[PCI_INTERRUPT_PIN] = 0x01;
>>> s->irq = pci_allocate_irq(&pci->dev);
>
> Hm. While this is an one-liner indeed, I'm not sure it's the right
> value. From my pci.ids:
>
> C 07 Communication controller
> 00 Serial controller
> 00 8250
> 01 16450
> 02 16550
> 03 16650
> 04 16750
> 05 16850
> 06 16950
>
> so it seems correct thing to do.
>
> What about multi_serial_pci_init() -- should it too set prog-if
> like this?
I'm not completely sure what the correct value should be for
multi_serial_pci_init so I've left that alone. There's also 07 02 00 that
means multiport serial controller that might apply for that case. For the
simple case I've sent the patch for I had a client expecting this value so
I think it is correct for that at least but I don't know about the
multiport case.
Regards,
BALATON Zoltan
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] serial-pci: Set prog interface field of pci config to 16550 compatible
@ 2014-03-14 17:44 ` BALATON Zoltan
0 siblings, 0 replies; 31+ messages in thread
From: BALATON Zoltan @ 2014-03-14 17:44 UTC (permalink / raw)
To: Michael Tokarev; +Cc: qemu-trivial, qemu-devel
On Fri, 14 Mar 2014, Michael Tokarev wrote:
> 10.03.2014 22:40, BALATON Zoltan wrote:
>> Ping!
>> http://patchwork.ozlabs.org/patch/324674/
>>
>> On Thu, 27 Feb 2014, BALATON Zoltan wrote:
>>> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
>>> ---
>>> hw/char/serial-pci.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/hw/char/serial-pci.c b/hw/char/serial-pci.c
>>> index 991c99f..e662b77 100644
>>> --- a/hw/char/serial-pci.c
>>> +++ b/hw/char/serial-pci.c
>>> @@ -60,6 +60,7 @@ static int serial_pci_init(PCIDevice *dev)
>>> return -1;
>>> }
>>>
>>> + pci->dev.config[PCI_CLASS_PROG] = 0x02; /* 16550 compatible */
>>> pci->dev.config[PCI_INTERRUPT_PIN] = 0x01;
>>> s->irq = pci_allocate_irq(&pci->dev);
>
> Hm. While this is an one-liner indeed, I'm not sure it's the right
> value. From my pci.ids:
>
> C 07 Communication controller
> 00 Serial controller
> 00 8250
> 01 16450
> 02 16550
> 03 16650
> 04 16750
> 05 16850
> 06 16950
>
> so it seems correct thing to do.
>
> What about multi_serial_pci_init() -- should it too set prog-if
> like this?
I'm not completely sure what the correct value should be for
multi_serial_pci_init so I've left that alone. There's also 07 02 00 that
means multiport serial controller that might apply for that case. For the
simple case I've sent the patch for I had a client expecting this value so
I think it is correct for that at least but I don't know about the
multiport case.
Regards,
BALATON Zoltan
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PATCH] serial-pci: Set prog interface field of pci config to 16550 compatible
2014-03-14 17:44 ` [Qemu-devel] [Qemu-trivial] " BALATON Zoltan
@ 2014-03-14 17:57 ` BALATON Zoltan
-1 siblings, 0 replies; 31+ messages in thread
From: BALATON Zoltan @ 2014-03-14 17:57 UTC (permalink / raw)
To: Michael Tokarev; +Cc: qemu-trivial, Gerd Hoffmann, qemu-devel
On Fri, 14 Mar 2014, BALATON Zoltan wrote:
> On Fri, 14 Mar 2014, Michael Tokarev wrote:
>> 10.03.2014 22:40, BALATON Zoltan wrote:
>>> Ping!
>>> http://patchwork.ozlabs.org/patch/324674/
>>>
>>> On Thu, 27 Feb 2014, BALATON Zoltan wrote:
>>>> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
>>>> ---
>>>> hw/char/serial-pci.c | 1 +
>>>> 1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/hw/char/serial-pci.c b/hw/char/serial-pci.c
>>>> index 991c99f..e662b77 100644
>>>> --- a/hw/char/serial-pci.c
>>>> +++ b/hw/char/serial-pci.c
>>>> @@ -60,6 +60,7 @@ static int serial_pci_init(PCIDevice *dev)
>>>> return -1;
>>>> }
>>>>
>>>> + pci->dev.config[PCI_CLASS_PROG] = 0x02; /* 16550 compatible */
>>>> pci->dev.config[PCI_INTERRUPT_PIN] = 0x01;
>>>> s->irq = pci_allocate_irq(&pci->dev);
>>
>> Hm. While this is an one-liner indeed, I'm not sure it's the right
>> value. From my pci.ids:
>>
>> C 07 Communication controller
>> 00 Serial controller
>> 00 8250
>> 01 16450
>> 02 16550
>> 03 16650
>> 04 16750
>> 05 16850
>> 06 16950
>>
>> so it seems correct thing to do.
>>
>> What about multi_serial_pci_init() -- should it too set prog-if
>> like this?
>
> I'm not completely sure what the correct value should be for
> multi_serial_pci_init so I've left that alone. There's also 07 02 00 that
> means multiport serial controller that might apply for that case. For the
> simple case I've sent the patch for I had a client expecting this value so I
> think it is correct for that at least but I don't know about the multiport
> case.
Also Gerd Hoffmann said he has picked this patch up so I'm adding him to
cc too.
> Regards,
> BALATON Zoltan
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] serial-pci: Set prog interface field of pci config to 16550 compatible
@ 2014-03-14 17:57 ` BALATON Zoltan
0 siblings, 0 replies; 31+ messages in thread
From: BALATON Zoltan @ 2014-03-14 17:57 UTC (permalink / raw)
To: Michael Tokarev; +Cc: qemu-trivial, Gerd Hoffmann, qemu-devel
On Fri, 14 Mar 2014, BALATON Zoltan wrote:
> On Fri, 14 Mar 2014, Michael Tokarev wrote:
>> 10.03.2014 22:40, BALATON Zoltan wrote:
>>> Ping!
>>> http://patchwork.ozlabs.org/patch/324674/
>>>
>>> On Thu, 27 Feb 2014, BALATON Zoltan wrote:
>>>> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
>>>> ---
>>>> hw/char/serial-pci.c | 1 +
>>>> 1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/hw/char/serial-pci.c b/hw/char/serial-pci.c
>>>> index 991c99f..e662b77 100644
>>>> --- a/hw/char/serial-pci.c
>>>> +++ b/hw/char/serial-pci.c
>>>> @@ -60,6 +60,7 @@ static int serial_pci_init(PCIDevice *dev)
>>>> return -1;
>>>> }
>>>>
>>>> + pci->dev.config[PCI_CLASS_PROG] = 0x02; /* 16550 compatible */
>>>> pci->dev.config[PCI_INTERRUPT_PIN] = 0x01;
>>>> s->irq = pci_allocate_irq(&pci->dev);
>>
>> Hm. While this is an one-liner indeed, I'm not sure it's the right
>> value. From my pci.ids:
>>
>> C 07 Communication controller
>> 00 Serial controller
>> 00 8250
>> 01 16450
>> 02 16550
>> 03 16650
>> 04 16750
>> 05 16850
>> 06 16950
>>
>> so it seems correct thing to do.
>>
>> What about multi_serial_pci_init() -- should it too set prog-if
>> like this?
>
> I'm not completely sure what the correct value should be for
> multi_serial_pci_init so I've left that alone. There's also 07 02 00 that
> means multiport serial controller that might apply for that case. For the
> simple case I've sent the patch for I had a client expecting this value so I
> think it is correct for that at least but I don't know about the multiport
> case.
Also Gerd Hoffmann said he has picked this patch up so I'm adding him to
cc too.
> Regards,
> BALATON Zoltan
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PATCH] serial-pci: Set prog interface field of pci config to 16550 compatible
2014-03-14 17:57 ` [Qemu-devel] [Qemu-trivial] " BALATON Zoltan
@ 2014-03-17 12:32 ` Gerd Hoffmann
-1 siblings, 0 replies; 31+ messages in thread
From: Gerd Hoffmann @ 2014-03-17 12:32 UTC (permalink / raw)
To: BALATON Zoltan; +Cc: qemu-trivial, Michael Tokarev, qemu-devel
> >> C 07 Communication controller
> >> 00 Serial controller
> >> 00 8250
> >> 01 16450
> >> 02 16550
> >> What about multi_serial_pci_init() -- should it too set prog-if
> >> like this?
> >
> > I'm not completely sure what the correct value should be for
> > multi_serial_pci_init so I've left that alone. There's also 07 02 00 that
> > means multiport serial controller that might apply for that case. For the
> > simple case I've sent the patch for I had a client expecting this value so I
> > think it is correct for that at least but I don't know about the multiport
> > case.
>
> Also Gerd Hoffmann said he has picked this patch up so I'm adding him to
> cc too.
The multiport variants are simply multiple 16550 chips mapped one after
the other. So "02" is better than "00".
I don't know what exactly the multiport serial controller is supposed to
be.
cheers,
Gerd
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] serial-pci: Set prog interface field of pci config to 16550 compatible
@ 2014-03-17 12:32 ` Gerd Hoffmann
0 siblings, 0 replies; 31+ messages in thread
From: Gerd Hoffmann @ 2014-03-17 12:32 UTC (permalink / raw)
To: BALATON Zoltan; +Cc: qemu-trivial, Michael Tokarev, qemu-devel
> >> C 07 Communication controller
> >> 00 Serial controller
> >> 00 8250
> >> 01 16450
> >> 02 16550
> >> What about multi_serial_pci_init() -- should it too set prog-if
> >> like this?
> >
> > I'm not completely sure what the correct value should be for
> > multi_serial_pci_init so I've left that alone. There's also 07 02 00 that
> > means multiport serial controller that might apply for that case. For the
> > simple case I've sent the patch for I had a client expecting this value so I
> > think it is correct for that at least but I don't know about the multiport
> > case.
>
> Also Gerd Hoffmann said he has picked this patch up so I'm adding him to
> cc too.
The multiport variants are simply multiple 16550 chips mapped one after
the other. So "02" is better than "00".
I don't know what exactly the multiport serial controller is supposed to
be.
cheers,
Gerd
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PATCH] serial-pci: Set prog interface field of pci config to 16550 compatible
2014-03-17 12:32 ` [Qemu-devel] [Qemu-trivial] " Gerd Hoffmann
@ 2014-03-20 9:58 ` BALATON Zoltan
-1 siblings, 0 replies; 31+ messages in thread
From: BALATON Zoltan @ 2014-03-20 9:58 UTC (permalink / raw)
To: Gerd Hoffmann; +Cc: qemu-trivial, Michael Tokarev, qemu-devel
On Mon, 17 Mar 2014, Gerd Hoffmann wrote:
>>>> C 07 Communication controller
>>>> 00 Serial controller
>>>> 00 8250
>>>> 01 16450
>>>> 02 16550
>
>>>> What about multi_serial_pci_init() -- should it too set prog-if
>>>> like this?
>>>
>>> I'm not completely sure what the correct value should be for
>>> multi_serial_pci_init so I've left that alone. There's also 07 02 00 that
>>> means multiport serial controller that might apply for that case. For the
>>> simple case I've sent the patch for I had a client expecting this value so I
>>> think it is correct for that at least but I don't know about the multiport
>>> case.
>>
>> Also Gerd Hoffmann said he has picked this patch up so I'm adding him to
>> cc too.
>
> The multiport variants are simply multiple 16550 chips mapped one after
> the other. So "02" is better than "00".
>
> I don't know what exactly the multiport serial controller is supposed to
> be.
So what should we do then? Should I send an updated patch which sets
070002 in the multiport case too?
Regards,
BALATON Zoltan
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] serial-pci: Set prog interface field of pci config to 16550 compatible
@ 2014-03-20 9:58 ` BALATON Zoltan
0 siblings, 0 replies; 31+ messages in thread
From: BALATON Zoltan @ 2014-03-20 9:58 UTC (permalink / raw)
To: Gerd Hoffmann; +Cc: qemu-trivial, Michael Tokarev, qemu-devel
On Mon, 17 Mar 2014, Gerd Hoffmann wrote:
>>>> C 07 Communication controller
>>>> 00 Serial controller
>>>> 00 8250
>>>> 01 16450
>>>> 02 16550
>
>>>> What about multi_serial_pci_init() -- should it too set prog-if
>>>> like this?
>>>
>>> I'm not completely sure what the correct value should be for
>>> multi_serial_pci_init so I've left that alone. There's also 07 02 00 that
>>> means multiport serial controller that might apply for that case. For the
>>> simple case I've sent the patch for I had a client expecting this value so I
>>> think it is correct for that at least but I don't know about the multiport
>>> case.
>>
>> Also Gerd Hoffmann said he has picked this patch up so I'm adding him to
>> cc too.
>
> The multiport variants are simply multiple 16550 chips mapped one after
> the other. So "02" is better than "00".
>
> I don't know what exactly the multiport serial controller is supposed to
> be.
So what should we do then? Should I send an updated patch which sets
070002 in the multiport case too?
Regards,
BALATON Zoltan
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PATCH] serial-pci: Set prog interface field of pci config to 16550 compatible
2014-03-20 9:58 ` [Qemu-devel] [Qemu-trivial] " BALATON Zoltan
@ 2014-03-21 8:43 ` Gerd Hoffmann
-1 siblings, 0 replies; 31+ messages in thread
From: Gerd Hoffmann @ 2014-03-21 8:43 UTC (permalink / raw)
To: BALATON Zoltan; +Cc: qemu-trivial, Michael Tokarev, qemu-devel
On Do, 2014-03-20 at 10:58 +0100, BALATON Zoltan wrote:
> So what should we do then? Should I send an updated patch which sets
> 070002 in the multiport case too?
Yes, that would be great.
cheers,
Gerd
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] serial-pci: Set prog interface field of pci config to 16550 compatible
@ 2014-03-21 8:43 ` Gerd Hoffmann
0 siblings, 0 replies; 31+ messages in thread
From: Gerd Hoffmann @ 2014-03-21 8:43 UTC (permalink / raw)
To: BALATON Zoltan; +Cc: qemu-trivial, Michael Tokarev, qemu-devel
On Do, 2014-03-20 at 10:58 +0100, BALATON Zoltan wrote:
> So what should we do then? Should I send an updated patch which sets
> 070002 in the multiport case too?
Yes, that would be great.
cheers,
Gerd
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PATCH] serial-pci: Set prog interface field of pci config to 16550 compatible
2014-03-21 8:43 ` [Qemu-devel] [Qemu-trivial] " Gerd Hoffmann
@ 2014-03-21 9:10 ` BALATON Zoltan
-1 siblings, 0 replies; 31+ messages in thread
From: BALATON Zoltan @ 2014-03-21 9:10 UTC (permalink / raw)
To: Gerd Hoffmann; +Cc: qemu-trivial, Paolo Bonzini, Michael Tokarev, qemu-devel
On Fri, 21 Mar 2014, Gerd Hoffmann wrote:
> On Do, 2014-03-20 at 10:58 +0100, BALATON Zoltan wrote:
>> So what should we do then? Should I send an updated patch which sets
>> 070002 in the multiport case too?
>
> Yes, that would be great.
OK, I'll resubmit it after pc-2.1 is added also with the multiport case.
Thank you,
BALATON Zoltan
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] serial-pci: Set prog interface field of pci config to 16550 compatible
@ 2014-03-21 9:10 ` BALATON Zoltan
0 siblings, 0 replies; 31+ messages in thread
From: BALATON Zoltan @ 2014-03-21 9:10 UTC (permalink / raw)
To: Gerd Hoffmann; +Cc: qemu-trivial, Paolo Bonzini, Michael Tokarev, qemu-devel
On Fri, 21 Mar 2014, Gerd Hoffmann wrote:
> On Do, 2014-03-20 at 10:58 +0100, BALATON Zoltan wrote:
>> So what should we do then? Should I send an updated patch which sets
>> 070002 in the multiport case too?
>
> Yes, that would be great.
OK, I'll resubmit it after pc-2.1 is added also with the multiport case.
Thank you,
BALATON Zoltan
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PATCH] serial-pci: Set prog interface field of pci config to 16550 compatible
2014-03-10 18:40 ` BALATON Zoltan
@ 2014-03-20 15:42 ` Michael Tokarev
-1 siblings, 0 replies; 31+ messages in thread
From: Michael Tokarev @ 2014-03-20 15:42 UTC (permalink / raw)
To: BALATON Zoltan; +Cc: qemu-trivial, qemu-devel
10.03.2014 22:40, BALATON Zoltan wrote:
> Ping!
> http://patchwork.ozlabs.org/patch/324674/
Thanks, applied to -trivial.
/mjt
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] serial-pci: Set prog interface field of pci config to 16550 compatible
@ 2014-03-20 15:42 ` Michael Tokarev
0 siblings, 0 replies; 31+ messages in thread
From: Michael Tokarev @ 2014-03-20 15:42 UTC (permalink / raw)
To: BALATON Zoltan; +Cc: qemu-trivial, qemu-devel
10.03.2014 22:40, BALATON Zoltan wrote:
> Ping!
> http://patchwork.ozlabs.org/patch/324674/
Thanks, applied to -trivial.
/mjt
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [Qemu-trivial] [PATCH] serial-pci: Set prog interface field of pci config to 16550 compatible
2014-03-20 15:42 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
@ 2014-03-20 15:51 ` Paolo Bonzini
-1 siblings, 0 replies; 31+ messages in thread
From: Paolo Bonzini @ 2014-03-20 15:51 UTC (permalink / raw)
To: Michael Tokarev, BALATON Zoltan; +Cc: qemu-trivial, qemu-devel
Il 20/03/2014 16:42, Michael Tokarev ha scritto:
> 10.03.2014 22:40, BALATON Zoltan wrote:
>> Ping!
>> http://patchwork.ozlabs.org/patch/324674/
>
> Thanks, applied to -trivial.
No, please don't; this needs to be done for new machine types only.
Paolo
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] serial-pci: Set prog interface field of pci config to 16550 compatible
@ 2014-03-20 15:51 ` Paolo Bonzini
0 siblings, 0 replies; 31+ messages in thread
From: Paolo Bonzini @ 2014-03-20 15:51 UTC (permalink / raw)
To: Michael Tokarev, BALATON Zoltan; +Cc: qemu-trivial, qemu-devel
Il 20/03/2014 16:42, Michael Tokarev ha scritto:
> 10.03.2014 22:40, BALATON Zoltan wrote:
>> Ping!
>> http://patchwork.ozlabs.org/patch/324674/
>
> Thanks, applied to -trivial.
No, please don't; this needs to be done for new machine types only.
Paolo
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [Qemu-trivial] [PATCH] serial-pci: Set prog interface field of pci config to 16550 compatible
2014-03-20 15:51 ` [Qemu-devel] " Paolo Bonzini
@ 2014-03-20 16:01 ` BALATON Zoltan
-1 siblings, 0 replies; 31+ messages in thread
From: BALATON Zoltan @ 2014-03-20 16:01 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: qemu-trivial, Michael Tokarev, qemu-devel
On Thu, 20 Mar 2014, Paolo Bonzini wrote:
> Il 20/03/2014 16:42, Michael Tokarev ha scritto:
>> 10.03.2014 22:40, BALATON Zoltan wrote:
>>> Ping!
>>> http://patchwork.ozlabs.org/patch/324674/
>>
>> Thanks, applied to -trivial.
>
> No, please don't; this needs to be done for new machine types only.
Why? I tried running a Windows XP image that was set up before this patch
and it did not complain about changed hardware. Or is there another reason
I'm missing?
Regards,
BALATON Zoltan
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] serial-pci: Set prog interface field of pci config to 16550 compatible
@ 2014-03-20 16:01 ` BALATON Zoltan
0 siblings, 0 replies; 31+ messages in thread
From: BALATON Zoltan @ 2014-03-20 16:01 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: qemu-trivial, Michael Tokarev, qemu-devel
On Thu, 20 Mar 2014, Paolo Bonzini wrote:
> Il 20/03/2014 16:42, Michael Tokarev ha scritto:
>> 10.03.2014 22:40, BALATON Zoltan wrote:
>>> Ping!
>>> http://patchwork.ozlabs.org/patch/324674/
>>
>> Thanks, applied to -trivial.
>
> No, please don't; this needs to be done for new machine types only.
Why? I tried running a Windows XP image that was set up before this patch
and it did not complain about changed hardware. Or is there another reason
I'm missing?
Regards,
BALATON Zoltan
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [Qemu-trivial] [PATCH] serial-pci: Set prog interface field of pci config to 16550 compatible
2014-03-20 16:01 ` [Qemu-devel] " BALATON Zoltan
@ 2014-03-20 16:32 ` Paolo Bonzini
-1 siblings, 0 replies; 31+ messages in thread
From: Paolo Bonzini @ 2014-03-20 16:32 UTC (permalink / raw)
To: BALATON Zoltan; +Cc: qemu-trivial, Michael Tokarev, qemu-devel
Il 20/03/2014 17:01, BALATON Zoltan ha scritto:
> On Thu, 20 Mar 2014, Paolo Bonzini wrote:
>> Il 20/03/2014 16:42, Michael Tokarev ha scritto:
>>> 10.03.2014 22:40, BALATON Zoltan wrote:
>>>> Ping!
>>>> http://patchwork.ozlabs.org/patch/324674/
>>>
>>> Thanks, applied to -trivial.
>>
>> No, please don't; this needs to be done for new machine types only.
>
> Why? I tried running a Windows XP image that was set up before this
> patch and it did not complain about changed hardware. Or is there
> another reason I'm missing?
Classes (or anything guest-visible in fact) must never ever be changed
for the same machine type. It's a rule.
Paolo
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] serial-pci: Set prog interface field of pci config to 16550 compatible
@ 2014-03-20 16:32 ` Paolo Bonzini
0 siblings, 0 replies; 31+ messages in thread
From: Paolo Bonzini @ 2014-03-20 16:32 UTC (permalink / raw)
To: BALATON Zoltan; +Cc: qemu-trivial, Michael Tokarev, qemu-devel
Il 20/03/2014 17:01, BALATON Zoltan ha scritto:
> On Thu, 20 Mar 2014, Paolo Bonzini wrote:
>> Il 20/03/2014 16:42, Michael Tokarev ha scritto:
>>> 10.03.2014 22:40, BALATON Zoltan wrote:
>>>> Ping!
>>>> http://patchwork.ozlabs.org/patch/324674/
>>>
>>> Thanks, applied to -trivial.
>>
>> No, please don't; this needs to be done for new machine types only.
>
> Why? I tried running a Windows XP image that was set up before this
> patch and it did not complain about changed hardware. Or is there
> another reason I'm missing?
Classes (or anything guest-visible in fact) must never ever be changed
for the same machine type. It's a rule.
Paolo
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [Qemu-trivial] [PATCH] serial-pci: Set prog interface field of pci config to 16550 compatible
2014-03-20 16:32 ` [Qemu-devel] " Paolo Bonzini
@ 2014-03-20 16:58 ` BALATON Zoltan
-1 siblings, 0 replies; 31+ messages in thread
From: BALATON Zoltan @ 2014-03-20 16:58 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: qemu-trivial, Michael Tokarev, qemu-devel
On Thu, 20 Mar 2014, Paolo Bonzini wrote:
> Il 20/03/2014 17:01, BALATON Zoltan ha scritto:
>> On Thu, 20 Mar 2014, Paolo Bonzini wrote:
>>> Il 20/03/2014 16:42, Michael Tokarev ha scritto:
>>>> 10.03.2014 22:40, BALATON Zoltan wrote:
>>>>> Ping!
>>>>> http://patchwork.ozlabs.org/patch/324674/
>>>>
>>>> Thanks, applied to -trivial.
>>>
>>> No, please don't; this needs to be done for new machine types only.
>>
>> Why? I tried running a Windows XP image that was set up before this
>> patch and it did not complain about changed hardware. Or is there
>> another reason I'm missing?
>
> Classes (or anything guest-visible in fact) must never ever be changed for
> the same machine type. It's a rule.
The class did not change only the prog interface field after it (which is
guest visible but I think most guests just ignore it). So then what's the
correct way to do it? Do I need to change the patch or can it be merged as
it is the next time a new machine type is added?
Regards,
BALATON Zoltan
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] serial-pci: Set prog interface field of pci config to 16550 compatible
@ 2014-03-20 16:58 ` BALATON Zoltan
0 siblings, 0 replies; 31+ messages in thread
From: BALATON Zoltan @ 2014-03-20 16:58 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: qemu-trivial, Michael Tokarev, qemu-devel
On Thu, 20 Mar 2014, Paolo Bonzini wrote:
> Il 20/03/2014 17:01, BALATON Zoltan ha scritto:
>> On Thu, 20 Mar 2014, Paolo Bonzini wrote:
>>> Il 20/03/2014 16:42, Michael Tokarev ha scritto:
>>>> 10.03.2014 22:40, BALATON Zoltan wrote:
>>>>> Ping!
>>>>> http://patchwork.ozlabs.org/patch/324674/
>>>>
>>>> Thanks, applied to -trivial.
>>>
>>> No, please don't; this needs to be done for new machine types only.
>>
>> Why? I tried running a Windows XP image that was set up before this
>> patch and it did not complain about changed hardware. Or is there
>> another reason I'm missing?
>
> Classes (or anything guest-visible in fact) must never ever be changed for
> the same machine type. It's a rule.
The class did not change only the prog interface field after it (which is
guest visible but I think most guests just ignore it). So then what's the
correct way to do it? Do I need to change the patch or can it be merged as
it is the next time a new machine type is added?
Regards,
BALATON Zoltan
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [Qemu-trivial] [PATCH] serial-pci: Set prog interface field of pci config to 16550 compatible
2014-03-20 16:58 ` [Qemu-devel] " BALATON Zoltan
@ 2014-03-20 17:35 ` Paolo Bonzini
-1 siblings, 0 replies; 31+ messages in thread
From: Paolo Bonzini @ 2014-03-20 17:35 UTC (permalink / raw)
To: BALATON Zoltan; +Cc: qemu-trivial, Michael Tokarev, qemu-devel
Il 20/03/2014 17:58, BALATON Zoltan ha scritto:
>>
>> Classes (or anything guest-visible in fact) must never ever be changed
>> for the same machine type. It's a rule.
>
> The class did not change only the prog interface field after it (which
> is guest visible but I think most guests just ignore it). So then what's
> the correct way to do it? Do I need to change the patch or can it be
> merged as it is the next time a new machine type is added?
You can wait for the 2.1 machine type to be added.
Paolo
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] serial-pci: Set prog interface field of pci config to 16550 compatible
@ 2014-03-20 17:35 ` Paolo Bonzini
0 siblings, 0 replies; 31+ messages in thread
From: Paolo Bonzini @ 2014-03-20 17:35 UTC (permalink / raw)
To: BALATON Zoltan; +Cc: qemu-trivial, Michael Tokarev, qemu-devel
Il 20/03/2014 17:58, BALATON Zoltan ha scritto:
>>
>> Classes (or anything guest-visible in fact) must never ever be changed
>> for the same machine type. It's a rule.
>
> The class did not change only the prog interface field after it (which
> is guest visible but I think most guests just ignore it). So then what's
> the correct way to do it? Do I need to change the patch or can it be
> merged as it is the next time a new machine type is added?
You can wait for the 2.1 machine type to be added.
Paolo
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [Qemu-trivial] [PATCH] serial-pci: Set prog interface field of pci config to 16550 compatible
2014-03-20 15:51 ` [Qemu-devel] " Paolo Bonzini
@ 2014-03-21 8:19 ` Michael Tokarev
-1 siblings, 0 replies; 31+ messages in thread
From: Michael Tokarev @ 2014-03-21 8:19 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: qemu-trivial, qemu-devel, BALATON Zoltan
20.03.2014 19:51, Paolo Bonzini wrote:
> Il 20/03/2014 16:42, Michael Tokarev ha scritto:
>> 10.03.2014 22:40, BALATON Zoltan wrote:
>>> Ping!
>>> http://patchwork.ozlabs.org/patch/324674/
>>
>> Thanks, applied to -trivial.
>
> No, please don't; this needs to be done for new machine types only.
I thought about this too, but decided this is too minor a difference
to warrant special per-machine-type handling. Oh well.
/mjt
^ permalink raw reply [flat|nested] 31+ messages in thread
end of thread, other threads:[~2014-03-21 9:11 UTC | newest]
Thread overview: 31+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-27 1:05 [Qemu-devel] [PATCH] serial-pci: Set prog interface field of pci config to 16550 compatible BALATON Zoltan
2014-03-10 18:40 ` [Qemu-trivial] " BALATON Zoltan
2014-03-10 18:40 ` BALATON Zoltan
2014-03-14 16:21 ` [Qemu-trivial] " Michael Tokarev
2014-03-14 16:21 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2014-03-14 17:44 ` [Qemu-trivial] [Qemu-devel] " BALATON Zoltan
2014-03-14 17:44 ` [Qemu-devel] [Qemu-trivial] " BALATON Zoltan
2014-03-14 17:57 ` [Qemu-trivial] [Qemu-devel] " BALATON Zoltan
2014-03-14 17:57 ` [Qemu-devel] [Qemu-trivial] " BALATON Zoltan
2014-03-17 12:32 ` [Qemu-trivial] [Qemu-devel] " Gerd Hoffmann
2014-03-17 12:32 ` [Qemu-devel] [Qemu-trivial] " Gerd Hoffmann
2014-03-20 9:58 ` [Qemu-trivial] [Qemu-devel] " BALATON Zoltan
2014-03-20 9:58 ` [Qemu-devel] [Qemu-trivial] " BALATON Zoltan
2014-03-21 8:43 ` [Qemu-trivial] [Qemu-devel] " Gerd Hoffmann
2014-03-21 8:43 ` [Qemu-devel] [Qemu-trivial] " Gerd Hoffmann
2014-03-21 9:10 ` [Qemu-trivial] [Qemu-devel] " BALATON Zoltan
2014-03-21 9:10 ` [Qemu-devel] [Qemu-trivial] " BALATON Zoltan
2014-03-20 15:42 ` [Qemu-trivial] [Qemu-devel] " Michael Tokarev
2014-03-20 15:42 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2014-03-20 15:51 ` Paolo Bonzini
2014-03-20 15:51 ` [Qemu-devel] " Paolo Bonzini
2014-03-20 16:01 ` BALATON Zoltan
2014-03-20 16:01 ` [Qemu-devel] " BALATON Zoltan
2014-03-20 16:32 ` Paolo Bonzini
2014-03-20 16:32 ` [Qemu-devel] " Paolo Bonzini
2014-03-20 16:58 ` BALATON Zoltan
2014-03-20 16:58 ` [Qemu-devel] " BALATON Zoltan
2014-03-20 17:35 ` Paolo Bonzini
2014-03-20 17:35 ` [Qemu-devel] " Paolo Bonzini
2014-03-21 8:19 ` Michael Tokarev
2014-03-21 8:19 ` [Qemu-devel] " Michael Tokarev
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.