* Re: [PATCH v2] mtd: davinci-nand: disable subpage write for keystone-nand
@ 2014-03-20 20:14 ` Santosh Shilimkar
0 siblings, 0 replies; 32+ messages in thread
From: Santosh Shilimkar @ 2014-03-20 20:14 UTC (permalink / raw)
To: Ivan Khoronzhuk, dwmw2, computersforpeace, galak
Cc: robh+dt, pawel.moll, mark.rutland, ijc+devicetree, rob, linux,
grygorii.strashko, devicetree, linux-kernel, linux-arm-kernel,
linux-mtd, m-karicheri2, Warner Losh
On Thursday 20 March 2014 04:08 PM, Ivan Khoronzhuk wrote:
> From: Murali Karicheri <m-karicheri2@ti.com>
>
> Sub page write doesn't work because of hw issue in controller found on
> Keystone SOCs. AEMIF controller is also used on DaVinci SOCs which
> don't seems to have any issue. So add "ti,keysone-nand" compatible
> to nand driver in order to set NAND_NO_SUBPAGE_WRITE option.
>
> Cc: Brian Norris <computersforpeace@gmail.com>
> Cc: Warner Losh <imp@bsdimp.com>
> Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
>
> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@ti.com>
> ---
>
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
> This patch is a result of discussion on patch v1:
> https://lkml.org/lkml/2014/3/20/461
>
> drivers/mtd/nand/davinci_nand.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/mtd/nand/davinci_nand.c b/drivers/mtd/nand/davinci_nand.c
> index 4615d79..b922c8e 100644
> --- a/drivers/mtd/nand/davinci_nand.c
> +++ b/drivers/mtd/nand/davinci_nand.c
> @@ -523,6 +523,7 @@ static struct nand_ecclayout hwecc4_2048 = {
> #if defined(CONFIG_OF)
> static const struct of_device_id davinci_nand_of_match[] = {
> {.compatible = "ti,davinci-nand", },
> + {.compatible = "ti,keystone-nand", },
> {},
> };
> MODULE_DEVICE_TABLE(of, davinci_nand_of_match);
> @@ -581,6 +582,11 @@ static struct davinci_nand_pdata
> of_property_read_bool(pdev->dev.of_node,
> "ti,davinci-nand-use-bbt"))
> pdata->bbt_options = NAND_BBT_USE_FLASH;
> +
> + if (of_device_is_compatible(pdev->dev.of_node,
> + "ti,keystone-nand")) {
> + pdata->options |= NAND_NO_SUBPAGE_WRITE;
> + }
> }
>
> return dev_get_platdata(&pdev->dev);
>
^ permalink raw reply [flat|nested] 32+ messages in thread* Re: [PATCH v2] mtd: davinci-nand: disable subpage write for keystone-nand
@ 2014-03-20 20:14 ` Santosh Shilimkar
0 siblings, 0 replies; 32+ messages in thread
From: Santosh Shilimkar @ 2014-03-20 20:14 UTC (permalink / raw)
To: Ivan Khoronzhuk, dwmw2, computersforpeace, galak
Cc: mark.rutland, devicetree, grygorii.strashko, linux, pawel.moll,
ijc+devicetree, linux-kernel, robh+dt, linux-mtd, m-karicheri2,
rob, Warner Losh, linux-arm-kernel
On Thursday 20 March 2014 04:08 PM, Ivan Khoronzhuk wrote:
> From: Murali Karicheri <m-karicheri2@ti.com>
>
> Sub page write doesn't work because of hw issue in controller found on
> Keystone SOCs. AEMIF controller is also used on DaVinci SOCs which
> don't seems to have any issue. So add "ti,keysone-nand" compatible
> to nand driver in order to set NAND_NO_SUBPAGE_WRITE option.
>
> Cc: Brian Norris <computersforpeace@gmail.com>
> Cc: Warner Losh <imp@bsdimp.com>
> Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
>
> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@ti.com>
> ---
>
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
> This patch is a result of discussion on patch v1:
> https://lkml.org/lkml/2014/3/20/461
>
> drivers/mtd/nand/davinci_nand.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/mtd/nand/davinci_nand.c b/drivers/mtd/nand/davinci_nand.c
> index 4615d79..b922c8e 100644
> --- a/drivers/mtd/nand/davinci_nand.c
> +++ b/drivers/mtd/nand/davinci_nand.c
> @@ -523,6 +523,7 @@ static struct nand_ecclayout hwecc4_2048 = {
> #if defined(CONFIG_OF)
> static const struct of_device_id davinci_nand_of_match[] = {
> {.compatible = "ti,davinci-nand", },
> + {.compatible = "ti,keystone-nand", },
> {},
> };
> MODULE_DEVICE_TABLE(of, davinci_nand_of_match);
> @@ -581,6 +582,11 @@ static struct davinci_nand_pdata
> of_property_read_bool(pdev->dev.of_node,
> "ti,davinci-nand-use-bbt"))
> pdata->bbt_options = NAND_BBT_USE_FLASH;
> +
> + if (of_device_is_compatible(pdev->dev.of_node,
> + "ti,keystone-nand")) {
> + pdata->options |= NAND_NO_SUBPAGE_WRITE;
> + }
> }
>
> return dev_get_platdata(&pdev->dev);
>
^ permalink raw reply [flat|nested] 32+ messages in thread* [PATCH v2] mtd: davinci-nand: disable subpage write for keystone-nand
@ 2014-03-20 20:14 ` Santosh Shilimkar
0 siblings, 0 replies; 32+ messages in thread
From: Santosh Shilimkar @ 2014-03-20 20:14 UTC (permalink / raw)
To: linux-arm-kernel
On Thursday 20 March 2014 04:08 PM, Ivan Khoronzhuk wrote:
> From: Murali Karicheri <m-karicheri2@ti.com>
>
> Sub page write doesn't work because of hw issue in controller found on
> Keystone SOCs. AEMIF controller is also used on DaVinci SOCs which
> don't seems to have any issue. So add "ti,keysone-nand" compatible
> to nand driver in order to set NAND_NO_SUBPAGE_WRITE option.
>
> Cc: Brian Norris <computersforpeace@gmail.com>
> Cc: Warner Losh <imp@bsdimp.com>
> Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
>
> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@ti.com>
> ---
>
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
> This patch is a result of discussion on patch v1:
> https://lkml.org/lkml/2014/3/20/461
>
> drivers/mtd/nand/davinci_nand.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/mtd/nand/davinci_nand.c b/drivers/mtd/nand/davinci_nand.c
> index 4615d79..b922c8e 100644
> --- a/drivers/mtd/nand/davinci_nand.c
> +++ b/drivers/mtd/nand/davinci_nand.c
> @@ -523,6 +523,7 @@ static struct nand_ecclayout hwecc4_2048 = {
> #if defined(CONFIG_OF)
> static const struct of_device_id davinci_nand_of_match[] = {
> {.compatible = "ti,davinci-nand", },
> + {.compatible = "ti,keystone-nand", },
> {},
> };
> MODULE_DEVICE_TABLE(of, davinci_nand_of_match);
> @@ -581,6 +582,11 @@ static struct davinci_nand_pdata
> of_property_read_bool(pdev->dev.of_node,
> "ti,davinci-nand-use-bbt"))
> pdata->bbt_options = NAND_BBT_USE_FLASH;
> +
> + if (of_device_is_compatible(pdev->dev.of_node,
> + "ti,keystone-nand")) {
> + pdata->options |= NAND_NO_SUBPAGE_WRITE;
> + }
> }
>
> return dev_get_platdata(&pdev->dev);
>
^ permalink raw reply [flat|nested] 32+ messages in thread* Re: [PATCH v2] mtd: davinci-nand: disable subpage write for keystone-nand
2014-03-20 20:14 ` Santosh Shilimkar
(?)
(?)
@ 2014-04-08 12:51 ` Ivan Khoronzhuk
-1 siblings, 0 replies; 32+ messages in thread
From: Ivan Khoronzhuk @ 2014-04-08 12:51 UTC (permalink / raw)
To: Brian Norris, dwmw2, Santosh Shilimkar, galak
Cc: mark.rutland, devicetree, grygorii.strashko, linux, pawel.moll,
ijc+devicetree, linux-kernel, robh+dt, linux-mtd, m-karicheri2,
rob, Warner Losh, linux-arm-kernel
On 03/20/2014 10:14 PM, Santosh Shilimkar wrote:
> On Thursday 20 March 2014 04:08 PM, Ivan Khoronzhuk wrote:
>> From: Murali Karicheri <m-karicheri2@ti.com>
>>
>> Sub page write doesn't work because of hw issue in controller found on
>> Keystone SOCs. AEMIF controller is also used on DaVinci SOCs which
>> don't seems to have any issue. So add "ti,keysone-nand" compatible
>> to nand driver in order to set NAND_NO_SUBPAGE_WRITE option.
>>
>> Cc: Brian Norris <computersforpeace@gmail.com>
>> Cc: Warner Losh <imp@bsdimp.com>
>> Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
>>
>> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
>> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@ti.com>
>> ---
>>
> Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
>
>> This patch is a result of discussion on patch v1:
>> https://lkml.org/lkml/2014/3/20/461
>>
>> drivers/mtd/nand/davinci_nand.c | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/drivers/mtd/nand/davinci_nand.c b/drivers/mtd/nand/davinci_nand.c
>> index 4615d79..b922c8e 100644
>> --- a/drivers/mtd/nand/davinci_nand.c
>> +++ b/drivers/mtd/nand/davinci_nand.c
>> @@ -523,6 +523,7 @@ static struct nand_ecclayout hwecc4_2048 = {
>> #if defined(CONFIG_OF)
>> static const struct of_device_id davinci_nand_of_match[] = {
>> {.compatible = "ti,davinci-nand", },
>> + {.compatible = "ti,keystone-nand", },
>> {},
>> };
>> MODULE_DEVICE_TABLE(of, davinci_nand_of_match);
>> @@ -581,6 +582,11 @@ static struct davinci_nand_pdata
>> of_property_read_bool(pdev->dev.of_node,
>> "ti,davinci-nand-use-bbt"))
>> pdata->bbt_options = NAND_BBT_USE_FLASH;
>> +
>> + if (of_device_is_compatible(pdev->dev.of_node,
>> + "ti,keystone-nand")) {
>> + pdata->options |= NAND_NO_SUBPAGE_WRITE;
>> + }
>> }
>>
>> return dev_get_platdata(&pdev->dev);
>>
>>
Brian,
Could you pick up subj patch?
--
Regards,
Ivan Khoronzhuk
^ permalink raw reply [flat|nested] 32+ messages in thread* Re: [PATCH v2] mtd: davinci-nand: disable subpage write for keystone-nand
@ 2014-04-08 12:51 ` Ivan Khoronzhuk
0 siblings, 0 replies; 32+ messages in thread
From: Ivan Khoronzhuk @ 2014-04-08 12:51 UTC (permalink / raw)
To: Brian Norris, dwmw2, Santosh Shilimkar, galak
Cc: robh+dt, pawel.moll, mark.rutland, ijc+devicetree, rob, linux,
grygorii.strashko, devicetree, linux-kernel, linux-arm-kernel,
linux-mtd, m-karicheri2, Warner Losh
On 03/20/2014 10:14 PM, Santosh Shilimkar wrote:
> On Thursday 20 March 2014 04:08 PM, Ivan Khoronzhuk wrote:
>> From: Murali Karicheri <m-karicheri2@ti.com>
>>
>> Sub page write doesn't work because of hw issue in controller found on
>> Keystone SOCs. AEMIF controller is also used on DaVinci SOCs which
>> don't seems to have any issue. So add "ti,keysone-nand" compatible
>> to nand driver in order to set NAND_NO_SUBPAGE_WRITE option.
>>
>> Cc: Brian Norris <computersforpeace@gmail.com>
>> Cc: Warner Losh <imp@bsdimp.com>
>> Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
>>
>> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
>> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@ti.com>
>> ---
>>
> Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
>
>> This patch is a result of discussion on patch v1:
>> https://lkml.org/lkml/2014/3/20/461
>>
>> drivers/mtd/nand/davinci_nand.c | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/drivers/mtd/nand/davinci_nand.c b/drivers/mtd/nand/davinci_nand.c
>> index 4615d79..b922c8e 100644
>> --- a/drivers/mtd/nand/davinci_nand.c
>> +++ b/drivers/mtd/nand/davinci_nand.c
>> @@ -523,6 +523,7 @@ static struct nand_ecclayout hwecc4_2048 = {
>> #if defined(CONFIG_OF)
>> static const struct of_device_id davinci_nand_of_match[] = {
>> {.compatible = "ti,davinci-nand", },
>> + {.compatible = "ti,keystone-nand", },
>> {},
>> };
>> MODULE_DEVICE_TABLE(of, davinci_nand_of_match);
>> @@ -581,6 +582,11 @@ static struct davinci_nand_pdata
>> of_property_read_bool(pdev->dev.of_node,
>> "ti,davinci-nand-use-bbt"))
>> pdata->bbt_options = NAND_BBT_USE_FLASH;
>> +
>> + if (of_device_is_compatible(pdev->dev.of_node,
>> + "ti,keystone-nand")) {
>> + pdata->options |= NAND_NO_SUBPAGE_WRITE;
>> + }
>> }
>>
>> return dev_get_platdata(&pdev->dev);
>>
>>
Brian,
Could you pick up subj patch?
--
Regards,
Ivan Khoronzhuk
^ permalink raw reply [flat|nested] 32+ messages in thread* Re: [PATCH v2] mtd: davinci-nand: disable subpage write for keystone-nand
@ 2014-04-08 12:51 ` Ivan Khoronzhuk
0 siblings, 0 replies; 32+ messages in thread
From: Ivan Khoronzhuk @ 2014-04-08 12:51 UTC (permalink / raw)
To: Brian Norris, dwmw2-wEGCiKHe2LqWVfeAwA7xHQ, Santosh Shilimkar,
galak-sgV2jX0FEOL9JmXXK+q4OQ
Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A, pawel.moll-5wv7dgnIgG8,
mark.rutland-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg,
rob-VoJi6FS/r0vR7s880joybQ, linux-lFZ/pmaqli7XmaaqVzeoHQ,
grygorii.strashko-l0cyMroinI0, devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
m-karicheri2-l0cyMroinI0, Warner Losh
On 03/20/2014 10:14 PM, Santosh Shilimkar wrote:
> On Thursday 20 March 2014 04:08 PM, Ivan Khoronzhuk wrote:
>> From: Murali Karicheri <m-karicheri2-l0cyMroinI0@public.gmane.org>
>>
>> Sub page write doesn't work because of hw issue in controller found on
>> Keystone SOCs. AEMIF controller is also used on DaVinci SOCs which
>> don't seems to have any issue. So add "ti,keysone-nand" compatible
>> to nand driver in order to set NAND_NO_SUBPAGE_WRITE option.
>>
>> Cc: Brian Norris <computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>> Cc: Warner Losh <imp-uzTCJ5RojNnQT0dZR+AlfA@public.gmane.org>
>> Cc: Santosh Shilimkar <santosh.shilimkar-l0cyMroinI0@public.gmane.org>
>>
>> Signed-off-by: Murali Karicheri <m-karicheri2-l0cyMroinI0@public.gmane.org>
>> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk-l0cyMroinI0@public.gmane.org>
>> ---
>>
> Acked-by: Santosh Shilimkar <santosh.shilimkar-l0cyMroinI0@public.gmane.org>
>
>> This patch is a result of discussion on patch v1:
>> https://lkml.org/lkml/2014/3/20/461
>>
>> drivers/mtd/nand/davinci_nand.c | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/drivers/mtd/nand/davinci_nand.c b/drivers/mtd/nand/davinci_nand.c
>> index 4615d79..b922c8e 100644
>> --- a/drivers/mtd/nand/davinci_nand.c
>> +++ b/drivers/mtd/nand/davinci_nand.c
>> @@ -523,6 +523,7 @@ static struct nand_ecclayout hwecc4_2048 = {
>> #if defined(CONFIG_OF)
>> static const struct of_device_id davinci_nand_of_match[] = {
>> {.compatible = "ti,davinci-nand", },
>> + {.compatible = "ti,keystone-nand", },
>> {},
>> };
>> MODULE_DEVICE_TABLE(of, davinci_nand_of_match);
>> @@ -581,6 +582,11 @@ static struct davinci_nand_pdata
>> of_property_read_bool(pdev->dev.of_node,
>> "ti,davinci-nand-use-bbt"))
>> pdata->bbt_options = NAND_BBT_USE_FLASH;
>> +
>> + if (of_device_is_compatible(pdev->dev.of_node,
>> + "ti,keystone-nand")) {
>> + pdata->options |= NAND_NO_SUBPAGE_WRITE;
>> + }
>> }
>>
>> return dev_get_platdata(&pdev->dev);
>>
>>
Brian,
Could you pick up subj patch?
--
Regards,
Ivan Khoronzhuk
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 32+ messages in thread* [PATCH v2] mtd: davinci-nand: disable subpage write for keystone-nand
@ 2014-04-08 12:51 ` Ivan Khoronzhuk
0 siblings, 0 replies; 32+ messages in thread
From: Ivan Khoronzhuk @ 2014-04-08 12:51 UTC (permalink / raw)
To: linux-arm-kernel
On 03/20/2014 10:14 PM, Santosh Shilimkar wrote:
> On Thursday 20 March 2014 04:08 PM, Ivan Khoronzhuk wrote:
>> From: Murali Karicheri <m-karicheri2@ti.com>
>>
>> Sub page write doesn't work because of hw issue in controller found on
>> Keystone SOCs. AEMIF controller is also used on DaVinci SOCs which
>> don't seems to have any issue. So add "ti,keysone-nand" compatible
>> to nand driver in order to set NAND_NO_SUBPAGE_WRITE option.
>>
>> Cc: Brian Norris <computersforpeace@gmail.com>
>> Cc: Warner Losh <imp@bsdimp.com>
>> Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
>>
>> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
>> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@ti.com>
>> ---
>>
> Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
>
>> This patch is a result of discussion on patch v1:
>> https://lkml.org/lkml/2014/3/20/461
>>
>> drivers/mtd/nand/davinci_nand.c | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/drivers/mtd/nand/davinci_nand.c b/drivers/mtd/nand/davinci_nand.c
>> index 4615d79..b922c8e 100644
>> --- a/drivers/mtd/nand/davinci_nand.c
>> +++ b/drivers/mtd/nand/davinci_nand.c
>> @@ -523,6 +523,7 @@ static struct nand_ecclayout hwecc4_2048 = {
>> #if defined(CONFIG_OF)
>> static const struct of_device_id davinci_nand_of_match[] = {
>> {.compatible = "ti,davinci-nand", },
>> + {.compatible = "ti,keystone-nand", },
>> {},
>> };
>> MODULE_DEVICE_TABLE(of, davinci_nand_of_match);
>> @@ -581,6 +582,11 @@ static struct davinci_nand_pdata
>> of_property_read_bool(pdev->dev.of_node,
>> "ti,davinci-nand-use-bbt"))
>> pdata->bbt_options = NAND_BBT_USE_FLASH;
>> +
>> + if (of_device_is_compatible(pdev->dev.of_node,
>> + "ti,keystone-nand")) {
>> + pdata->options |= NAND_NO_SUBPAGE_WRITE;
>> + }
>> }
>>
>> return dev_get_platdata(&pdev->dev);
>>
>>
Brian,
Could you pick up subj patch?
--
Regards,
Ivan Khoronzhuk
^ permalink raw reply [flat|nested] 32+ messages in thread* Re: [PATCH v2] mtd: davinci-nand: disable subpage write for keystone-nand
2014-04-08 12:51 ` Ivan Khoronzhuk
(?)
(?)
@ 2014-04-16 7:08 ` Brian Norris
-1 siblings, 0 replies; 32+ messages in thread
From: Brian Norris @ 2014-04-16 7:08 UTC (permalink / raw)
To: Ivan Khoronzhuk
Cc: mark.rutland, devicetree, grygorii.strashko, linux, pawel.moll,
ijc+devicetree, linux-kernel, robh+dt, Santosh Shilimkar,
m-karicheri2, rob, galak, linux-mtd, dwmw2, Warner Losh,
linux-arm-kernel
On Tue, Apr 08, 2014 at 03:51:34PM +0300, Ivan Khoronzhuk wrote:
> On 03/20/2014 10:14 PM, Santosh Shilimkar wrote:
> >On Thursday 20 March 2014 04:08 PM, Ivan Khoronzhuk wrote:
> >>From: Murali Karicheri <m-karicheri2@ti.com>
> >>Sub page write doesn't work because of hw issue in controller found on
> >>Keystone SOCs. AEMIF controller is also used on DaVinci SOCs which
> >>don't seems to have any issue. So add "ti,keysone-nand" compatible
> >>to nand driver in order to set NAND_NO_SUBPAGE_WRITE option.
> >>
> >>Cc: Brian Norris <computersforpeace@gmail.com>
> >>Cc: Warner Losh <imp@bsdimp.com>
> >>Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
> >>
> >>Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
> >>Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@ti.com>
> >>---
> >>
> >Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
>
> Brian,
> Could you pick up subj patch?
Pushed to l2-mtd.git. Is it critical this goes in for 3.15? It's
currently queued for -next (3.16).
Brian
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH v2] mtd: davinci-nand: disable subpage write for keystone-nand
@ 2014-04-16 7:08 ` Brian Norris
0 siblings, 0 replies; 32+ messages in thread
From: Brian Norris @ 2014-04-16 7:08 UTC (permalink / raw)
To: Ivan Khoronzhuk
Cc: dwmw2, Santosh Shilimkar, galak, robh+dt, pawel.moll,
mark.rutland, ijc+devicetree, rob, linux, grygorii.strashko,
devicetree, linux-kernel, linux-arm-kernel, linux-mtd,
m-karicheri2, Warner Losh
On Tue, Apr 08, 2014 at 03:51:34PM +0300, Ivan Khoronzhuk wrote:
> On 03/20/2014 10:14 PM, Santosh Shilimkar wrote:
> >On Thursday 20 March 2014 04:08 PM, Ivan Khoronzhuk wrote:
> >>From: Murali Karicheri <m-karicheri2@ti.com>
> >>Sub page write doesn't work because of hw issue in controller found on
> >>Keystone SOCs. AEMIF controller is also used on DaVinci SOCs which
> >>don't seems to have any issue. So add "ti,keysone-nand" compatible
> >>to nand driver in order to set NAND_NO_SUBPAGE_WRITE option.
> >>
> >>Cc: Brian Norris <computersforpeace@gmail.com>
> >>Cc: Warner Losh <imp@bsdimp.com>
> >>Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
> >>
> >>Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
> >>Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@ti.com>
> >>---
> >>
> >Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
>
> Brian,
> Could you pick up subj patch?
Pushed to l2-mtd.git. Is it critical this goes in for 3.15? It's
currently queued for -next (3.16).
Brian
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH v2] mtd: davinci-nand: disable subpage write for keystone-nand
@ 2014-04-16 7:08 ` Brian Norris
0 siblings, 0 replies; 32+ messages in thread
From: Brian Norris @ 2014-04-16 7:08 UTC (permalink / raw)
To: Ivan Khoronzhuk
Cc: dwmw2-wEGCiKHe2LqWVfeAwA7xHQ, Santosh Shilimkar,
galak-sgV2jX0FEOL9JmXXK+q4OQ, robh+dt-DgEjT+Ai2ygdnm+yROfE0A,
pawel.moll-5wv7dgnIgG8, mark.rutland-5wv7dgnIgG8,
ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg, rob-VoJi6FS/r0vR7s880joybQ,
linux-lFZ/pmaqli7XmaaqVzeoHQ, grygorii.strashko-l0cyMroinI0,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
m-karicheri2-l0cyMroinI0, Warner Losh
On Tue, Apr 08, 2014 at 03:51:34PM +0300, Ivan Khoronzhuk wrote:
> On 03/20/2014 10:14 PM, Santosh Shilimkar wrote:
> >On Thursday 20 March 2014 04:08 PM, Ivan Khoronzhuk wrote:
> >>From: Murali Karicheri <m-karicheri2-l0cyMroinI0@public.gmane.org>
> >>Sub page write doesn't work because of hw issue in controller found on
> >>Keystone SOCs. AEMIF controller is also used on DaVinci SOCs which
> >>don't seems to have any issue. So add "ti,keysone-nand" compatible
> >>to nand driver in order to set NAND_NO_SUBPAGE_WRITE option.
> >>
> >>Cc: Brian Norris <computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> >>Cc: Warner Losh <imp-uzTCJ5RojNnQT0dZR+AlfA@public.gmane.org>
> >>Cc: Santosh Shilimkar <santosh.shilimkar-l0cyMroinI0@public.gmane.org>
> >>
> >>Signed-off-by: Murali Karicheri <m-karicheri2-l0cyMroinI0@public.gmane.org>
> >>Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk-l0cyMroinI0@public.gmane.org>
> >>---
> >>
> >Acked-by: Santosh Shilimkar <santosh.shilimkar-l0cyMroinI0@public.gmane.org>
>
> Brian,
> Could you pick up subj patch?
Pushed to l2-mtd.git. Is it critical this goes in for 3.15? It's
currently queued for -next (3.16).
Brian
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 32+ messages in thread
* [PATCH v2] mtd: davinci-nand: disable subpage write for keystone-nand
@ 2014-04-16 7:08 ` Brian Norris
0 siblings, 0 replies; 32+ messages in thread
From: Brian Norris @ 2014-04-16 7:08 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Apr 08, 2014 at 03:51:34PM +0300, Ivan Khoronzhuk wrote:
> On 03/20/2014 10:14 PM, Santosh Shilimkar wrote:
> >On Thursday 20 March 2014 04:08 PM, Ivan Khoronzhuk wrote:
> >>From: Murali Karicheri <m-karicheri2@ti.com>
> >>Sub page write doesn't work because of hw issue in controller found on
> >>Keystone SOCs. AEMIF controller is also used on DaVinci SOCs which
> >>don't seems to have any issue. So add "ti,keysone-nand" compatible
> >>to nand driver in order to set NAND_NO_SUBPAGE_WRITE option.
> >>
> >>Cc: Brian Norris <computersforpeace@gmail.com>
> >>Cc: Warner Losh <imp@bsdimp.com>
> >>Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
> >>
> >>Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
> >>Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@ti.com>
> >>---
> >>
> >Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
>
> Brian,
> Could you pick up subj patch?
Pushed to l2-mtd.git. Is it critical this goes in for 3.15? It's
currently queued for -next (3.16).
Brian
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH v2] mtd: davinci-nand: disable subpage write for keystone-nand
2014-04-16 7:08 ` Brian Norris
(?)
(?)
@ 2014-04-16 9:47 ` Ivan Khoronzhuk
-1 siblings, 0 replies; 32+ messages in thread
From: Ivan Khoronzhuk @ 2014-04-16 9:47 UTC (permalink / raw)
To: Brian Norris
Cc: mark.rutland, devicetree, grygorii.strashko, linux, pawel.moll,
ijc+devicetree, linux-kernel, robh+dt, Santosh Shilimkar,
m-karicheri2, rob, galak, linux-mtd, dwmw2, Warner Losh,
linux-arm-kernel
On 04/16/2014 10:08 AM, Brian Norris wrote:
> On Tue, Apr 08, 2014 at 03:51:34PM +0300, Ivan Khoronzhuk wrote:
>> On 03/20/2014 10:14 PM, Santosh Shilimkar wrote:
>>> On Thursday 20 March 2014 04:08 PM, Ivan Khoronzhuk wrote:
>>>> From: Murali Karicheri <m-karicheri2@ti.com>
>>>> Sub page write doesn't work because of hw issue in controller found on
>>>> Keystone SOCs. AEMIF controller is also used on DaVinci SOCs which
>>>> don't seems to have any issue. So add "ti,keysone-nand" compatible
>>>> to nand driver in order to set NAND_NO_SUBPAGE_WRITE option.
>>>>
>>>> Cc: Brian Norris <computersforpeace@gmail.com>
>>>> Cc: Warner Losh <imp@bsdimp.com>
>>>> Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
>>>>
>>>> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
>>>> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@ti.com>
>>>> ---
>>>>
>>> Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
>> Brian,
>> Could you pick up subj patch?
> Pushed to l2-mtd.git. Is it critical this goes in for 3.15? It's
> currently queued for -next (3.16).
>
> Brian
This is a critical fix and it should be for 3.15.
Thanks.
--
Regards,
Ivan Khoronzhuk
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH v2] mtd: davinci-nand: disable subpage write for keystone-nand
@ 2014-04-16 9:47 ` Ivan Khoronzhuk
0 siblings, 0 replies; 32+ messages in thread
From: Ivan Khoronzhuk @ 2014-04-16 9:47 UTC (permalink / raw)
To: Brian Norris
Cc: dwmw2, Santosh Shilimkar, galak, robh+dt, pawel.moll,
mark.rutland, ijc+devicetree, rob, linux, grygorii.strashko,
devicetree, linux-kernel, linux-arm-kernel, linux-mtd,
m-karicheri2, Warner Losh
On 04/16/2014 10:08 AM, Brian Norris wrote:
> On Tue, Apr 08, 2014 at 03:51:34PM +0300, Ivan Khoronzhuk wrote:
>> On 03/20/2014 10:14 PM, Santosh Shilimkar wrote:
>>> On Thursday 20 March 2014 04:08 PM, Ivan Khoronzhuk wrote:
>>>> From: Murali Karicheri <m-karicheri2@ti.com>
>>>> Sub page write doesn't work because of hw issue in controller found on
>>>> Keystone SOCs. AEMIF controller is also used on DaVinci SOCs which
>>>> don't seems to have any issue. So add "ti,keysone-nand" compatible
>>>> to nand driver in order to set NAND_NO_SUBPAGE_WRITE option.
>>>>
>>>> Cc: Brian Norris <computersforpeace@gmail.com>
>>>> Cc: Warner Losh <imp@bsdimp.com>
>>>> Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
>>>>
>>>> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
>>>> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@ti.com>
>>>> ---
>>>>
>>> Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
>> Brian,
>> Could you pick up subj patch?
> Pushed to l2-mtd.git. Is it critical this goes in for 3.15? It's
> currently queued for -next (3.16).
>
> Brian
This is a critical fix and it should be for 3.15.
Thanks.
--
Regards,
Ivan Khoronzhuk
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH v2] mtd: davinci-nand: disable subpage write for keystone-nand
@ 2014-04-16 9:47 ` Ivan Khoronzhuk
0 siblings, 0 replies; 32+ messages in thread
From: Ivan Khoronzhuk @ 2014-04-16 9:47 UTC (permalink / raw)
To: Brian Norris
Cc: dwmw2-wEGCiKHe2LqWVfeAwA7xHQ, Santosh Shilimkar,
galak-sgV2jX0FEOL9JmXXK+q4OQ, robh+dt-DgEjT+Ai2ygdnm+yROfE0A,
pawel.moll-5wv7dgnIgG8, mark.rutland-5wv7dgnIgG8,
ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg, rob-VoJi6FS/r0vR7s880joybQ,
linux-lFZ/pmaqli7XmaaqVzeoHQ, grygorii.strashko-l0cyMroinI0,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
m-karicheri2-l0cyMroinI0, Warner Losh
On 04/16/2014 10:08 AM, Brian Norris wrote:
> On Tue, Apr 08, 2014 at 03:51:34PM +0300, Ivan Khoronzhuk wrote:
>> On 03/20/2014 10:14 PM, Santosh Shilimkar wrote:
>>> On Thursday 20 March 2014 04:08 PM, Ivan Khoronzhuk wrote:
>>>> From: Murali Karicheri <m-karicheri2-l0cyMroinI0@public.gmane.org>
>>>> Sub page write doesn't work because of hw issue in controller found on
>>>> Keystone SOCs. AEMIF controller is also used on DaVinci SOCs which
>>>> don't seems to have any issue. So add "ti,keysone-nand" compatible
>>>> to nand driver in order to set NAND_NO_SUBPAGE_WRITE option.
>>>>
>>>> Cc: Brian Norris <computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>>>> Cc: Warner Losh <imp-uzTCJ5RojNnQT0dZR+AlfA@public.gmane.org>
>>>> Cc: Santosh Shilimkar <santosh.shilimkar-l0cyMroinI0@public.gmane.org>
>>>>
>>>> Signed-off-by: Murali Karicheri <m-karicheri2-l0cyMroinI0@public.gmane.org>
>>>> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk-l0cyMroinI0@public.gmane.org>
>>>> ---
>>>>
>>> Acked-by: Santosh Shilimkar <santosh.shilimkar-l0cyMroinI0@public.gmane.org>
>> Brian,
>> Could you pick up subj patch?
> Pushed to l2-mtd.git. Is it critical this goes in for 3.15? It's
> currently queued for -next (3.16).
>
> Brian
This is a critical fix and it should be for 3.15.
Thanks.
--
Regards,
Ivan Khoronzhuk
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 32+ messages in thread
* [PATCH v2] mtd: davinci-nand: disable subpage write for keystone-nand
@ 2014-04-16 9:47 ` Ivan Khoronzhuk
0 siblings, 0 replies; 32+ messages in thread
From: Ivan Khoronzhuk @ 2014-04-16 9:47 UTC (permalink / raw)
To: linux-arm-kernel
On 04/16/2014 10:08 AM, Brian Norris wrote:
> On Tue, Apr 08, 2014 at 03:51:34PM +0300, Ivan Khoronzhuk wrote:
>> On 03/20/2014 10:14 PM, Santosh Shilimkar wrote:
>>> On Thursday 20 March 2014 04:08 PM, Ivan Khoronzhuk wrote:
>>>> From: Murali Karicheri <m-karicheri2@ti.com>
>>>> Sub page write doesn't work because of hw issue in controller found on
>>>> Keystone SOCs. AEMIF controller is also used on DaVinci SOCs which
>>>> don't seems to have any issue. So add "ti,keysone-nand" compatible
>>>> to nand driver in order to set NAND_NO_SUBPAGE_WRITE option.
>>>>
>>>> Cc: Brian Norris <computersforpeace@gmail.com>
>>>> Cc: Warner Losh <imp@bsdimp.com>
>>>> Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
>>>>
>>>> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
>>>> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@ti.com>
>>>> ---
>>>>
>>> Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
>> Brian,
>> Could you pick up subj patch?
> Pushed to l2-mtd.git. Is it critical this goes in for 3.15? It's
> currently queued for -next (3.16).
>
> Brian
This is a critical fix and it should be for 3.15.
Thanks.
--
Regards,
Ivan Khoronzhuk
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH v2] mtd: davinci-nand: disable subpage write for keystone-nand
2014-04-16 9:47 ` Ivan Khoronzhuk
(?)
(?)
@ 2014-04-16 14:03 ` Santosh Shilimkar
-1 siblings, 0 replies; 32+ messages in thread
From: Santosh Shilimkar @ 2014-04-16 14:03 UTC (permalink / raw)
To: Ivan Khoronzhuk, Brian Norris
Cc: mark.rutland, devicetree, grygorii.strashko, linux, pawel.moll,
ijc+devicetree, linux-kernel, robh+dt, linux-mtd, m-karicheri2,
rob, galak, dwmw2, Warner Losh, linux-arm-kernel
On Wednesday 16 April 2014 05:47 AM, Ivan Khoronzhuk wrote:
>
> On 04/16/2014 10:08 AM, Brian Norris wrote:
>> On Tue, Apr 08, 2014 at 03:51:34PM +0300, Ivan Khoronzhuk wrote:
>>> On 03/20/2014 10:14 PM, Santosh Shilimkar wrote:
>>>> On Thursday 20 March 2014 04:08 PM, Ivan Khoronzhuk wrote:
>>>>> From: Murali Karicheri <m-karicheri2@ti.com>
>>>>> Sub page write doesn't work because of hw issue in controller found on
>>>>> Keystone SOCs. AEMIF controller is also used on DaVinci SOCs which
>>>>> don't seems to have any issue. So add "ti,keysone-nand" compatible
>>>>> to nand driver in order to set NAND_NO_SUBPAGE_WRITE option.
>>>>>
>>>>> Cc: Brian Norris <computersforpeace@gmail.com>
>>>>> Cc: Warner Losh <imp@bsdimp.com>
>>>>> Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
>>>>>
>>>>> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
>>>>> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@ti.com>
>>>>> ---
>>>>>
>>>> Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
>>> Brian,
>>> Could you pick up subj patch?
>> Pushed to l2-mtd.git. Is it critical this goes in for 3.15? It's
>> currently queued for -next (3.16).
>>
>> Brian
>
> This is a critical fix and it should be for 3.15.
Yep. The NAND is broken on Keystone without this patch.
So 3.15 fixes please
Regards,
Santosh
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH v2] mtd: davinci-nand: disable subpage write for keystone-nand
@ 2014-04-16 14:03 ` Santosh Shilimkar
0 siblings, 0 replies; 32+ messages in thread
From: Santosh Shilimkar @ 2014-04-16 14:03 UTC (permalink / raw)
To: Ivan Khoronzhuk, Brian Norris
Cc: dwmw2, galak, robh+dt, pawel.moll, mark.rutland, ijc+devicetree,
rob, linux, grygorii.strashko, devicetree, linux-kernel,
linux-arm-kernel, linux-mtd, m-karicheri2, Warner Losh
On Wednesday 16 April 2014 05:47 AM, Ivan Khoronzhuk wrote:
>
> On 04/16/2014 10:08 AM, Brian Norris wrote:
>> On Tue, Apr 08, 2014 at 03:51:34PM +0300, Ivan Khoronzhuk wrote:
>>> On 03/20/2014 10:14 PM, Santosh Shilimkar wrote:
>>>> On Thursday 20 March 2014 04:08 PM, Ivan Khoronzhuk wrote:
>>>>> From: Murali Karicheri <m-karicheri2@ti.com>
>>>>> Sub page write doesn't work because of hw issue in controller found on
>>>>> Keystone SOCs. AEMIF controller is also used on DaVinci SOCs which
>>>>> don't seems to have any issue. So add "ti,keysone-nand" compatible
>>>>> to nand driver in order to set NAND_NO_SUBPAGE_WRITE option.
>>>>>
>>>>> Cc: Brian Norris <computersforpeace@gmail.com>
>>>>> Cc: Warner Losh <imp@bsdimp.com>
>>>>> Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
>>>>>
>>>>> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
>>>>> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@ti.com>
>>>>> ---
>>>>>
>>>> Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
>>> Brian,
>>> Could you pick up subj patch?
>> Pushed to l2-mtd.git. Is it critical this goes in for 3.15? It's
>> currently queued for -next (3.16).
>>
>> Brian
>
> This is a critical fix and it should be for 3.15.
Yep. The NAND is broken on Keystone without this patch.
So 3.15 fixes please
Regards,
Santosh
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH v2] mtd: davinci-nand: disable subpage write for keystone-nand
@ 2014-04-16 14:03 ` Santosh Shilimkar
0 siblings, 0 replies; 32+ messages in thread
From: Santosh Shilimkar @ 2014-04-16 14:03 UTC (permalink / raw)
To: Ivan Khoronzhuk, Brian Norris
Cc: dwmw2, galak, robh+dt, pawel.moll, mark.rutland, ijc+devicetree,
rob, linux, grygorii.strashko, devicetree, linux-kernel,
linux-arm-kernel, linux-mtd, m-karicheri2, Warner Losh
On Wednesday 16 April 2014 05:47 AM, Ivan Khoronzhuk wrote:
>
> On 04/16/2014 10:08 AM, Brian Norris wrote:
>> On Tue, Apr 08, 2014 at 03:51:34PM +0300, Ivan Khoronzhuk wrote:
>>> On 03/20/2014 10:14 PM, Santosh Shilimkar wrote:
>>>> On Thursday 20 March 2014 04:08 PM, Ivan Khoronzhuk wrote:
>>>>> From: Murali Karicheri <m-karicheri2@ti.com>
>>>>> Sub page write doesn't work because of hw issue in controller found on
>>>>> Keystone SOCs. AEMIF controller is also used on DaVinci SOCs which
>>>>> don't seems to have any issue. So add "ti,keysone-nand" compatible
>>>>> to nand driver in order to set NAND_NO_SUBPAGE_WRITE option.
>>>>>
>>>>> Cc: Brian Norris <computersforpeace@gmail.com>
>>>>> Cc: Warner Losh <imp@bsdimp.com>
>>>>> Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
>>>>>
>>>>> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
>>>>> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@ti.com>
>>>>> ---
>>>>>
>>>> Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
>>> Brian,
>>> Could you pick up subj patch?
>> Pushed to l2-mtd.git. Is it critical this goes in for 3.15? It's
>> currently queued for -next (3.16).
>>
>> Brian
>
> This is a critical fix and it should be for 3.15.
Yep. The NAND is broken on Keystone without this patch.
So 3.15 fixes please
Regards,
Santosh
^ permalink raw reply [flat|nested] 32+ messages in thread
* [PATCH v2] mtd: davinci-nand: disable subpage write for keystone-nand
@ 2014-04-16 14:03 ` Santosh Shilimkar
0 siblings, 0 replies; 32+ messages in thread
From: Santosh Shilimkar @ 2014-04-16 14:03 UTC (permalink / raw)
To: linux-arm-kernel
On Wednesday 16 April 2014 05:47 AM, Ivan Khoronzhuk wrote:
>
> On 04/16/2014 10:08 AM, Brian Norris wrote:
>> On Tue, Apr 08, 2014 at 03:51:34PM +0300, Ivan Khoronzhuk wrote:
>>> On 03/20/2014 10:14 PM, Santosh Shilimkar wrote:
>>>> On Thursday 20 March 2014 04:08 PM, Ivan Khoronzhuk wrote:
>>>>> From: Murali Karicheri <m-karicheri2@ti.com>
>>>>> Sub page write doesn't work because of hw issue in controller found on
>>>>> Keystone SOCs. AEMIF controller is also used on DaVinci SOCs which
>>>>> don't seems to have any issue. So add "ti,keysone-nand" compatible
>>>>> to nand driver in order to set NAND_NO_SUBPAGE_WRITE option.
>>>>>
>>>>> Cc: Brian Norris <computersforpeace@gmail.com>
>>>>> Cc: Warner Losh <imp@bsdimp.com>
>>>>> Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
>>>>>
>>>>> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
>>>>> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@ti.com>
>>>>> ---
>>>>>
>>>> Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
>>> Brian,
>>> Could you pick up subj patch?
>> Pushed to l2-mtd.git. Is it critical this goes in for 3.15? It's
>> currently queued for -next (3.16).
>>
>> Brian
>
> This is a critical fix and it should be for 3.15.
Yep. The NAND is broken on Keystone without this patch.
So 3.15 fixes please
Regards,
Santosh
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH v2] mtd: davinci-nand: disable subpage write for keystone-nand
2014-04-16 9:47 ` Ivan Khoronzhuk
(?)
(?)
@ 2014-04-28 13:43 ` Santosh Shilimkar
-1 siblings, 0 replies; 32+ messages in thread
From: Santosh Shilimkar @ 2014-04-28 13:43 UTC (permalink / raw)
To: Brian Norris
Cc: mark.rutland, devicetree, grygorii.strashko, linux, pawel.moll,
ijc+devicetree, linux-kernel, robh+dt, linux-mtd, m-karicheri2,
rob, galak, Ivan Khoronzhuk, dwmw2, Warner Losh, linux-arm-kernel
Brian,
On Wednesday 16 April 2014 05:47 AM, Ivan Khoronzhuk wrote:
>
> On 04/16/2014 10:08 AM, Brian Norris wrote:
>> On Tue, Apr 08, 2014 at 03:51:34PM +0300, Ivan Khoronzhuk wrote:
>>> On 03/20/2014 10:14 PM, Santosh Shilimkar wrote:
>>>> On Thursday 20 March 2014 04:08 PM, Ivan Khoronzhuk wrote:
>>>>> From: Murali Karicheri <m-karicheri2@ti.com>
>>>>> Sub page write doesn't work because of hw issue in controller found on
>>>>> Keystone SOCs. AEMIF controller is also used on DaVinci SOCs which
>>>>> don't seems to have any issue. So add "ti,keysone-nand" compatible
>>>>> to nand driver in order to set NAND_NO_SUBPAGE_WRITE option.
>>>>>
>>>>> Cc: Brian Norris <computersforpeace@gmail.com>
>>>>> Cc: Warner Losh <imp@bsdimp.com>
>>>>> Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
>>>>>
>>>>> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
>>>>> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@ti.com>
>>>>> ---
>>>>>
>>>> Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
>>> Brian,
>>> Could you pick up subj patch?
>> Pushed to l2-mtd.git. Is it critical this goes in for 3.15? It's
>> currently queued for -next (3.16).
>>
[..]
>
> This is a critical fix and it should be for 3.15.
Ping. 3.15-rc3 is already out and I still see this fix merged
yet.
Regards,
Santosh
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH v2] mtd: davinci-nand: disable subpage write for keystone-nand
@ 2014-04-28 13:43 ` Santosh Shilimkar
0 siblings, 0 replies; 32+ messages in thread
From: Santosh Shilimkar @ 2014-04-28 13:43 UTC (permalink / raw)
To: Brian Norris
Cc: Ivan Khoronzhuk, dwmw2, galak, robh+dt, pawel.moll, mark.rutland,
ijc+devicetree, rob, linux, grygorii.strashko, devicetree,
linux-kernel, linux-arm-kernel, linux-mtd, m-karicheri2,
Warner Losh
Brian,
On Wednesday 16 April 2014 05:47 AM, Ivan Khoronzhuk wrote:
>
> On 04/16/2014 10:08 AM, Brian Norris wrote:
>> On Tue, Apr 08, 2014 at 03:51:34PM +0300, Ivan Khoronzhuk wrote:
>>> On 03/20/2014 10:14 PM, Santosh Shilimkar wrote:
>>>> On Thursday 20 March 2014 04:08 PM, Ivan Khoronzhuk wrote:
>>>>> From: Murali Karicheri <m-karicheri2@ti.com>
>>>>> Sub page write doesn't work because of hw issue in controller found on
>>>>> Keystone SOCs. AEMIF controller is also used on DaVinci SOCs which
>>>>> don't seems to have any issue. So add "ti,keysone-nand" compatible
>>>>> to nand driver in order to set NAND_NO_SUBPAGE_WRITE option.
>>>>>
>>>>> Cc: Brian Norris <computersforpeace@gmail.com>
>>>>> Cc: Warner Losh <imp@bsdimp.com>
>>>>> Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
>>>>>
>>>>> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
>>>>> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@ti.com>
>>>>> ---
>>>>>
>>>> Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
>>> Brian,
>>> Could you pick up subj patch?
>> Pushed to l2-mtd.git. Is it critical this goes in for 3.15? It's
>> currently queued for -next (3.16).
>>
[..]
>
> This is a critical fix and it should be for 3.15.
Ping. 3.15-rc3 is already out and I still see this fix merged
yet.
Regards,
Santosh
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH v2] mtd: davinci-nand: disable subpage write for keystone-nand
@ 2014-04-28 13:43 ` Santosh Shilimkar
0 siblings, 0 replies; 32+ messages in thread
From: Santosh Shilimkar @ 2014-04-28 13:43 UTC (permalink / raw)
To: Brian Norris
Cc: Ivan Khoronzhuk, dwmw2, galak, robh+dt, pawel.moll, mark.rutland,
ijc+devicetree, rob, linux, grygorii.strashko, devicetree,
linux-kernel, linux-arm-kernel, linux-mtd, m-karicheri2,
Warner Losh
Brian,
On Wednesday 16 April 2014 05:47 AM, Ivan Khoronzhuk wrote:
>
> On 04/16/2014 10:08 AM, Brian Norris wrote:
>> On Tue, Apr 08, 2014 at 03:51:34PM +0300, Ivan Khoronzhuk wrote:
>>> On 03/20/2014 10:14 PM, Santosh Shilimkar wrote:
>>>> On Thursday 20 March 2014 04:08 PM, Ivan Khoronzhuk wrote:
>>>>> From: Murali Karicheri <m-karicheri2@ti.com>
>>>>> Sub page write doesn't work because of hw issue in controller found on
>>>>> Keystone SOCs. AEMIF controller is also used on DaVinci SOCs which
>>>>> don't seems to have any issue. So add "ti,keysone-nand" compatible
>>>>> to nand driver in order to set NAND_NO_SUBPAGE_WRITE option.
>>>>>
>>>>> Cc: Brian Norris <computersforpeace@gmail.com>
>>>>> Cc: Warner Losh <imp@bsdimp.com>
>>>>> Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
>>>>>
>>>>> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
>>>>> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@ti.com>
>>>>> ---
>>>>>
>>>> Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
>>> Brian,
>>> Could you pick up subj patch?
>> Pushed to l2-mtd.git. Is it critical this goes in for 3.15? It's
>> currently queued for -next (3.16).
>>
[..]
>
> This is a critical fix and it should be for 3.15.
Ping. 3.15-rc3 is already out and I still see this fix merged
yet.
Regards,
Santosh
^ permalink raw reply [flat|nested] 32+ messages in thread
* [PATCH v2] mtd: davinci-nand: disable subpage write for keystone-nand
@ 2014-04-28 13:43 ` Santosh Shilimkar
0 siblings, 0 replies; 32+ messages in thread
From: Santosh Shilimkar @ 2014-04-28 13:43 UTC (permalink / raw)
To: linux-arm-kernel
Brian,
On Wednesday 16 April 2014 05:47 AM, Ivan Khoronzhuk wrote:
>
> On 04/16/2014 10:08 AM, Brian Norris wrote:
>> On Tue, Apr 08, 2014 at 03:51:34PM +0300, Ivan Khoronzhuk wrote:
>>> On 03/20/2014 10:14 PM, Santosh Shilimkar wrote:
>>>> On Thursday 20 March 2014 04:08 PM, Ivan Khoronzhuk wrote:
>>>>> From: Murali Karicheri <m-karicheri2@ti.com>
>>>>> Sub page write doesn't work because of hw issue in controller found on
>>>>> Keystone SOCs. AEMIF controller is also used on DaVinci SOCs which
>>>>> don't seems to have any issue. So add "ti,keysone-nand" compatible
>>>>> to nand driver in order to set NAND_NO_SUBPAGE_WRITE option.
>>>>>
>>>>> Cc: Brian Norris <computersforpeace@gmail.com>
>>>>> Cc: Warner Losh <imp@bsdimp.com>
>>>>> Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
>>>>>
>>>>> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
>>>>> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@ti.com>
>>>>> ---
>>>>>
>>>> Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
>>> Brian,
>>> Could you pick up subj patch?
>> Pushed to l2-mtd.git. Is it critical this goes in for 3.15? It's
>> currently queued for -next (3.16).
>>
[..]
>
> This is a critical fix and it should be for 3.15.
Ping. 3.15-rc3 is already out and I still see this fix merged
yet.
Regards,
Santosh
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH v2] mtd: davinci-nand: disable subpage write for keystone-nand
2014-04-28 13:43 ` Santosh Shilimkar
(?)
(?)
@ 2014-04-30 22:33 ` Brian Norris
-1 siblings, 0 replies; 32+ messages in thread
From: Brian Norris @ 2014-04-30 22:33 UTC (permalink / raw)
To: Santosh Shilimkar
Cc: mark.rutland, devicetree, grygorii.strashko, linux, pawel.moll,
ijc+devicetree, linux-kernel, robh+dt, linux-mtd, m-karicheri2,
rob, galak, Ivan Khoronzhuk, dwmw2, Warner Losh, linux-arm-kernel
On Mon, Apr 28, 2014 at 09:43:17AM -0400, Santosh Shilimkar wrote:
> On Wednesday 16 April 2014 05:47 AM, Ivan Khoronzhuk wrote:
> > On 04/16/2014 10:08 AM, Brian Norris wrote:
> >> On Tue, Apr 08, 2014 at 03:51:34PM +0300, Ivan Khoronzhuk wrote:
> >>> Could you pick up subj patch?
> >> Pushed to l2-mtd.git. Is it critical this goes in for 3.15? It's
> >> currently queued for -next (3.16).
> >>
>
> [..]
>
> >
> > This is a critical fix and it should be for 3.15.
> Ping. 3.15-rc3 is already out and I still see this fix merged
> yet.
OK, cherry-picked to linux-mtd.git with the intention of sending to
Linus soon.
Regards,
Brian
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH v2] mtd: davinci-nand: disable subpage write for keystone-nand
@ 2014-04-30 22:33 ` Brian Norris
0 siblings, 0 replies; 32+ messages in thread
From: Brian Norris @ 2014-04-30 22:33 UTC (permalink / raw)
To: Santosh Shilimkar
Cc: Ivan Khoronzhuk, dwmw2, galak, robh+dt, pawel.moll, mark.rutland,
ijc+devicetree, rob, linux, grygorii.strashko, devicetree,
linux-kernel, linux-arm-kernel, linux-mtd, m-karicheri2,
Warner Losh
On Mon, Apr 28, 2014 at 09:43:17AM -0400, Santosh Shilimkar wrote:
> On Wednesday 16 April 2014 05:47 AM, Ivan Khoronzhuk wrote:
> > On 04/16/2014 10:08 AM, Brian Norris wrote:
> >> On Tue, Apr 08, 2014 at 03:51:34PM +0300, Ivan Khoronzhuk wrote:
> >>> Could you pick up subj patch?
> >> Pushed to l2-mtd.git. Is it critical this goes in for 3.15? It's
> >> currently queued for -next (3.16).
> >>
>
> [..]
>
> >
> > This is a critical fix and it should be for 3.15.
> Ping. 3.15-rc3 is already out and I still see this fix merged
> yet.
OK, cherry-picked to linux-mtd.git with the intention of sending to
Linus soon.
Regards,
Brian
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH v2] mtd: davinci-nand: disable subpage write for keystone-nand
@ 2014-04-30 22:33 ` Brian Norris
0 siblings, 0 replies; 32+ messages in thread
From: Brian Norris @ 2014-04-30 22:33 UTC (permalink / raw)
To: Santosh Shilimkar
Cc: Ivan Khoronzhuk, dwmw2-wEGCiKHe2LqWVfeAwA7xHQ,
galak-sgV2jX0FEOL9JmXXK+q4OQ, robh+dt-DgEjT+Ai2ygdnm+yROfE0A,
pawel.moll-5wv7dgnIgG8, mark.rutland-5wv7dgnIgG8,
ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg, rob-VoJi6FS/r0vR7s880joybQ,
linux-lFZ/pmaqli7XmaaqVzeoHQ, grygorii.strashko-l0cyMroinI0,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
m-karicheri2-l0cyMroinI0, Warner Losh
On Mon, Apr 28, 2014 at 09:43:17AM -0400, Santosh Shilimkar wrote:
> On Wednesday 16 April 2014 05:47 AM, Ivan Khoronzhuk wrote:
> > On 04/16/2014 10:08 AM, Brian Norris wrote:
> >> On Tue, Apr 08, 2014 at 03:51:34PM +0300, Ivan Khoronzhuk wrote:
> >>> Could you pick up subj patch?
> >> Pushed to l2-mtd.git. Is it critical this goes in for 3.15? It's
> >> currently queued for -next (3.16).
> >>
>
> [..]
>
> >
> > This is a critical fix and it should be for 3.15.
> Ping. 3.15-rc3 is already out and I still see this fix merged
> yet.
OK, cherry-picked to linux-mtd.git with the intention of sending to
Linus soon.
Regards,
Brian
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 32+ messages in thread
* [PATCH v2] mtd: davinci-nand: disable subpage write for keystone-nand
@ 2014-04-30 22:33 ` Brian Norris
0 siblings, 0 replies; 32+ messages in thread
From: Brian Norris @ 2014-04-30 22:33 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Apr 28, 2014 at 09:43:17AM -0400, Santosh Shilimkar wrote:
> On Wednesday 16 April 2014 05:47 AM, Ivan Khoronzhuk wrote:
> > On 04/16/2014 10:08 AM, Brian Norris wrote:
> >> On Tue, Apr 08, 2014 at 03:51:34PM +0300, Ivan Khoronzhuk wrote:
> >>> Could you pick up subj patch?
> >> Pushed to l2-mtd.git. Is it critical this goes in for 3.15? It's
> >> currently queued for -next (3.16).
> >>
>
> [..]
>
> >
> > This is a critical fix and it should be for 3.15.
> Ping. 3.15-rc3 is already out and I still see this fix merged
> yet.
OK, cherry-picked to linux-mtd.git with the intention of sending to
Linus soon.
Regards,
Brian
^ permalink raw reply [flat|nested] 32+ messages in thread