All of lore.kernel.org
 help / color / mirror / Atom feed
From: boris.brezillon@free-electrons.com (Boris BREZILLON)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 7/7] ARM: sunxi: dt: add PRCM clk and reset controller subdevices
Date: Thu, 08 May 2014 22:08:17 +0200	[thread overview]
Message-ID: <536BE431.50007@free-electrons.com> (raw)
In-Reply-To: <20140508142934.GV7047@lukather>


On 08/05/2014 16:29, Maxime Ripard wrote:
> On Thu, May 08, 2014 at 11:40:59AM +0800, Chen-Yu Tsai wrote:
>>>> +                     apb0_gates: apb0_gates_clk {
>>>> +                             compatible = "allwinner,sun6i-a31-apb0-gates-clk";
>>>> +                             #clock-cells = <1>;
>>>> +                             clocks = <&apb0>;
>>>> +                             clock-output-names = "apb0_pio", "apb0_ir",
>>>> +                                             "apb0_timer01", "apb0_p2wi",
>>> timer01 ? is this a typo?
>> A23 manual lists the clock gate as "r_timer0_1", so I put the name on the wiki.
>> Allwinner sun6i code uses "r_tmr" or just "tmr". I see no problem naming this
>> clock output as "apb0_timer" though.
> Yep, it seems better.

Fair enough, I'll change the name for the next version.

>
> Maxime
>

-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

WARNING: multiple messages have this Message-ID (diff)
From: Boris BREZILLON <boris.brezillon@free-electrons.com>
To: Maxime Ripard <maxime.ripard@free-electrons.com>,
	Chen-Yu Tsai <wens@csie.org>
Cc: "Emilio López" <emilio@elopez.com.ar>,
	"Mike Turquette" <mturquette@linaro.org>,
	"Samuel Ortiz" <sameo@linux.intel.com>,
	"Lee Jones" <lee.jones@linaro.org>,
	"Philipp Zabel" <p.zabel@pengutronix.de>,
	Shuge <shuge@allwinnertech.com>, kevin <kevin@allwinnertech.com>,
	"Hans de Goede" <hdegoede@redhat.com>,
	"Randy Dunlap" <rdunlap@infradead.org>,
	devicetree <devicetree@vger.kernel.org>,
	linux-doc@vger.kernel.org,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	dev <dev@linux-sunxi.org>
Subject: Re: [PATCH v2 7/7] ARM: sunxi: dt: add PRCM clk and reset controller subdevices
Date: Thu, 08 May 2014 22:08:17 +0200	[thread overview]
Message-ID: <536BE431.50007@free-electrons.com> (raw)
In-Reply-To: <20140508142934.GV7047@lukather>


On 08/05/2014 16:29, Maxime Ripard wrote:
> On Thu, May 08, 2014 at 11:40:59AM +0800, Chen-Yu Tsai wrote:
>>>> +                     apb0_gates: apb0_gates_clk {
>>>> +                             compatible = "allwinner,sun6i-a31-apb0-gates-clk";
>>>> +                             #clock-cells = <1>;
>>>> +                             clocks = <&apb0>;
>>>> +                             clock-output-names = "apb0_pio", "apb0_ir",
>>>> +                                             "apb0_timer01", "apb0_p2wi",
>>> timer01 ? is this a typo?
>> A23 manual lists the clock gate as "r_timer0_1", so I put the name on the wiki.
>> Allwinner sun6i code uses "r_tmr" or just "tmr". I see no problem naming this
>> clock output as "apb0_timer" though.
> Yep, it seems better.

Fair enough, I'll change the name for the next version.

>
> Maxime
>

-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com


  reply	other threads:[~2014-05-08 20:08 UTC|newest]

Thread overview: 71+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-07 17:25 [PATCH v2 0/7] mfd: add basic sun6i A31 PRCM support Boris BREZILLON
2014-05-07 17:25 ` Boris BREZILLON
2014-05-07 17:25 ` [PATCH v2 1/7] reset: sunxi: document sunxi's reset controllers bindings Boris BREZILLON
2014-05-07 17:25   ` Boris BREZILLON
2014-05-07 17:25   ` Boris BREZILLON
2014-05-08  3:05   ` Maxime Ripard
2014-05-08  3:05     ` Maxime Ripard
2014-05-07 17:25 ` [PATCH v2 2/7] reset: sunxi: allow MFD subdevices probe Boris BREZILLON
2014-05-07 17:25   ` Boris BREZILLON
2014-05-07 17:25   ` Boris BREZILLON
2014-05-08  3:07   ` Maxime Ripard
2014-05-08  3:07     ` Maxime Ripard
2014-05-08  3:07     ` Maxime Ripard
2014-05-08 20:05     ` Boris BREZILLON
2014-05-08 20:05       ` Boris BREZILLON
2014-05-08 20:05       ` Boris BREZILLON
2014-05-07 17:25 ` [PATCH v2 3/7] mfd: add support for sun6i PRCM (Power/Reset/Clock Management) unit Boris BREZILLON
2014-05-07 17:25   ` Boris BREZILLON
2014-05-07 17:25   ` Boris BREZILLON
2014-05-08  3:09   ` Maxime Ripard
2014-05-08  3:09     ` Maxime Ripard
2014-05-08 11:02   ` Lee Jones
2014-05-08 11:02     ` Lee Jones
2014-05-08 20:04     ` Boris BREZILLON
2014-05-08 20:04       ` Boris BREZILLON
2014-05-09  5:05       ` [linux-sunxi] " Priit Laes
2014-05-09  5:05         ` Priit Laes
2014-05-09  5:05         ` Priit Laes
2014-05-09  7:11         ` [linux-sunxi] " Lee Jones
2014-05-09  7:11           ` Lee Jones
2014-05-09  7:12       ` Lee Jones
2014-05-09  7:12         ` Lee Jones
2014-05-09  7:34         ` Hans de Goede
2014-05-09  7:34           ` Hans de Goede
2014-05-09  7:34           ` Hans de Goede
2014-05-09  8:08           ` Lee Jones
2014-05-09  8:08             ` Lee Jones
2014-05-09  8:08             ` Lee Jones
2014-05-09  8:18             ` Hans de Goede
2014-05-09  8:18               ` Hans de Goede
2014-05-09  8:28               ` Boris BREZILLON
2014-05-09  8:28                 ` Boris BREZILLON
2014-05-09  8:28                 ` Boris BREZILLON
2014-05-09  8:59                 ` Lee Jones
2014-05-09  8:59                   ` Lee Jones
2014-05-07 17:25 ` [PATCH v2 4/7] mfd: sun6i-prcm: document DT bindings Boris BREZILLON
2014-05-07 17:25   ` Boris BREZILLON
2014-05-07 17:25   ` Boris BREZILLON
2014-05-07 17:25 ` [PATCH v2 5/7] clk: sunxi: add PRCM (Power/Reset/Clock Management) clks support Boris BREZILLON
2014-05-07 17:25   ` Boris BREZILLON
2014-05-07 17:25   ` Boris BREZILLON
2014-05-08  3:11   ` Maxime Ripard
2014-05-08  3:11     ` Maxime Ripard
2014-05-08  3:11     ` Maxime Ripard
2014-05-07 17:25 ` [PATCH v2 6/7] clk: sunxi: document PRCM clock compatible strings Boris BREZILLON
2014-05-07 17:25   ` Boris BREZILLON
2014-05-07 17:25   ` Boris BREZILLON
2014-05-07 17:25 ` [PATCH v2 7/7] ARM: sunxi: dt: add PRCM clk and reset controller subdevices Boris BREZILLON
2014-05-07 17:25   ` Boris BREZILLON
2014-05-07 17:25   ` Boris BREZILLON
2014-05-08  3:17   ` Maxime Ripard
2014-05-08  3:17     ` Maxime Ripard
2014-05-08  3:17     ` Maxime Ripard
2014-05-08  3:40     ` Chen-Yu Tsai
2014-05-08  3:40       ` Chen-Yu Tsai
2014-05-08  3:40       ` Chen-Yu Tsai
2014-05-08 14:29       ` Maxime Ripard
2014-05-08 14:29         ` Maxime Ripard
2014-05-08 14:29         ` Maxime Ripard
2014-05-08 20:08         ` Boris BREZILLON [this message]
2014-05-08 20:08           ` Boris BREZILLON

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=536BE431.50007@free-electrons.com \
    --to=boris.brezillon@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.