* libxl: default behavior when libxl fail to map an IRQ
@ 2014-05-14 16:34 Julien Grall
2014-05-14 16:43 ` Ian Campbell
0 siblings, 1 reply; 3+ messages in thread
From: Julien Grall @ 2014-05-14 16:34 UTC (permalink / raw)
To: Ian Campbell, Ian Jackson, Stefano Stabellini, xen-devel
Hello all,
It seems that libxl continue to create the domain even when the function
domcreate_launch (tools/libxl/libxl_create.c) fails to map an IRQ to a
domain.
I looked at the code and libxl only prints an error message when an
error occurred. It's the same thing for MMIO and ioport.
Shouldn't we stop to create the domain when something is failing?
Regards,
--
Julien Grall
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: libxl: default behavior when libxl fail to map an IRQ
2014-05-14 16:34 libxl: default behavior when libxl fail to map an IRQ Julien Grall
@ 2014-05-14 16:43 ` Ian Campbell
2014-05-14 16:48 ` Julien Grall
0 siblings, 1 reply; 3+ messages in thread
From: Ian Campbell @ 2014-05-14 16:43 UTC (permalink / raw)
To: Julien Grall; +Cc: xen-devel, Ian Jackson, Stefano Stabellini
On Wed, 2014-05-14 at 17:34 +0100, Julien Grall wrote:
> Hello all,
>
> It seems that libxl continue to create the domain even when the function
> domcreate_launch (tools/libxl/libxl_create.c) fails to map an IRQ to a
> domain.
>
> I looked at the code and libxl only prints an error message when an
> error occurred. It's the same thing for MMIO and ioport.
>
> Shouldn't we stop to create the domain when something is failing?
yeah, it seems like all three of those loops are missing a goto
error_out.
Ian.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: libxl: default behavior when libxl fail to map an IRQ
2014-05-14 16:43 ` Ian Campbell
@ 2014-05-14 16:48 ` Julien Grall
0 siblings, 0 replies; 3+ messages in thread
From: Julien Grall @ 2014-05-14 16:48 UTC (permalink / raw)
To: Ian Campbell; +Cc: xen-devel, Ian Jackson, Stefano Stabellini
On 05/14/2014 05:43 PM, Ian Campbell wrote:
> On Wed, 2014-05-14 at 17:34 +0100, Julien Grall wrote:
>> Hello all,
>>
>> It seems that libxl continue to create the domain even when the function
>> domcreate_launch (tools/libxl/libxl_create.c) fails to map an IRQ to a
>> domain.
>>
>> I looked at the code and libxl only prints an error message when an
>> error occurred. It's the same thing for MMIO and ioport.
>>
>> Shouldn't we stop to create the domain when something is failing?
>
> yeah, it seems like all three of those loops are missing a goto
> error_out.
Thanks for you answer. I will write a patch to add a goto in theses loop.
Regards,
--
Julien Grall
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-05-14 16:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-14 16:34 libxl: default behavior when libxl fail to map an IRQ Julien Grall
2014-05-14 16:43 ` Ian Campbell
2014-05-14 16:48 ` Julien Grall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.