All of lore.kernel.org
 help / color / mirror / Atom feed
From: jiri.prchal@aksignal.cz (Jiří Prchal)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: at91: at91sam9x5: sets NPCS0 (PA14) back to GPIO
Date: Fri, 25 Jul 2014 10:37:31 +0200	[thread overview]
Message-ID: <53D2174B.4020403@aksignal.cz> (raw)
In-Reply-To: <20140725083053.GD9532@piout.net>



Dne 25.7.2014 v 10:30 Alexandre Belloni napsal(a):
> Hi,
>
> On 25/07/2014 at 08:14:40 +0200, Ji?? Prchal wrote :
>> I'm using custom board. My spi node:
>> 			spi0: spi at f0000000 {
>
> You should override the pinctrl here as you are using gpios for the cs.
> 				pinctrl-0 = <&pinctrl_spi0_custom>;
>
>> 				status = "okay";
>> 				cs-gpios = <&pioA 23 0
>> 					    &pioA 22 0
>> 					    &pioC 29 0
>> 					    &pioA 14 0>;
>>
>
> 		pinctrl at fffff400 {
> 				spi0 {
> 					 pinctrl_spi0_custom: spi0-custom {
> 							 atmel,pins =
> 									 <AT91_PIOA 23 AT91_PERIPH_GPIO AT91_PINCTRL_NONE>,
> 									 <AT91_PIOA 22 AT91_PERIPH_GPIO AT91_PINCTRL_NONE>,
> 									 <AT91_PIOC 29 AT91_PERIPH_GPIO AT91_PINCTRL_NONE>,
> 									 <AT91_PIOA 14 AT91_PERIPH_GPIO AT91_PINCTRL_NONE>;
> 					 };
> 				};
> 		};
>
Of course, it's the way, but in all other drivers, for example LEDS, it's not needed. And in other way, if I will not 
use PA14 at all, the pin will goes down every spi transfer.

WARNING: multiple messages have this Message-ID (diff)
From: "Jiří Prchal" <jiri.prchal@aksignal.cz>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: Boris BREZILLON <boris.brezillon@free-electrons.com>,
	devicetree@vger.kernel.org, nicolas.ferre@atmel.com,
	linux-arm-kernel@lists.infradead.org,
	Bo Shen <voice.shen@atmel.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: at91: at91sam9x5: sets NPCS0 (PA14) back to GPIO
Date: Fri, 25 Jul 2014 10:37:31 +0200	[thread overview]
Message-ID: <53D2174B.4020403@aksignal.cz> (raw)
In-Reply-To: <20140725083053.GD9532@piout.net>



Dne 25.7.2014 v 10:30 Alexandre Belloni napsal(a):
> Hi,
>
> On 25/07/2014 at 08:14:40 +0200, Jiří Prchal wrote :
>> I'm using custom board. My spi node:
>> 			spi0: spi@f0000000 {
>
> You should override the pinctrl here as you are using gpios for the cs.
> 				pinctrl-0 = <&pinctrl_spi0_custom>;
>
>> 				status = "okay";
>> 				cs-gpios = <&pioA 23 0
>> 					    &pioA 22 0
>> 					    &pioC 29 0
>> 					    &pioA 14 0>;
>>
>
> 		pinctrl@fffff400 {
> 				spi0 {
> 					 pinctrl_spi0_custom: spi0-custom {
> 							 atmel,pins =
> 									 <AT91_PIOA 23 AT91_PERIPH_GPIO AT91_PINCTRL_NONE>,
> 									 <AT91_PIOA 22 AT91_PERIPH_GPIO AT91_PINCTRL_NONE>,
> 									 <AT91_PIOC 29 AT91_PERIPH_GPIO AT91_PINCTRL_NONE>,
> 									 <AT91_PIOA 14 AT91_PERIPH_GPIO AT91_PINCTRL_NONE>;
> 					 };
> 				};
> 		};
>
Of course, it's the way, but in all other drivers, for example LEDS, it's not needed. And in other way, if I will not 
use PA14 at all, the pin will goes down every spi transfer.

  parent reply	other threads:[~2014-07-25  8:37 UTC|newest]

Thread overview: 73+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-11 10:22 [PATCH] ARM: at91: at91sam9x5: add clocks for usb device Bo Shen
2014-07-11 10:22 ` Bo Shen
2014-07-11 10:22 ` Bo Shen
2014-07-11 10:47 ` Alexandre Belloni
2014-07-11 10:47   ` Alexandre Belloni
2014-07-11 10:47   ` Alexandre Belloni
2014-07-11 10:55   ` Jiří Prchal
2014-07-11 10:55     ` Jiří Prchal
2014-07-24 13:38 ` [PATCH] ARM: at91: at91sam9x5: sets NPCS0 (PA14) back to GPIO Jiří Prchal
2014-07-24 13:38   ` Jiří Prchal
2014-07-24 13:38   ` Jiří Prchal
2014-07-24 14:26   ` Boris BREZILLON
2014-07-24 14:26     ` Boris BREZILLON
2014-07-24 15:06     ` Jiří Prchal
2014-07-24 15:06       ` Jiří Prchal
2014-07-24 15:58       ` Boris BREZILLON
2014-07-24 15:58         ` Boris BREZILLON
2014-07-25  6:14         ` Jiří Prchal
2014-07-25  6:14           ` Jiří Prchal
2014-07-25  6:14           ` Jiří Prchal
2014-07-25  7:53           ` Boris BREZILLON
2014-07-25  7:53             ` Boris BREZILLON
2014-07-25  7:53             ` Boris BREZILLON
2014-07-25  8:27             ` Jiří Prchal
2014-07-25  8:27               ` Jiří Prchal
2014-07-25  8:27               ` Jiří Prchal
2014-07-25  8:45               ` Boris BREZILLON
2014-07-25  8:45                 ` Boris BREZILLON
2014-07-25  8:54                 ` Jiří Prchal
2014-07-25  8:54                   ` Jiří Prchal
2014-07-25  8:54                   ` Jiří Prchal
2014-07-25  9:01                   ` Boris BREZILLON
2014-07-25  9:01                     ` Boris BREZILLON
2014-07-25  9:13                     ` Jiří Prchal
2014-07-25  9:13                       ` Jiří Prchal
2014-07-25  9:13                       ` Jiří Prchal
2014-07-25  9:31                       ` Boris BREZILLON
2014-07-25  9:31                         ` Boris BREZILLON
2014-07-25  9:31                         ` Boris BREZILLON
2014-07-25 10:06                         ` Jiří Prchal
2014-07-25 10:06                           ` Jiří Prchal
2014-07-25 10:06                           ` Jiří Prchal
2014-07-25 10:18                           ` Boris BREZILLON
2014-07-25 10:18                             ` Boris BREZILLON
2014-07-25 10:32                             ` Jiří Prchal
2014-07-25 10:32                               ` Jiří Prchal
2014-07-25 10:32                               ` Jiří Prchal
2014-07-25 11:34                               ` Boris BREZILLON
2014-07-25 11:34                                 ` Boris BREZILLON
2014-07-25 11:34                                 ` Boris BREZILLON
2014-07-25  8:33             ` Jiří Prchal
2014-07-25  8:33               ` Jiří Prchal
2014-07-25  8:30           ` Alexandre Belloni
2014-07-25  8:30             ` Alexandre Belloni
2014-07-25  8:30             ` Alexandre Belloni
2014-07-25  8:36             ` Boris BREZILLON
2014-07-25  8:36               ` Boris BREZILLON
2014-07-25  8:50               ` Alexandre Belloni
2014-07-25  8:50                 ` Alexandre Belloni
2014-07-25  8:50                 ` Alexandre Belloni
2014-07-25  8:37             ` Jiří Prchal [this message]
2014-07-25  8:37               ` Jiří Prchal
2014-07-25  8:54               ` Alexandre Belloni
2014-07-25  8:54                 ` Alexandre Belloni
2014-07-25  8:59                 ` Jiří Prchal
2014-07-25  8:59                   ` Jiří Prchal
2014-07-25  8:59                   ` Jiří Prchal
2014-07-25  9:02                   ` Alexandre Belloni
2014-07-25  9:02                     ` Alexandre Belloni
2014-07-25  9:10                   ` Boris BREZILLON
2014-07-25  9:10                     ` Boris BREZILLON
2014-07-25  9:40                     ` Jiří Prchal
2014-07-25  9:40                       ` Jiří Prchal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53D2174B.4020403@aksignal.cz \
    --to=jiri.prchal@aksignal.cz \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.