All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kukjin Kim <kgene.kim@samsung.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: linux-samsung-soc@vger.kernel.org,
	Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, Kukjin Kim <kgene.kim@samsung.com>,
	Vincent Palatin <vpalatin@chromium.org>,
	Pawel Moll <pawel.moll@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	open list <linux-kernel@vger.kernel.org>,
	Kumar Gala <galak@codeaurora.org>,
	Stephan van Schaik <stephan@synkhronix.com>,
	Doug Anderson <dianders@chromium.org>,
	Jaehoon Chung <jh80.chung@samsung.com>,
	Rob Herring <robh+dt@kernel.org>, Ben Dooks <ben-linux@fluff.org>,
	Russell King <linux@arm.linux.org.uk>,
	Javier Martinez Canillas <javier.martinez@collabora.co.uk>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 1/4] ARM: dts: Fix MMC pinctrl for exynos5250-snow
Date: Fri, 01 Aug 2014 03:41:37 +0900	[thread overview]
Message-ID: <53DA8DE1.10601@samsung.com> (raw)
In-Reply-To: <1406822910-6255-2-git-send-email-afaerber@suse.de>

On 08/01/14 01:08, Andreas Färber wrote:
> The pinctrl properties should be on the device directly and not on the
> slot sub-node.
>
> Reported-by: Doug Anderson<dianders@chromium.org>
> Cc: Jaehoon Chung<jh80.chung@samsung.com>
> Signed-off-by: Andreas Färber<afaerber@suse.de>
> ---
>   v3 ->  v4: Unchanged
>
>   v3: New (Doug Anderson)
>   Redundant with Jaehoon Chung's general slot@0 deprecation,
>   in case that hits the tree earlier.
>
>   arch/arm/boot/dts/exynos5250-snow.dts | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts
> index f2b8c4116541..eb437f6afec1 100644
> --- a/arch/arm/boot/dts/exynos5250-snow.dts
> +++ b/arch/arm/boot/dts/exynos5250-snow.dts
> @@ -240,10 +240,8 @@
>   	 */
>   	mmc@12230000 {
>   		status = "okay";
> -		slot@0 {
> -			pinctrl-names = "default";
> -			pinctrl-0 =<&sd3_clk&sd3_cmd&sd3_bus4>;
> -		};
> +		pinctrl-names = "default";
> +		pinctrl-0 =<&sd3_clk&sd3_cmd&sd3_bus4>;
>   	};
>
>   	i2c@12CD0000 {

Once I get Doug's reviewed tag on exynos5250-snow dt changes, I will 
take this series :) Though Doug suggested or reported...

Thanks,
Kukjin

WARNING: multiple messages have this Message-ID (diff)
From: kgene.kim@samsung.com (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 1/4] ARM: dts: Fix MMC pinctrl for exynos5250-snow
Date: Fri, 01 Aug 2014 03:41:37 +0900	[thread overview]
Message-ID: <53DA8DE1.10601@samsung.com> (raw)
In-Reply-To: <1406822910-6255-2-git-send-email-afaerber@suse.de>

On 08/01/14 01:08, Andreas F?rber wrote:
> The pinctrl properties should be on the device directly and not on the
> slot sub-node.
>
> Reported-by: Doug Anderson<dianders@chromium.org>
> Cc: Jaehoon Chung<jh80.chung@samsung.com>
> Signed-off-by: Andreas F?rber<afaerber@suse.de>
> ---
>   v3 ->  v4: Unchanged
>
>   v3: New (Doug Anderson)
>   Redundant with Jaehoon Chung's general slot at 0 deprecation,
>   in case that hits the tree earlier.
>
>   arch/arm/boot/dts/exynos5250-snow.dts | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts
> index f2b8c4116541..eb437f6afec1 100644
> --- a/arch/arm/boot/dts/exynos5250-snow.dts
> +++ b/arch/arm/boot/dts/exynos5250-snow.dts
> @@ -240,10 +240,8 @@
>   	 */
>   	mmc at 12230000 {
>   		status = "okay";
> -		slot at 0 {
> -			pinctrl-names = "default";
> -			pinctrl-0 =<&sd3_clk&sd3_cmd&sd3_bus4>;
> -		};
> +		pinctrl-names = "default";
> +		pinctrl-0 =<&sd3_clk&sd3_cmd&sd3_bus4>;
>   	};
>
>   	i2c at 12CD0000 {

Once I get Doug's reviewed tag on exynos5250-snow dt changes, I will 
take this series :) Though Doug suggested or reported...

Thanks,
Kukjin

  reply	other threads:[~2014-07-31 18:41 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-31 16:08 [PATCH v4 0/4] ARM: dts: exynos: Prepare Spring Andreas Färber
2014-07-31 16:08 ` Andreas Färber
2014-07-31 16:08 ` [PATCH v4 1/4] ARM: dts: Fix MMC pinctrl for exynos5250-snow Andreas Färber
2014-07-31 16:08   ` Andreas Färber
2014-07-31 16:08   ` Andreas Färber
2014-07-31 18:41   ` Kukjin Kim [this message]
2014-07-31 18:41     ` Kukjin Kim
2014-07-31 19:20   ` Tomasz Figa
2014-07-31 19:20     ` Tomasz Figa
2014-07-31 16:08 ` [PATCH v4 2/4] ARM: dts: Fold exynos5250-cros-common into exynos5250-snow Andreas Färber
2014-07-31 16:08   ` Andreas Färber
2014-07-31 16:08   ` Andreas Färber
2014-07-31 19:22   ` Tomasz Figa
2014-07-31 19:22     ` Tomasz Figa
2014-07-31 16:08 ` [PATCH v4 3/4] ARM: dts: Clean up exynos5250-snow Andreas Färber
2014-07-31 16:08   ` Andreas Färber
2014-07-31 16:08   ` Andreas Färber
2014-07-31 19:19   ` Tomasz Figa
2014-07-31 19:19     ` Tomasz Figa
2014-07-31 19:21     ` Andreas Färber
2014-07-31 19:21       ` Andreas Färber
2014-07-31 16:08 ` [PATCH v4 4/4] ARM: dts: Add exynos5250-spring device tree Andreas Färber
2014-07-31 16:08   ` Andreas Färber
2014-07-31 16:08   ` Andreas Färber
2014-07-31 17:00   ` Vincent Palatin
2014-07-31 17:00     ` Vincent Palatin
2014-07-31 17:14     ` Andreas Färber
2014-07-31 17:14       ` Andreas Färber
2014-07-31 17:38       ` Andreas Färber
2014-07-31 17:38         ` Andreas Färber
2014-07-31 18:51       ` Vincent Palatin
2014-07-31 18:51         ` Vincent Palatin
     [not found]   ` <1406822910-6255-5-git-send-email-afaerber-l3A5Bk7waGM@public.gmane.org>
2014-07-31 19:05     ` Tomasz Figa
2014-07-31 19:05       ` Tomasz Figa
2014-07-31 19:05       ` Tomasz Figa
2014-07-31 19:20       ` Andreas Färber
2014-07-31 19:20         ` Andreas Färber
2014-07-31 19:40         ` Tomasz Figa
2014-07-31 19:40           ` Tomasz Figa
2014-07-31 23:17           ` Andreas Färber
2014-07-31 23:17             ` Andreas Färber
     [not found]             ` <53DACE73.8080009-l3A5Bk7waGM@public.gmane.org>
2014-07-31 23:26               ` Tomasz Figa
2014-07-31 23:26                 ` Tomasz Figa
2014-07-31 23:26                 ` Tomasz Figa
2014-07-31 23:31                 ` Andreas Färber
2014-07-31 23:31                   ` Andreas Färber
2014-08-02  5:15           ` Doug Anderson
2014-08-02  5:15             ` Doug Anderson
2014-08-02  7:49             ` Andreas Färber
2014-08-02  7:49               ` Andreas Färber
2014-07-31 20:36       ` Andreas Färber
2014-07-31 20:36         ` Andreas Färber
2014-07-31 21:09         ` Tomasz Figa
2014-07-31 21:09           ` Tomasz Figa
2014-08-01  3:17       ` Andreas Färber
2014-08-01  3:17         ` Andreas Färber
2014-08-02 12:40         ` Tomasz Figa
2014-08-02 12:40           ` Tomasz Figa
2014-07-31 16:21 ` [PATCH v4 0/4] ARM: dts: exynos: Prepare Spring Andreas Färber
2014-07-31 16:21   ` Andreas Färber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53DA8DE1.10601@samsung.com \
    --to=kgene.kim@samsung.com \
    --cc=afaerber@suse.de \
    --cc=ben-linux@fluff.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=javier.martinez@collabora.co.uk \
    --cc=jh80.chung@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=stephan@synkhronix.com \
    --cc=vpalatin@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.