From: Tomasz Figa <tomasz.figa@gmail.com>
To: "Andreas Färber" <afaerber@suse.de>, linux-samsung-soc@vger.kernel.org
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Kukjin Kim <kgene.kim@samsung.com>,
Vincent Palatin <vpalatin@chromium.org>,
Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
open list <linux-kernel@vger.kernel.org>,
Kumar Gala <galak@codeaurora.org>,
Stephan van Schaik <stephan@synkhronix.com>,
Doug Anderson <dianders@chromium.org>,
Rob Herring <robh+dt@kernel.org>, Ben Dooks <ben-linux@fluff.org>,
Russell King <linux@arm.linux.org.uk>,
Javier Martinez Canillas <javier.martinez@collabora.co.uk>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 3/4] ARM: dts: Clean up exynos5250-snow
Date: Thu, 31 Jul 2014 21:19:35 +0200 [thread overview]
Message-ID: <53DA96C7.30009@gmail.com> (raw)
In-Reply-To: <1406822910-6255-4-git-send-email-afaerber@suse.de>
Andreas,
Please see my comments inline.
On 31.07.2014 18:08, Andreas Färber wrote:
> Use the new style of referencing inherited nodes and use symbolic names.
>
> Suggested-by: Doug Anderson <dianders@chromium.org>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
[snip]
> -
> usb@12110000 {
> - samsung,vbus-gpio = <&gpx1 1 0>;
> + samsung,vbus-gpio = <&gpx1 1 GPIO_ACTIVE_HIGH>;
> };
This is a higher level node being overridden, so it should be specified
using references too.
>
> fixed-rate-clocks {
> @@ -287,7 +206,7 @@
> };
>
> hdmi {
Ditto.
Best regards,
Tomasz
WARNING: multiple messages have this Message-ID (diff)
From: tomasz.figa@gmail.com (Tomasz Figa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 3/4] ARM: dts: Clean up exynos5250-snow
Date: Thu, 31 Jul 2014 21:19:35 +0200 [thread overview]
Message-ID: <53DA96C7.30009@gmail.com> (raw)
In-Reply-To: <1406822910-6255-4-git-send-email-afaerber@suse.de>
Andreas,
Please see my comments inline.
On 31.07.2014 18:08, Andreas F?rber wrote:
> Use the new style of referencing inherited nodes and use symbolic names.
>
> Suggested-by: Doug Anderson <dianders@chromium.org>
> Signed-off-by: Andreas F?rber <afaerber@suse.de>
[snip]
> -
> usb at 12110000 {
> - samsung,vbus-gpio = <&gpx1 1 0>;
> + samsung,vbus-gpio = <&gpx1 1 GPIO_ACTIVE_HIGH>;
> };
This is a higher level node being overridden, so it should be specified
using references too.
>
> fixed-rate-clocks {
> @@ -287,7 +206,7 @@
> };
>
> hdmi {
Ditto.
Best regards,
Tomasz
next prev parent reply other threads:[~2014-07-31 19:19 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-31 16:08 [PATCH v4 0/4] ARM: dts: exynos: Prepare Spring Andreas Färber
2014-07-31 16:08 ` Andreas Färber
2014-07-31 16:08 ` [PATCH v4 1/4] ARM: dts: Fix MMC pinctrl for exynos5250-snow Andreas Färber
2014-07-31 16:08 ` Andreas Färber
2014-07-31 16:08 ` Andreas Färber
2014-07-31 18:41 ` Kukjin Kim
2014-07-31 18:41 ` Kukjin Kim
2014-07-31 19:20 ` Tomasz Figa
2014-07-31 19:20 ` Tomasz Figa
2014-07-31 16:08 ` [PATCH v4 2/4] ARM: dts: Fold exynos5250-cros-common into exynos5250-snow Andreas Färber
2014-07-31 16:08 ` Andreas Färber
2014-07-31 16:08 ` Andreas Färber
2014-07-31 19:22 ` Tomasz Figa
2014-07-31 19:22 ` Tomasz Figa
2014-07-31 16:08 ` [PATCH v4 3/4] ARM: dts: Clean up exynos5250-snow Andreas Färber
2014-07-31 16:08 ` Andreas Färber
2014-07-31 16:08 ` Andreas Färber
2014-07-31 19:19 ` Tomasz Figa [this message]
2014-07-31 19:19 ` Tomasz Figa
2014-07-31 19:21 ` Andreas Färber
2014-07-31 19:21 ` Andreas Färber
2014-07-31 16:08 ` [PATCH v4 4/4] ARM: dts: Add exynos5250-spring device tree Andreas Färber
2014-07-31 16:08 ` Andreas Färber
2014-07-31 16:08 ` Andreas Färber
2014-07-31 17:00 ` Vincent Palatin
2014-07-31 17:00 ` Vincent Palatin
2014-07-31 17:14 ` Andreas Färber
2014-07-31 17:14 ` Andreas Färber
2014-07-31 17:38 ` Andreas Färber
2014-07-31 17:38 ` Andreas Färber
2014-07-31 18:51 ` Vincent Palatin
2014-07-31 18:51 ` Vincent Palatin
[not found] ` <1406822910-6255-5-git-send-email-afaerber-l3A5Bk7waGM@public.gmane.org>
2014-07-31 19:05 ` Tomasz Figa
2014-07-31 19:05 ` Tomasz Figa
2014-07-31 19:05 ` Tomasz Figa
2014-07-31 19:20 ` Andreas Färber
2014-07-31 19:20 ` Andreas Färber
2014-07-31 19:40 ` Tomasz Figa
2014-07-31 19:40 ` Tomasz Figa
2014-07-31 23:17 ` Andreas Färber
2014-07-31 23:17 ` Andreas Färber
[not found] ` <53DACE73.8080009-l3A5Bk7waGM@public.gmane.org>
2014-07-31 23:26 ` Tomasz Figa
2014-07-31 23:26 ` Tomasz Figa
2014-07-31 23:26 ` Tomasz Figa
2014-07-31 23:31 ` Andreas Färber
2014-07-31 23:31 ` Andreas Färber
2014-08-02 5:15 ` Doug Anderson
2014-08-02 5:15 ` Doug Anderson
2014-08-02 7:49 ` Andreas Färber
2014-08-02 7:49 ` Andreas Färber
2014-07-31 20:36 ` Andreas Färber
2014-07-31 20:36 ` Andreas Färber
2014-07-31 21:09 ` Tomasz Figa
2014-07-31 21:09 ` Tomasz Figa
2014-08-01 3:17 ` Andreas Färber
2014-08-01 3:17 ` Andreas Färber
2014-08-02 12:40 ` Tomasz Figa
2014-08-02 12:40 ` Tomasz Figa
2014-07-31 16:21 ` [PATCH v4 0/4] ARM: dts: exynos: Prepare Spring Andreas Färber
2014-07-31 16:21 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53DA96C7.30009@gmail.com \
--to=tomasz.figa@gmail.com \
--cc=afaerber@suse.de \
--cc=ben-linux@fluff.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=javier.martinez@collabora.co.uk \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=stephan@synkhronix.com \
--cc=vpalatin@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.