All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Greear <greearb@candelatech.com>
To: Michal Kazior <michal.kazior@tieto.com>,
	Kalle Valo <kvalo@qca.qualcomm.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
	"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: [PATCH v7 3/8] ath10k: save firmware debug log messages
Date: Tue, 19 Aug 2014 08:16:31 -0700	[thread overview]
Message-ID: <53F36A4F.5050505@candelatech.com> (raw)
In-Reply-To: <CA+BoTQ=UduqFY6G=sXJR43hQWk-4v09uYvYJYKO7EGuea7L-Xg@mail.gmail.com>


>>> +       spin_lock_bh(&ar->data_lock);
>>> +
>>> +       /* First 4 bytes are a messages-dropped-due-to-overflow counter,
>>> +        * and should not be recorded in the dbglog buffer, so we skip
>>> +        * them.
>>> +        */
>>> +       ath10k_debug_dbglog_add(ar, skb->data + 4, skb->len - 4);
>
> Can't we just:
>
> struct wmi_dbg_msg {
>    __le32 num_dropped_due_to_overflow;
>    u8 payload[0]; // is this an array of u8 or __le32 actually?
> };

When I wrote this, I was more paranoid about exposing
any possible details of firmware.  It is an array of 32-bit ints in firmware,
and it decodes as ints instead of bytes, so probably u32 payload instead of u8.

Thanks,
Ben


-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Ben Greear <greearb@candelatech.com>
To: Michal Kazior <michal.kazior@tieto.com>,
	Kalle Valo <kvalo@qca.qualcomm.com>
Cc: "ath10k@lists.infradead.org" <ath10k@lists.infradead.org>,
	linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v7 3/8] ath10k: save firmware debug log messages
Date: Tue, 19 Aug 2014 08:16:31 -0700	[thread overview]
Message-ID: <53F36A4F.5050505@candelatech.com> (raw)
In-Reply-To: <CA+BoTQ=UduqFY6G=sXJR43hQWk-4v09uYvYJYKO7EGuea7L-Xg@mail.gmail.com>


>>> +       spin_lock_bh(&ar->data_lock);
>>> +
>>> +       /* First 4 bytes are a messages-dropped-due-to-overflow counter,
>>> +        * and should not be recorded in the dbglog buffer, so we skip
>>> +        * them.
>>> +        */
>>> +       ath10k_debug_dbglog_add(ar, skb->data + 4, skb->len - 4);
>
> Can't we just:
>
> struct wmi_dbg_msg {
>    __le32 num_dropped_due_to_overflow;
>    u8 payload[0]; // is this an array of u8 or __le32 actually?
> };

When I wrote this, I was more paranoid about exposing
any possible details of firmware.  It is an array of 32-bit ints in firmware,
and it decodes as ints instead of bytes, so probably u32 payload instead of u8.

Thanks,
Ben


-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com

  reply	other threads:[~2014-08-19 15:16 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-19  8:22 [PATCH v7 0/8] ath10k: firmware crash dump Kalle Valo
2014-08-19  8:22 ` Kalle Valo
2014-08-19  8:22 ` [PATCH v7 1/8] ath10k: add ath10k_pci_diag_* helpers Kalle Valo
2014-08-19  8:22   ` Kalle Valo
2014-08-19  8:22 ` [PATCH v7 2/8] ath10k: provide firmware crash info via debugfs Kalle Valo
2014-08-19  8:22   ` Kalle Valo
2014-08-19  9:33   ` Michal Kazior
2014-08-19  9:33     ` Michal Kazior
2014-08-19 15:25     ` Ben Greear
2014-08-19 15:25       ` Ben Greear
2014-08-19 16:05       ` Ben Greear
2014-08-19 16:05         ` Ben Greear
2014-08-20  7:36         ` Kalle Valo
2014-08-20  7:36           ` Kalle Valo
2014-08-20  6:28       ` Michal Kazior
2014-08-20  6:28         ` Michal Kazior
2014-08-20  6:48         ` Kalle Valo
2014-08-20  6:48           ` Kalle Valo
2014-08-20  6:56           ` Kalle Valo
2014-08-20  6:56             ` Kalle Valo
2014-08-20 13:13         ` Ben Greear
2014-08-20 13:13           ` Ben Greear
2014-08-20  7:29       ` Kalle Valo
2014-08-20  7:29         ` Kalle Valo
2014-08-20 13:08         ` Ben Greear
2014-08-20 13:08           ` Ben Greear
2014-08-20 14:19           ` Kalle Valo
2014-08-20 14:19             ` Kalle Valo
2014-08-20 14:52             ` Ben Greear
2014-08-20 14:52               ` Ben Greear
2014-08-19  8:23 ` [PATCH v7 3/8] ath10k: save firmware debug log messages Kalle Valo
2014-08-19  8:23   ` Kalle Valo
2014-08-19  9:39   ` Michal Kazior
2014-08-19  9:39     ` Michal Kazior
2014-08-19  9:44     ` Michal Kazior
2014-08-19  9:44       ` Michal Kazior
2014-08-19 15:16       ` Ben Greear [this message]
2014-08-19 15:16         ` Ben Greear
2014-08-19  8:23 ` [PATCH v7 4/8] ath10k: save firmware stack upon firmware crash Kalle Valo
2014-08-19  8:23   ` Kalle Valo
2014-08-19  9:37   ` Michal Kazior
2014-08-19  9:37     ` Michal Kazior
2014-08-19  8:23 ` [PATCH v7 5/8] ath10k: dump exception stack contents on " Kalle Valo
2014-08-19  8:23   ` Kalle Valo
2014-08-19  9:38   ` Michal Kazior
2014-08-19  9:38     ` Michal Kazior
2014-08-19  8:23 ` [PATCH v7 6/8] ath10k: save firmware RAM and ROM BSS sections on crash Kalle Valo
2014-08-19  8:23   ` Kalle Valo
2014-08-19  9:39   ` Michal Kazior
2014-08-19  9:39     ` Michal Kazior
2014-08-19  8:23 ` [PATCH v7 7/8] ath10k: rename ath10k_pci_hif_dump_area() to ath10k_pci_fw_crashed_dump() Kalle Valo
2014-08-19  8:23   ` Kalle Valo
2014-08-19  8:23 ` [PATCH v7 8/8] ath10k: print more driver info when firmware crashes Kalle Valo
2014-08-19  8:23   ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53F36A4F.5050505@candelatech.com \
    --to=greearb@candelatech.com \
    --cc=ath10k@lists.infradead.org \
    --cc=kvalo@qca.qualcomm.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=michal.kazior@tieto.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.