From: Ben Greear <greearb@candelatech.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: Kalle Valo <kvalo@qca.qualcomm.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: [PATCH v7 2/8] ath10k: provide firmware crash info via debugfs
Date: Wed, 20 Aug 2014 06:13:32 -0700 [thread overview]
Message-ID: <53F49EFC.5000008@candelatech.com> (raw)
In-Reply-To: <CA+BoTQ=ocpY2BDCGhMB7E9s4ykp18uXHMTc7rOn0qb7mDyZ5qw@mail.gmail.com>
>>> Hmm should this really be sizeof()? Not next_idx (which effectively
>>> defines number of bytes of the dbglog)?
>>
>>
>> I haven't tried decoding this yet, but we may need to know the next_idx
>> to decode this properly.
>
> So basically a (length, payload) encoding would be necessary here
> instead of a single stream, right?
As long as you know the starting point for a message, you can decode the
rest of the message(s) as a stream of 32 bit ints. The current code that
I wrote is a circular buffer, so after first wrap, we lose an idea of where
to start reading.
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Ben Greear <greearb@candelatech.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: Kalle Valo <kvalo@qca.qualcomm.com>,
"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v7 2/8] ath10k: provide firmware crash info via debugfs
Date: Wed, 20 Aug 2014 06:13:32 -0700 [thread overview]
Message-ID: <53F49EFC.5000008@candelatech.com> (raw)
In-Reply-To: <CA+BoTQ=ocpY2BDCGhMB7E9s4ykp18uXHMTc7rOn0qb7mDyZ5qw@mail.gmail.com>
>>> Hmm should this really be sizeof()? Not next_idx (which effectively
>>> defines number of bytes of the dbglog)?
>>
>>
>> I haven't tried decoding this yet, but we may need to know the next_idx
>> to decode this properly.
>
> So basically a (length, payload) encoding would be necessary here
> instead of a single stream, right?
As long as you know the starting point for a message, you can decode the
rest of the message(s) as a stream of 32 bit ints. The current code that
I wrote is a circular buffer, so after first wrap, we lose an idea of where
to start reading.
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2014-08-20 13:13 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-19 8:22 [PATCH v7 0/8] ath10k: firmware crash dump Kalle Valo
2014-08-19 8:22 ` Kalle Valo
2014-08-19 8:22 ` [PATCH v7 1/8] ath10k: add ath10k_pci_diag_* helpers Kalle Valo
2014-08-19 8:22 ` Kalle Valo
2014-08-19 8:22 ` [PATCH v7 2/8] ath10k: provide firmware crash info via debugfs Kalle Valo
2014-08-19 8:22 ` Kalle Valo
2014-08-19 9:33 ` Michal Kazior
2014-08-19 9:33 ` Michal Kazior
2014-08-19 15:25 ` Ben Greear
2014-08-19 15:25 ` Ben Greear
2014-08-19 16:05 ` Ben Greear
2014-08-19 16:05 ` Ben Greear
2014-08-20 7:36 ` Kalle Valo
2014-08-20 7:36 ` Kalle Valo
2014-08-20 6:28 ` Michal Kazior
2014-08-20 6:28 ` Michal Kazior
2014-08-20 6:48 ` Kalle Valo
2014-08-20 6:48 ` Kalle Valo
2014-08-20 6:56 ` Kalle Valo
2014-08-20 6:56 ` Kalle Valo
2014-08-20 13:13 ` Ben Greear [this message]
2014-08-20 13:13 ` Ben Greear
2014-08-20 7:29 ` Kalle Valo
2014-08-20 7:29 ` Kalle Valo
2014-08-20 13:08 ` Ben Greear
2014-08-20 13:08 ` Ben Greear
2014-08-20 14:19 ` Kalle Valo
2014-08-20 14:19 ` Kalle Valo
2014-08-20 14:52 ` Ben Greear
2014-08-20 14:52 ` Ben Greear
2014-08-19 8:23 ` [PATCH v7 3/8] ath10k: save firmware debug log messages Kalle Valo
2014-08-19 8:23 ` Kalle Valo
2014-08-19 9:39 ` Michal Kazior
2014-08-19 9:39 ` Michal Kazior
2014-08-19 9:44 ` Michal Kazior
2014-08-19 9:44 ` Michal Kazior
2014-08-19 15:16 ` Ben Greear
2014-08-19 15:16 ` Ben Greear
2014-08-19 8:23 ` [PATCH v7 4/8] ath10k: save firmware stack upon firmware crash Kalle Valo
2014-08-19 8:23 ` Kalle Valo
2014-08-19 9:37 ` Michal Kazior
2014-08-19 9:37 ` Michal Kazior
2014-08-19 8:23 ` [PATCH v7 5/8] ath10k: dump exception stack contents on " Kalle Valo
2014-08-19 8:23 ` Kalle Valo
2014-08-19 9:38 ` Michal Kazior
2014-08-19 9:38 ` Michal Kazior
2014-08-19 8:23 ` [PATCH v7 6/8] ath10k: save firmware RAM and ROM BSS sections on crash Kalle Valo
2014-08-19 8:23 ` Kalle Valo
2014-08-19 9:39 ` Michal Kazior
2014-08-19 9:39 ` Michal Kazior
2014-08-19 8:23 ` [PATCH v7 7/8] ath10k: rename ath10k_pci_hif_dump_area() to ath10k_pci_fw_crashed_dump() Kalle Valo
2014-08-19 8:23 ` Kalle Valo
2014-08-19 8:23 ` [PATCH v7 8/8] ath10k: print more driver info when firmware crashes Kalle Valo
2014-08-19 8:23 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F49EFC.5000008@candelatech.com \
--to=greearb@candelatech.com \
--cc=ath10k@lists.infradead.org \
--cc=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.