From: David Vrabel <david.vrabel@citrix.com>
To: Jan Beulich <JBeulich@suse.com>, David Vrabel <david.vrabel@citrix.com>
Cc: Juergen Gross <JGross@suse.com>, <boris.ostrovsky@oracle.com>,
<xen-devel@lists.xensource.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [Xen-devel] [PATCH 2/3] xen: eliminate scalability issues from initrd handling
Date: Thu, 4 Sep 2014 15:53:23 +0100 [thread overview]
Message-ID: <54087CE3.6020400@citrix.com> (raw)
In-Reply-To: <540893570200007800030E4C@mail.emea.novell.com>
On 04/09/14 15:29, Jan Beulich wrote:
>>>> On 04.09.14 at 14:52, <david.vrabel@citrix.com> wrote:
>> On 04/09/14 13:38, Juergen Gross wrote:
>>> --- a/arch/x86/xen/xen-head.S
>>> +++ b/arch/x86/xen/xen-head.S
>>> @@ -124,6 +124,9 @@ NEXT_HYPERCALL(arch_6)
>>> ELFNOTE(Xen, XEN_ELFNOTE_L1_MFN_VALID,
>>> .quad _PAGE_PRESENT; .quad _PAGE_PRESENT)
>>> ELFNOTE(Xen, XEN_ELFNOTE_SUSPEND_CANCEL, .long 1)
>>> +#ifdef CONFIG_X86_64
>>> + ELFNOTE(Xen, XEN_ELFNOTE_MOD_START_PFN, .long 1)
>>> +#endif
>>
>> Why X86_64 only? If there's a good reason the commit message needs to
>> explain why.
>
> Does native 32-bit support huge initrd?
Does that matter? If the MOD_START_PFN options works with a 32-bit guest
then it should use it, regardless of whether it is essential or not.
Because this reduces the #ifdef'ery.
David
WARNING: multiple messages have this Message-ID (diff)
From: David Vrabel <david.vrabel@citrix.com>
To: Jan Beulich <JBeulich@suse.com>, David Vrabel <david.vrabel@citrix.com>
Cc: Juergen Gross <JGross@suse.com>,
boris.ostrovsky@oracle.com, xen-devel@lists.xensource.com,
linux-kernel@vger.kernel.org
Subject: Re: [Xen-devel] [PATCH 2/3] xen: eliminate scalability issues from initrd handling
Date: Thu, 4 Sep 2014 15:53:23 +0100 [thread overview]
Message-ID: <54087CE3.6020400@citrix.com> (raw)
In-Reply-To: <540893570200007800030E4C@mail.emea.novell.com>
On 04/09/14 15:29, Jan Beulich wrote:
>>>> On 04.09.14 at 14:52, <david.vrabel@citrix.com> wrote:
>> On 04/09/14 13:38, Juergen Gross wrote:
>>> --- a/arch/x86/xen/xen-head.S
>>> +++ b/arch/x86/xen/xen-head.S
>>> @@ -124,6 +124,9 @@ NEXT_HYPERCALL(arch_6)
>>> ELFNOTE(Xen, XEN_ELFNOTE_L1_MFN_VALID,
>>> .quad _PAGE_PRESENT; .quad _PAGE_PRESENT)
>>> ELFNOTE(Xen, XEN_ELFNOTE_SUSPEND_CANCEL, .long 1)
>>> +#ifdef CONFIG_X86_64
>>> + ELFNOTE(Xen, XEN_ELFNOTE_MOD_START_PFN, .long 1)
>>> +#endif
>>
>> Why X86_64 only? If there's a good reason the commit message needs to
>> explain why.
>
> Does native 32-bit support huge initrd?
Does that matter? If the MOD_START_PFN options works with a 32-bit guest
then it should use it, regardless of whether it is essential or not.
Because this reduces the #ifdef'ery.
David
next prev parent reply other threads:[~2014-09-04 14:53 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-04 12:38 [PATCH 0/3] xen: remove memory limits from pv-domains Juergen Gross
2014-09-04 12:38 ` [PATCH 1/3] xen: sync some headers with xen tree Juergen Gross
2014-09-04 12:52 ` Jan Beulich
2014-09-04 12:52 ` Jan Beulich
2014-09-05 8:06 ` Juergen Gross
2014-09-04 12:38 ` [PATCH 2/3] xen: eliminate scalability issues from initrd handling Juergen Gross
2014-09-04 12:52 ` David Vrabel
2014-09-04 12:52 ` David Vrabel
2014-09-04 14:29 ` Jan Beulich
2014-09-04 14:29 ` Jan Beulich
2014-09-04 14:53 ` David Vrabel [this message]
2014-09-04 14:53 ` [Xen-devel] " David Vrabel
2014-09-05 8:04 ` Juergen Gross
2014-09-04 12:38 ` [PATCH 3/3] xen: eliminate scalability issues from initial mapping setup Juergen Gross
2014-09-04 12:59 ` David Vrabel
2014-09-04 12:59 ` David Vrabel
2014-09-04 13:02 ` [Xen-devel] " Andrew Cooper
2014-09-04 13:02 ` Andrew Cooper
2014-09-04 14:31 ` Jan Beulich
2014-09-04 14:31 ` Jan Beulich
2014-09-04 14:43 ` Andrew Cooper
2014-09-04 14:43 ` Andrew Cooper
2014-09-05 7:55 ` Juergen Gross
2014-09-05 9:05 ` Andrew Cooper
2014-09-05 9:05 ` Andrew Cooper
2014-09-05 9:44 ` Juergen Gross
2014-09-04 15:13 ` David Vrabel
2014-09-04 15:13 ` David Vrabel
2014-09-05 8:03 ` Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54087CE3.6020400@citrix.com \
--to=david.vrabel@citrix.com \
--cc=JBeulich@suse.com \
--cc=JGross@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.