Re: [PATCH for-4.5 v6 04/16] xen: Add vmware_port support

[Andrew Cooper <andrew.cooper3@citrix.com>]

On 24/09/14 17:48, Don Slutz wrote:
> On 09/24/14 12:01, George Dunlap wrote:
>> On 09/20/2014 07:07 PM, Don Slutz wrote:
>>
>>> diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c
>>> index 7b1dfe6..e2e4aad 100644
>>> --- a/xen/arch/x86/domain.c
>>> +++ b/xen/arch/x86/domain.c
>>> @@ -510,6 +510,8 @@ int arch_domain_create(struct domain *d,
>>> unsigned int domcr_flags)
>>>       d->arch.hvm_domain.mem_sharing_enabled = 0;
>>>         d->arch.s3_integrity = !!(domcr_flags & DOMCRF_s3_integrity);
>>> +    d->arch.hvm_domain.is_vmware_port_enabled =
>>> +        (domcr_flags & DOMCRF_vmware_port);
>>
>> Should this be "!!(domcr..."?
>>
>
> I do not think it is needed, but happy to change to that.

It sadly is as bool_t isn't of type _Bool as one would expect.  It is
int8_t as Xen's bool_t pre-dates the general acceptance of using header
files such as <stdbool.h>

~Andrew