From: zhangfei <zhangfei.gao-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
Cc: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>,
haifeng.yan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
jchxue-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
xuwei5-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Wei Yan <sledge.yanwei-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH v2 1/3] i2c: hix5hd2: add devicetree documentation
Date: Tue, 30 Sep 2014 17:25:25 +0800 [thread overview]
Message-ID: <542A7705.2030404@linaro.org> (raw)
In-Reply-To: <2135291.ciFUCkAm4U@wuerfel>
On 09/30/2014 05:01 PM, Arnd Bergmann wrote:
> On Sunday 28 September 2014 12:22:07 Zhangfei Gao wrote:
>> +
>> +Required properties:
>> +- compatible: Must be "hisilicon,hix5hd2-i2c"
>> + Specifically, the following versions of the chipset are supported:
>> + Hi3716CV200 (support six I2C module)
>> + Hi3719CV100 (support six I2C module)
>> + Hi3718CV100 (support six I2C module)
>> + Hi3719MV100 (support two I2C module)
>> + Hi3718MV100 (support two I2C module)
>>
>
> How do you detect the specific model? Is there a hardware register that
> lets you know the type?
> If you have a device specific "compatible" string, you should list all
> the known strings.
>
In fact, no need to distinguish these hardware, the only difference is
i2c module number.
The same compatible is used.
These info can be removed to remove the confusion.
Thanks
WARNING: multiple messages have this Message-ID (diff)
From: zhangfei.gao@linaro.org (zhangfei)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/3] i2c: hix5hd2: add devicetree documentation
Date: Tue, 30 Sep 2014 17:25:25 +0800 [thread overview]
Message-ID: <542A7705.2030404@linaro.org> (raw)
In-Reply-To: <2135291.ciFUCkAm4U@wuerfel>
On 09/30/2014 05:01 PM, Arnd Bergmann wrote:
> On Sunday 28 September 2014 12:22:07 Zhangfei Gao wrote:
>> +
>> +Required properties:
>> +- compatible: Must be "hisilicon,hix5hd2-i2c"
>> + Specifically, the following versions of the chipset are supported:
>> + Hi3716CV200 (support six I2C module)
>> + Hi3719CV100 (support six I2C module)
>> + Hi3718CV100 (support six I2C module)
>> + Hi3719MV100 (support two I2C module)
>> + Hi3718MV100 (support two I2C module)
>>
>
> How do you detect the specific model? Is there a hardware register that
> lets you know the type?
> If you have a device specific "compatible" string, you should list all
> the known strings.
>
In fact, no need to distinguish these hardware, the only difference is
i2c module number.
The same compatible is used.
These info can be removed to remove the confusion.
Thanks
next prev parent reply other threads:[~2014-09-30 9:25 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-28 4:22 [PATCH v2 0/3] i2c: hix5hd2: add i2c controller driver Zhangfei Gao
2014-09-28 4:22 ` Zhangfei Gao
[not found] ` <1411878129-19743-1-git-send-email-zhangfei.gao-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-09-28 4:22 ` [PATCH v2 1/3] i2c: hix5hd2: add devicetree documentation Zhangfei Gao
2014-09-28 4:22 ` Zhangfei Gao
[not found] ` <1411878129-19743-2-git-send-email-zhangfei.gao-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-09-30 9:01 ` Arnd Bergmann
2014-09-30 9:01 ` Arnd Bergmann
2014-09-30 9:25 ` zhangfei [this message]
2014-09-30 9:25 ` zhangfei
[not found] ` <542A7705.2030404-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-09-30 10:24 ` Arnd Bergmann
2014-09-30 10:24 ` Arnd Bergmann
2014-09-28 4:22 ` [PATCH v2 2/3] i2c: hix5hd2: add i2c controller driver Zhangfei Gao
2014-09-28 4:22 ` Zhangfei Gao
[not found] ` <1411878129-19743-3-git-send-email-zhangfei.gao-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-09-29 12:49 ` zhangfei
2014-09-29 12:49 ` zhangfei
2014-09-28 4:22 ` [PATCH v2 3/3] ARM: dts: hix5hd2: add i2c node Zhangfei Gao
2014-09-28 4:22 ` Zhangfei Gao
[not found] ` <1411878129-19743-4-git-send-email-zhangfei.gao-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-09-30 9:02 ` Arnd Bergmann
2014-09-30 9:02 ` Arnd Bergmann
2014-09-30 9:21 ` zhangfei
2014-09-30 9:21 ` zhangfei
2014-09-30 9:31 ` Wei Xu
2014-09-30 9:31 ` Wei Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=542A7705.2030404@linaro.org \
--to=zhangfei.gao-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \
--cc=arnd-r2nGTMty4D4@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=haifeng.yan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=jchxue-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sledge.yanwei-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
--cc=xuwei5-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.