All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wei Xu <xuwei5-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org>
To: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
	Zhangfei Gao
	<zhangfei.gao-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>,
	haifeng.yan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
	jchxue-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v2 3/3] ARM: dts: hix5hd2: add i2c node
Date: Tue, 30 Sep 2014 17:31:20 +0800	[thread overview]
Message-ID: <542A7868.8080306@hisilicon.com> (raw)
In-Reply-To: <2637538.ufF2KQPbi9@wuerfel>



On 2014/9/30 17:02, Arnd Bergmann wrote:
> On Sunday 28 September 2014 12:22:09 Zhangfei Gao wrote:
>> +
>> +               i2c0: i2c@b10000 {
>> +                       compatible = "hisilicon,hix5hd2-i2c";
>> +                       reg = <0xb10000 0x1000>;
>> +                       interrupts = <0 38 4>;
>> +                       clocks = <&clock HIX5HD2_I2C0_RST>;
>> +                       #address-cells = <1>;
>> +                       #size-cells = <0>;
>> +                       status = "disabled";
>> +               };
>>

Hi Arnd,
 
> HIX5HD2_I2C0_RST is not defined anywhere, so this will result in the
> same build error that has required reverting a lot of patches for the
> 3.18 merge window.

Sorry again for bringing so much troubles to you, Olof and Stephen.
On 9/30, Mike Turquette has already accepted the clock pull request
which includes the HIX5HD2_I2C0_RST definition.

> How do you plan to deal with the dependency in the future? 

In the future, I will check the dependence firstly about the patches.
When creating pull request tag, I will test it and make sure it works.
And I will also make sure that the order of the pull request is sent correctly.

Best Regards,
Wei

> 	Arnd
> 
> .
> 

WARNING: multiple messages have this Message-ID (diff)
From: xuwei5@hisilicon.com (Wei Xu)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/3] ARM: dts: hix5hd2: add i2c node
Date: Tue, 30 Sep 2014 17:31:20 +0800	[thread overview]
Message-ID: <542A7868.8080306@hisilicon.com> (raw)
In-Reply-To: <2637538.ufF2KQPbi9@wuerfel>



On 2014/9/30 17:02, Arnd Bergmann wrote:
> On Sunday 28 September 2014 12:22:09 Zhangfei Gao wrote:
>> +
>> +               i2c0: i2c at b10000 {
>> +                       compatible = "hisilicon,hix5hd2-i2c";
>> +                       reg = <0xb10000 0x1000>;
>> +                       interrupts = <0 38 4>;
>> +                       clocks = <&clock HIX5HD2_I2C0_RST>;
>> +                       #address-cells = <1>;
>> +                       #size-cells = <0>;
>> +                       status = "disabled";
>> +               };
>>

Hi Arnd,
 
> HIX5HD2_I2C0_RST is not defined anywhere, so this will result in the
> same build error that has required reverting a lot of patches for the
> 3.18 merge window.

Sorry again for bringing so much troubles to you, Olof and Stephen.
On 9/30, Mike Turquette has already accepted the clock pull request
which includes the HIX5HD2_I2C0_RST definition.

> How do you plan to deal with the dependency in the future? 

In the future, I will check the dependence firstly about the patches.
When creating pull request tag, I will test it and make sure it works.
And I will also make sure that the order of the pull request is sent correctly.

Best Regards,
Wei

> 	Arnd
> 
> .
> 

  parent reply	other threads:[~2014-09-30  9:31 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-28  4:22 [PATCH v2 0/3] i2c: hix5hd2: add i2c controller driver Zhangfei Gao
2014-09-28  4:22 ` Zhangfei Gao
     [not found] ` <1411878129-19743-1-git-send-email-zhangfei.gao-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-09-28  4:22   ` [PATCH v2 1/3] i2c: hix5hd2: add devicetree documentation Zhangfei Gao
2014-09-28  4:22     ` Zhangfei Gao
     [not found]     ` <1411878129-19743-2-git-send-email-zhangfei.gao-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-09-30  9:01       ` Arnd Bergmann
2014-09-30  9:01         ` Arnd Bergmann
2014-09-30  9:25         ` zhangfei
2014-09-30  9:25           ` zhangfei
     [not found]           ` <542A7705.2030404-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-09-30 10:24             ` Arnd Bergmann
2014-09-30 10:24               ` Arnd Bergmann
2014-09-28  4:22   ` [PATCH v2 2/3] i2c: hix5hd2: add i2c controller driver Zhangfei Gao
2014-09-28  4:22     ` Zhangfei Gao
     [not found]     ` <1411878129-19743-3-git-send-email-zhangfei.gao-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-09-29 12:49       ` zhangfei
2014-09-29 12:49         ` zhangfei
2014-09-28  4:22   ` [PATCH v2 3/3] ARM: dts: hix5hd2: add i2c node Zhangfei Gao
2014-09-28  4:22     ` Zhangfei Gao
     [not found]     ` <1411878129-19743-4-git-send-email-zhangfei.gao-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-09-30  9:02       ` Arnd Bergmann
2014-09-30  9:02         ` Arnd Bergmann
2014-09-30  9:21         ` zhangfei
2014-09-30  9:21           ` zhangfei
2014-09-30  9:31         ` Wei Xu [this message]
2014-09-30  9:31           ` Wei Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=542A7868.8080306@hisilicon.com \
    --to=xuwei5-c8/m+/jpzteamjb+lgu22q@public.gmane.org \
    --cc=arnd-r2nGTMty4D4@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=haifeng.yan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=jchxue-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
    --cc=zhangfei.gao-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.