All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Chen, Tiejun" <tiejun.chen@intel.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: yang.z.zhang@intel.com, kevin.tian@intel.com, xen-devel@lists.xen.org
Subject: Re: [PATCH] xen/vtd: cleanup some comments
Date: Mon, 27 Oct 2014 09:33:29 +0800	[thread overview]
Message-ID: <544DA0E9.3000306@intel.com> (raw)
In-Reply-To: <544A46FE0200007800041DA2@mail.emea.novell.com>

On 2014/10/24 18:33, Jan Beulich wrote:
>>>> On 24.10.14 at 04:50, <tiejun.chen@intel.com> wrote:
>> --- a/xen/drivers/passthrough/vtd/iommu.c
>> +++ b/xen/drivers/passthrough/vtd/iommu.c
>> @@ -1248,7 +1248,7 @@ static void __hwdom_init intel_iommu_hwdom_init(struct domain *d)
>>
>>       if ( !iommu_passthrough && !need_iommu(d) )
>>       {
>> -        /* Set up 1:1 page table for dom0 */
>> +        /* Set up 1:1 page table for hardware domain */
>>           vtd_set_hwdom_mapping(d);
>>       }
>>
>> @@ -1696,7 +1696,7 @@ static int intel_iommu_map_page(
>>       if ( iommu_use_hap_pt(d) )
>>           return 0;
>>
>> -    /* do nothing if dom0 and iommu supports pass thru */
>> +    /* do nothing if hardware domain and iommu supports pass thru */
>
> If you clean up comments, please make them match ./CODING_STYLE.

Sorry, could you say this explicitly?

 From my point of view, this is just one line and this line is already 
less than 80 characters in length. Or just add a period at the end of 
the sentence?

Thanks
Tiejun

  reply	other threads:[~2014-10-27  1:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-24  2:50 [PATCH] xen/vtd: cleanup some comments Tiejun Chen
2014-10-24 10:33 ` Jan Beulich
2014-10-27  1:33   ` Chen, Tiejun [this message]
2014-10-27  9:19     ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=544DA0E9.3000306@intel.com \
    --to=tiejun.chen@intel.com \
    --cc=JBeulich@suse.com \
    --cc=kevin.tian@intel.com \
    --cc=xen-devel@lists.xen.org \
    --cc=yang.z.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.